[jira] [Commented] (HADOOP-15808) Harden Token service loader use

[ https://issues.apache.org/jira/browse/HADOOP-15808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754144#comment-16754144 ] Steve Loughran commented on HADOOP-15808: - Followup, this isn't enough: token.toString() will

[jira] [Commented] (HADOOP-15808) Harden Token service loader use

[ https://issues.apache.org/jira/browse/HADOOP-15808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16717660#comment-16717660 ] Hudson commented on HADOOP-15808: - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #15591 (See

[jira] [Commented] (HADOOP-15808) Harden Token service loader use

[ https://issues.apache.org/jira/browse/HADOOP-15808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16717616#comment-16717616 ] Larry McCay commented on HADOOP-15808: -- Okay, very good, [~ste...@apache.org]. +1 on the patch as

[jira] [Commented] (HADOOP-15808) Harden Token service loader use

[ https://issues.apache.org/jira/browse/HADOOP-15808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16717595#comment-16717595 ] Steve Loughran commented on HADOOP-15808: - bq. I assume once this gets in a patch for all of

[jira] [Commented] (HADOOP-15808) Harden Token service loader use

[ https://issues.apache.org/jira/browse/HADOOP-15808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16717604#comment-16717604 ] Steve Loughran commented on HADOOP-15808: - javadocs are correct. ReflectionUtils.newInstance()

[jira] [Commented] (HADOOP-15808) Harden Token service loader use

[ https://issues.apache.org/jira/browse/HADOOP-15808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16715232#comment-16715232 ] Larry McCay commented on HADOOP-15808: -- [~ste...@apache.org] - what is the difference between no

[jira] [Commented] (HADOOP-15808) Harden Token service loader use

[ https://issues.apache.org/jira/browse/HADOOP-15808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713171#comment-16713171 ] Steve Loughran commented on HADOOP-15808: - I've seen the exact issue I was predicting surface

[jira] [Commented] (HADOOP-15808) Harden Token service loader use

[ https://issues.apache.org/jira/browse/HADOOP-15808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701734#comment-16701734 ] Steve Loughran commented on HADOOP-15808: - Revisited this to see about changing message for

[jira] [Commented] (HADOOP-15808) Harden Token service loader use

[ https://issues.apache.org/jira/browse/HADOOP-15808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683781#comment-16683781 ] Steve Loughran commented on HADOOP-15808: - bq. I don't fully understand why the Iterator#next()

[jira] [Commented] (HADOOP-15808) Harden Token service loader use

[ https://issues.apache.org/jira/browse/HADOOP-15808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669031#comment-16669031 ] Íñigo Goiri commented on HADOOP-15808: -- I have to say that the pattern of iterating and then

[jira] [Commented] (HADOOP-15808) Harden Token service loader use

[ https://issues.apache.org/jira/browse/HADOOP-15808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638392#comment-16638392 ] Hadoop QA commented on HADOOP-15808: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-15808) Harden Token service loader use

[ https://issues.apache.org/jira/browse/HADOOP-15808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638122#comment-16638122 ] Steve Loughran commented on HADOOP-15808: - patch 003; removed that now unused import > Harden

[jira] [Commented] (HADOOP-15808) Harden Token service loader use

[ https://issues.apache.org/jira/browse/HADOOP-15808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638112#comment-16638112 ] Steve Loughran commented on HADOOP-15808: - checkstyle {code}

[jira] [Commented] (HADOOP-15808) Harden Token service loader use

[ https://issues.apache.org/jira/browse/HADOOP-15808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637263#comment-16637263 ] Hadoop QA commented on HADOOP-15808: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-15808) Harden Token service loader use

[ https://issues.apache.org/jira/browse/HADOOP-15808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637017#comment-16637017 ] Steve Loughran commented on HADOOP-15808: - HADOOP-15808: patch 002: remove state checks for no

[jira] [Commented] (HADOOP-15808) Harden Token service loader use

[ https://issues.apache.org/jira/browse/HADOOP-15808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16636928#comment-16636928 ] Steve Loughran commented on HADOOP-15808: - Checkstyle is minor, test failure not. {code}

[jira] [Commented] (HADOOP-15808) Harden Token service loader use

[ https://issues.apache.org/jira/browse/HADOOP-15808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634669#comment-16634669 ] Hadoop QA commented on HADOOP-15808: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-15808) Harden Token service loader use

[ https://issues.apache.org/jira/browse/HADOOP-15808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634539#comment-16634539 ] Steve Loughran commented on HADOOP-15808: - Patch 001 * harden service loading in Token clases

[jira] [Commented] (HADOOP-15808) Harden Token service loader use

[ https://issues.apache.org/jira/browse/HADOOP-15808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634435#comment-16634435 ] Steve Loughran commented on HADOOP-15808: - There's a related issue, which is most (all?) uses