[
https://issues.apache.org/jira/browse/HADOOP-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840523#comment-16840523
]
He Xiaoqiao commented on HADOOP-16161:
--
Thanks [~elgoiri] for the review and commit.
>
[
https://issues.apache.org/jira/browse/HADOOP-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838813#comment-16838813
]
Hudson commented on HADOOP-16161:
-
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #16545 (See
[
https://issues.apache.org/jira/browse/HADOOP-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838801#comment-16838801
]
Íñigo Goiri commented on HADOOP-16161:
--
Thanks [~hexiaoqiao] for the contribution.
Committed to
[
https://issues.apache.org/jira/browse/HADOOP-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16834419#comment-16834419
]
He Xiaoqiao commented on HADOOP-16161:
--
[~elgoiri], any furthermore comments or suggestions about
[
https://issues.apache.org/jira/browse/HADOOP-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16810152#comment-16810152
]
Íñigo Goiri commented on HADOOP-16161:
--
[^HADOOP-16161.009.patch] LGTM.
The failed unit tests are
[
https://issues.apache.org/jira/browse/HADOOP-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16809698#comment-16809698
]
Hadoop QA commented on HADOOP-16161:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16809502#comment-16809502
]
Íñigo Goiri commented on HADOOP-16161:
--
The main thing with {{assertEquals()}} is that when
[
https://issues.apache.org/jira/browse/HADOOP-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16809484#comment-16809484
]
He Xiaoqiao commented on HADOOP-16161:
--
Thanks [~elgoiri] correct {{assertEquals}} usage times,
[
https://issues.apache.org/jira/browse/HADOOP-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16809347#comment-16809347
]
Íñigo Goiri commented on HADOOP-16161:
--
{{assertEquals()}} should have the excepted value as the
[
https://issues.apache.org/jira/browse/HADOOP-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16809113#comment-16809113
]
Hadoop QA commented on HADOOP-16161:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808867#comment-16808867
]
He Xiaoqiao commented on HADOOP-16161:
--
Thanks [~elgoiri], [^HADOOP-16161.008.patch] update unit
[
https://issues.apache.org/jira/browse/HADOOP-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808013#comment-16808013
]
Íñigo Goiri commented on HADOOP-16161:
--
Can we use assertEquals instead of assertThat?
Not much
[
https://issues.apache.org/jira/browse/HADOOP-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806937#comment-16806937
]
Hadoop QA commented on HADOOP-16161:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806728#comment-16806728
]
He Xiaoqiao commented on HADOOP-16161:
--
Thanks [~elgoiri] for your reviews,
[
https://issues.apache.org/jira/browse/HADOOP-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16803805#comment-16803805
]
Íñigo Goiri commented on HADOOP-16161:
--
Should we add more coverage for this?
Covering
[
https://issues.apache.org/jira/browse/HADOOP-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16791292#comment-16791292
]
He Xiaoqiao commented on HADOOP-16161:
--
[~elgoiri], Thanks for digging deep to find the truth.
[
https://issues.apache.org/jira/browse/HADOOP-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16790780#comment-16790780
]
Íñigo Goiri commented on HADOOP-16161:
--
It would be nice to get some more reviews but it doesn't
[
https://issues.apache.org/jira/browse/HADOOP-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16790333#comment-16790333
]
He Xiaoqiao commented on HADOOP-16161:
--
Thanks [~elgoiri], do we need another one reviews?
>
[
https://issues.apache.org/jira/browse/HADOOP-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16789836#comment-16789836
]
Íñigo Goiri commented on HADOOP-16161:
--
Thanks [~hexiaoqiao] for the update.
+1 on
[
https://issues.apache.org/jira/browse/HADOOP-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788870#comment-16788870
]
Hadoop QA commented on HADOOP-16161:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788842#comment-16788842
]
He Xiaoqiao commented on HADOOP-16161:
--
Thanks [~elgoiri], [^HADOOP-16161.006.patch] correct the
[
https://issues.apache.org/jira/browse/HADOOP-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788769#comment-16788769
]
Íñigo Goiri commented on HADOOP-16161:
--
{quote}
Sorry I don't get the point, variable
[
https://issues.apache.org/jira/browse/HADOOP-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788749#comment-16788749
]
Hadoop QA commented on HADOOP-16161:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788685#comment-16788685
]
He Xiaoqiao commented on HADOOP-16161:
--
[~elgoiri], Thanks.
{quote}One minor thing: the
[
https://issues.apache.org/jira/browse/HADOOP-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788440#comment-16788440
]
Íñigo Goiri commented on HADOOP-16161:
--
One minor thing: the assertEquals() in testGetWeight() are
[
https://issues.apache.org/jira/browse/HADOOP-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16787674#comment-16787674
]
Hadoop QA commented on HADOOP-16161:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16787499#comment-16787499
]
He Xiaoqiao commented on HADOOP-16161:
--
Thanks [~elgoiri] for reviews. update patch following
[
https://issues.apache.org/jira/browse/HADOOP-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16787323#comment-16787323
]
Íñigo Goiri commented on HADOOP-16161:
--
Thanks [~hexiaoqiao] for [^HADOOP-16161.003.patch]:
* Why
[
https://issues.apache.org/jira/browse/HADOOP-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786541#comment-16786541
]
Hadoop QA commented on HADOOP-16161:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786402#comment-16786402
]
He Xiaoqiao commented on HADOOP-16161:
--
Thanks [~elgoiri]. resubmit [^HADOOP-16161.003.patch]
[
https://issues.apache.org/jira/browse/HADOOP-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785895#comment-16785895
]
Íñigo Goiri commented on HADOOP-16161:
--
Thanks [~hexiaoqiao] for [^HADOOP-16161.002.patch].
Yetus
[
https://issues.apache.org/jira/browse/HADOOP-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784992#comment-16784992
]
Hadoop QA commented on HADOOP-16161:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784754#comment-16784754
]
He Xiaoqiao commented on HADOOP-16161:
--
upload patch [^HADOOP-16161.002.patch], add complex
[
https://issues.apache.org/jira/browse/HADOOP-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784734#comment-16784734
]
He Xiaoqiao commented on HADOOP-16161:
--
[~elgoiri], Thanks for your continue following. In my test
[
https://issues.apache.org/jira/browse/HADOOP-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784717#comment-16784717
]
Íñigo Goiri commented on HADOOP-16161:
--
Internally we have a topology like:
[
https://issues.apache.org/jira/browse/HADOOP-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784467#comment-16784467
]
He Xiaoqiao commented on HADOOP-16161:
--
I would like to offer more comment about this issue. The
[
https://issues.apache.org/jira/browse/HADOOP-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16783600#comment-16783600
]
He Xiaoqiao commented on HADOOP-16161:
--
[~elgoiri], I think it is not related to depth of the
[
https://issues.apache.org/jira/browse/HADOOP-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16783591#comment-16783591
]
Hadoop QA commented on HADOOP-16161:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16783582#comment-16783582
]
Íñigo Goiri commented on HADOOP-16161:
--
There might be topologies deeper than {{/d1/r2}}.
Can we
[
https://issues.apache.org/jira/browse/HADOOP-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16783380#comment-16783380
]
He Xiaoqiao commented on HADOOP-16161:
--
move from project HDFS to COMMON and rename the patch.
>
40 matches
Mail list logo
