[
https://issues.apache.org/jira/browse/HADOOP-8649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13435110#comment-13435110
]
Daryn Sharp commented on HADOOP-8649:
-
I'm just generally concerned about the
[
https://issues.apache.org/jira/browse/HADOOP-8649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13433220#comment-13433220
]
Daryn Sharp commented on HADOOP-8649:
-
You may want to test if there's any
[
https://issues.apache.org/jira/browse/HADOOP-8649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13433541#comment-13433541
]
Karthik Kambatla commented on HADOOP-8649:
--
Thanks for the review, Daryn.
- I
[
https://issues.apache.org/jira/browse/HADOOP-8649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13431992#comment-13431992
]
Hadoop QA commented on HADOOP-8649:
---
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HADOOP-8649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13432021#comment-13432021
]
Karthik Kambatla commented on HADOOP-8649:
--
I don't think the patch has anything
[
https://issues.apache.org/jira/browse/HADOOP-8649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13431337#comment-13431337
]
Hadoop QA commented on HADOOP-8649:
---
-1 overall. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HADOOP-8649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13431389#comment-13431389
]
Karthik Kambatla commented on HADOOP-8649:
--
Found the javadoc warning. The
[
https://issues.apache.org/jira/browse/HADOOP-8649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13430545#comment-13430545
]
Daryn Sharp commented on HADOOP-8649:
-
What I _think_ I see in trunk is:
# (A)
[
https://issues.apache.org/jira/browse/HADOOP-8649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13430626#comment-13430626
]
Karthik Kambatla commented on HADOOP-8649:
--
Hi Daryn, thanks for your comments.
[
https://issues.apache.org/jira/browse/HADOOP-8649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13429184#comment-13429184
]
Daryn Sharp commented on HADOOP-8649:
-
Good catch! In
[
https://issues.apache.org/jira/browse/HADOOP-8649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13429259#comment-13429259
]
Karthik Kambatla commented on HADOOP-8649:
--
Thanks for the review, Daryn. Great
[
https://issues.apache.org/jira/browse/HADOOP-8649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13429277#comment-13429277
]
Daryn Sharp commented on HADOOP-8649:
-
Yes, we're in agreement. I intended to convey
[
https://issues.apache.org/jira/browse/HADOOP-8649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13429293#comment-13429293
]
Karthik Kambatla commented on HADOOP-8649:
--
Wrong placement of null check in
[
https://issues.apache.org/jira/browse/HADOOP-8649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13429459#comment-13429459
]
Karthik Kambatla commented on HADOOP-8649:
--
Hi Daryn,
The trunk code seems to
14 matches
Mail list logo