[GitHub] [hadoop] elek opened a new pull request #814: HDDS-1518. Use /etc/ozone for configuration inside docker-compose

2019-05-13 Thread GitBox
elek opened a new pull request #814: HDDS-1518. Use /etc/ozone for configuration inside docker-compose URL: https://github.com/apache/hadoop/pull/814 See https://issues.apache.org/jira/browse/HDDS-1518 for more details. This

[GitHub] [hadoop] lokeshj1703 opened a new pull request #813: HDDS-1503. Reduce garbage generated by non-netty threads in datanode ratis server

2019-05-13 Thread GitBox
lokeshj1703 opened a new pull request #813: HDDS-1503. Reduce garbage generated by non-netty threads in datanode ratis server URL: https://github.com/apache/hadoop/pull/813 We use GRPC protocol for rpc communication in Ratis. By default thread caches are generated even for non-netty thread

[GitHub] [hadoop] elek commented on issue #814: HDDS-1518. Use /etc/ozone for configuration inside docker-compose

2019-05-13 Thread GitBox
elek commented on issue #814: HDDS-1518. Use /etc/ozone for configuration inside docker-compose URL: https://github.com/apache/hadoop/pull/814#issuecomment-491745153 Note: we create config files based on name convention: FILENAME_EXT_key=value will be converted to FILENAME.EXT. As CONF is

[jira] [Commented] (HADOOP-16302) Fix typo on Hadoop Site Help dropdown menu

2019-05-13 Thread Elek, Marton (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16838414#comment-16838414 ] Elek, Marton commented on HADOOP-16302: --- Yes, you should commit both the source c

[GitHub] [hadoop] lokeshj1703 commented on issue #813: HDDS-1503. Reduce garbage generated by non-netty threads in datanode ratis server

2019-05-13 Thread GitBox
lokeshj1703 commented on issue #813: HDDS-1503. Reduce garbage generated by non-netty threads in datanode ratis server URL: https://github.com/apache/hadoop/pull/813#issuecomment-491754137 @mukul1987 I have added the corresponding Ratis issue link. -

[jira] [Commented] (HADOOP-16306) AliyunOSS: Remove temporary files when upload small files to OSS

2019-05-13 Thread wujinhu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16838428#comment-16838428 ] wujinhu commented on HADOOP-16306: -- Hi [~weiweiyagn666] Please help to review this pat

[GitHub] [hadoop] supratimdeka commented on a change in pull request #812: HDDS-1511. Space tracking for Open Containers in HDDS Volumes. Contributed by Supratim Deka

2019-05-13 Thread GitBox
supratimdeka commented on a change in pull request #812: HDDS-1511. Space tracking for Open Containers in HDDS Volumes. Contributed by Supratim Deka URL: https://github.com/apache/hadoop/pull/812#discussion_r283274385 ## File path: hadoop-hdds/container-service/src/main/java/org/ap

[GitHub] [hadoop] supratimdeka commented on a change in pull request #812: HDDS-1511. Space tracking for Open Containers in HDDS Volumes. Contributed by Supratim Deka

2019-05-13 Thread GitBox
supratimdeka commented on a change in pull request #812: HDDS-1511. Space tracking for Open Containers in HDDS Volumes. Contributed by Supratim Deka URL: https://github.com/apache/hadoop/pull/812#discussion_r283274169 ## File path: hadoop-hdds/container-service/src/main/java/org/ap

[GitHub] [hadoop] supratimdeka commented on a change in pull request #812: HDDS-1511. Space tracking for Open Containers in HDDS Volumes. Contributed by Supratim Deka

2019-05-13 Thread GitBox
supratimdeka commented on a change in pull request #812: HDDS-1511. Space tracking for Open Containers in HDDS Volumes. Contributed by Supratim Deka URL: https://github.com/apache/hadoop/pull/812#discussion_r283274385 ## File path: hadoop-hdds/container-service/src/main/java/org/ap

[GitHub] [hadoop] jiwq commented on a change in pull request #812: HDDS-1511. Space tracking for Open Containers in HDDS Volumes. Contributed by Supratim Deka

2019-05-13 Thread GitBox
jiwq commented on a change in pull request #812: HDDS-1511. Space tracking for Open Containers in HDDS Volumes. Contributed by Supratim Deka URL: https://github.com/apache/hadoop/pull/812#discussion_r283277627 ## File path: hadoop-hdds/container-service/src/main/java/org/apache/had

[GitHub] [hadoop] hadoop-yetus commented on issue #813: HDDS-1503. Reduce garbage generated by non-netty threads in datanode ratis server

2019-05-13 Thread GitBox
hadoop-yetus commented on issue #813: HDDS-1503. Reduce garbage generated by non-netty threads in datanode ratis server URL: https://github.com/apache/hadoop/pull/813#issuecomment-491769716 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] hadoop-yetus commented on issue #813: HDDS-1503. Reduce garbage generated by non-netty threads in datanode ratis server

2019-05-13 Thread GitBox
hadoop-yetus commented on issue #813: HDDS-1503. Reduce garbage generated by non-netty threads in datanode ratis server URL: https://github.com/apache/hadoop/pull/813#issuecomment-491769924 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Commented] (HADOOP-16302) Fix typo on Hadoop Site Help dropdown menu

2019-05-13 Thread Elek, Marton (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16838456#comment-16838456 ] Elek, Marton commented on HADOOP-16302: --- Oh, I just realized that Ajay regenerate

[jira] [Created] (HADOOP-16312) Remove dumb-init from hadoop-runner image

2019-05-13 Thread Elek, Marton (JIRA)
Elek, Marton created HADOOP-16312: - Summary: Remove dumb-init from hadoop-runner image Key: HADOOP-16312 URL: https://issues.apache.org/jira/browse/HADOOP-16312 Project: Hadoop Common Issue T

[jira] [Commented] (HADOOP-16312) Remove dumb-init from hadoop-runner image

2019-05-13 Thread Elek, Marton (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16838462#comment-16838462 ] Elek, Marton commented on HADOOP-16312: --- First of all, let me clarify that we are

[jira] [Commented] (HADOOP-16248) Fix MutableQuantiles memory leak

2019-05-13 Thread Alexis Daboville (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16838465#comment-16838465 ] Alexis Daboville commented on HADOOP-16248: --- [~prongs]: thanks for the link (

[GitHub] [hadoop] bshashikant commented on issue #795: HDDS-1491. Ozone KeyInputStream seek() should not read the chunk file.

2019-05-13 Thread GitBox
bshashikant commented on issue #795: HDDS-1491. Ozone KeyInputStream seek() should not read the chunk file. URL: https://github.com/apache/hadoop/pull/795#issuecomment-491798375 Thanks @hanishakoneru for updating the patch. The patch looks good to me. I am +1 on this. Please address the

[GitHub] [hadoop] bshashikant edited a comment on issue #795: HDDS-1491. Ozone KeyInputStream seek() should not read the chunk file.

2019-05-13 Thread GitBox
bshashikant edited a comment on issue #795: HDDS-1491. Ozone KeyInputStream seek() should not read the chunk file. URL: https://github.com/apache/hadoop/pull/795#issuecomment-491798375 Thanks @hanishakoneru for updating the patch. The patch looks good to me. I am +1 on this. Please addr

[GitHub] [hadoop] bshashikant commented on issue #745: HDDS-1441. Remove usage of getRetryFailureException. (swagle)

2019-05-13 Thread GitBox
bshashikant commented on issue #745: HDDS-1441. Remove usage of getRetryFailureException. (swagle) URL: https://github.com/apache/hadoop/pull/745#issuecomment-491803723 /retest This is an automated message from the Apache Git

[GitHub] [hadoop] sahilTakiar commented on issue #784: HADOOP-16050: s3a SSL connections should use OpenSSL

2019-05-13 Thread GitBox
sahilTakiar commented on issue #784: HADOOP-16050: s3a SSL connections should use OpenSSL URL: https://github.com/apache/hadoop/pull/784#issuecomment-491848505 Ping @DadanielZ for Steve's comment above: "We're changing the scope of the wildfly lib from compile to runtime in ABFS -is everyo

[GitHub] [hadoop] ben-roling commented on issue #794: HADOOP-16085: use object version or etags to protect against inconsistent read after replace/overwrite

2019-05-13 Thread GitBox
ben-roling commented on issue #794: HADOOP-16085: use object version or etags to protect against inconsistent read after replace/overwrite URL: https://github.com/apache/hadoop/pull/794#issuecomment-491856023 > The issue seems to suggest that a 412 response would never actually happen, whi

[GitHub] [hadoop] anuengineer commented on a change in pull request #814: HDDS-1518. Use /etc/ozone for configuration inside docker-compose

2019-05-13 Thread GitBox
anuengineer commented on a change in pull request #814: HDDS-1518. Use /etc/ozone for configuration inside docker-compose URL: https://github.com/apache/hadoop/pull/814#discussion_r283415507 ## File path: Dockerfile ## @@ -36,7 +36,9 @@ RUN chown hadoop /opt ADD scripts

[GitHub] [hadoop] ben-roling commented on issue #794: HADOOP-16085: use object version or etags to protect against inconsistent read after replace/overwrite

2019-05-13 Thread GitBox
ben-roling commented on issue #794: HADOOP-16085: use object version or etags to protect against inconsistent read after replace/overwrite URL: https://github.com/apache/hadoop/pull/794#issuecomment-491883021 Hey @steveloughran - I think I've covered everything previously discussed now if

[GitHub] [hadoop] ben-roling commented on issue #794: HADOOP-16085: use object version or etags to protect against inconsistent read after replace/overwrite

2019-05-13 Thread GitBox
ben-roling commented on issue #794: HADOOP-16085: use object version or etags to protect against inconsistent read after replace/overwrite URL: https://github.com/apache/hadoop/pull/794#issuecomment-491887679 > BTW, note that the CopyOutcome class only stores SdkBaseExceptions raised in th

[GitHub] [hadoop] xiaoyuyao commented on issue #813: HDDS-1503. Reduce garbage generated by non-netty threads in datanode ratis server

2019-05-13 Thread GitBox
xiaoyuyao commented on issue #813: HDDS-1503. Reduce garbage generated by non-netty threads in datanode ratis server URL: https://github.com/apache/hadoop/pull/813#issuecomment-491889803 +1 from me too. Do we need to update ozone with a new Ratis release to take the newly added config? --

[jira] [Commented] (HADOOP-16312) Remove dumb-init from hadoop-runner image

2019-05-13 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16838676#comment-16838676 ] Eric Yang commented on HADOOP-16312: {quote}Would you be so kind Eric Yang to expla

[GitHub] [hadoop] elek opened a new pull request #815: HDDS-1522. Provide intellij runConfiguration for Ozone components

2019-05-13 Thread GitBox
elek opened a new pull request #815: HDDS-1522. Provide intellij runConfiguration for Ozone components URL: https://github.com/apache/hadoop/pull/815 Sometimes I need to start ozone cluster from intellij to debug issues. It's possible but it requires to create many runConfiguration object

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #815: HDDS-1522. Provide intellij runConfiguration for Ozone components

2019-05-13 Thread GitBox
xiaoyuyao commented on a change in pull request #815: HDDS-1522. Provide intellij runConfiguration for Ozone components URL: https://github.com/apache/hadoop/pull/815#discussion_r283440458 ## File path: hadoop-ozone/dev-support/intellij/install-runconfigs.sh ## @@ -0,0 +1,

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #815: HDDS-1522. Provide intellij runConfiguration for Ozone components

2019-05-13 Thread GitBox
xiaoyuyao commented on a change in pull request #815: HDDS-1522. Provide intellij runConfiguration for Ozone components URL: https://github.com/apache/hadoop/pull/815#discussion_r283440458 ## File path: hadoop-ozone/dev-support/intellij/install-runconfigs.sh ## @@ -0,0 +1,

[GitHub] [hadoop] hadoop-yetus commented on issue #815: HDDS-1522. Provide intellij runConfiguration for Ozone components

2019-05-13 Thread GitBox
hadoop-yetus commented on issue #815: HDDS-1522. Provide intellij runConfiguration for Ozone components URL: https://github.com/apache/hadoop/pull/815#issuecomment-491909106 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #714: HDDS-1406. Avoid usage of commonPool in RatisPipelineUtils.

2019-05-13 Thread GitBox
bharatviswa504 commented on a change in pull request #714: HDDS-1406. Avoid usage of commonPool in RatisPipelineUtils. URL: https://github.com/apache/hadoop/pull/714#discussion_r283456973 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/Pipelin

[GitHub] [hadoop] bharatviswa504 commented on issue #714: HDDS-1406. Avoid usage of commonPool in RatisPipelineUtils.

2019-05-13 Thread GitBox
bharatviswa504 commented on issue #714: HDDS-1406. Avoid usage of commonPool in RatisPipelineUtils. URL: https://github.com/apache/hadoop/pull/714#issuecomment-491917096 Thank You @lokeshj1703 for the review. I have addressed review comments.

[jira] [Commented] (HADOOP-16279) S3Guard: Implement time-based (TTL) expiry for entries (and tombstones)

2019-05-13 Thread Gabor Bota (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16838753#comment-16838753 ] Gabor Bota commented on HADOOP-16279: - Thank you for reviewing this [~fabbri]! Wit

[jira] [Comment Edited] (HADOOP-16279) S3Guard: Implement time-based (TTL) expiry for entries (and tombstones)

2019-05-13 Thread Gabor Bota (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16838753#comment-16838753 ] Gabor Bota edited comment on HADOOP-16279 at 5/13/19 5:55 PM: ---

[jira] [Comment Edited] (HADOOP-16279) S3Guard: Implement time-based (TTL) expiry for entries (and tombstones)

2019-05-13 Thread Gabor Bota (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16838753#comment-16838753 ] Gabor Bota edited comment on HADOOP-16279 at 5/13/19 5:56 PM: ---

[GitHub] [hadoop] hadoop-yetus commented on issue #794: HADOOP-16085: use object version or etags to protect against inconsistent read after replace/overwrite

2019-05-13 Thread GitBox
hadoop-yetus commented on issue #794: HADOOP-16085: use object version or etags to protect against inconsistent read after replace/overwrite URL: https://github.com/apache/hadoop/pull/794#issuecomment-491926485 :confetti_ball: **+1 overall** | Vote | Subsystem | R

[GitHub] [hadoop] ben-roling commented on issue #794: HADOOP-16085: use object version or etags to protect against inconsistent read after replace/overwrite

2019-05-13 Thread GitBox
ben-roling commented on issue #794: HADOOP-16085: use object version or etags to protect against inconsistent read after replace/overwrite URL: https://github.com/apache/hadoop/pull/794#issuecomment-491934251 Test run complete against a bucket in us-west-2 with object versioning enabled:

[jira] [Updated] (HADOOP-16161) NetworkTopology#getWeightUsingNetworkLocation return unexpected result

2019-05-13 Thread JIRA
[ https://issues.apache.org/jira/browse/HADOOP-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Íñigo Goiri updated HADOOP-16161: - Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 3.3.0 Status: Res

[jira] [Commented] (HADOOP-16161) NetworkTopology#getWeightUsingNetworkLocation return unexpected result

2019-05-13 Thread JIRA
[ https://issues.apache.org/jira/browse/HADOOP-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16838801#comment-16838801 ] Íñigo Goiri commented on HADOOP-16161: -- Thanks [~hexiaoqiao] for the contribution.

[GitHub] [hadoop] hadoop-yetus commented on issue #794: HADOOP-16085: use object version or etags to protect against inconsistent read after replace/overwrite

2019-05-13 Thread GitBox
hadoop-yetus commented on issue #794: HADOOP-16085: use object version or etags to protect against inconsistent read after replace/overwrite URL: https://github.com/apache/hadoop/pull/794#issuecomment-491941647 :confetti_ball: **+1 overall** | Vote | Subsystem | R

[GitHub] [hadoop] bharatviswa504 commented on issue #810: HDDS-1512. Implement DoubleBuffer in OzoneManager.

2019-05-13 Thread GitBox
bharatviswa504 commented on issue #810: HDDS-1512. Implement DoubleBuffer in OzoneManager. URL: https://github.com/apache/hadoop/pull/810#issuecomment-491944348 Thank You @jiwq for the review. I have addressed your review comments. ---

[jira] [Commented] (HADOOP-16161) NetworkTopology#getWeightUsingNetworkLocation return unexpected result

2019-05-13 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16838813#comment-16838813 ] Hudson commented on HADOOP-16161: - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Co

[GitHub] [hadoop] ben-roling commented on issue #794: HADOOP-16085: use object version or etags to protect against inconsistent read after replace/overwrite

2019-05-13 Thread GitBox
ben-roling commented on issue #794: HADOOP-16085: use object version or etags to protect against inconsistent read after replace/overwrite URL: https://github.com/apache/hadoop/pull/794#issuecomment-491948048 > I'll do another run with a bucket with object versioning disabled. That's

[GitHub] [hadoop] hadoop-yetus commented on issue #714: HDDS-1406. Avoid usage of commonPool in RatisPipelineUtils.

2019-05-13 Thread GitBox
hadoop-yetus commented on issue #714: HDDS-1406. Avoid usage of commonPool in RatisPipelineUtils. URL: https://github.com/apache/hadoop/pull/714#issuecomment-491949750 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|--

[GitHub] [hadoop] sahilTakiar opened a new pull request #816: HDFS-14482: Crash when using libhdfs with bad classpath

2019-05-13 Thread GitBox
sahilTakiar opened a new pull request #816: HDFS-14482: Crash when using libhdfs with bad classpath URL: https://github.com/apache/hadoop/pull/816 Fixes a bug in `jni_helper.c` `getJNIEnv` introduced by HDFS-14304. After HDFS-14304, the `getJNIEnv` would call `getGlobalJNIEnv` and pass the

[GitHub] [hadoop] arp7 commented on issue #814: HDDS-1518. Use /etc/ozone for configuration inside docker-compose

2019-05-13 Thread GitBox
arp7 commented on issue #814: HDDS-1518. Use /etc/ozone for configuration inside docker-compose URL: https://github.com/apache/hadoop/pull/814#issuecomment-491959914 +1 LGTM. I see @anuengineer has an open question so I will hold off committing. --

[GitHub] [hadoop] elek commented on a change in pull request #814: HDDS-1518. Use /etc/ozone for configuration inside docker-compose

2019-05-13 Thread GitBox
elek commented on a change in pull request #814: HDDS-1518. Use /etc/ozone for configuration inside docker-compose URL: https://github.com/apache/hadoop/pull/814#discussion_r283514163 ## File path: Dockerfile ## @@ -36,7 +36,9 @@ RUN chown hadoop /opt ADD scripts /opt/

[GitHub] [hadoop] elek commented on a change in pull request #815: HDDS-1522. Provide intellij runConfiguration for Ozone components

2019-05-13 Thread GitBox
elek commented on a change in pull request #815: HDDS-1522. Provide intellij runConfiguration for Ozone components URL: https://github.com/apache/hadoop/pull/815#discussion_r283516872 ## File path: hadoop-ozone/dev-support/intellij/install-runconfigs.sh ## @@ -0,0 +1,20 @@

[GitHub] [hadoop] hadoop-yetus commented on issue #816: HDFS-14482: Crash when using libhdfs with bad classpath

2019-05-13 Thread GitBox
hadoop-yetus commented on issue #816: HDFS-14482: Crash when using libhdfs with bad classpath URL: https://github.com/apache/hadoop/pull/816#issuecomment-491970577 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|--

[GitHub] [hadoop] arp7 commented on issue #725: HDDS-1422. Exception during DataNode shutdown. Contributed by Arpit A…

2019-05-13 Thread GitBox
arp7 commented on issue #725: HDDS-1422. Exception during DataNode shutdown. Contributed by Arpit A… URL: https://github.com/apache/hadoop/pull/725#issuecomment-491978202 Fix UT failures caused by previous commit. This is an

[GitHub] [hadoop] hadoop-yetus commented on issue #810: HDDS-1512. Implement DoubleBuffer in OzoneManager.

2019-05-13 Thread GitBox
hadoop-yetus commented on issue #810: HDDS-1512. Implement DoubleBuffer in OzoneManager. URL: https://github.com/apache/hadoop/pull/810#issuecomment-491978630 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:

[GitHub] [hadoop] hadoop-yetus commented on issue #810: HDDS-1512. Implement DoubleBuffer in OzoneManager.

2019-05-13 Thread GitBox
hadoop-yetus commented on issue #810: HDDS-1512. Implement DoubleBuffer in OzoneManager. URL: https://github.com/apache/hadoop/pull/810#issuecomment-491981350 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:

[GitHub] [hadoop] hadoop-yetus commented on issue #714: HDDS-1406. Avoid usage of commonPool in RatisPipelineUtils.

2019-05-13 Thread GitBox
hadoop-yetus commented on issue #714: HDDS-1406. Avoid usage of commonPool in RatisPipelineUtils. URL: https://github.com/apache/hadoop/pull/714#issuecomment-491983496 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|--

[jira] [Commented] (HADOOP-11505) Various native parts use bswap incorrectly and unportably

2019-05-13 Thread AiBe Gee (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-11505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16838872#comment-16838872 ] AiBe Gee commented on HADOOP-11505: --- Found a fix for HADOOP-16311 (it's a duplicate)

[jira] [Commented] (HADOOP-16287) KerberosAuthenticationHandler Trusted Proxy Support for Knox

2019-05-13 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1683#comment-1683 ] Eric Yang commented on HADOOP-16287: [~Prabhu Joseph] Thank you for the patch. I t

[GitHub] [hadoop] DadanielZ edited a comment on issue #784: HADOOP-16050: s3a SSL connections should use OpenSSL

2019-05-13 Thread GitBox
DadanielZ edited a comment on issue #784: HADOOP-16050: s3a SSL connections should use OpenSSL URL: https://github.com/apache/hadoop/pull/784#issuecomment-492000546 sorry for the late reply. "We're changing the scope of the wildfly lib from compile to runtime in ABFS" looks good. +1

[GitHub] [hadoop] DadanielZ commented on issue #784: HADOOP-16050: s3a SSL connections should use OpenSSL

2019-05-13 Thread GitBox
DadanielZ commented on issue #784: HADOOP-16050: s3a SSL connections should use OpenSSL URL: https://github.com/apache/hadoop/pull/784#issuecomment-492000546 sorry for the late reply. Sure, "We're changing the scope of the wildfly lib from compile to runtime in ABFS" looks good. +1

[GitHub] [hadoop] hadoop-yetus commented on issue #795: HDDS-1491. Ozone KeyInputStream seek() should not read the chunk file.

2019-05-13 Thread GitBox
hadoop-yetus commented on issue #795: HDDS-1491. Ozone KeyInputStream seek() should not read the chunk file. URL: https://github.com/apache/hadoop/pull/795#issuecomment-492012291 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|---

[GitHub] [hadoop] eyanghwx commented on a change in pull request #814: HDDS-1518. Use /etc/ozone for configuration inside docker-compose

2019-05-13 Thread GitBox
eyanghwx commented on a change in pull request #814: HDDS-1518. Use /etc/ozone for configuration inside docker-compose URL: https://github.com/apache/hadoop/pull/814#discussion_r283566084 ## File path: Dockerfile ## @@ -36,7 +36,9 @@ RUN chown hadoop /opt ADD scripts /op

[jira] [Commented] (HADOOP-16092) Move the source of hadoop/ozone containers to the same repository

2019-05-13 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16838948#comment-16838948 ] Eric Yang commented on HADOOP-16092: We don't need hadoop-docker repository. We ca

[GitHub] [hadoop] hanishakoneru commented on issue #795: HDDS-1491. Ozone KeyInputStream seek() should not read the chunk file.

2019-05-13 Thread GitBox
hanishakoneru commented on issue #795: HDDS-1491. Ozone KeyInputStream seek() should not read the chunk file. URL: https://github.com/apache/hadoop/pull/795#issuecomment-492033413 /retest This is an automated message from

[GitHub] [hadoop] hanishakoneru commented on issue #804: HDDS-1496. Support partial chunk reads and checksum verification

2019-05-13 Thread GitBox
hanishakoneru commented on issue #804: HDDS-1496. Support partial chunk reads and checksum verification URL: https://github.com/apache/hadoop/pull/804#issuecomment-492041921 @bshashikant , @arp7 This PR consists of the patch for Partial Chunk Reads on top of HDDS-1491. The second commi

[GitHub] [hadoop] hanishakoneru merged pull request #795: HDDS-1491. Ozone KeyInputStream seek() should not read the chunk file.

2019-05-13 Thread GitBox
hanishakoneru merged pull request #795: HDDS-1491. Ozone KeyInputStream seek() should not read the chunk file. URL: https://github.com/apache/hadoop/pull/795 This is an automated message from the Apache Git Service. To respo

[GitHub] [hadoop] hanishakoneru commented on issue #795: HDDS-1491. Ozone KeyInputStream seek() should not read the chunk file.

2019-05-13 Thread GitBox
hanishakoneru commented on issue #795: HDDS-1491. Ozone KeyInputStream seek() should not read the chunk file. URL: https://github.com/apache/hadoop/pull/795#issuecomment-492068325 Thank you @bshashikant . I fixed the checkstyle issue and run checkstyle inspection locally. Looks like CI

[GitHub] [hadoop] hanishakoneru commented on issue #804: HDDS-1496. Support partial chunk reads and checksum verification

2019-05-13 Thread GitBox
hanishakoneru commented on issue #804: HDDS-1496. Support partial chunk reads and checksum verification URL: https://github.com/apache/hadoop/pull/804#issuecomment-492071737 Merger HDDS-1491 and updated this PR to include only changes for this Jira.

[GitHub] [hadoop] sahilTakiar commented on issue #784: HADOOP-16050: s3a SSL connections should use OpenSSL

2019-05-13 Thread GitBox
sahilTakiar commented on issue #784: HADOOP-16050: s3a SSL connections should use OpenSSL URL: https://github.com/apache/hadoop/pull/784#issuecomment-492091474 @steveloughran is this good to be merged now? This is an automate

[jira] [Commented] (HADOOP-16112) Delete the baseTrashPath's subDir leads to don't modify baseTrashPath

2019-05-13 Thread Lisheng Sun (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16839141#comment-16839141 ] Lisheng Sun commented on HADOOP-16112: -- Test failures are not caused by this patch

[GitHub] [hadoop] iamgd67 opened a new pull request #817: HDFS-14303: scan only meta file produce block dir structure check warn fix

2019-05-13 Thread GitBox
iamgd67 opened a new pull request #817: HDFS-14303: scan only meta file produce block dir structure check warn fix URL: https://github.com/apache/hadoop/pull/817 when scan a only meta file but no block file block, will produce a block structure warn eg: WARN DirectoryScanner:? - Blo

[GitHub] [hadoop] hadoop-yetus commented on issue #804: HDDS-1496. Support partial chunk reads and checksum verification

2019-05-13 Thread GitBox
hadoop-yetus commented on issue #804: HDDS-1496. Support partial chunk reads and checksum verification URL: https://github.com/apache/hadoop/pull/804#issuecomment-492098851 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|-