[
https://issues.apache.org/jira/browse/HADOOP-18534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xinqiu.hu updated HADOOP-18534:
---
Attachment: (was: 未命名文件 (1).png)
> Propose a mechanism to free the direct memory occupied by
[
https://issues.apache.org/jira/browse/HADOOP-18534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xinqiu.hu updated HADOOP-18534:
---
Description:
In the RPC Client, a thread called RpcRequestSender is responsible for
writing the
[
https://issues.apache.org/jira/browse/HADOOP-18534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xinqiu.hu updated HADOOP-18534:
---
Description:
In the RPC Client, a thread called RpcRequestSender is responsible for
writing the
ayushtkn commented on code in PR #5152:
URL: https://github.com/apache/hadoop/pull/5152#discussion_r1027665142
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/package-info.java:
##
@@ -1,4 +1,4 @@
-/*
+/**
Review
aajisaka closed pull request #3322: HDFS-6874. Add GETFILEBLOCKLOCATIONS
operation to HttpFS.
URL: https://github.com/apache/hadoop/pull/3322
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
aajisaka commented on PR #3322:
URL: https://github.com/apache/hadoop/pull/3322#issuecomment-1321579547
Fixed by #4750
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
slfan1989 commented on PR #5152:
URL: https://github.com/apache/hadoop/pull/5152#issuecomment-1321574600
@ayushtkn @aajisaka Can you help to review the code again? Thank you very
much! I have fixed the java doc problem of hadoop-yarn-api module.
--
This is an automated message from the
K0K0V0K commented on code in PR #5119:
URL: https://github.com/apache/hadoop/pull/5119#discussion_r1027655301
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/CommonUtil.java:
##
hadoop-yetus commented on PR #5152:
URL: https://github.com/apache/hadoop/pull/5152#issuecomment-1321559011
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
susheel-gupta commented on code in PR #5119:
URL: https://github.com/apache/hadoop/pull/5119#discussion_r1027642975
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/CommonUtil.java:
[
https://issues.apache.org/jira/browse/HADOOP-15327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636482#comment-17636482
]
ASF GitHub Bot commented on HADOOP-15327:
-
aajisaka closed pull request #3259: HADOOP-15327.
[
https://issues.apache.org/jira/browse/HADOOP-15327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636481#comment-17636481
]
ASF GitHub Bot commented on HADOOP-15327:
-
aajisaka commented on PR #3259:
URL:
aajisaka closed pull request #3259: HADOOP-15327. Upgrade MR ShuffleHandler to
use Netty4
URL: https://github.com/apache/hadoop/pull/3259
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
aajisaka commented on PR #3259:
URL: https://github.com/apache/hadoop/pull/3259#issuecomment-1321546109
Closing this PR as it's already merged into trunk. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
aajisaka commented on PR #5125:
URL: https://github.com/apache/hadoop/pull/5125#issuecomment-1321544345
I'm +1 for the @xinglin 's proposal. @ZanderXu could you update the PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
[
https://issues.apache.org/jira/browse/HADOOP-18532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Akira Ajisaka updated HADOOP-18532:
---
Summary: Update command usage in FileSystemShell.md (was: fix typos in
FileSystemShell)
[
https://issues.apache.org/jira/browse/HADOOP-18532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Akira Ajisaka resolved HADOOP-18532.
Fix Version/s: 3.4.0
3.3.9
Resolution: Fixed
Committed to
[
https://issues.apache.org/jira/browse/HADOOP-18532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636469#comment-17636469
]
ASF GitHub Bot commented on HADOOP-18532:
-
aajisaka commented on PR #5141:
URL:
[
https://issues.apache.org/jira/browse/HADOOP-18532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Akira Ajisaka reassigned HADOOP-18532:
--
Assignee: guophilipse
> fix typos in FileSystemShell
>
aajisaka commented on PR #5141:
URL: https://github.com/apache/hadoop/pull/5141#issuecomment-1321541024
Thank you @GuoPhilipse for your contribution and thank you @slfan1989
@ashutoshcipher for your reviews!
--
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/HADOOP-18532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636468#comment-17636468
]
ASF GitHub Bot commented on HADOOP-18532:
-
aajisaka merged PR #5141:
URL:
aajisaka merged PR #5141:
URL: https://github.com/apache/hadoop/pull/5141
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/HADOOP-18532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Akira Ajisaka updated HADOOP-18532:
---
Issue Type: Bug (was: Improvement)
> fix typos in FileSystemShell
>
slfan1989 opened a new pull request, #5153:
URL: https://github.com/apache/hadoop/pull/5153
JIRA: YARN-11381. Fix hadoop-yarn-common module Java Doc Errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
aajisaka commented on code in PR #4797:
URL: https://github.com/apache/hadoop/pull/4797#discussion_r1027616899
##
[
https://issues.apache.org/jira/browse/HADOOP-8728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636457#comment-17636457
]
ASF GitHub Bot commented on HADOOP-8728:
ashutoshcipher commented on PR #5010:
URL:
[
https://issues.apache.org/jira/browse/HADOOP-8728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636456#comment-17636456
]
ASF GitHub Bot commented on HADOOP-8728:
aajisaka commented on PR #5010:
URL:
[
https://issues.apache.org/jira/browse/HADOOP-8728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Akira Ajisaka updated HADOOP-8728:
--
Fix Version/s: 3.4.0
Resolution: Fixed
Status: Resolved (was: Patch
ashutoshcipher commented on PR #5010:
URL: https://github.com/apache/hadoop/pull/5010#issuecomment-1321499379
Thanks @aajisaka for reviewing and merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
aajisaka commented on PR #5010:
URL: https://github.com/apache/hadoop/pull/5010#issuecomment-1321498932
Thank you @ashutoshcipher for your contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/HADOOP-8728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636455#comment-17636455
]
ASF GitHub Bot commented on HADOOP-8728:
aajisaka merged PR #5010:
URL:
aajisaka merged PR #5010:
URL: https://github.com/apache/hadoop/pull/5010
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ashutoshcipher commented on PR #4717:
URL: https://github.com/apache/hadoop/pull/4717#issuecomment-1321498614
Thanks @aajisaka for reviewing and merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
[
https://issues.apache.org/jira/browse/HADOOP-18534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636453#comment-17636453
]
fanshilun edited comment on HADOOP-18534 at 11/21/22 5:50 AM:
--
Usually an
[
https://issues.apache.org/jira/browse/HADOOP-18534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636453#comment-17636453
]
fanshilun commented on HADOOP-18534:
Usually an rpc request is returned in milliseconds. At this
aajisaka commented on PR #4717:
URL: https://github.com/apache/hadoop/pull/4717#issuecomment-1321492007
Thank you @ashutoshcipher for your contribution and thank you @slfan1989 for
your review! Also, thank you for cleaning up bunch of checkstyle issues :)
> hadoop-yarn-project: The
aajisaka merged PR #4717:
URL: https://github.com/apache/hadoop/pull/4717
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
slfan1989 commented on PR #5152:
URL: https://github.com/apache/hadoop/pull/5152#issuecomment-1321491555
> The following error is remaining:
[
https://issues.apache.org/jira/browse/HADOOP-18534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xinqiu.hu updated HADOOP-18534:
---
Description:
In the RPC Client, a thread called RpcRequestSender is responsible for
writing the
[
https://issues.apache.org/jira/browse/HADOOP-18534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xinqiu.hu updated HADOOP-18534:
---
Description:
In the RPC Client, a thread called RpcRequestSender is responsible for
writing the
ashutoshcipher commented on PR #5029:
URL: https://github.com/apache/hadoop/pull/5029#issuecomment-1321490540
Thanks for reviewing and merging @aajisaka
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
aajisaka commented on PR #5029:
URL: https://github.com/apache/hadoop/pull/5029#issuecomment-1321490052
Thank you @ashutoshcipher
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
aajisaka merged PR #5029:
URL: https://github.com/apache/hadoop/pull/5029
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/HADOOP-18534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xinqiu.hu updated HADOOP-18534:
---
Description:
In the RPC Client, a thread called RpcRequestSender is responsible for
writing the
[
https://issues.apache.org/jira/browse/HADOOP-18534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xinqiu.hu updated HADOOP-18534:
---
Description:
In the RPC Client, a thread called RpcRequestSender is responsible for
writing the
[
https://issues.apache.org/jira/browse/HADOOP-18534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xinqiu.hu updated HADOOP-18534:
---
Description:
In the RPC Client, a thread called RpcRequestSender is responsible for
writing the
[
https://issues.apache.org/jira/browse/HADOOP-18534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xinqiu.hu updated HADOOP-18534:
---
Description:
In the RPC Client, a thread called RpcRequestSender is responsible for
writing the
aajisaka commented on PR #5152:
URL: https://github.com/apache/hadoop/pull/5152#issuecomment-1321483958
The following error is remaining:
ashutoshcipher commented on PR #4717:
URL: https://github.com/apache/hadoop/pull/4717#issuecomment-1321483949
> Thank you @ashutoshcipher The test result looks good to me. Could you
revert the empty line change?
@aajisaka - Done in my last commit.
--
This is an automated message
[
https://issues.apache.org/jira/browse/HADOOP-18534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xinqiu.hu updated HADOOP-18534:
---
Description:
In the RPC Client, a thread called RpcRequestSender is responsible for
writing the
[
https://issues.apache.org/jira/browse/HADOOP-18534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xinqiu.hu updated HADOOP-18534:
---
Description:
In the RPC Client, a thread called RpcRequestSender is responsible for
writing the
xinqiu.hu created HADOOP-18534:
--
Summary: Propose a mechanism to free the direct memory occupied by
RPC Connections
Key: HADOOP-18534
URL: https://issues.apache.org/jira/browse/HADOOP-18534
Project:
ashutoshcipher commented on PR #4717:
URL: https://github.com/apache/hadoop/pull/4717#issuecomment-1321480128
Thanks @aajisaka I will revert that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
riyakhdl commented on PR #5113:
URL: https://github.com/apache/hadoop/pull/5113#issuecomment-1321479727
@ashutoshcipher Thanks for the review,
1. I have done a small performance test to prove it, hence attaching the
logs.
aajisaka commented on PR #4717:
URL: https://github.com/apache/hadoop/pull/4717#issuecomment-1321479607
Thank you @ashutoshcipher The test result looks good to me. Could you revert
the empty line change?
--
This is an automated message from the Apache Git Service.
To respond to the
hadoop-yetus commented on PR #5152:
URL: https://github.com/apache/hadoop/pull/5152#issuecomment-1321345447
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
tomscut commented on PR #4209:
URL: https://github.com/apache/hadoop/pull/4209#issuecomment-1321325256
Hi @tasanuma @ayushtkn , could you also please take a look? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
tomscut commented on code in PR #5129:
URL: https://github.com/apache/hadoop/pull/5129#discussion_r1027393176
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java:
##
@@ -101,8 +103,24 @@ public class
tomscut commented on code in PR #5129:
URL: https://github.com/apache/hadoop/pull/5129#discussion_r1027391813
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java:
##
@@ -81,6 +81,8 @@ public class
tomscut commented on code in PR #5129:
URL: https://github.com/apache/hadoop/pull/5129#discussion_r1027391813
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java:
##
@@ -81,6 +81,8 @@ public class
[
https://issues.apache.org/jira/browse/HADOOP-18533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636371#comment-17636371
]
ASF GitHub Bot commented on HADOOP-18533:
-
slfan1989 commented on PR #5151:
URL:
slfan1989 commented on PR #5151:
URL: https://github.com/apache/hadoop/pull/5151#issuecomment-1321285981
@huxinqiu I will deal with the problem of javadoc, we can focus on the RPC
code logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
slfan1989 commented on PR #5152:
URL: https://github.com/apache/hadoop/pull/5152#issuecomment-1321285035
> The Jdk-11 one is still failing
>
hadoop-yetus commented on PR #5143:
URL: https://github.com/apache/hadoop/pull/5143#issuecomment-1321230672
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5137:
URL: https://github.com/apache/hadoop/pull/5137#issuecomment-1321226138
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5113:
URL: https://github.com/apache/hadoop/pull/5113#issuecomment-1321206502
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
ayushtkn commented on PR #5152:
URL: https://github.com/apache/hadoop/pull/5152#issuecomment-1321204292
The Jdk-11 one is still failing
[
https://issues.apache.org/jira/browse/HADOOP-18533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636309#comment-17636309
]
ASF GitHub Bot commented on HADOOP-18533:
-
hadoop-yetus commented on PR #5151:
URL:
hadoop-yetus commented on PR #5151:
URL: https://github.com/apache/hadoop/pull/5151#issuecomment-1321171513
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5152:
URL: https://github.com/apache/hadoop/pull/5152#issuecomment-1321169830
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636304#comment-17636304
]
ASF GitHub Bot commented on HADOOP-18533:
-
hadoop-yetus commented on PR #5151:
URL:
hadoop-yetus commented on PR #5151:
URL: https://github.com/apache/hadoop/pull/5151#issuecomment-1321168319
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
slfan1989 commented on PR #5152:
URL: https://github.com/apache/hadoop/pull/5152#issuecomment-1321147063
@ayushtkn Can you help review this PR? Thank you very much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
slfan1989 opened a new pull request, #5152:
URL: https://github.com/apache/hadoop/pull/5152
JIRA: YARN-11380. Fix hadoop-yarn-api module Java Doc Errors.
When finishing
[YARN-11373](https://issues.apache.org/jira/browse/YARN-11373), ps has java-doc
compilation errors, I will fix all
[
https://issues.apache.org/jira/browse/HADOOP-18533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636297#comment-17636297
]
ASF GitHub Bot commented on HADOOP-18533:
-
slfan1989 commented on PR #5151:
URL:
slfan1989 commented on PR #5151:
URL: https://github.com/apache/hadoop/pull/5151#issuecomment-1321142480
@huxinqiu Thank you very much for your contribution!
We need to discuss something:
1. It seems that the benefit is to avoid declaring this variable
`ResponseBuffer`,
haiyang1987 commented on PR #4902:
URL: https://github.com/apache/hadoop/pull/4902#issuecomment-1321129513
Hi @Hexiaoqiao @ZanderXu @tomscut @ayushtkn
please help me review this pr when you are available, Thanks.
--
This is an automated message from the Apache Git Service.
To respond
haiyang1987 commented on PR #5137:
URL: https://github.com/apache/hadoop/pull/5137#issuecomment-1321125773
Update PR,
1.change to -skipFailureBlocks
2.about return value logic(return 0 if there are not any failures, else
return 1), keep the previous logic
please @ZanderXu
[
https://issues.apache.org/jira/browse/HADOOP-18533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636285#comment-17636285
]
ASF GitHub Bot commented on HADOOP-18533:
-
hadoop-yetus commented on PR #5151:
URL:
hadoop-yetus commented on PR #5151:
URL: https://github.com/apache/hadoop/pull/5151#issuecomment-1321113348
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636281#comment-17636281
]
ASF GitHub Bot commented on HADOOP-18531:
-
slfan1989 commented on PR #5149:
URL:
slfan1989 commented on PR #5149:
URL: https://github.com/apache/hadoop/pull/5149#issuecomment-1321102666
LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
tomscut commented on code in PR #5137:
URL: https://github.com/apache/hadoop/pull/5137#discussion_r1027256611
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DebugAdmin.java:
##
@@ -432,8 +432,16 @@ private class VerifyECCommand extends
tasanuma commented on code in PR #5137:
URL: https://github.com/apache/hadoop/pull/5137#discussion_r1027248133
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DebugAdmin.java:
##
@@ -432,8 +432,16 @@ private class VerifyECCommand extends
84 matches
Mail list logo