[jira] [Updated] (HADOOP-18534) Propose a mechanism to free the direct memory occupied by RPC Connections

2022-11-20 Thread xinqiu.hu (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xinqiu.hu updated HADOOP-18534: --- Attachment: (was: 未命名文件 (1).png) > Propose a mechanism to free the direct memory occupied by

[jira] [Updated] (HADOOP-18534) Propose a mechanism to free the direct memory occupied by RPC Connections

2022-11-20 Thread xinqiu.hu (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xinqiu.hu updated HADOOP-18534: --- Description:   In the RPC Client, a thread called RpcRequestSender is responsible for writing the

[jira] [Updated] (HADOOP-18534) Propose a mechanism to free the direct memory occupied by RPC Connections

2022-11-20 Thread xinqiu.hu (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xinqiu.hu updated HADOOP-18534: --- Description:   In the RPC Client, a thread called RpcRequestSender is responsible for writing the

[GitHub] [hadoop] ayushtkn commented on a diff in pull request #5152: YARN-11380. Fix hadoop-yarn-api module Java Doc Errors.

2022-11-20 Thread GitBox
ayushtkn commented on code in PR #5152: URL: https://github.com/apache/hadoop/pull/5152#discussion_r1027665142 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/package-info.java: ## @@ -1,4 +1,4 @@ -/* +/** Review

[GitHub] [hadoop] aajisaka closed pull request #3322: HDFS-6874. Add GETFILEBLOCKLOCATIONS operation to HttpFS.

2022-11-20 Thread GitBox
aajisaka closed pull request #3322: HDFS-6874. Add GETFILEBLOCKLOCATIONS operation to HttpFS. URL: https://github.com/apache/hadoop/pull/3322 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hadoop] aajisaka commented on pull request #3322: HDFS-6874. Add GETFILEBLOCKLOCATIONS operation to HttpFS.

2022-11-20 Thread GitBox
aajisaka commented on PR #3322: URL: https://github.com/apache/hadoop/pull/3322#issuecomment-1321579547 Fixed by #4750 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hadoop] slfan1989 commented on pull request #5152: YARN-11380. Fix hadoop-yarn-api module Java Doc Errors.

2022-11-20 Thread GitBox
slfan1989 commented on PR #5152: URL: https://github.com/apache/hadoop/pull/5152#issuecomment-1321574600 @ayushtkn @aajisaka Can you help to review the code again? Thank you very much! I have fixed the java doc problem of hadoop-yarn-api module. -- This is an automated message from the

[GitHub] [hadoop] K0K0V0K commented on a diff in pull request #5119: YARN-5607. Document TestContainerResourceUsage#waitForContainerCompletion

2022-11-20 Thread GitBox
K0K0V0K commented on code in PR #5119: URL: https://github.com/apache/hadoop/pull/5119#discussion_r1027655301 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/CommonUtil.java: ##

[GitHub] [hadoop] hadoop-yetus commented on pull request #5152: YARN-11380. Fix hadoop-yarn-api module Java Doc Errors.

2022-11-20 Thread GitBox
hadoop-yetus commented on PR #5152: URL: https://github.com/apache/hadoop/pull/5152#issuecomment-1321559011 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] susheel-gupta commented on a diff in pull request #5119: YARN-5607. Document TestContainerResourceUsage#waitForContainerCompletion

2022-11-20 Thread GitBox
susheel-gupta commented on code in PR #5119: URL: https://github.com/apache/hadoop/pull/5119#discussion_r1027642975 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/CommonUtil.java:

[jira] [Commented] (HADOOP-15327) Upgrade MR ShuffleHandler to use Netty4

2022-11-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636482#comment-17636482 ] ASF GitHub Bot commented on HADOOP-15327: - aajisaka closed pull request #3259: HADOOP-15327.

[jira] [Commented] (HADOOP-15327) Upgrade MR ShuffleHandler to use Netty4

2022-11-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636481#comment-17636481 ] ASF GitHub Bot commented on HADOOP-15327: - aajisaka commented on PR #3259: URL:

[GitHub] [hadoop] aajisaka closed pull request #3259: HADOOP-15327. Upgrade MR ShuffleHandler to use Netty4

2022-11-20 Thread GitBox
aajisaka closed pull request #3259: HADOOP-15327. Upgrade MR ShuffleHandler to use Netty4 URL: https://github.com/apache/hadoop/pull/3259 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hadoop] aajisaka commented on pull request #3259: HADOOP-15327. Upgrade MR ShuffleHandler to use Netty4

2022-11-20 Thread GitBox
aajisaka commented on PR #3259: URL: https://github.com/apache/hadoop/pull/3259#issuecomment-1321546109 Closing this PR as it's already merged into trunk. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop] aajisaka commented on pull request #5125: HDFS-16838. Fix NPE in testAddRplicaProcessorForAddingReplicaInMap

2022-11-20 Thread GitBox
aajisaka commented on PR #5125: URL: https://github.com/apache/hadoop/pull/5125#issuecomment-1321544345 I'm +1 for the @xinglin 's proposal. @ZanderXu could you update the PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Updated] (HADOOP-18532) Update command usage in FileSystemShell.md

2022-11-20 Thread Akira Ajisaka (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka updated HADOOP-18532: --- Summary: Update command usage in FileSystemShell.md (was: fix typos in FileSystemShell)

[jira] [Resolved] (HADOOP-18532) fix typos in FileSystemShell

2022-11-20 Thread Akira Ajisaka (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka resolved HADOOP-18532. Fix Version/s: 3.4.0 3.3.9 Resolution: Fixed Committed to

[jira] [Commented] (HADOOP-18532) fix typos in FileSystemShell

2022-11-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636469#comment-17636469 ] ASF GitHub Bot commented on HADOOP-18532: - aajisaka commented on PR #5141: URL:

[jira] [Assigned] (HADOOP-18532) fix typos in FileSystemShell

2022-11-20 Thread Akira Ajisaka (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka reassigned HADOOP-18532: -- Assignee: guophilipse > fix typos in FileSystemShell >

[GitHub] [hadoop] aajisaka commented on pull request #5141: HADOOP-18532. Update command usage in FileSystemShell.md

2022-11-20 Thread GitBox
aajisaka commented on PR #5141: URL: https://github.com/apache/hadoop/pull/5141#issuecomment-1321541024 Thank you @GuoPhilipse for your contribution and thank you @slfan1989 @ashutoshcipher for your reviews! -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (HADOOP-18532) fix typos in FileSystemShell

2022-11-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636468#comment-17636468 ] ASF GitHub Bot commented on HADOOP-18532: - aajisaka merged PR #5141: URL:

[GitHub] [hadoop] aajisaka merged pull request #5141: HADOOP-18532. Update command usage in FileSystemShell.md

2022-11-20 Thread GitBox
aajisaka merged PR #5141: URL: https://github.com/apache/hadoop/pull/5141 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (HADOOP-18532) fix typos in FileSystemShell

2022-11-20 Thread Akira Ajisaka (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka updated HADOOP-18532: --- Issue Type: Bug (was: Improvement) > fix typos in FileSystemShell >

[GitHub] [hadoop] slfan1989 opened a new pull request, #5153: YARN-11381. Fix hadoop-yarn-common module Java Doc Errors.

2022-11-20 Thread GitBox
slfan1989 opened a new pull request, #5153: URL: https://github.com/apache/hadoop/pull/5153 JIRA: YARN-11381. Fix hadoop-yarn-common module Java Doc Errors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop] aajisaka commented on a diff in pull request #4797: YARN-11277. Trigger log-dir deletion by size for NonAggregatingLogHandler

2022-11-20 Thread GitBox
aajisaka commented on code in PR #4797: URL: https://github.com/apache/hadoop/pull/4797#discussion_r1027616899 ##

[jira] [Commented] (HADOOP-8728) Display (fs -text) shouldn't hard-depend on Writable serialized sequence files.

2022-11-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-8728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636457#comment-17636457 ] ASF GitHub Bot commented on HADOOP-8728: ashutoshcipher commented on PR #5010: URL:

[jira] [Commented] (HADOOP-8728) Display (fs -text) shouldn't hard-depend on Writable serialized sequence files.

2022-11-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-8728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636456#comment-17636456 ] ASF GitHub Bot commented on HADOOP-8728: aajisaka commented on PR #5010: URL:

[jira] [Updated] (HADOOP-8728) Display (fs -text) shouldn't hard-depend on Writable serialized sequence files.

2022-11-20 Thread Akira Ajisaka (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-8728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka updated HADOOP-8728: -- Fix Version/s: 3.4.0 Resolution: Fixed Status: Resolved (was: Patch

[GitHub] [hadoop] ashutoshcipher commented on pull request #5010: HADOOP-8728. Display (fs -text) shouldn't hard-depend on Writable serialized sequence files.

2022-11-20 Thread GitBox
ashutoshcipher commented on PR #5010: URL: https://github.com/apache/hadoop/pull/5010#issuecomment-1321499379 Thanks @aajisaka for reviewing and merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hadoop] aajisaka commented on pull request #5010: HADOOP-8728. Display (fs -text) shouldn't hard-depend on Writable serialized sequence files.

2022-11-20 Thread GitBox
aajisaka commented on PR #5010: URL: https://github.com/apache/hadoop/pull/5010#issuecomment-1321498932 Thank you @ashutoshcipher for your contribution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (HADOOP-8728) Display (fs -text) shouldn't hard-depend on Writable serialized sequence files.

2022-11-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-8728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636455#comment-17636455 ] ASF GitHub Bot commented on HADOOP-8728: aajisaka merged PR #5010: URL:

[GitHub] [hadoop] aajisaka merged pull request #5010: HADOOP-8728. Display (fs -text) shouldn't hard-depend on Writable serialized sequence files.

2022-11-20 Thread GitBox
aajisaka merged PR #5010: URL: https://github.com/apache/hadoop/pull/5010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] ashutoshcipher commented on pull request #4717: YARN-6946. Upgrade JUnit from 4 to 5 in hadoop-yarn-common

2022-11-20 Thread GitBox
ashutoshcipher commented on PR #4717: URL: https://github.com/apache/hadoop/pull/4717#issuecomment-1321498614 Thanks @aajisaka for reviewing and merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Comment Edited] (HADOOP-18534) Propose a mechanism to free the direct memory occupied by RPC Connections

2022-11-20 Thread fanshilun (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636453#comment-17636453 ] fanshilun edited comment on HADOOP-18534 at 11/21/22 5:50 AM: -- Usually an

[jira] [Commented] (HADOOP-18534) Propose a mechanism to free the direct memory occupied by RPC Connections

2022-11-20 Thread fanshilun (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636453#comment-17636453 ] fanshilun commented on HADOOP-18534: Usually an rpc request is returned in milliseconds. At this

[GitHub] [hadoop] aajisaka commented on pull request #4717: YARN-6946. Upgrade JUnit from 4 to 5 in hadoop-yarn-common

2022-11-20 Thread GitBox
aajisaka commented on PR #4717: URL: https://github.com/apache/hadoop/pull/4717#issuecomment-1321492007 Thank you @ashutoshcipher for your contribution and thank you @slfan1989 for your review! Also, thank you for cleaning up bunch of checkstyle issues :) > hadoop-yarn-project: The

[GitHub] [hadoop] aajisaka merged pull request #4717: YARN-6946. Upgrade JUnit from 4 to 5 in hadoop-yarn-common

2022-11-20 Thread GitBox
aajisaka merged PR #4717: URL: https://github.com/apache/hadoop/pull/4717 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] slfan1989 commented on pull request #5152: YARN-11380. Fix hadoop-yarn-api module Java Doc Errors.

2022-11-20 Thread GitBox
slfan1989 commented on PR #5152: URL: https://github.com/apache/hadoop/pull/5152#issuecomment-1321491555 > The following error is remaining:

[jira] [Updated] (HADOOP-18534) Propose a mechanism to free the direct memory occupied by RPC Connections

2022-11-20 Thread xinqiu.hu (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xinqiu.hu updated HADOOP-18534: --- Description:   In the RPC Client, a thread called RpcRequestSender is responsible for writing the

[jira] [Updated] (HADOOP-18534) Propose a mechanism to free the direct memory occupied by RPC Connections

2022-11-20 Thread xinqiu.hu (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xinqiu.hu updated HADOOP-18534: --- Description:   In the RPC Client, a thread called RpcRequestSender is responsible for writing the

[GitHub] [hadoop] ashutoshcipher commented on pull request #5029: MAPREDUCE-7422. Upgrade Junit 4 to 5 in hadoop-mapreduce-examples

2022-11-20 Thread GitBox
ashutoshcipher commented on PR #5029: URL: https://github.com/apache/hadoop/pull/5029#issuecomment-1321490540 Thanks for reviewing and merging @aajisaka -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hadoop] aajisaka commented on pull request #5029: MAPREDUCE-7422. Upgrade Junit 4 to 5 in hadoop-mapreduce-examples

2022-11-20 Thread GitBox
aajisaka commented on PR #5029: URL: https://github.com/apache/hadoop/pull/5029#issuecomment-1321490052 Thank you @ashutoshcipher -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hadoop] aajisaka merged pull request #5029: MAPREDUCE-7422. Upgrade Junit 4 to 5 in hadoop-mapreduce-examples

2022-11-20 Thread GitBox
aajisaka merged PR #5029: URL: https://github.com/apache/hadoop/pull/5029 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (HADOOP-18534) Propose a mechanism to free the direct memory occupied by RPC Connections

2022-11-20 Thread xinqiu.hu (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xinqiu.hu updated HADOOP-18534: --- Description:   In the RPC Client, a thread called RpcRequestSender is responsible for writing the

[jira] [Updated] (HADOOP-18534) Propose a mechanism to free the direct memory occupied by RPC Connections

2022-11-20 Thread xinqiu.hu (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xinqiu.hu updated HADOOP-18534: --- Description:   In the RPC Client, a thread called RpcRequestSender is responsible for writing the

[jira] [Updated] (HADOOP-18534) Propose a mechanism to free the direct memory occupied by RPC Connections

2022-11-20 Thread xinqiu.hu (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xinqiu.hu updated HADOOP-18534: --- Description:   In the RPC Client, a thread called RpcRequestSender is responsible for writing the

[jira] [Updated] (HADOOP-18534) Propose a mechanism to free the direct memory occupied by RPC Connections

2022-11-20 Thread xinqiu.hu (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xinqiu.hu updated HADOOP-18534: --- Description:   In the RPC Client, a thread called RpcRequestSender is responsible for writing the

[GitHub] [hadoop] aajisaka commented on pull request #5152: YARN-11380. Fix hadoop-yarn-api module Java Doc Errors.

2022-11-20 Thread GitBox
aajisaka commented on PR #5152: URL: https://github.com/apache/hadoop/pull/5152#issuecomment-1321483958 The following error is remaining:

[GitHub] [hadoop] ashutoshcipher commented on pull request #4717: YARN-6946. Upgrade JUnit from 4 to 5 in hadoop-yarn-common

2022-11-20 Thread GitBox
ashutoshcipher commented on PR #4717: URL: https://github.com/apache/hadoop/pull/4717#issuecomment-1321483949 > Thank you @ashutoshcipher The test result looks good to me. Could you revert the empty line change? @aajisaka - Done in my last commit. -- This is an automated message

[jira] [Updated] (HADOOP-18534) Propose a mechanism to free the direct memory occupied by RPC Connections

2022-11-20 Thread xinqiu.hu (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xinqiu.hu updated HADOOP-18534: --- Description:   In the RPC Client, a thread called RpcRequestSender is responsible for writing the

[jira] [Updated] (HADOOP-18534) Propose a mechanism to free the direct memory occupied by RPC Connections

2022-11-20 Thread xinqiu.hu (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xinqiu.hu updated HADOOP-18534: --- Description:   In the RPC Client, a thread called RpcRequestSender is responsible for writing the

[jira] [Created] (HADOOP-18534) Propose a mechanism to free the direct memory occupied by RPC Connections

2022-11-20 Thread xinqiu.hu (Jira)
xinqiu.hu created HADOOP-18534: -- Summary: Propose a mechanism to free the direct memory occupied by RPC Connections Key: HADOOP-18534 URL: https://issues.apache.org/jira/browse/HADOOP-18534 Project:

[GitHub] [hadoop] ashutoshcipher commented on pull request #4717: YARN-6946. Upgrade JUnit from 4 to 5 in hadoop-yarn-common

2022-11-20 Thread GitBox
ashutoshcipher commented on PR #4717: URL: https://github.com/apache/hadoop/pull/4717#issuecomment-1321480128 Thanks @aajisaka I will revert that -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hadoop] riyakhdl commented on pull request #5113: YARN-6971 Clean up different ways to create resources

2022-11-20 Thread GitBox
riyakhdl commented on PR #5113: URL: https://github.com/apache/hadoop/pull/5113#issuecomment-1321479727 @ashutoshcipher Thanks for the review, 1. I have done a small performance test to prove it, hence attaching the logs.

[GitHub] [hadoop] aajisaka commented on pull request #4717: YARN-6946. Upgrade JUnit from 4 to 5 in hadoop-yarn-common

2022-11-20 Thread GitBox
aajisaka commented on PR #4717: URL: https://github.com/apache/hadoop/pull/4717#issuecomment-1321479607 Thank you @ashutoshcipher The test result looks good to me. Could you revert the empty line change? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop] hadoop-yetus commented on pull request #5152: YARN-11380. Fix hadoop-yarn-api module Java Doc Errors.

2022-11-20 Thread GitBox
hadoop-yetus commented on PR #5152: URL: https://github.com/apache/hadoop/pull/5152#issuecomment-1321345447 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] tomscut commented on pull request #4209: HDFS-16550. Improper cache-size for journal node may cause cluster crash

2022-11-20 Thread GitBox
tomscut commented on PR #4209: URL: https://github.com/apache/hadoop/pull/4209#issuecomment-1321325256 Hi @tasanuma @ayushtkn , could you also please take a look? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hadoop] tomscut commented on a diff in pull request #5129: HDFS-16840. Enhance the usage description about oiv in HDFSCommands.md and OfflineImageViewerPB

2022-11-20 Thread GitBox
tomscut commented on code in PR #5129: URL: https://github.com/apache/hadoop/pull/5129#discussion_r1027393176 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java: ## @@ -101,8 +103,24 @@ public class

[GitHub] [hadoop] tomscut commented on a diff in pull request #5129: HDFS-16840. Enhance the usage description about oiv in HDFSCommands.md and OfflineImageViewerPB

2022-11-20 Thread GitBox
tomscut commented on code in PR #5129: URL: https://github.com/apache/hadoop/pull/5129#discussion_r1027391813 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java: ## @@ -81,6 +81,8 @@ public class

[GitHub] [hadoop] tomscut commented on a diff in pull request #5129: HDFS-16840. Enhance the usage description about oiv in HDFSCommands.md and OfflineImageViewerPB

2022-11-20 Thread GitBox
tomscut commented on code in PR #5129: URL: https://github.com/apache/hadoop/pull/5129#discussion_r1027391813 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java: ## @@ -81,6 +81,8 @@ public class

[jira] [Commented] (HADOOP-18533) RPC Client performance improvement

2022-11-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636371#comment-17636371 ] ASF GitHub Bot commented on HADOOP-18533: - slfan1989 commented on PR #5151: URL:

[GitHub] [hadoop] slfan1989 commented on pull request #5151: HADOOP-18533. RPC Client performance improvement

2022-11-20 Thread GitBox
slfan1989 commented on PR #5151: URL: https://github.com/apache/hadoop/pull/5151#issuecomment-1321285981 @huxinqiu I will deal with the problem of javadoc, we can focus on the RPC code logic. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hadoop] slfan1989 commented on pull request #5152: YARN-11380. Fix hadoop-yarn-api module Java Doc Errors.

2022-11-20 Thread GitBox
slfan1989 commented on PR #5152: URL: https://github.com/apache/hadoop/pull/5152#issuecomment-1321285035 > The Jdk-11 one is still failing >

[GitHub] [hadoop] hadoop-yetus commented on pull request #5143: HDFS-16846. EC: Only EC blocks should be effected by max-streams-hard-limit configuration

2022-11-20 Thread GitBox
hadoop-yetus commented on PR #5143: URL: https://github.com/apache/hadoop/pull/5143#issuecomment-1321230672 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5137: HDFS-16841. Enhance the function of DebugAdmin#VerifyECCommand

2022-11-20 Thread GitBox
hadoop-yetus commented on PR #5137: URL: https://github.com/apache/hadoop/pull/5137#issuecomment-1321226138 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5113: YARN-6971 Clean up different ways to create resources

2022-11-20 Thread GitBox
hadoop-yetus commented on PR #5113: URL: https://github.com/apache/hadoop/pull/5113#issuecomment-1321206502 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] ayushtkn commented on pull request #5152: YARN-11380. Fix hadoop-yarn-api module Java Doc Errors.

2022-11-20 Thread GitBox
ayushtkn commented on PR #5152: URL: https://github.com/apache/hadoop/pull/5152#issuecomment-1321204292 The Jdk-11 one is still failing

[jira] [Commented] (HADOOP-18533) RPC Client performance improvement

2022-11-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636309#comment-17636309 ] ASF GitHub Bot commented on HADOOP-18533: - hadoop-yetus commented on PR #5151: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5151: HADOOP-18533. RPC Client performance improvement

2022-11-20 Thread GitBox
hadoop-yetus commented on PR #5151: URL: https://github.com/apache/hadoop/pull/5151#issuecomment-1321171513 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5152: YARN-11380. Fix hadoop-yarn-api module Java Doc Errors.

2022-11-20 Thread GitBox
hadoop-yetus commented on PR #5152: URL: https://github.com/apache/hadoop/pull/5152#issuecomment-1321169830 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18533) RPC Client performance improvement

2022-11-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636304#comment-17636304 ] ASF GitHub Bot commented on HADOOP-18533: - hadoop-yetus commented on PR #5151: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5151: HADOOP-18533. RPC Client performance improvement

2022-11-20 Thread GitBox
hadoop-yetus commented on PR #5151: URL: https://github.com/apache/hadoop/pull/5151#issuecomment-1321168319 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 commented on pull request #5152: YARN-11380. Fix hadoop-yarn-api module Java Doc Errors.

2022-11-20 Thread GitBox
slfan1989 commented on PR #5152: URL: https://github.com/apache/hadoop/pull/5152#issuecomment-1321147063 @ayushtkn Can you help review this PR? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop] slfan1989 opened a new pull request, #5152: YARN-11380. Fix hadoop-yarn-api module Java Doc Errors.

2022-11-20 Thread GitBox
slfan1989 opened a new pull request, #5152: URL: https://github.com/apache/hadoop/pull/5152 JIRA: YARN-11380. Fix hadoop-yarn-api module Java Doc Errors. When finishing [YARN-11373](https://issues.apache.org/jira/browse/YARN-11373), ps has java-doc compilation errors, I will fix all

[jira] [Commented] (HADOOP-18533) RPC Client performance improvement

2022-11-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636297#comment-17636297 ] ASF GitHub Bot commented on HADOOP-18533: - slfan1989 commented on PR #5151: URL:

[GitHub] [hadoop] slfan1989 commented on pull request #5151: HADOOP-18533. RPC Client performance improvement

2022-11-20 Thread GitBox
slfan1989 commented on PR #5151: URL: https://github.com/apache/hadoop/pull/5151#issuecomment-1321142480 @huxinqiu Thank you very much for your contribution! We need to discuss something: 1. It seems that the benefit is to avoid declaring this variable `ResponseBuffer`,

[GitHub] [hadoop] haiyang1987 commented on pull request #4902: HDFS-16775.Improve BlockPlacementPolicyRackFaultTolerant's chooseOnce

2022-11-20 Thread GitBox
haiyang1987 commented on PR #4902: URL: https://github.com/apache/hadoop/pull/4902#issuecomment-1321129513 Hi @Hexiaoqiao @ZanderXu @tomscut @ayushtkn please help me review this pr when you are available, Thanks. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [hadoop] haiyang1987 commented on pull request #5137: HDFS-16841. Enhance the function of DebugAdmin#VerifyECCommand

2022-11-20 Thread GitBox
haiyang1987 commented on PR #5137: URL: https://github.com/apache/hadoop/pull/5137#issuecomment-1321125773 Update PR, 1.change to -skipFailureBlocks 2.about return value logic(return 0 if there are not any failures, else return 1), keep the previous logic please @ZanderXu

[jira] [Commented] (HADOOP-18533) RPC Client performance improvement

2022-11-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636285#comment-17636285 ] ASF GitHub Bot commented on HADOOP-18533: - hadoop-yetus commented on PR #5151: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5151: HADOOP-18533. RPC Client performance improvement

2022-11-20 Thread GitBox
hadoop-yetus commented on PR #5151: URL: https://github.com/apache/hadoop/pull/5151#issuecomment-1321113348 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18531) assertion failure in ITestS3APrefetchingInputStream

2022-11-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636281#comment-17636281 ] ASF GitHub Bot commented on HADOOP-18531: - slfan1989 commented on PR #5149: URL:

[GitHub] [hadoop] slfan1989 commented on pull request #5149: HADOOP-18531. Fix assertion failure in ITestS3APrefetchingInputStream

2022-11-20 Thread GitBox
slfan1989 commented on PR #5149: URL: https://github.com/apache/hadoop/pull/5149#issuecomment-1321102666 LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hadoop] tomscut commented on a diff in pull request #5137: HDFS-16841. Enhance the function of DebugAdmin#VerifyECCommand

2022-11-20 Thread GitBox
tomscut commented on code in PR #5137: URL: https://github.com/apache/hadoop/pull/5137#discussion_r1027256611 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DebugAdmin.java: ## @@ -432,8 +432,16 @@ private class VerifyECCommand extends

[GitHub] [hadoop] tasanuma commented on a diff in pull request #5137: HDFS-16841. Enhance the function of DebugAdmin#VerifyECCommand

2022-11-20 Thread GitBox
tasanuma commented on code in PR #5137: URL: https://github.com/apache/hadoop/pull/5137#discussion_r1027248133 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DebugAdmin.java: ## @@ -432,8 +432,16 @@ private class VerifyECCommand extends