[GitHub] [hadoop] tasanuma merged pull request #5296: HDFS-16888. BlockManager#maxReplicationStreams, replicationStreamsHardLimit, blocksReplWorkMultiplier and PendingReconstructionBlocks#timeout shou

2023-01-31 Thread via GitHub
tasanuma merged PR #5296: URL: https://github.com/apache/hadoop/pull/5296 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] tasanuma commented on pull request #5296: HDFS-16888. BlockManager#maxReplicationStreams, replicationStreamsHardLimit, blocksReplWorkMultiplier and PendingReconstructionBlocks#timeou

2023-01-31 Thread via GitHub
tasanuma commented on PR #5296: URL: https://github.com/apache/hadoop/pull/5296#issuecomment-1409977862 I confirmed that `mvn install` succeeded, and the changed tests passed on my local computer. I merged it. Thanks for your contribution, @haiyang1987. Thanks for your review,

[GitHub] [hadoop] ashutoshcipher commented on pull request #5293: YARN-11414. ClusterMetricsInfo shows wrong availableMB when node labels enabled

2023-01-31 Thread via GitHub
ashutoshcipher commented on PR #5293: URL: https://github.com/apache/hadoop/pull/5293#issuecomment-1409990939 Hi @cnauroth, Please help in reviewing the PR in your free slot. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (HADOOP-18582) No need to clean tmp files in distcp direct mode

2023-01-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682467#comment-17682467 ] ASF GitHub Bot commented on HADOOP-18582: - steveloughran commented on PR #5251: URL:

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5326: YARN-11425. [Federation] Router Supports SubClusterCleaner.

2023-01-31 Thread via GitHub
slfan1989 commented on code in PR #5326: URL: https://github.com/apache/hadoop/pull/5326#discussion_r1091699471 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/cleaner/TestSubClusterCleaner.java:

[jira] [Commented] (HADOOP-18206) Cleanup the commons-logging references in the code base

2023-01-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682472#comment-17682472 ] ASF GitHub Bot commented on HADOOP-18206: - steveloughran commented on code in PR #5315: URL:

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

2023-01-31 Thread via GitHub
steveloughran commented on code in PR #5315: URL: https://github.com/apache/hadoop/pull/5315#discussion_r1091697823 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/log/LogLevel.java: ## @@ -340,22 +337,14 @@ public void doGet(HttpServletRequest request,

[GitHub] [hadoop] iwasakims commented on pull request #5319: HADOOP-18598. maven site generation doesn't include javadocs.

2023-01-31 Thread via GitHub
iwasakims commented on PR #5319: URL: https://github.com/apache/hadoop/pull/5319#issuecomment-1410146118 Thanks, @cnauroth. I merged this to branch-3.3 and cherry-picked it to trunk since I can test this on trunk after #5331. -- This is an automated message from the Apache Git Service.

[jira] [Commented] (HADOOP-18598) maven site generation doesn't include javadocs

2023-01-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682493#comment-17682493 ] ASF GitHub Bot commented on HADOOP-18598: - iwasakims commented on PR #5319: URL:

[jira] [Commented] (HADOOP-18609) Fix source code modification after building with docs profile

2023-01-31 Thread Masatake Iwasaki (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682499#comment-17682499 ] Masatake Iwasaki commented on HADOOP-18609: --- {noformat} $ mvn clean install -DskipTests

[GitHub] [hadoop] hadoop-yetus commented on pull request #5333: HDFS-16815. Error occurred in processing CacheManagerSection for xml parsing fsimage

2023-01-31 Thread via GitHub
hadoop-yetus commented on PR #5333: URL: https://github.com/apache/hadoop/pull/5333#issuecomment-1410298119 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18206) Cleanup the commons-logging references in the code base

2023-01-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682574#comment-17682574 ] ASF GitHub Bot commented on HADOOP-18206: - hadoop-yetus commented on PR #5315: URL:

[GitHub] [hadoop] steveloughran commented on pull request #5251: HADOOP-18582. skip unnecessary cleanup logic in distcp

2023-01-31 Thread via GitHub
steveloughran commented on PR #5251: URL: https://github.com/apache/hadoop/pull/5251#issuecomment-1410065588 nice. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hadoop] iwasakims commented on pull request #5331: HADOOP-18601. Fix build failure with docs profile.

2023-01-31 Thread via GitHub
iwasakims commented on PR #5331: URL: https://github.com/apache/hadoop/pull/5331#issuecomment-1410131241 > this doesn't relate to whatever is stopping api docs getting into the site on 3.3, does it? Yes. We need to address the version mismatch between maven-site-plugin and

[GitHub] [hadoop] iwasakims merged pull request #5319: HADOOP-18598. maven site generation doesn't include javadocs.

2023-01-31 Thread via GitHub
iwasakims merged PR #5319: URL: https://github.com/apache/hadoop/pull/5319 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (HADOOP-18598) maven site generation doesn't include javadocs

2023-01-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682489#comment-17682489 ] ASF GitHub Bot commented on HADOOP-18598: - iwasakims merged PR #5319: URL:

[GitHub] [hadoop] iwasakims merged pull request #5331: HADOOP-18601. Fix build failure with docs profile.

2023-01-31 Thread via GitHub
iwasakims merged PR #5331: URL: https://github.com/apache/hadoop/pull/5331 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (HADOOP-18598) maven site generation doesn't include javadocs

2023-01-31 Thread Masatake Iwasaki (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682497#comment-17682497 ] Masatake Iwasaki commented on HADOOP-18598: --- {quote} rc validation scripts to include checks

[GitHub] [hadoop] tasanuma commented on pull request #4127: HDFS-16767. RBF: Support observer node from Router-Based Federation

2023-01-31 Thread via GitHub
tasanuma commented on PR #4127: URL: https://github.com/apache/hadoop/pull/4127#issuecomment-1410205059 Actually, it was committed to trunk. https://github.com/apache/hadoop/commit/6422eaf3017eed43d081406ab0c41426c9b6dc6f -- This is an automated message from the Apache Git Service. To

[jira] [Comment Edited] (HADOOP-18609) Fix source code modification after building with docs profile

2023-01-31 Thread Masatake Iwasaki (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682502#comment-17682502 ] Masatake Iwasaki edited comment on HADOOP-18609 at 1/31/23 11:33 AM:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

2023-01-31 Thread via GitHub
hadoop-yetus commented on PR #5315: URL: https://github.com/apache/hadoop/pull/5315#issuecomment-1410316168 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18601) Fix build failure with docs profile

2023-01-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682485#comment-17682485 ] ASF GitHub Bot commented on HADOOP-18601: - iwasakims merged PR #5331: URL:

[GitHub] [hadoop] iwasakims commented on pull request #5331: HADOOP-18601. Fix build failure with docs profile.

2023-01-31 Thread via GitHub
iwasakims commented on PR #5331: URL: https://github.com/apache/hadoop/pull/5331#issuecomment-1410135010 I merged this. Thanks, @steveloughran. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (HADOOP-18609) Fix source code modification after building with docs profile

2023-01-31 Thread Masatake Iwasaki (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682502#comment-17682502 ] Masatake Iwasaki commented on HADOOP-18609: --- I found this on HADOOP-18601 but turned out to

[jira] [Commented] (HADOOP-18598) maven site generation doesn't include javadocs

2023-01-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682510#comment-17682510 ] ASF GitHub Bot commented on HADOOP-18598: - iwasakims commented on PR #5319: URL:

[jira] [Resolved] (HADOOP-18598) maven site generation doesn't include javadocs

2023-01-31 Thread Masatake Iwasaki (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Masatake Iwasaki resolved HADOOP-18598. --- Fix Version/s: 3.4.0 3.3.5 Hadoop Flags: Reviewed

[GitHub] [hadoop] Apache9 commented on a diff in pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

2023-01-31 Thread via GitHub
Apache9 commented on code in PR #5315: URL: https://github.com/apache/hadoop/pull/5315#discussion_r1091726604 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/log/LogLevel.java: ## @@ -340,22 +337,14 @@ public void doGet(HttpServletRequest request,

[jira] [Commented] (HADOOP-18206) Cleanup the commons-logging references in the code base

2023-01-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682572#comment-17682572 ] ASF GitHub Bot commented on HADOOP-18206: - Apache9 commented on code in PR #5315: URL:

[jira] [Created] (HADOOP-18609) Fix source code modification after building with docs profile

2023-01-31 Thread Masatake Iwasaki (Jira)
Masatake Iwasaki created HADOOP-18609: - Summary: Fix source code modification after building with docs profile Key: HADOOP-18609 URL: https://issues.apache.org/jira/browse/HADOOP-18609 Project:

[GitHub] [hadoop] Daniel-009497 commented on pull request #4127: HDFS-16767. RBF: Support observer node from Router-Based Federation

2023-01-31 Thread via GitHub
Daniel-009497 commented on PR #4127: URL: https://github.com/apache/hadoop/pull/4127#issuecomment-1410193590 Why it is closed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hadoop] iwasakims commented on pull request #5319: HADOOP-18598. maven site generation doesn't include javadocs.

2023-01-31 Thread via GitHub
iwasakims commented on PR #5319: URL: https://github.com/apache/hadoop/pull/5319#issuecomment-1410193583 cherry-picked this to branch-3.3.5 too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hadoop] hadoop-yetus commented on pull request #5318: YARN-11412 Concurrent user management

2023-01-31 Thread via GitHub
hadoop-yetus commented on PR #5318: URL: https://github.com/apache/hadoop/pull/5318#issuecomment-1410268516 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5326: YARN-11425. [Federation] Router Supports SubClusterCleaner.

2023-01-31 Thread via GitHub
hadoop-yetus commented on PR #5326: URL: https://github.com/apache/hadoop/pull/5326#issuecomment-1410307637 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5326: YARN-11425. [Federation] Router Supports SubClusterCleaner.

2023-01-31 Thread via GitHub
slfan1989 commented on code in PR #5326: URL: https://github.com/apache/hadoop/pull/5326#discussion_r1091699471 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/cleaner/TestSubClusterCleaner.java:

[jira] [Commented] (HADOOP-18601) Fix build failure with docs profile

2023-01-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682483#comment-17682483 ] ASF GitHub Bot commented on HADOOP-18601: - iwasakims commented on PR #5331: URL:

[jira] [Created] (HADOOP-18608) Add validation to check Javadocs are included in site documentation

2023-01-31 Thread Masatake Iwasaki (Jira)
Masatake Iwasaki created HADOOP-18608: - Summary: Add validation to check Javadocs are included in site documentation Key: HADOOP-18608 URL: https://issues.apache.org/jira/browse/HADOOP-18608

[GitHub] [hadoop] hadoop-yetus commented on pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

2023-01-31 Thread via GitHub
hadoop-yetus commented on PR #5315: URL: https://github.com/apache/hadoop/pull/5315#issuecomment-1410364342 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Updated] (HADOOP-18601) Fix build failure with docs profile

2023-01-31 Thread Masatake Iwasaki (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Masatake Iwasaki updated HADOOP-18601: -- Fix Version/s: 3.4.0 Hadoop Flags: Reviewed Resolution: Fixed

[jira] [Commented] (HADOOP-18601) Fix build failure with docs profile

2023-01-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682487#comment-17682487 ] ASF GitHub Bot commented on HADOOP-18601: - iwasakims commented on PR #5331: URL:

[jira] [Commented] (HADOOP-18206) Cleanup the commons-logging references in the code base

2023-01-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682564#comment-17682564 ] ASF GitHub Bot commented on HADOOP-18206: - hadoop-yetus commented on PR #5315: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5320: YARN-11416. FS2CS should use CapacitySchedulerConfiguration in FSQueueConverterBuilder

2023-01-31 Thread via GitHub
hadoop-yetus commented on PR #5320: URL: https://github.com/apache/hadoop/pull/5320#issuecomment-1410567489 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

2023-01-31 Thread via GitHub
virajjasani commented on code in PR #5315: URL: https://github.com/apache/hadoop/pull/5315#discussion_r1092392836 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/log/LogLevel.java: ## @@ -340,22 +337,14 @@ public void doGet(HttpServletRequest request,

[jira] [Commented] (HADOOP-18206) Cleanup the commons-logging references in the code base

2023-01-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682730#comment-17682730 ] ASF GitHub Bot commented on HADOOP-18206: - virajjasani commented on code in PR #5315: URL:

[jira] [Commented] (HADOOP-18592) Sasl connection failure should log remote address

2023-01-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682789#comment-17682789 ] ASF GitHub Bot commented on HADOOP-18592: - virajjasani commented on PR #5294: URL:

[GitHub] [hadoop] virajjasani commented on pull request #5294: HADOOP-18592 Sasl connection failure should log remote address

2023-01-31 Thread via GitHub
virajjasani commented on PR #5294: URL: https://github.com/apache/hadoop/pull/5294#issuecomment-1411225115 Thanks for the review @steveloughran -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hadoop] haiyang1987 commented on pull request #5296: HDFS-16888. BlockManager#maxReplicationStreams, replicationStreamsHardLimit, blocksReplWorkMultiplier and PendingReconstructionBlocks#tim

2023-01-31 Thread via GitHub
haiyang1987 commented on PR #5296: URL: https://github.com/apache/hadoop/pull/5296#issuecomment-1411364291 Thanks @tomscut @tasanuma help me review and merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop] whua3 commented on pull request #5306: YARN-11418. Add a new metric that reflects the number of applications whose FinalStatus is FAILED

2023-01-31 Thread via GitHub
whua3 commented on PR #5306: URL: https://github.com/apache/hadoop/pull/5306#issuecomment-1411414034 @ashutoshcipher Hello, can you help me to review my commits? Thank you very much. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (HADOOP-18206) Cleanup the commons-logging references in the code base

2023-01-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682877#comment-17682877 ] ASF GitHub Bot commented on HADOOP-18206: - virajjasani commented on code in PR #5315: URL:

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

2023-01-31 Thread via GitHub
virajjasani commented on code in PR #5315: URL: https://github.com/apache/hadoop/pull/5315#discussion_r1092394399 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/service/ServiceOperations.java: ## @@ -67,26 +66,6 @@ public static Exception

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

2023-01-31 Thread via GitHub
virajjasani commented on code in PR #5315: URL: https://github.com/apache/hadoop/pull/5315#discussion_r1092394399 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/service/ServiceOperations.java: ## @@ -67,26 +66,6 @@ public static Exception

[jira] [Commented] (HADOOP-18206) Cleanup the commons-logging references in the code base

2023-01-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682876#comment-17682876 ] ASF GitHub Bot commented on HADOOP-18206: - virajjasani commented on code in PR #5315: URL: