Re: [PR] HADOOP-19129: [ABFS] Test Fixes and Test Script Bug Fixes [hadoop]

2024-04-01 Thread via GitHub
anmolanmol1234 commented on code in PR #6676: URL: https://github.com/apache/hadoop/pull/6676#discussion_r1546029787 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsClient.java: ## @@ -102,11 +103,31 @@ public void testListPathWithValidListMaxRe

[jira] [Commented] (HADOOP-19129) ABFS: Fixing Test Script Bug and Some Known test Failures in ABFS Test Suite

2024-04-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832749#comment-17832749 ] ASF GitHub Bot commented on HADOOP-19129: - anmolanmol1234 commented on code in

Re: [PR] HADOOP-19129: [ABFS] Test Fixes and Test Script Bug Fixes [hadoop]

2024-04-01 Thread via GitHub
anmolanmol1234 commented on code in PR #6676: URL: https://github.com/apache/hadoop/pull/6676#discussion_r1546033711 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemChecksum.java: ## @@ -71,14 +71,14 @@ public void testAppendWithC

[jira] [Commented] (HADOOP-19129) ABFS: Fixing Test Script Bug and Some Known test Failures in ABFS Test Suite

2024-04-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832753#comment-17832753 ] ASF GitHub Bot commented on HADOOP-19129: - anmolanmol1234 commented on code in

Re: [PR] HADOOP-19077. Remove use of javax.ws.rs.core.HttpHeaders [hadoop]

2024-04-01 Thread via GitHub
ayushtkn commented on PR #6554: URL: https://github.com/apache/hadoop/pull/6554#issuecomment-2029283259 Spotbugs warning not related already reported [HADOOP-19100](https://issues.apache.org/jira/browse/HADOOP-19100), merging -- This is an automated message from the Apache Git Service. To

[jira] [Commented] (HADOOP-19077) remove use of javax.ws.rs.core.HttpHeaders

2024-04-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832754#comment-17832754 ] ASF GitHub Bot commented on HADOOP-19077: - ayushtkn commented on PR #6554: URL:

[jira] [Assigned] (HADOOP-19077) remove use of javax.ws.rs.core.HttpHeaders

2024-04-01 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayush Saxena reassigned HADOOP-19077: - Assignee: PJ Fanning > remove use of javax.ws.rs.core.HttpHeaders > --

Re: [PR] HADOOP-19077. Remove use of javax.ws.rs.core.HttpHeaders [hadoop]

2024-04-01 Thread via GitHub
ayushtkn merged PR #6554: URL: https://github.com/apache/hadoop/pull/6554 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hado

[jira] [Updated] (HADOOP-19077) Remove use of javax.ws.rs.core.HttpHeaders

2024-04-01 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayush Saxena updated HADOOP-19077: -- Summary: Remove use of javax.ws.rs.core.HttpHeaders (was: remove use of javax.ws.rs.core.Htt

[jira] [Commented] (HADOOP-19077) remove use of javax.ws.rs.core.HttpHeaders

2024-04-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832756#comment-17832756 ] ASF GitHub Bot commented on HADOOP-19077: - ayushtkn merged PR #6554: URL: https

[jira] [Commented] (HADOOP-19077) Remove use of javax.ws.rs.core.HttpHeaders

2024-04-01 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832757#comment-17832757 ] Ayush Saxena commented on HADOOP-19077: --- Committed to trunk. Thanx [~pj.fanning]

[jira] [Resolved] (HADOOP-19077) Remove use of javax.ws.rs.core.HttpHeaders

2024-04-01 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayush Saxena resolved HADOOP-19077. --- Fix Version/s: 3.4.1 Hadoop Flags: Reviewed Resolution: Fixed > Remove use of j

[jira] [Updated] (HADOOP-19077) Remove use of javax.ws.rs.core.HttpHeaders

2024-04-01 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayush Saxena updated HADOOP-19077: -- Fix Version/s: 3.5.0 (was: 3.4.1) > Remove use of javax.ws.rs.core.Htt

Re: [PR] HADOOP-19077. Remove use of javax.ws.rs.core.HttpHeaders [hadoop]

2024-04-01 Thread via GitHub
slfan1989 commented on PR #6554: URL: https://github.com/apache/hadoop/pull/6554#issuecomment-2029312220 @ayushtkn Thank you for reviewing the pr. This pr can be merged. @pjfanning Thanks for the contribution! I have been quite busy lately, which caused a delay in addressing HADOOP-

[jira] [Commented] (HADOOP-19077) Remove use of javax.ws.rs.core.HttpHeaders

2024-04-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832759#comment-17832759 ] ASF GitHub Bot commented on HADOOP-19077: - slfan1989 commented on PR #6554: URL

Re: [PR] HADOOP-19077. Remove use of javax.ws.rs.core.HttpHeaders [hadoop]

2024-04-01 Thread via GitHub
slfan1989 commented on PR #6554: URL: https://github.com/apache/hadoop/pull/6554#issuecomment-2029318231 I still have a question, why there is a private package in the hadoop project. @pjfanning ``` com.github.pjfanning jersey-json ``` -- This is an a

[jira] [Commented] (HADOOP-19077) Remove use of javax.ws.rs.core.HttpHeaders

2024-04-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832760#comment-17832760 ] ASF GitHub Bot commented on HADOOP-19077: - slfan1989 commented on PR #6554: URL

Re: [PR] HADOOP-19120. ApacheHttpClient adaptation in ABFS. [hadoop]

2024-04-01 Thread via GitHub
anujmodi2021 commented on code in PR #6633: URL: https://github.com/apache/hadoop/pull/6633#discussion_r1542292161 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AbfsConfiguration.java: ## @@ -842,6 +847,17 @@ public DelegatingSSLSocketFactory.SSLChanne

[jira] [Commented] (HADOOP-19120) [ABFS]: ApacheHttpClient adaptation as network library

2024-04-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832765#comment-17832765 ] ASF GitHub Bot commented on HADOOP-19120: - anujmodi2021 commented on code in PR

Re: [PR] HDFS-17444. Add getJournalSyncerStarted jmx metrics, to Indicates whether the JournalSyncer thread has been started. [hadoop]

2024-04-01 Thread via GitHub
hadoop-yetus commented on PR #6694: URL: https://github.com/apache/hadoop/pull/6694#issuecomment-2029365198 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HADOOP-19120. ApacheHttpClient adaptation in ABFS. [hadoop]

2024-04-01 Thread via GitHub
anujmodi2021 commented on code in PR #6633: URL: https://github.com/apache/hadoop/pull/6633#discussion_r1546081399 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsAHCHttpOperation.java: ## @@ -0,0 +1,422 @@ +/** + * Licensed to the Apache So

Re: [PR] HADOOP-19120. ApacheHttpClient adaptation in ABFS. [hadoop]

2024-04-01 Thread via GitHub
anujmodi2021 commented on code in PR #6633: URL: https://github.com/apache/hadoop/pull/6633#discussion_r1546081799 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsAHCHttpOperation.java: ## @@ -0,0 +1,422 @@ +/** + * Licensed to the Apache So

[jira] [Commented] (HADOOP-19120) [ABFS]: ApacheHttpClient adaptation as network library

2024-04-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832767#comment-17832767 ] ASF GitHub Bot commented on HADOOP-19120: - anujmodi2021 commented on code in PR

Re: [PR] HADOOP-19120. ApacheHttpClient adaptation in ABFS. [hadoop]

2024-04-01 Thread via GitHub
anujmodi2021 commented on code in PR #6633: URL: https://github.com/apache/hadoop/pull/6633#discussion_r1546081399 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsAHCHttpOperation.java: ## @@ -0,0 +1,422 @@ +/** + * Licensed to the Apache So

[jira] [Commented] (HADOOP-19120) [ABFS]: ApacheHttpClient adaptation as network library

2024-04-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832768#comment-17832768 ] ASF GitHub Bot commented on HADOOP-19120: - anujmodi2021 commented on code in PR

[jira] [Commented] (HADOOP-19120) [ABFS]: ApacheHttpClient adaptation as network library

2024-04-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832769#comment-17832769 ] ASF GitHub Bot commented on HADOOP-19120: - anujmodi2021 commented on code in PR

Re: [PR] HDFS-17444. Add getJournalSyncerStarted jmx metrics, to Indicates whether the JournalSyncer thread has been started. [hadoop]

2024-04-01 Thread via GitHub
hadoop-yetus commented on PR #6694: URL: https://github.com/apache/hadoop/pull/6694#issuecomment-2029430219 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HADOOP-19129: [ABFS] Test Fixes and Test Script Bug Fixes [hadoop]

2024-04-01 Thread via GitHub
anujmodi2021 commented on code in PR #6676: URL: https://github.com/apache/hadoop/pull/6676#discussion_r1546127193 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsClient.java: ## @@ -102,11 +103,31 @@ public void testListPathWithValidListMaxResu

[jira] [Commented] (HADOOP-19129) ABFS: Fixing Test Script Bug and Some Known test Failures in ABFS Test Suite

2024-04-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832777#comment-17832777 ] ASF GitHub Bot commented on HADOOP-19129: - anujmodi2021 commented on code in PR

Re: [PR] HADOOP-19120. ApacheHttpClient adaptation in ABFS. [hadoop]

2024-04-01 Thread via GitHub
hadoop-yetus commented on PR #6633: URL: https://github.com/apache/hadoop/pull/6633#issuecomment-2029430513 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-19120) [ABFS]: ApacheHttpClient adaptation as network library

2024-04-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832779#comment-17832779 ] ASF GitHub Bot commented on HADOOP-19120: - hadoop-yetus commented on PR #6633:

Re: [PR] HADOOP-19129: [ABFS] Test Fixes and Test Script Bug Fixes [hadoop]

2024-04-01 Thread via GitHub
anujmodi2021 commented on code in PR #6676: URL: https://github.com/apache/hadoop/pull/6676#discussion_r1546130334 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemChecksum.java: ## @@ -71,14 +71,14 @@ public void testAppendWithChe

[jira] [Commented] (HADOOP-19129) ABFS: Fixing Test Script Bug and Some Known test Failures in ABFS Test Suite

2024-04-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832780#comment-17832780 ] ASF GitHub Bot commented on HADOOP-19129: - anujmodi2021 commented on code in PR

Re: [PR] HDFS-17446. The DataNode adds a log to report its progress during addToReplicasMap execution. [hadoop]

2024-04-01 Thread via GitHub
hiwangzhihui commented on code in PR #6685: URL: https://github.com/apache/hadoop/pull/6685#discussion_r1546135795 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/BlockPoolSlice.java: ## @@ -749,6 +749,8 @@ void addToReplica

[jira] [Comment Edited] (HADOOP-19110) ITestExponentialRetryPolicy failing in branch-3.4

2024-04-01 Thread Anuj Modi (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832784#comment-17832784 ] Anuj Modi edited comment on HADOOP-19110 at 4/1/24 9:08 AM:

[jira] [Commented] (HADOOP-19110) ITestExponentialRetryPolicy failing in branch-3.4

2024-04-01 Thread Anuj Modi (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832784#comment-17832784 ] Anuj Modi commented on HADOOP-19110: [~mthakur]  Fixed via PR: [HADOOP-19129: [ABFS

[jira] [Comment Edited] (HADOOP-19110) ITestExponentialRetryPolicy failing in branch-3.4

2024-04-01 Thread Anuj Modi (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832784#comment-17832784 ] Anuj Modi edited comment on HADOOP-19110 at 4/1/24 9:08 AM:

Re: [PR] HADOOP-19077. Remove use of javax.ws.rs.core.HttpHeaders [hadoop]

2024-04-01 Thread via GitHub
pjfanning commented on PR #6554: URL: https://github.com/apache/hadoop/pull/6554#issuecomment-2029451756 @slfan1989 https://github.com/pjfanning/jersey-1.x provides some background. The dependency on my fork of jersey-json can be removed when the move to Jersey 2.x is done. -- This is an

[jira] [Commented] (HADOOP-19077) Remove use of javax.ws.rs.core.HttpHeaders

2024-04-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832785#comment-17832785 ] ASF GitHub Bot commented on HADOOP-19077: - pjfanning commented on PR #6554: URL

Re: [PR] HDFS-17446. The DataNode adds a log to report its progress during addToReplicasMap execution. [hadoop]

2024-04-01 Thread via GitHub
xiaojunxiang2023 commented on code in PR #6685: URL: https://github.com/apache/hadoop/pull/6685#discussion_r1546155860 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/BlockPoolSlice.java: ## @@ -749,6 +749,8 @@ void addToRep

Re: [PR] HADOOP-19120. ApacheHttpClient adaptation in ABFS. [hadoop]

2024-04-01 Thread via GitHub
saxenapranav commented on code in PR #6633: URL: https://github.com/apache/hadoop/pull/6633#discussion_r1546156603 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/kac/TestApacheClientConnectionPool.java: ## @@ -0,0 +1,129 @@ +/** + * Licensed to

[jira] [Commented] (HADOOP-19120) [ABFS]: ApacheHttpClient adaptation as network library

2024-04-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832795#comment-17832795 ] ASF GitHub Bot commented on HADOOP-19120: - saxenapranav commented on code in PR

Re: [PR] HDFS-17446. The DataNode adds a log to report its progress during addToReplicasMap execution. [hadoop]

2024-04-01 Thread via GitHub
xiaojunxiang2023 commented on code in PR #6685: URL: https://github.com/apache/hadoop/pull/6685#discussion_r1546157919 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/BlockPoolSlice.java: ## @@ -749,6 +749,8 @@ void addToRep

[jira] [Commented] (HADOOP-19106) [ABFS] All tests of. ITestAzureBlobFileSystemAuthorization fails with NPE

2024-04-01 Thread Anuj Modi (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832798#comment-17832798 ] Anuj Modi commented on HADOOP-19106: [~mthakur]  Raised a PR with fix: [HADOOP-1912

Re: [PR] HDFS-17444. Add getJournalSyncerStarted jmx metrics, to Indicates whether the JournalSyncer thread has been started. [hadoop]

2024-04-01 Thread via GitHub
hadoop-yetus commented on PR #6694: URL: https://github.com/apache/hadoop/pull/6694#issuecomment-2029527535 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HADOOP-18656: [ABFS] Adding Support for Paginated Delete for Large Directories in HNS Account [hadoop]

2024-04-01 Thread via GitHub
anujmodi2021 commented on code in PR #6409: URL: https://github.com/apache/hadoop/pull/6409#discussion_r1546222398 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/constants/AbfsHttpConstants.java: ## @@ -121,8 +121,34 @@ public final class AbfsHttpConsta

[jira] [Commented] (HADOOP-18656) ABFS: Support for Pagination in Recursive Directory Delete

2024-04-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832815#comment-17832815 ] ASF GitHub Bot commented on HADOOP-18656: - anujmodi2021 commented on code in PR

Re: [PR] HADOOP-18656: [ABFS] Adding Support for Paginated Delete for Large Directories in HNS Account [hadoop]

2024-04-01 Thread via GitHub
anujmodi2021 commented on code in PR #6409: URL: https://github.com/apache/hadoop/pull/6409#discussion_r1546230961 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java: ## @@ -1117,12 +1117,22 @@ public AbfsRestOperation read(final St

[jira] [Commented] (HADOOP-18656) ABFS: Support for Pagination in Recursive Directory Delete

2024-04-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832816#comment-17832816 ] ASF GitHub Bot commented on HADOOP-18656: - anujmodi2021 commented on code in PR

Re: [PR] HADOOP-18135. Produce Windows binaries of Hadoop [hadoop]

2024-04-01 Thread via GitHub
hadoop-yetus commented on PR #6673: URL: https://github.com/apache/hadoop/pull/6673#issuecomment-2029616101 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18135) Produce Windows binaries of Hadoop

2024-04-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832818#comment-17832818 ] ASF GitHub Bot commented on HADOOP-18135: - hadoop-yetus commented on PR #6673:

Re: [PR] HADOOP-19120. ApacheHttpClient adaptation in ABFS. [hadoop]

2024-04-01 Thread via GitHub
hadoop-yetus commented on PR #6633: URL: https://github.com/apache/hadoop/pull/6633#issuecomment-2029626654 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-19120) [ABFS]: ApacheHttpClient adaptation as network library

2024-04-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832820#comment-17832820 ] ASF GitHub Bot commented on HADOOP-19120: - hadoop-yetus commented on PR #6633:

Re: [PR] HADOOP-19120. ApacheHttpClient adaptation in ABFS. [hadoop]

2024-04-01 Thread via GitHub
hadoop-yetus commented on PR #6633: URL: https://github.com/apache/hadoop/pull/6633#issuecomment-2029670723 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-19120) [ABFS]: ApacheHttpClient adaptation as network library

2024-04-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832825#comment-17832825 ] ASF GitHub Bot commented on HADOOP-19120: - hadoop-yetus commented on PR #6633:

Re: [PR] HADOOP-19120. ApacheHttpClient adaptation in ABFS. [hadoop]

2024-04-01 Thread via GitHub
saxenapranav commented on code in PR #6633: URL: https://github.com/apache/hadoop/pull/6633#discussion_r1546281317 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/ITestAbfsHttpClientRequestExecutor.java: ## @@ -0,0 +1,178 @@ +/** + * Licensed to

[jira] [Commented] (HADOOP-19120) [ABFS]: ApacheHttpClient adaptation as network library

2024-04-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832829#comment-17832829 ] ASF GitHub Bot commented on HADOOP-19120: - saxenapranav commented on code in PR

Re: [PR] HADOOP-19120. ApacheHttpClient adaptation in ABFS. [hadoop]

2024-04-01 Thread via GitHub
hadoop-yetus commented on PR #6633: URL: https://github.com/apache/hadoop/pull/6633#issuecomment-2029707913 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-19120) [ABFS]: ApacheHttpClient adaptation as network library

2024-04-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832832#comment-17832832 ] ASF GitHub Bot commented on HADOOP-19120: - hadoop-yetus commented on PR #6633:

Re: [PR] HADOOP-19129: [ABFS] Test Fixes and Test Script Bug Fixes [hadoop]

2024-04-01 Thread via GitHub
hadoop-yetus commented on PR #6676: URL: https://github.com/apache/hadoop/pull/6676#issuecomment-2029712956 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HDFS-17408:Reduce the number of quota calculations in FSDirRenameOp [hadoop]

2024-04-01 Thread via GitHub
ThinkerLei commented on PR #6653: URL: https://github.com/apache/hadoop/pull/6653#issuecomment-2029711670 > @ThinkerLei Thanks for your reply. So what you mean is: If src directory does not have any storage policy set (that is, files under src use the default storage policy, ALL_DISK for ex

Re: [PR] HDFS-17408:Reduce the number of quota calculations in FSDirRenameOp [hadoop]

2024-04-01 Thread via GitHub
ThinkerLei commented on PR #6653: URL: https://github.com/apache/hadoop/pull/6653#issuecomment-2029713202 > @ThinkerLei Thanks for your reply. So what you mean is: If src directory does not have any storage policy set (that is, files under src use the default storage policy, ALL_DISK for ex

[jira] [Commented] (HADOOP-19129) ABFS: Fixing Test Script Bug and Some Known test Failures in ABFS Test Suite

2024-04-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832835#comment-17832835 ] ASF GitHub Bot commented on HADOOP-19129: - hadoop-yetus commented on PR #6676:

Re: [PR] YARN-11626. Optimize ResourceManager's operations on Zookeeper metadata [hadoop]

2024-04-01 Thread via GitHub
XbaoWu closed pull request #6577: YARN-11626. Optimize ResourceManager's operations on Zookeeper metadata URL: https://github.com/apache/hadoop/pull/6577 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] HDFS-17444. Add getJournalSyncerStarted jmx metrics, to Indicates whether the JournalSyncer thread has been started. [hadoop]

2024-04-01 Thread via GitHub
hadoop-yetus commented on PR #6694: URL: https://github.com/apache/hadoop/pull/6694#issuecomment-2029801205 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HADOOP-19120. ApacheHttpClient adaptation in ABFS. [hadoop]

2024-04-01 Thread via GitHub
hadoop-yetus commented on PR #6633: URL: https://github.com/apache/hadoop/pull/6633#issuecomment-2029909989 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-19120) [ABFS]: ApacheHttpClient adaptation as network library

2024-04-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832868#comment-17832868 ] ASF GitHub Bot commented on HADOOP-19120: - hadoop-yetus commented on PR #6633:

Re: [PR] HDFS-17444. Add getJournalSyncerStarted jmx metrics, to Indicates whether the JournalSyncer thread has been started. [hadoop]

2024-04-01 Thread via GitHub
hadoop-yetus commented on PR #6694: URL: https://github.com/apache/hadoop/pull/6694#issuecomment-2030056382 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HDFS-17446. The DataNode adds a log to report its progress during addToReplicasMap execution. [hadoop]

2024-04-01 Thread via GitHub
hadoop-yetus commented on PR #6685: URL: https://github.com/apache/hadoop/pull/6685#issuecomment-2030082476 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17446. The DataNode adds a log to report its progress during addToReplicasMap execution. [hadoop]

2024-04-01 Thread via GitHub
hadoop-yetus commented on PR #6685: URL: https://github.com/apache/hadoop/pull/6685#issuecomment-2030122801 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HADOOP-18135. Produce Windows binaries of Hadoop [hadoop]

2024-04-01 Thread via GitHub
GauthamBanasandra commented on PR #6673: URL: https://github.com/apache/hadoop/pull/6673#issuecomment-2030238139 > docs are good, but still shellcheck issues > > ``` > dev-support/bin/create-release:540:1: note: The mentioned syntax error was in this brace group. [SC1009] > dev-

[jira] [Commented] (HADOOP-18135) Produce Windows binaries of Hadoop

2024-04-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832915#comment-17832915 ] ASF GitHub Bot commented on HADOOP-18135: - GauthamBanasandra commented on PR #6

Re: [PR] HDFS-17439. Support -nonSuperUser for NNThroughputBenchmark: useful f… [hadoop]

2024-04-01 Thread via GitHub
fateh288 commented on PR #6677: URL: https://github.com/apache/hadoop/pull/6677#issuecomment-2030265933 @dineshchitlangia Requesting your feedback -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] YARN-11664: Remove HDFS Binaries/Jars Dependency From Yarn [hadoop]

2024-04-01 Thread via GitHub
steveloughran commented on PR #6631: URL: https://github.com/apache/hadoop/pull/6631#issuecomment-2030429061 please, avoid force push unless things are completely unreconcilable *or nobody has reviewed yet*. It really makes reviewing harder, which discourages people from reviewing. -- Th

[jira] [Updated] (HADOOP-19133) "No test bucket" error in ITestS3AContractVectoredRead if provided via CLI property

2024-04-01 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-19133: Affects Version/s: 3.3.6 3.4.0 > "No test bucket" error in ITestS3

[jira] [Commented] (HADOOP-19133) "No test bucket" error in ITestS3AContractVectoredRead if provided via CLI property

2024-04-01 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832940#comment-17832940 ] Steve Loughran commented on HADOOP-19133: - thanks. looks like "removeBaseAndBuc

Re: [PR] HDFS-17216. Distcp: When handle the small files, the bandwidth parameter will be invalid, fix this bug. [hadoop]

2024-04-01 Thread via GitHub
steveloughran commented on PR #6138: URL: https://github.com/apache/hadoop/pull/6138#issuecomment-2030463783 just missed this as it went in under hdfs/distcp rather than hadoop common distcp (why two? who knows?) made some basic comments. If you can address them as a followup (same ji

Re: [PR] YARN-11663. [Federation] Add Cache Entity Nums Limit. [hadoop]

2024-04-01 Thread via GitHub
slfan1989 merged PR #6662: URL: https://github.com/apache/hadoop/pull/6662 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@had

Re: [PR] YARN-11663. [Federation] Add Cache Entity Nums Limit. [hadoop]

2024-04-01 Thread via GitHub
slfan1989 commented on PR #6662: URL: https://github.com/apache/hadoop/pull/6662#issuecomment-2030807018 @dineshchitlangia Thanks for reviewing the code! @luoyuan3471 Thank you for reporting this issue! -- This is an automated message from the Apache Git Service. To respond to the message

Re: [PR] HADOOP-19115. Upgrade to nimbus-jose-jwt 9.37.2 due to CVE-2023-52428 (#6637) [hadoop]

2024-04-01 Thread via GitHub
slfan1989 merged PR #6689: URL: https://github.com/apache/hadoop/pull/6689 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@had

Re: [PR] HADOOP-19115. Upgrade to nimbus-jose-jwt 9.37.2 due to CVE-2023-52428 (#6637) [hadoop]

2024-04-01 Thread via GitHub
slfan1989 commented on PR #6689: URL: https://github.com/apache/hadoop/pull/6689#issuecomment-2030808521 @pjfanning Thank you for your contribution! Merged into branch-3.3. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] HDFS-17438. RBF: The newest STANDBY and UNAVAILABLE nn should be the lowest priority. [hadoop]

2024-04-01 Thread via GitHub
goiri commented on code in PR #6655: URL: https://github.com/apache/hadoop/pull/6655#discussion_r1546976890 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/resolver/TestNamenodeResolver.java: ## @@ -359,11 +359,12 @@ public void test

[jira] [Created] (HADOOP-19135) Remove Jcache 1.0-alpha

2024-04-01 Thread Shilun Fan (Jira)
Shilun Fan created HADOOP-19135: --- Summary: Remove Jcache 1.0-alpha Key: HADOOP-19135 URL: https://issues.apache.org/jira/browse/HADOOP-19135 Project: Hadoop Common Issue Type: Improvement

[PR] HADOOP-19135. Remove Jcache 1.0-alpha. [hadoop]

2024-04-01 Thread via GitHub
slfan1989 opened a new pull request, #6695: URL: https://github.com/apache/hadoop/pull/6695 ### Description of PR HADOOP-19135. Remove Jcache 1.0-alpha. In YARN Federation, we use JCache. The version of JCache has not been maintained for a long time. We directly use ECa

[jira] [Updated] (HADOOP-19135) Remove Jcache 1.0-alpha

2024-04-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-19135: Labels: pull-request-available (was: ) > Remove Jcache 1.0-alpha > -

[jira] [Commented] (HADOOP-19135) Remove Jcache 1.0-alpha

2024-04-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832979#comment-17832979 ] ASF GitHub Bot commented on HADOOP-19135: - slfan1989 opened a new pull request,

Re: [PR] HADOOP-19071. Update maven-surefire-plugin from 3.0.0 to 3.2.5. [hadoop]

2024-04-01 Thread via GitHub
slfan1989 commented on PR #6664: URL: https://github.com/apache/hadoop/pull/6664#issuecomment-2030867204 @ayushtkn @steveloughran I still want to upgrade this plugin to a higher version. I'm not sure why the number of running unit tests is decreasing. -- This is an automated message fro

Re: [PR] HDFS-17216. Distcp: When handle the small files, the bandwidth parameter will be invalid, fix this bug. [hadoop]

2024-04-01 Thread via GitHub
hiwangzhihui commented on PR #6138: URL: https://github.com/apache/hadoop/pull/6138#issuecomment-2030966943 > just missed this as it went in under hdfs/distcp rather than hadoop common distcp (why two? who knows?) > > made some basic comments. If you can address them as a followup (sa

Re: [PR] HDFS-17408:Reduce the number of quota calculations in FSDirRenameOp [hadoop]

2024-04-01 Thread via GitHub
zhangshuyan0 commented on PR #6653: URL: https://github.com/apache/hadoop/pull/6653#issuecomment-2030969495 @ThinkerLei Thanks for your explanation. Agree with you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] HDFS-17408:Reduce the number of quota calculations in FSDirRenameOp [hadoop]

2024-04-01 Thread via GitHub
zhangshuyan0 merged PR #6653: URL: https://github.com/apache/hadoop/pull/6653 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@

Re: [PR] HDFS-17408:Reduce the number of quota calculations in FSDirRenameOp [hadoop]

2024-04-01 Thread via GitHub
zhangshuyan0 commented on PR #6653: URL: https://github.com/apache/hadoop/pull/6653#issuecomment-2030971312 Committed to trunk. Thanks for your contribution @ThinkerLei @Hexiaoqiao @dineshchitlangia . -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Updated] (HADOOP-18656) ABFS: Support for Pagination in Recursive Directory Delete

2024-04-01 Thread Anuj Modi (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anuj Modi updated HADOOP-18656: --- Description: Today, when a recursive delete is issued for a large directory in ADLS Gen2 (HNS) acc

Re: [PR] YARN-11670. Add CallerContext in NodeManager [hadoop]

2024-04-01 Thread via GitHub
slfan1989 commented on PR #6688: URL: https://github.com/apache/hadoop/pull/6688#issuecomment-2031103857 @dineshchitlangia Can you help review this pr again? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] YARN-11670. Add CallerContext in NodeManager [hadoop]

2024-04-01 Thread via GitHub
dineshchitlangia commented on PR #6688: URL: https://github.com/apache/hadoop/pull/6688#issuecomment-2031106762 @yangjiandan can you please address the new check style violation? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] HADOOP-19120. ApacheHttpClient adaptation in ABFS. [hadoop]

2024-04-01 Thread via GitHub
saxenapranav commented on PR #6633: URL: https://github.com/apache/hadoop/pull/6633#issuecomment-2031137987 > 1. Add more tests around verifying the sendTime and receiveTime for ManagedClientContext. > 2. Tests around connections in KAC getting stale and returning false. taken. -

[jira] [Commented] (HADOOP-19120) [ABFS]: ApacheHttpClient adaptation as network library

2024-04-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17833018#comment-17833018 ] ASF GitHub Bot commented on HADOOP-19120: - saxenapranav commented on PR #6633:

Re: [PR] YARN-11664: Remove HDFS Binaries/Jars Dependency From Yarn [hadoop]

2024-04-01 Thread via GitHub
shameersss1 commented on PR #6631: URL: https://github.com/apache/hadoop/pull/6631#issuecomment-2031143396 > please, avoid force push unless things are completely unreconcilable _or nobody has reviewed yet_. It really makes reviewing harder, which discourages people from reviewing. I

Re: [PR] HDFS-17216. Distcp: When handle the small files, the bandwidth parameter will be invalid, fix this bug. [hadoop]

2024-04-01 Thread via GitHub
xiaojunxiang2023 commented on PR #6138: URL: https://github.com/apache/hadoop/pull/6138#issuecomment-2031158756 > just missed this as it went in under hdfs/distcp rather than hadoop common distcp (why two? who knows?) > > made some basic comments. If you can address them as a followup

Re: [PR] HADOOP-19072. S3A: expand optimisations on stores with "fs.s3a.create.performance" [hadoop]

2024-04-01 Thread via GitHub
virajjasani commented on PR #6543: URL: https://github.com/apache/hadoop/pull/6543#issuecomment-2031166900 > ok, this is getting over complex. > > proposed: copy the superclass code but remove the expectation of failures, retaining only setup and validation. sounds good, address

[jira] [Commented] (HADOOP-19072) S3A: expand optimisations on stores with "fs.s3a.create.performance"

2024-04-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17833026#comment-17833026 ] ASF GitHub Bot commented on HADOOP-19072: - virajjasani commented on PR #6543: U

  1   2   >