Re: [PR] HADOOP-19072. S3A: expand optimisations on stores with "fs.s3a.create.performance" [hadoop]

2024-05-02 Thread via GitHub
virajjasani commented on PR #6543: URL: https://github.com/apache/hadoop/pull/6543#issuecomment-2089805333 As of today, `fs.s3a.create.performance` is mandatory option while creating file: ``` builder .create() .overwrite(true)

Re: [PR] YARN-11687. Update CGroupsResourceCalculator to track usages using cgroupv2 [hadoop]

2024-05-02 Thread via GitHub
brumi1024 commented on code in PR #6780: URL: https://github.com/apache/hadoop/pull/6780#discussion_r1587268842 ##

Re: [PR] YARN-11687. Update CGroupsResourceCalculator to track usages using cgroupv2 [hadoop]

2024-05-02 Thread via GitHub
brumi1024 commented on code in PR #6780: URL: https://github.com/apache/hadoop/pull/6780#discussion_r1587268842 ##

Re: [PR] YARN-11687. Update CGroupsResourceCalculator to track usages using cgroupv2 [hadoop]

2024-05-02 Thread via GitHub
K0K0V0K commented on code in PR #6780: URL: https://github.com/apache/hadoop/pull/6780#discussion_r1587324661 ##

Re: [PR] HADOOP-19072. S3A: expand optimisations on stores with "fs.s3a.create.performance" [hadoop]

2024-05-02 Thread via GitHub
virajjasani commented on PR #6543: URL: https://github.com/apache/hadoop/pull/6543#issuecomment-2089769498 The above proposal of providing list of optimization flags sounds impressive. Please let me know if this summary looks good: As part of this Jira: - Add

[jira] [Commented] (HADOOP-19072) S3A: expand optimisations on stores with "fs.s3a.create.performance"

2024-05-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842856#comment-17842856 ] ASF GitHub Bot commented on HADOOP-19072: - virajjasani commented on PR #6543: URL:

Re: [PR] YARN-11687. Update CGroupsResourceCalculator to track usages using cgroupv2 [hadoop]

2024-05-02 Thread via GitHub
K0K0V0K commented on code in PR #6780: URL: https://github.com/apache/hadoop/pull/6780#discussion_r1587324661 ##

Re: [PR] YARN-11687. Update CGroupsResourceCalculator to track usages using cgroupv2 [hadoop]

2024-05-02 Thread via GitHub
hadoop-yetus commented on PR #6780: URL: https://github.com/apache/hadoop/pull/6780#issuecomment-2090344394 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17509. RBF: Fix ClientProtocol.concat will throw NPE if tgr is a empty file. [hadoop]

2024-05-02 Thread via GitHub
hadoop-yetus commented on PR #6784: URL: https://github.com/apache/hadoop/pull/6784#issuecomment-2090029891 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[PR] HADOOP-19160. hadoop-auth should not depend on kerb-simplekdc [hadoop]

2024-05-02 Thread via GitHub
adoroszlai opened a new pull request, #6788: URL: https://github.com/apache/hadoop/pull/6788 ## What changes were proposed in this pull request? HADOOP-16179 attempted to remove dependency on `kerb-simplekdc` from `hadoop-common`. However, `hadoop-auth` still has a compile-scope

Re: [PR] HADOOP-19160. hadoop-auth should not depend on kerb-simplekdc [hadoop]

2024-05-02 Thread via GitHub
hadoop-yetus commented on PR #6788: URL: https://github.com/apache/hadoop/pull/6788#issuecomment-2090746084 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11687. Update CGroupsResourceCalculator to track usages using cgroupv2 [hadoop]

2024-05-02 Thread via GitHub
brumi1024 commented on code in PR #6780: URL: https://github.com/apache/hadoop/pull/6780#discussion_r1587889122 ##

Re: [PR] YARN-11687. Update CGroupsResourceCalculator to track usages using cgroupv2 [hadoop]

2024-05-02 Thread via GitHub
brumi1024 commented on code in PR #6780: URL: https://github.com/apache/hadoop/pull/6780#discussion_r1587889935 ##

[PR] HADOOP-19160. hadoop-auth should not depend on kerb-simplekdc [hadoop-release-support]

2024-05-02 Thread via GitHub
adoroszlai opened a new pull request, #2: URL: https://github.com/apache/hadoop-release-support/pull/2 ## What changes were proposed in this pull request? Add `kerb-simplekdc` as forbidden artifact. See https://github.com/apache/hadoop/pull/6788 for details.

[jira] [Updated] (HADOOP-19160) hadoop-auth should not depend on kerb-simplekdc

2024-05-02 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-19160: Affects Version/s: 3.4.0 > hadoop-auth should not depend on kerb-simplekdc >

Re: [PR] YARN-11687. Update CGroupsResourceCalculator to track usages using cgroupv2 [hadoop]

2024-05-02 Thread via GitHub
brumi1024 commented on code in PR #6780: URL: https://github.com/apache/hadoop/pull/6780#discussion_r1587900352 ##

[jira] [Commented] (HADOOP-18508) support multiple s3a integration test runs on same bucket in parallel

2024-05-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843034#comment-17843034 ] ASF GitHub Bot commented on HADOOP-18508: - mukund-thakur commented on code in PR #5081: URL:

Re: [PR] HADOOP-18508. Support multiple s3a integration test runs on same bucket in parallel [hadoop]

2024-05-02 Thread via GitHub
mukund-thakur commented on code in PR #5081: URL: https://github.com/apache/hadoop/pull/5081#discussion_r1588080314 ## hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/scale/AbstractSTestS3AHugeFiles.java: ## @@ -113,6 +113,16 @@ public void setup() throws

[jira] [Commented] (HADOOP-19073) WASB: Fix connection leak in FolderRenamePending

2024-05-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843070#comment-17843070 ] ASF GitHub Bot commented on HADOOP-19073: - steveloughran commented on PR #6534: URL:

[jira] [Commented] (HADOOP-19073) WASB: Fix connection leak in FolderRenamePending

2024-05-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843071#comment-17843071 ] ASF GitHub Bot commented on HADOOP-19073: - steveloughran commented on PR #6534: URL:

Re: [PR] HADOOP-19073 WASB: Fix connection leak in FolderRenamePending [hadoop]

2024-05-02 Thread via GitHub
steveloughran commented on PR #6534: URL: https://github.com/apache/hadoop/pull/6534#issuecomment-2091420304 (which I can't do today as both my hadoop source trees are testing my "support parallel tests against the same s3 bucket" right now... -- This is an automated message from the

Re: [PR] HADOOP-18679. Add API for bulk/paged object deletion [hadoop]

2024-05-02 Thread via GitHub
steveloughran commented on code in PR #6726: URL: https://github.com/apache/hadoop/pull/6726#discussion_r1588274603 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java: ## @@ -4980,4 +4982,17 @@ public MultipartUploaderBuilder

[jira] [Commented] (HADOOP-19072) S3A: expand optimisations on stores with "fs.s3a.create.performance"

2024-05-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843026#comment-17843026 ] ASF GitHub Bot commented on HADOOP-19072: - steveloughran commented on PR #6543: URL:

Re: [PR] HADOOP-19072. S3A: expand optimisations on stores with "fs.s3a.create.performance" [hadoop]

2024-05-02 Thread via GitHub
steveloughran commented on PR #6543: URL: https://github.com/apache/hadoop/pull/6543#issuecomment-2091119335 I'm doing a quick PR of the design; @HarshitGupta11 and I discussed it. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Updated] (HADOOP-19161) S3A: option "fs.s3a.performance.flags" to take list of performance flags

2024-05-02 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-19161: Summary: S3A: option "fs.s3a.performance.flags" to take list of performance flags (was:

Re: [PR] HADOOP-18508. Support multiple s3a integration test runs on same bucket in parallel [hadoop]

2024-05-02 Thread via GitHub
hadoop-yetus commented on PR #5081: URL: https://github.com/apache/hadoop/pull/5081#issuecomment-2091286919 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18508) support multiple s3a integration test runs on same bucket in parallel

2024-05-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843064#comment-17843064 ] ASF GitHub Bot commented on HADOOP-18508: - steveloughran commented on PR #5081: URL:

Re: [PR] HADOOP-18508. Support multiple s3a integration test runs on same bucket in parallel [hadoop]

2024-05-02 Thread via GitHub
steveloughran commented on PR #5081: URL: https://github.com/apache/hadoop/pull/5081#issuecomment-2091402827 ooh, good point. I did a while back, but let me kick that off again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] MAPREDUCE-7475. Fixed non-idempotent unit tests [hadoop]

2024-05-02 Thread via GitHub
steveloughran commented on PR #6785: URL: https://github.com/apache/hadoop/pull/6785#issuecomment-2091417231 will merge once the build completes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] HADOOP-19073 WASB: Fix connection leak in FolderRenamePending [hadoop]

2024-05-02 Thread via GitHub
steveloughran commented on PR #6534: URL: https://github.com/apache/hadoop/pull/6534#issuecomment-2091418801 let me try and test this myself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] HADOOP-19161. S3A: option "fs.s3a.performance.flags" to take list of performance flags [hadoop]

2024-05-02 Thread via GitHub
steveloughran commented on PR #6789: URL: https://github.com/apache/hadoop/pull/6789#issuecomment-2091180025 note the commented out bit where we considered adding options like "hive" or "spark". @HarshitGupta11 and I discussed this; for now lets go with a list of options and "*"

[jira] [Commented] (HADOOP-19161) S3A: option "fs.s3a.performance.flags" to take list of performance flags

2024-05-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843032#comment-17843032 ] ASF GitHub Bot commented on HADOOP-19161: - steveloughran commented on PR #6789: URL:

[jira] [Commented] (HADOOP-18508) support multiple s3a integration test runs on same bucket in parallel

2024-05-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843037#comment-17843037 ] ASF GitHub Bot commented on HADOOP-18508: - mukund-thakur commented on PR #5081: URL:

[jira] [Created] (HADOOP-19161) S3A: support a comma separated list of performance flags

2024-05-02 Thread Steve Loughran (Jira)
Steve Loughran created HADOOP-19161: --- Summary: S3A: support a comma separated list of performance flags Key: HADOOP-19161 URL: https://issues.apache.org/jira/browse/HADOOP-19161 Project: Hadoop

[jira] [Commented] (HADOOP-18508) support multiple s3a integration test runs on same bucket in parallel

2024-05-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843056#comment-17843056 ] ASF GitHub Bot commented on HADOOP-18508: - hadoop-yetus commented on PR #5081: URL:

Re: [PR] HADOOP-19160. hadoop-auth should not depend on kerb-simplekdc [hadoop-release-support]

2024-05-02 Thread via GitHub
steveloughran commented on PR #2: URL: https://github.com/apache/hadoop-release-support/pull/2#issuecomment-2091415131 @adoroszlai this repo doesn't need review before merging, so when you are happy just commit it. -- This is an automated message from the Apache Git Service. To respond

[jira] [Commented] (HADOOP-19160) hadoop-auth should not depend on kerb-simplekdc

2024-05-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843068#comment-17843068 ] ASF GitHub Bot commented on HADOOP-19160: - steveloughran commented on PR #2: URL:

[jira] [Commented] (HADOOP-19161) S3A: option "fs.s3a.performance.flags" to take list of performance flags

2024-05-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843077#comment-17843077 ] ASF GitHub Bot commented on HADOOP-19161: - hadoop-yetus commented on PR #6789: URL:

Re: [PR] HADOOP-19161. S3A: option "fs.s3a.performance.flags" to take list of performance flags [hadoop]

2024-05-02 Thread via GitHub
hadoop-yetus commented on PR #6789: URL: https://github.com/apache/hadoop/pull/6789#issuecomment-2091484477 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19161) S3A: option "fs.s3a.performance.flags" to take list of performance flags

2024-05-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843031#comment-17843031 ] ASF GitHub Bot commented on HADOOP-19161: - steveloughran opened a new pull request, #6789: URL:

[jira] [Updated] (HADOOP-19161) S3A: option "fs.s3a.performance.flags" to take list of performance flags

2024-05-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-19161: Labels: pull-request-available (was: ) > S3A: option "fs.s3a.performance.flags" to take

[PR] HADOOP-19161. S3A: option "fs.s3a.performance.flags" to take list of performance flags [hadoop]

2024-05-02 Thread via GitHub
steveloughran opened a new pull request, #6789: URL: https://github.com/apache/hadoop/pull/6789 Initial design * no tests or docs * served up via StoreContext. Not sure about the merits of that I think it is needed so it gets down to all AbstractStoreOperation instances, but

Re: [PR] HADOOP-18508. Support multiple s3a integration test runs on same bucket in parallel [hadoop]

2024-05-02 Thread via GitHub
mukund-thakur commented on PR #5081: URL: https://github.com/apache/hadoop/pull/5081#issuecomment-2091200752 Are you running multiple parallel tests in different terminal windows to verify everything is correct? -- This is an automated message from the Apache Git Service. To respond to

[jira] [Created] (HADOOP-19162) Add LzoCodec implementation based on aircompressor

2024-05-02 Thread L. C. Hsieh (Jira)
L. C. Hsieh created HADOOP-19162: Summary: Add LzoCodec implementation based on aircompressor Key: HADOOP-19162 URL: https://issues.apache.org/jira/browse/HADOOP-19162 Project: Hadoop Common

Re: [PR] HADOOP-19161. S3A: option "fs.s3a.performance.flags" to take list of performance flags [hadoop]

2024-05-02 Thread via GitHub
hadoop-yetus commented on PR #6789: URL: https://github.com/apache/hadoop/pull/6789#issuecomment-2091557594 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19161) S3A: option "fs.s3a.performance.flags" to take list of performance flags

2024-05-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843079#comment-17843079 ] ASF GitHub Bot commented on HADOOP-19161: - hadoop-yetus commented on PR #6789: URL:

[jira] [Commented] (HADOOP-19161) S3A: option "fs.s3a.performance.flags" to take list of performance flags

2024-05-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843087#comment-17843087 ] ASF GitHub Bot commented on HADOOP-19161: - virajjasani commented on code in PR #6789: URL:

[jira] [Commented] (HADOOP-19161) S3A: option "fs.s3a.performance.flags" to take list of performance flags

2024-05-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843102#comment-17843102 ] ASF GitHub Bot commented on HADOOP-19161: - virajjasani commented on code in PR #6789: URL:

Re: [PR] HADOOP-19161. S3A: option "fs.s3a.performance.flags" to take list of performance flags [hadoop]

2024-05-02 Thread via GitHub
virajjasani commented on code in PR #6789: URL: https://github.com/apache/hadoop/pull/6789#discussion_r1588408014 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/S3APerformanceFlags.java: ## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (HADOOP-19131) Assist reflection IO with WrappedOperations class

2024-05-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843084#comment-17843084 ] ASF GitHub Bot commented on HADOOP-19131: - hadoop-yetus commented on PR #6686: URL:

Re: [PR] HADOOP-19131. Assist reflection IO with WrappedOperations class [hadoop]

2024-05-02 Thread via GitHub
hadoop-yetus commented on PR #6686: URL: https://github.com/apache/hadoop/pull/6686#issuecomment-2091578654 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17500: Add missing operation name while authorizing create and completeFile operations [hadoop]

2024-05-02 Thread via GitHub
kulkabhay commented on PR #6776: URL: https://github.com/apache/hadoop/pull/6776#issuecomment-2091917836 @jojochuang Can you please review? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] HADOOP-19072. S3A: expand optimisations on stores with "fs.s3a.create.performance" [hadoop]

2024-05-02 Thread via GitHub
virajjasani commented on PR #6543: URL: https://github.com/apache/hadoop/pull/6543#issuecomment-2091630129 > I'm doing a quick PR of the design; @HarshitGupta11 and I discussed it. Got it, i was planning to embed the logic as part of this PR sometime early next week but separate PR

Re: [PR] HADOOP-19161. S3A: option "fs.s3a.performance.flags" to take list of performance flags [hadoop]

2024-05-02 Thread via GitHub
virajjasani commented on code in PR #6789: URL: https://github.com/apache/hadoop/pull/6789#discussion_r1588404029 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/S3APerformanceFlags.java: ## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (HADOOP-19072) S3A: expand optimisations on stores with "fs.s3a.create.performance"

2024-05-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843086#comment-17843086 ] ASF GitHub Bot commented on HADOOP-19072: - virajjasani commented on PR #6543: URL: