[jira] [Commented] (HADOOP-16248) Fix MutableQuantiles memory leak

2019-05-15 Thread Alexis Daboville (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840992#comment-16840992 ] Alexis Daboville commented on HADOOP-16248: --- Great thanks, reattached the patch with the

[jira] [Updated] (HADOOP-16248) Fix MutableQuantiles memory leak

2019-05-15 Thread Alexis Daboville (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexis Daboville updated HADOOP-16248: -- Attachment: HADOOP-16248.00.patch > Fix MutableQuantiles memory leak >

[GitHub] [hadoop] swagle commented on a change in pull request #822: HDDS-1527. HDDS Datanode start fails due to datanode.id file read error

2019-05-15 Thread GitBox
swagle commented on a change in pull request #822: HDDS-1527. HDDS Datanode start fails due to datanode.id file read error URL: https://github.com/apache/hadoop/pull/822#discussion_r284537726 ## File path:

[GitHub] [hadoop] bharatviswa504 commented on issue #798: HDDS-1499. OzoneManager Cache.

2019-05-15 Thread GitBox
bharatviswa504 commented on issue #798: HDDS-1499. OzoneManager Cache. URL: https://github.com/apache/hadoop/pull/798#issuecomment-492910899 > Seems like cache.put is never called except testcases, cache will always be empty. This jira add's Table Cache, this is not integrated to OM

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #822: HDDS-1527. HDDS Datanode start fails due to datanode.id file read error

2019-05-15 Thread GitBox
xiaoyuyao commented on a change in pull request #822: HDDS-1527. HDDS Datanode start fails due to datanode.id file read error URL: https://github.com/apache/hadoop/pull/822#discussion_r284531715 ## File path:

[jira] [Comment Edited] (HADOOP-15685) Build fails (hadoop pipes) on newer Linux envs (like Fedora 28)

2019-05-15 Thread Feilong He (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840954#comment-16840954 ] Feilong He edited comment on HADOOP-15685 at 5/16/19 3:51 AM: -- I

[GitHub] [hadoop] chinphing edited a comment on issue #798: HDDS-1499. OzoneManager Cache.

2019-05-15 Thread GitBox
chinphing edited a comment on issue #798: HDDS-1499. OzoneManager Cache. URL: https://github.com/apache/hadoop/pull/798#issuecomment-492905610 Seems like cache.put is never called except testcases, cache will always be empty.

[GitHub] [hadoop] chinphing edited a comment on issue #798: HDDS-1499. OzoneManager Cache.

2019-05-15 Thread GitBox
chinphing edited a comment on issue #798: HDDS-1499. OzoneManager Cache. URL: https://github.com/apache/hadoop/pull/798#issuecomment-492905610 Seems like addCacheEntry is never called, cache will always be empty. `@Override public void addCacheEntry(CacheKey cacheKey,

[GitHub] [hadoop] chinphing commented on issue #798: HDDS-1499. OzoneManager Cache.

2019-05-15 Thread GitBox
chinphing commented on issue #798: HDDS-1499. OzoneManager Cache. URL: https://github.com/apache/hadoop/pull/798#issuecomment-492905610 Seems like addCacheEntry is never called, cache will always be empty. ` @Override public void addCacheEntry(CacheKey cacheKey,

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #815: HDDS-1522. Provide intellij runConfiguration for Ozone components

2019-05-15 Thread GitBox
xiaoyuyao commented on a change in pull request #815: HDDS-1522. Provide intellij runConfiguration for Ozone components URL: https://github.com/apache/hadoop/pull/815#discussion_r284529730 ## File path: hadoop-ozone/dev-support/intellij/install-runconfigs.sh ## @@ -0,0

[jira] [Commented] (HADOOP-15685) Build fails (hadoop pipes) on newer Linux envs (like Fedora 28)

2019-05-15 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840960#comment-16840960 ] Hadoop QA commented on HADOOP-15685: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-15685) Build fails (hadoop pipes) on newer Linux envs (like Fedora 28)

2019-05-15 Thread Feilong He (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840954#comment-16840954 ] Feilong He commented on HADOOP-15685: - I encountered the same error when I build

[jira] [Commented] (HADOOP-16268) Allow custom wrapped exception to be thrown by server if RPC call queue is filled up

2019-05-15 Thread CR Hota (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840907#comment-16840907 ] CR Hota commented on HADOOP-16268: -- [~elgoiri] [~brahmareddy] [~xkrogen] [~daryn] Gentle reminder!

[jira] [Comment Edited] (HADOOP-16248) Fix MutableQuantiles memory leak

2019-05-15 Thread Bharat Viswanadham (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840893#comment-16840893 ] Bharat Viswanadham edited comment on HADOOP-16248 at 5/16/19 1:06 AM:

[jira] [Commented] (HADOOP-16248) Fix MutableQuantiles memory leak

2019-05-15 Thread Bharat Viswanadham (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840893#comment-16840893 ] Bharat Viswanadham commented on HADOOP-16248: - Hi [~adaboville] You can create a patch

[jira] [Updated] (HADOOP-16247) NPE in FsUrlConnection

2019-05-15 Thread Bharat Viswanadham (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharat Viswanadham updated HADOOP-16247: Fix Version/s: 3.2.1 > NPE in FsUrlConnection > -- > >

[jira] [Comment Edited] (HADOOP-16247) NPE in FsUrlConnection

2019-05-15 Thread Bharat Viswanadham (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840889#comment-16840889 ] Bharat Viswanadham edited comment on HADOOP-16247 at 5/16/19 1:03 AM:

[jira] [Commented] (HADOOP-16247) NPE in FsUrlConnection

2019-05-15 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840892#comment-16840892 ] Hudson commented on HADOOP-16247: - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #16556 (See

[jira] [Comment Edited] (HADOOP-16247) NPE in FsUrlConnection

2019-05-15 Thread Bharat Viswanadham (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840889#comment-16840889 ] Bharat Viswanadham edited comment on HADOOP-16247 at 5/16/19 12:55 AM:

[jira] [Updated] (HADOOP-16247) NPE in FsUrlConnection

2019-05-15 Thread Bharat Viswanadham (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharat Viswanadham updated HADOOP-16247: Fix Version/s: 3.1.3 > NPE in FsUrlConnection > -- > >

[jira] [Updated] (HADOOP-16247) NPE in FsUrlConnection

2019-05-15 Thread Bharat Viswanadham (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharat Viswanadham updated HADOOP-16247: Resolution: Fixed Fix Version/s: 3.3.0 Status: Resolved (was:

[jira] [Commented] (HADOOP-16247) NPE in FsUrlConnection

2019-05-15 Thread Bharat Viswanadham (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840882#comment-16840882 ] Bharat Viswanadham commented on HADOOP-16247: - As no further comments, I will commit this

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #782: HDDS-1461. Optimize listStatus api in OzoneFileSystem

2019-05-15 Thread GitBox
xiaoyuyao commented on a change in pull request #782: HDDS-1461. Optimize listStatus api in OzoneFileSystem URL: https://github.com/apache/hadoop/pull/782#discussion_r284485092 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #782: HDDS-1461. Optimize listStatus api in OzoneFileSystem

2019-05-15 Thread GitBox
xiaoyuyao commented on a change in pull request #782: HDDS-1461. Optimize listStatus api in OzoneFileSystem URL: https://github.com/apache/hadoop/pull/782#discussion_r284484826 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java

[jira] [Commented] (HADOOP-16279) S3Guard: Implement time-based (TTL) expiry for entries (and tombstones)

2019-05-15 Thread Aaron Fabbri (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840849#comment-16840849 ] Aaron Fabbri commented on HADOOP-16279: --- {quote}With HADOOP-15999 we changed a bit how

[GitHub] [hadoop] hadoop-yetus commented on issue #798: HDDS-1499. OzoneManager Cache.

2019-05-15 Thread GitBox
hadoop-yetus commented on issue #798: HDDS-1499. OzoneManager Cache. URL: https://github.com/apache/hadoop/pull/798#issuecomment-492853658 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 |

[GitHub] [hadoop] swagle commented on a change in pull request #819: HDDS-1501 : Create a Recon task interface to update internal DB on updates from OM.

2019-05-15 Thread GitBox
swagle commented on a change in pull request #819: HDDS-1501 : Create a Recon task interface to update internal DB on updates from OM. URL: https://github.com/apache/hadoop/pull/819#discussion_r284481714 ## File path:

[jira] [Commented] (HADOOP-15999) S3Guard: Better support for out-of-band operations

2019-05-15 Thread Sean Mackrory (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840846#comment-16840846 ] Sean Mackrory commented on HADOOP-15999: {quote} Seems like a common case{quote} Yeah that's

[jira] [Comment Edited] (HADOOP-15999) S3Guard: Better support for out-of-band operations

2019-05-15 Thread Sean Mackrory (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840846#comment-16840846 ] Sean Mackrory edited comment on HADOOP-15999 at 5/15/19 10:49 PM: --

[jira] [Commented] (HADOOP-15999) S3Guard: Better support for out-of-band operations

2019-05-15 Thread Aaron Fabbri (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840844#comment-16840844 ] Aaron Fabbri commented on HADOOP-15999: --- What about in-band delete (create tombstone) and then

[GitHub] [hadoop] swagle commented on a change in pull request #819: HDDS-1501 : Create a Recon task interface to update internal DB on updates from OM.

2019-05-15 Thread GitBox
swagle commented on a change in pull request #819: HDDS-1501 : Create a Recon task interface to update internal DB on updates from OM. URL: https://github.com/apache/hadoop/pull/819#discussion_r284480734 ## File path:

[GitHub] [hadoop] swagle commented on a change in pull request #819: HDDS-1501 : Create a Recon task interface to update internal DB on updates from OM.

2019-05-15 Thread GitBox
swagle commented on a change in pull request #819: HDDS-1501 : Create a Recon task interface to update internal DB on updates from OM. URL: https://github.com/apache/hadoop/pull/819#discussion_r284480391 ## File path:

[GitHub] [hadoop] swagle commented on a change in pull request #819: HDDS-1501 : Create a Recon task interface to update internal DB on updates from OM.

2019-05-15 Thread GitBox
swagle commented on a change in pull request #819: HDDS-1501 : Create a Recon task interface to update internal DB on updates from OM. URL: https://github.com/apache/hadoop/pull/819#discussion_r284479782 ## File path:

[GitHub] [hadoop] swagle commented on a change in pull request #819: HDDS-1501 : Create a Recon task interface to update internal DB on updates from OM.

2019-05-15 Thread GitBox
swagle commented on a change in pull request #819: HDDS-1501 : Create a Recon task interface to update internal DB on updates from OM. URL: https://github.com/apache/hadoop/pull/819#discussion_r284474899 ## File path:

[GitHub] [hadoop] swagle commented on a change in pull request #819: HDDS-1501 : Create a Recon task interface to update internal DB on updates from OM.

2019-05-15 Thread GitBox
swagle commented on a change in pull request #819: HDDS-1501 : Create a Recon task interface to update internal DB on updates from OM. URL: https://github.com/apache/hadoop/pull/819#discussion_r284474695 ## File path:

[GitHub] [hadoop] swagle commented on a change in pull request #819: HDDS-1501 : Create a Recon task interface to update internal DB on updates from OM.

2019-05-15 Thread GitBox
swagle commented on a change in pull request #819: HDDS-1501 : Create a Recon task interface to update internal DB on updates from OM. URL: https://github.com/apache/hadoop/pull/819#discussion_r284474114 ## File path:

[GitHub] [hadoop] swagle commented on a change in pull request #819: HDDS-1501 : Create a Recon task interface to update internal DB on updates from OM.

2019-05-15 Thread GitBox
swagle commented on a change in pull request #819: HDDS-1501 : Create a Recon task interface to update internal DB on updates from OM. URL: https://github.com/apache/hadoop/pull/819#discussion_r284472229 ## File path:

[GitHub] [hadoop] swagle commented on a change in pull request #819: HDDS-1501 : Create a Recon task interface to update internal DB on updates from OM.

2019-05-15 Thread GitBox
swagle commented on a change in pull request #819: HDDS-1501 : Create a Recon task interface to update internal DB on updates from OM. URL: https://github.com/apache/hadoop/pull/819#discussion_r284472028 ## File path:

[GitHub] [hadoop] swagle commented on a change in pull request #819: HDDS-1501 : Create a Recon task interface to update internal DB on updates from OM.

2019-05-15 Thread GitBox
swagle commented on a change in pull request #819: HDDS-1501 : Create a Recon task interface to update internal DB on updates from OM. URL: https://github.com/apache/hadoop/pull/819#discussion_r284471626 ## File path:

[GitHub] [hadoop] swagle commented on a change in pull request #819: HDDS-1501 : Create a Recon task interface to update internal DB on updates from OM.

2019-05-15 Thread GitBox
swagle commented on a change in pull request #819: HDDS-1501 : Create a Recon task interface to update internal DB on updates from OM. URL: https://github.com/apache/hadoop/pull/819#discussion_r284470960 ## File path:

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #798: HDDS-1499. OzoneManager Cache.

2019-05-15 Thread GitBox
bharatviswa504 commented on a change in pull request #798: HDDS-1499. OzoneManager Cache. URL: https://github.com/apache/hadoop/pull/798#discussion_r284462072 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/TypedTable.java ## @@ -71,6 +96,27 @@

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #798: HDDS-1499. OzoneManager Cache.

2019-05-15 Thread GitBox
bharatviswa504 commented on a change in pull request #798: HDDS-1499. OzoneManager Cache. URL: https://github.com/apache/hadoop/pull/798#discussion_r284461812 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/cache/PartialTableCache.java ## @@

[GitHub] [hadoop] swagle commented on issue #822: HDDS-1527. HDDS Datanode start fails due to datanode.id file read error

2019-05-15 Thread GitBox
swagle commented on issue #822: HDDS-1527. HDDS Datanode start fails due to datanode.id file read error URL: https://github.com/apache/hadoop/pull/822#issuecomment-492832955 Unit test failures are unrelated. @arp7 Can you review this change, please?

[jira] [Comment Edited] (HADOOP-16279) S3Guard: Implement time-based (TTL) expiry for entries (and tombstones)

2019-05-15 Thread Aaron Fabbri (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840799#comment-16840799 ] Aaron Fabbri edited comment on HADOOP-16279 at 5/15/19 9:34 PM:

[jira] [Commented] (HADOOP-16279) S3Guard: Implement time-based (TTL) expiry for entries (and tombstones)

2019-05-15 Thread Aaron Fabbri (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840799#comment-16840799 ] Aaron Fabbri commented on HADOOP-16279: --- {quote}with HADOOP-15999 we changed a bit how

[GitHub] [hadoop] bharatviswa504 commented on issue #798: HDDS-1499. OzoneManager Cache.

2019-05-15 Thread GitBox
bharatviswa504 commented on issue #798: HDDS-1499. OzoneManager Cache. URL: https://github.com/apache/hadoop/pull/798#issuecomment-492831553 Thank You @arp7 for offline discussion. I have addressed review the comments.

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #798: HDDS-1499. OzoneManager Cache.

2019-05-15 Thread GitBox
bharatviswa504 commented on a change in pull request #798: HDDS-1499. OzoneManager Cache. URL: https://github.com/apache/hadoop/pull/798#discussion_r284458211 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java ##

[GitHub] [hadoop] hadoop-yetus commented on issue #823: HADOOP-16315. ABFS: transform full UPN for named user in AclStatus

2019-05-15 Thread GitBox
hadoop-yetus commented on issue #823: HADOOP-16315. ABFS: transform full UPN for named user in AclStatus URL: https://github.com/apache/hadoop/pull/823#issuecomment-492830088 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #798: HDDS-1499. OzoneManager Cache.

2019-05-15 Thread GitBox
bharatviswa504 commented on a change in pull request #798: HDDS-1499. OzoneManager Cache. URL: https://github.com/apache/hadoop/pull/798#discussion_r284458025 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/cache/TableCache.java ## @@ -0,0 +1,73

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #798: HDDS-1499. OzoneManager Cache.

2019-05-15 Thread GitBox
bharatviswa504 commented on a change in pull request #798: HDDS-1499. OzoneManager Cache. URL: https://github.com/apache/hadoop/pull/798#discussion_r284457687 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/cache/FullTableCache.java ## @@ -0,0

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #798: HDDS-1499. OzoneManager Cache.

2019-05-15 Thread GitBox
bharatviswa504 commented on a change in pull request #798: HDDS-1499. OzoneManager Cache. URL: https://github.com/apache/hadoop/pull/798#discussion_r284457474 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/TypedTable.java ## @@ -31,22 +38,40 @@

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #798: HDDS-1499. OzoneManager Cache.

2019-05-15 Thread GitBox
bharatviswa504 commented on a change in pull request #798: HDDS-1499. OzoneManager Cache. URL: https://github.com/apache/hadoop/pull/798#discussion_r284457204 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/DBStore.java ## @@ -44,17 +45,20 @@

[GitHub] [hadoop] hadoop-yetus commented on issue #822: HDDS-1527. HDDS Datanode start fails due to datanode.id file read error

2019-05-15 Thread GitBox
hadoop-yetus commented on issue #822: HDDS-1527. HDDS Datanode start fails due to datanode.id file read error URL: https://github.com/apache/hadoop/pull/822#issuecomment-492826896 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] DadanielZ opened a new pull request #823: HADOOP-16315. ABFS: transform full UPN for named user in AclStatus

2019-05-15 Thread GitBox
DadanielZ opened a new pull request #823: HADOOP-16315. ABFS: transform full UPN for named user in AclStatus URL: https://github.com/apache/hadoop/pull/823 Fixed identity conversion for AclEntry when calling getAclStatus() All tests passed my US-west account: xns account:

[GitHub] [hadoop] hadoop-yetus commented on issue #798: HDDS-1499. OzoneManager Cache.

2019-05-15 Thread GitBox
hadoop-yetus commented on issue #798: HDDS-1499. OzoneManager Cache. URL: https://github.com/apache/hadoop/pull/798#issuecomment-492800469 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 |

[GitHub] [hadoop] swagle opened a new pull request #822: HDDS-1527. HDDS Datanode start fails due to datanode.id file read error

2019-05-15 Thread GitBox
swagle opened a new pull request #822: HDDS-1527. HDDS Datanode start fails due to datanode.id file read error URL: https://github.com/apache/hadoop/pull/822 This is an automated message from the Apache Git Service. To

[GitHub] [hadoop] hadoop-yetus commented on issue #654: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename

2019-05-15 Thread GitBox
hadoop-yetus commented on issue #654: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename URL: https://github.com/apache/hadoop/pull/654#issuecomment-492791717 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] bharatviswa504 commented on issue #798: HDDS-1499. OzoneManager Cache.

2019-05-15 Thread GitBox
bharatviswa504 commented on issue #798: HDDS-1499. OzoneManager Cache. URL: https://github.com/apache/hadoop/pull/798#issuecomment-492770431 Thank You @arp7 for the review. Few of the review comments I have addressed them, for other's provided reply for the comments.

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #798: HDDS-1499. OzoneManager Cache.

2019-05-15 Thread GitBox
bharatviswa504 commented on a change in pull request #798: HDDS-1499. OzoneManager Cache. URL: https://github.com/apache/hadoop/pull/798#discussion_r284392124 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/TypedTable.java ## @@ -69,8 +94,40 @@

[GitHub] [hadoop] arp7 merged pull request #812: HDDS-1511. Space tracking for Open Containers in HDDS Volumes. Contributed by Supratim Deka

2019-05-15 Thread GitBox
arp7 merged pull request #812: HDDS-1511. Space tracking for Open Containers in HDDS Volumes. Contributed by Supratim Deka URL: https://github.com/apache/hadoop/pull/812 This is an automated message from the Apache Git

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #798: HDDS-1499. OzoneManager Cache.

2019-05-15 Thread GitBox
bharatviswa504 commented on a change in pull request #798: HDDS-1499. OzoneManager Cache. URL: https://github.com/apache/hadoop/pull/798#discussion_r284365121 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/cache/TableCache.java ## @@ -0,0 +1,73

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #798: HDDS-1499. OzoneManager Cache.

2019-05-15 Thread GitBox
bharatviswa504 commented on a change in pull request #798: HDDS-1499. OzoneManager Cache. URL: https://github.com/apache/hadoop/pull/798#discussion_r284364154 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java ##

[GitHub] [hadoop] arp7 commented on a change in pull request #798: HDDS-1499. OzoneManager Cache.

2019-05-15 Thread GitBox
arp7 commented on a change in pull request #798: HDDS-1499. OzoneManager Cache. URL: https://github.com/apache/hadoop/pull/798#discussion_r284363840 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/cache/TableCache.java ## @@ -0,0 +1,73 @@ +/* + *

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #798: HDDS-1499. OzoneManager Cache.

2019-05-15 Thread GitBox
bharatviswa504 commented on a change in pull request #798: HDDS-1499. OzoneManager Cache. URL: https://github.com/apache/hadoop/pull/798#discussion_r284363194 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/cache/TableCache.java ## @@ -0,0 +1,73

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #798: HDDS-1499. OzoneManager Cache.

2019-05-15 Thread GitBox
bharatviswa504 commented on a change in pull request #798: HDDS-1499. OzoneManager Cache. URL: https://github.com/apache/hadoop/pull/798#discussion_r284362406 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/cache/FullTableCache.java ## @@ -0,0

[GitHub] [hadoop] arp7 commented on a change in pull request #798: HDDS-1499. OzoneManager Cache.

2019-05-15 Thread GitBox
arp7 commented on a change in pull request #798: HDDS-1499. OzoneManager Cache. URL: https://github.com/apache/hadoop/pull/798#discussion_r284362457 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/TypedTable.java ## @@ -69,8 +94,40 @@ public

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #798: HDDS-1499. OzoneManager Cache.

2019-05-15 Thread GitBox
bharatviswa504 commented on a change in pull request #798: HDDS-1499. OzoneManager Cache. URL: https://github.com/apache/hadoop/pull/798#discussion_r284361950 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/cache/CacheValue.java ## @@ -0,0 +1,63

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #798: HDDS-1499. OzoneManager Cache.

2019-05-15 Thread GitBox
bharatviswa504 commented on a change in pull request #798: HDDS-1499. OzoneManager Cache. URL: https://github.com/apache/hadoop/pull/798#discussion_r284361801 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/TypedTable.java ## @@ -69,8 +94,40 @@

[GitHub] [hadoop] steveloughran commented on issue #654: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename

2019-05-15 Thread GitBox
steveloughran commented on issue #654: HADOOP-15183 S3Guard store becomes inconsistent after partial failure of rename URL: https://github.com/apache/hadoop/pull/654#issuecomment-492739025 just pushed out my addition of a bulk update context all the way through the commit operation; it's

[jira] [Created] (HADOOP-16316) S3A delegation tests fail if you set fs.s3a.secret.key

2019-05-15 Thread Steve Loughran (JIRA)
Steve Loughran created HADOOP-16316: --- Summary: S3A delegation tests fail if you set fs.s3a.secret.key Key: HADOOP-16316 URL: https://issues.apache.org/jira/browse/HADOOP-16316 Project: Hadoop Common

[jira] [Commented] (HADOOP-16316) S3A delegation tests fail if you set fs.s3a.secret.key

2019-05-15 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840564#comment-16840564 ] Steve Loughran commented on HADOOP-16316: - Stack {code} [ERROR]

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #798: HDDS-1499. OzoneManager Cache.

2019-05-15 Thread GitBox
bharatviswa504 commented on a change in pull request #798: HDDS-1499. OzoneManager Cache. URL: https://github.com/apache/hadoop/pull/798#discussion_r284350525 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/TypedTable.java ## @@ -69,8 +94,40 @@

[GitHub] [hadoop] eyanghwx commented on a change in pull request #814: HDDS-1518. Use /etc/ozone for configuration inside docker-compose

2019-05-15 Thread GitBox
eyanghwx commented on a change in pull request #814: HDDS-1518. Use /etc/ozone for configuration inside docker-compose URL: https://github.com/apache/hadoop/pull/814#discussion_r284348832 ## File path: Dockerfile ## @@ -36,7 +36,9 @@ RUN chown hadoop /opt ADD scripts

[jira] [Updated] (HADOOP-16314) Make sure all end point URL is covered by the same AuthenticationFilter

2019-05-15 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Yang updated HADOOP-16314: --- Component/s: security > Make sure all end point URL is covered by the same AuthenticationFilter >

[jira] [Updated] (HADOOP-16314) Make sure all end point URL is covered by the same AuthenticationFilter

2019-05-15 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Yang updated HADOOP-16314: --- Attachment: scan.txt > Make sure all end point URL is covered by the same AuthenticationFilter >

[jira] [Updated] (HADOOP-16314) Make sure all end point URL is covered by the same AuthenticationFilter

2019-05-15 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Yang updated HADOOP-16314: --- Attachment: Hadoop Web Security.xlsx > Make sure all end point URL is covered by the same

[jira] [Updated] (HADOOP-16315) ABFS: transform full UPN for named user in AclStatus

2019-05-15 Thread Da Zhou (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Da Zhou updated HADOOP-16315: - Affects Version/s: 3.2.0 Target Version/s: 3.2.1 Component/s: fs/azure > ABFS:

[jira] [Created] (HADOOP-16315) ABFS: transform full UPN for named user in AclStatus

2019-05-15 Thread Da Zhou (JIRA)
Da Zhou created HADOOP-16315: Summary: ABFS: transform full UPN for named user in AclStatus Key: HADOOP-16315 URL: https://issues.apache.org/jira/browse/HADOOP-16315 Project: Hadoop Common Issue

[jira] [Updated] (HADOOP-16314) Make sure all end point URL is covered by the same AuthenticationFilter

2019-05-15 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Yang updated HADOOP-16314: --- Issue Type: Sub-task (was: Improvement) Parent: HADOOP-16095 > Make sure all end point

[jira] [Updated] (HADOOP-16287) KerberosAuthenticationHandler Trusted Proxy Support for Knox

2019-05-15 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Yang updated HADOOP-16287: --- Issue Type: Sub-task (was: New Feature) Parent: HADOOP-16095 >

[jira] [Commented] (HADOOP-16095) Support impersonation for AuthenticationFilter

2019-05-15 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840542#comment-16840542 ] Eric Yang commented on HADOOP-16095: The patch 004 was the original patch that posted in Hadoop

[jira] [Updated] (HADOOP-16095) Support impersonation for AuthenticationFilter

2019-05-15 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Yang updated HADOOP-16095: --- Attachment: HADOOP-16095.004.patch > Support impersonation for AuthenticationFilter >

[jira] [Commented] (HADOOP-16287) KerberosAuthenticationHandler Trusted Proxy Support for Knox

2019-05-15 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840528#comment-16840528 ] Eric Yang commented on HADOOP-16287: +1 on patch 007 to include the new

[jira] [Created] (HADOOP-16314) Make sure all end point URL is covered by the same AuthenticationFilter

2019-05-15 Thread Eric Yang (JIRA)
Eric Yang created HADOOP-16314: -- Summary: Make sure all end point URL is covered by the same AuthenticationFilter Key: HADOOP-16314 URL: https://issues.apache.org/jira/browse/HADOOP-16314 Project:

[jira] [Commented] (HADOOP-16161) NetworkTopology#getWeightUsingNetworkLocation return unexpected result

2019-05-15 Thread He Xiaoqiao (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840523#comment-16840523 ] He Xiaoqiao commented on HADOOP-16161: -- Thanks [~elgoiri] for the review and commit. >

[jira] [Commented] (HADOOP-15183) S3Guard store becomes inconsistent after partial failure of rename

2019-05-15 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840347#comment-16840347 ] Steve Loughran commented on HADOOP-15183: - HADOOP-15604 is going to be addressed by this: the

[GitHub] [hadoop] jiwq opened a new pull request #821: MAPREDUCE-7205. Changed to the interpret container scheduler kill exit code as a task attempt killing event

2019-05-15 Thread GitBox
jiwq opened a new pull request #821: MAPREDUCE-7205. Changed to the interpret container scheduler kill exit code as a task attempt killing event URL: https://github.com/apache/hadoop/pull/821 [MAPREDUCE-7205](https://issues.apache.org/jira/browse/) MR needs to recognize the special

[jira] [Commented] (HADOOP-16263) Update BUILDING.txt with macOS native build instructions

2019-05-15 Thread Adam Antal (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840268#comment-16840268 ] Adam Antal commented on HADOOP-16263: - Sorry didn't have the chance to try this yet, but I hope I

[jira] [Created] (HADOOP-16313) multipart/huge file upload tests to look at checksums returned

2019-05-15 Thread Steve Loughran (JIRA)
Steve Loughran created HADOOP-16313: --- Summary: multipart/huge file upload tests to look at checksums returned Key: HADOOP-16313 URL: https://issues.apache.org/jira/browse/HADOOP-16313 Project:

[GitHub] [hadoop] supratimdeka commented on issue #812: HDDS-1511. Space tracking for Open Containers in HDDS Volumes. Contributed by Supratim Deka

2019-05-15 Thread GitBox
supratimdeka commented on issue #812: HDDS-1511. Space tracking for Open Containers in HDDS Volumes. Contributed by Supratim Deka URL: https://github.com/apache/hadoop/pull/812#issuecomment-492577036 TestBlockOutputStreamWithFailures appears to be unpredictable - failures are

[GitHub] [hadoop] mukul1987 commented on issue #820: HDDS-1531. Disable the sync flag by default during chunk writes in Datanode.

2019-05-15 Thread GitBox
mukul1987 commented on issue #820: HDDS-1531. Disable the sync flag by default during chunk writes in Datanode. URL: https://github.com/apache/hadoop/pull/820#issuecomment-492572153 /retest This is an automated message

[GitHub] [hadoop] hadoop-yetus commented on issue #820: HDDS-1531. Disable the sync flag by default during chunk writes in Datanode.

2019-05-15 Thread GitBox
hadoop-yetus commented on issue #820: HDDS-1531. Disable the sync flag by default during chunk writes in Datanode. URL: https://github.com/apache/hadoop/pull/820#issuecomment-492537408 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Commented] (HADOOP-16287) KerberosAuthenticationHandler Trusted Proxy Support for Knox

2019-05-15 Thread Prabhu Joseph (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840110#comment-16840110 ] Prabhu Joseph commented on HADOOP-16287: Fixed checkstyle issues in [^HADOOP-16287-007.patch].

[jira] [Commented] (HADOOP-16287) KerberosAuthenticationHandler Trusted Proxy Support for Knox

2019-05-15 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840105#comment-16840105 ] Hadoop QA commented on HADOOP-16287: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||