[GitHub] [hadoop] hadoop-yetus commented on pull request #3713: HDFS-16351. add path exception information in FSNamesystem

2021-11-23 Thread GitBox
hadoop-yetus commented on pull request #3713: URL: https://github.com/apache/hadoop/pull/3713#issuecomment-977619424 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Work logged] (HADOOP-18021) Provide a public wrapper of Configuration#substituteVars

2021-11-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18021?focusedWorklogId=685647=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-685647 ] ASF GitHub Bot logged work on HADOOP-18021: --- Author: ASF GitHub Bot

[GitHub] [hadoop] 9uapaw commented on pull request #3710: HADOOP-18021. Provide a public wrapper of Configuration#substituteVars

2021-11-23 Thread GitBox
9uapaw commented on pull request #3710: URL: https://github.com/apache/hadoop/pull/3710#issuecomment-977598778 Thanks for the suggestions @steveloughran. I am not sure about the tests however, what do you have in mind? Variable substitution is already tested in

[jira] [Work logged] (HADOOP-18016) Make certain methods LimitedPrivate in S3AUtils.java to provide proxy support

2021-11-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18016?focusedWorklogId=685643=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-685643 ] ASF GitHub Bot logged work on HADOOP-18016: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #3685: HADOOP-18016. Make certain methods LimitedPrivate in S3AUtils.java

2021-11-23 Thread GitBox
hadoop-yetus commented on pull request #3685: URL: https://github.com/apache/hadoop/pull/3685#issuecomment-977594063 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Work started] (HADOOP-18022) Add restrict-imports-enforcer-rule for Guava Preconditions in hadoop-main pom

2021-11-23 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HADOOP-18022 started by Viraj Jasani. - > Add restrict-imports-enforcer-rule for Guava Preconditions in hadoop-main

[jira] [Updated] (HADOOP-18022) Add restrict-imports-enforcer-rule for Guava Preconditions in hadoop-main pom

2021-11-23 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HADOOP-18022: -- Status: Patch Available (was: In Progress) > Add restrict-imports-enforcer-rule for Guava

[GitHub] [hadoop] virajjasani commented on pull request #3686: HDFS-16336. De-flake TestRollingUpgrade#testRollback

2021-11-23 Thread GitBox
virajjasani commented on pull request #3686: URL: https://github.com/apache/hadoop/pull/3686#issuecomment-977592414 FYI @ferhui if you would also like to take a look. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hadoop] virajjasani commented on pull request #3711: HDFS-16350. Datanode start time should be set after RPC server starts successfully

2021-11-23 Thread GitBox
virajjasani commented on pull request #3711: URL: https://github.com/apache/hadoop/pull/3711#issuecomment-977572315 @ferhui could you please also take a look? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Comment Edited] (HADOOP-18019) S3AFileSystem.s3GetFileStatus() doesn't find dir markers on minio

2021-11-23 Thread Harshavardhana (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17448375#comment-17448375 ] Harshavardhana edited comment on HADOOP-18019 at 11/24/21, 6:05 AM:

[jira] [Comment Edited] (HADOOP-18019) S3AFileSystem.s3GetFileStatus() doesn't find dir markers on minio

2021-11-23 Thread Harshavardhana (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17448375#comment-17448375 ] Harshavardhana edited comment on HADOOP-18019 at 11/24/21, 6:03 AM:

[jira] [Commented] (HADOOP-18019) S3AFileSystem.s3GetFileStatus() doesn't find dir markers on minio

2021-11-23 Thread Harshavardhana (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17448375#comment-17448375 ] Harshavardhana commented on HADOOP-18019: - MinIO has a few ways you can deploy i.e  * server

[GitHub] [hadoop] tomscut commented on pull request #3676: HDFS-16331. Make dfs.blockreport.intervalMsec reconfigurable

2021-11-23 Thread GitBox
tomscut commented on pull request #3676: URL: https://github.com/apache/hadoop/pull/3676#issuecomment-977557224 @jojochuang @tasanuma @ferhui @ayushtkn , PTAL. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [hadoop] hadoop-yetus commented on pull request #3676: HDFS-16331. Make dfs.blockreport.intervalMsec reconfigurable

2021-11-23 Thread GitBox
hadoop-yetus commented on pull request #3676: URL: https://github.com/apache/hadoop/pull/3676#issuecomment-977551764 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] GuoPhilipse edited a comment on pull request #3696: HDFS-16345. Fix test case fail in TestBlockStoragePolicy

2021-11-23 Thread GitBox
GuoPhilipse edited a comment on pull request #3696: URL: https://github.com/apache/hadoop/pull/3696#issuecomment-976220112 cc @aajisaka @ayushtkn here are several PR tests fail for BindException of `TestBlockStoragePolicy` class.

[GitHub] [hadoop] GuoPhilipse commented on pull request #3713: HDFS-16351. add path exception information in FSNamesystem

2021-11-23 Thread GitBox
GuoPhilipse commented on pull request #3713: URL: https://github.com/apache/hadoop/pull/3713#issuecomment-977415121 Thanks @virajjasani for your review .test case have just updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Work logged] (HADOOP-17995) Stale record should be remove when DataNodePeerMetrics#dumpSendPacketDownstreamAvgInfoAsJson

2021-11-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17995?focusedWorklogId=685569=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-685569 ] ASF GitHub Bot logged work on HADOOP-17995: --- Author: ASF GitHub Bot

[GitHub] [hadoop] ferhui commented on pull request #3708: HADOOP-17995. Stale record should be remove when DataNodePeerMetrics#dumpSendPacketDownstreamAvgInfoAsJson

2021-11-23 Thread GitBox
ferhui commented on pull request #3708: URL: https://github.com/apache/hadoop/pull/3708#issuecomment-977391748 cc @steveloughran @sodonnel -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hadoop] liubingxing commented on pull request #3679: HDFS-16333. fix balancer bug when transfer an EC block

2021-11-23 Thread GitBox
liubingxing commented on pull request #3679: URL: https://github.com/apache/hadoop/pull/3679#issuecomment-977356044 > @liubingxing can you extend an UT for your scenario @hemanthboyina sorry for the late reply, I add a UT to simulate the balancer with EC file, the excluded node is

[GitHub] [hadoop] tomscut commented on pull request #3695: HDFS-16344. Improve DirectoryScanner.Stats#toString

2021-11-23 Thread GitBox
tomscut commented on pull request #3695: URL: https://github.com/apache/hadoop/pull/3695#issuecomment-977317596 Hi @tasanuma @ayushtkn , PTAL. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop] tomscut commented on pull request #3689: HDFS-16339. Show the threshold when mover threads quota is exceeded

2021-11-23 Thread GitBox
tomscut commented on pull request #3689: URL: https://github.com/apache/hadoop/pull/3689#issuecomment-977317248 Hi @tasanuma @ferhui , PTAL. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Work logged] (HADOOP-17409) Remove S3Guard - no longer needed

2021-11-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17409?focusedWorklogId=685527=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-685527 ] ASF GitHub Bot logged work on HADOOP-17409: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #3534: HADOOP-17409. Remove s3guard from S3A module

2021-11-23 Thread GitBox
hadoop-yetus commented on pull request #3534: URL: https://github.com/apache/hadoop/pull/3534#issuecomment-977215558 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] hadoop-yetus commented on pull request #3713: HDFS-16351. add path exception information in FSNamesystem

2021-11-23 Thread GitBox
hadoop-yetus commented on pull request #3713: URL: https://github.com/apache/hadoop/pull/3713#issuecomment-977204613 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] hadoop-yetus commented on pull request #3711: HDFS-16350. Datanode start time should be set after RPC server starts successfully

2021-11-23 Thread GitBox
hadoop-yetus commented on pull request #3711: URL: https://github.com/apache/hadoop/pull/3711#issuecomment-977195641 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] goiri merged pull request #3642: YARN-10760. Number of allocated OPPORTUNISTIC containers can dip below 0

2021-11-23 Thread GitBox
goiri merged pull request #3642: URL: https://github.com/apache/hadoop/pull/3642 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] goiri merged pull request #3646: YARN-11003. Make RMNode aware of all (OContainer inclusive) allocated resources

2021-11-23 Thread GitBox
goiri merged pull request #3646: URL: https://github.com/apache/hadoop/pull/3646 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] hadoop-yetus commented on pull request #3714: HDFS-16352. return the real datanode numBlocks in #getDatanodeStorage…

2021-11-23 Thread GitBox
hadoop-yetus commented on pull request #3714: URL: https://github.com/apache/hadoop/pull/3714#issuecomment-977104836 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] hadoop-yetus commented on pull request #3679: HDFS-16333. fix balancer bug when transfer an EC block

2021-11-23 Thread GitBox
hadoop-yetus commented on pull request #3679: URL: https://github.com/apache/hadoop/pull/3679#issuecomment-977056058 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] hadoop-yetus commented on pull request #3715: YARN-11014. YARN incorrectly validates maximum capacity resources on …

2021-11-23 Thread GitBox
hadoop-yetus commented on pull request #3715: URL: https://github.com/apache/hadoop/pull/3715#issuecomment-977026520 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Work logged] (HADOOP-17975) Fallback to simple auth does not work for a secondary DistributedFileSystem instance

2021-11-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17975?focusedWorklogId=685453=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-685453 ] ASF GitHub Bot logged work on HADOOP-17975: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #3579: HADOOP-17975 Fallback to simple auth does not work for a secondary DistributedFileSystem instance.

2021-11-23 Thread GitBox
hadoop-yetus commented on pull request #3579: URL: https://github.com/apache/hadoop/pull/3579#issuecomment-976984820 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Work logged] (HADOOP-17995) Stale record should be remove when DataNodePeerMetrics#dumpSendPacketDownstreamAvgInfoAsJson

2021-11-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17995?focusedWorklogId=685451=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-685451 ] ASF GitHub Bot logged work on HADOOP-17995: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #3708: HADOOP-17995. Stale record should be remove when DataNodePeerMetrics#dumpSendPacketDownstreamAvgInfoAsJson

2021-11-23 Thread GitBox
hadoop-yetus commented on pull request #3708: URL: https://github.com/apache/hadoop/pull/3708#issuecomment-976981142 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Work logged] (HADOOP-17409) Remove S3Guard - no longer needed

2021-11-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17409?focusedWorklogId=685445=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-685445 ] ASF GitHub Bot logged work on HADOOP-17409: --- Author: ASF GitHub Bot

[jira] [Work logged] (HADOOP-17409) Remove S3Guard - no longer needed

2021-11-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17409?focusedWorklogId=685444=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-685444 ] ASF GitHub Bot logged work on HADOOP-17409: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus removed a comment on pull request #3534: HADOOP-17409. Remove s3guard from S3A module

2021-11-23 Thread GitBox
hadoop-yetus removed a comment on pull request #3534: URL: https://github.com/apache/hadoop/pull/3534#issuecomment-976828074 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:|

[GitHub] [hadoop] hadoop-yetus removed a comment on pull request #3534: HADOOP-17409. Remove s3guard from S3A module

2021-11-23 Thread GitBox
hadoop-yetus removed a comment on pull request #3534: URL: https://github.com/apache/hadoop/pull/3534#issuecomment-975888432 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:|

[jira] [Work logged] (HADOOP-17409) Remove S3Guard - no longer needed

2021-11-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17409?focusedWorklogId=685443=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-685443 ] ASF GitHub Bot logged work on HADOOP-17409: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus removed a comment on pull request #3534: HADOOP-17409. Remove s3guard from S3A module

2021-11-23 Thread GitBox
hadoop-yetus removed a comment on pull request #3534: URL: https://github.com/apache/hadoop/pull/3534#issuecomment-974899616 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Work logged] (HADOOP-18022) Add restrict-imports-enforcer-rule for Guava Preconditions in hadoop-main pom

2021-11-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18022?focusedWorklogId=685441=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-685441 ] ASF GitHub Bot logged work on HADOOP-18022: --- Author: ASF GitHub Bot

[GitHub] [hadoop] virajjasani commented on pull request #3712: HADOOP-18022. Add restrict-imports-enforcer-rule for Guava Preconditions in hadoop-main pom

2021-11-23 Thread GitBox
virajjasani commented on pull request #3712: URL: https://github.com/apache/hadoop/pull/3712#issuecomment-976944312 Could you please take a look @tasanuma? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Work logged] (HADOOP-18016) Make certain methods LimitedPrivate in S3AUtils.java to provide proxy support

2021-11-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18016?focusedWorklogId=685439=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-685439 ] ASF GitHub Bot logged work on HADOOP-18016: --- Author: ASF GitHub Bot

[GitHub] [hadoop] steveloughran commented on pull request #3685: HADOOP-18016. Make certain methods LimitedPrivate in S3AUtils.java

2021-11-23 Thread GitBox
steveloughran commented on pull request #3685: URL: https://github.com/apache/hadoop/pull/3685#issuecomment-976939337 just rebase and resubmit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (HADOOP-17996) UserGroupInformation#unprotectedRelogin sets the last login time before logging in

2021-11-23 Thread Surendra Singh Lilhore (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17448161#comment-17448161 ] Surendra Singh Lilhore commented on HADOOP-17996: - >> Yes it can be workaround by

[jira] [Comment Edited] (HADOOP-17996) UserGroupInformation#unprotectedRelogin sets the last login time before logging in

2021-11-23 Thread Surendra Singh Lilhore (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17448161#comment-17448161 ] Surendra Singh Lilhore edited comment on HADOOP-17996 at 11/23/21, 5:52 PM:

[GitHub] [hadoop] goiri commented on a change in pull request #3709: YARN-9532. SLSRunner.run() throws a YarnException when it fails to cr…

2021-11-23 Thread GitBox
goiri commented on a change in pull request #3709: URL: https://github.com/apache/hadoop/pull/3709#discussion_r755358288 ## File path: hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/SLSRunner.java ## @@ -998,7 +998,7 @@ public int run(final String[] argv)

[GitHub] [hadoop] goiri commented on a change in pull request #3650: YARN-9853. Add number of paused containers in NodeInfo page.

2021-11-23 Thread GitBox
goiri commented on a change in pull request #3650: URL: https://github.com/apache/hadoop/pull/3650#discussion_r755356452 ## File path:

[GitHub] [hadoop] goiri commented on a change in pull request #3650: YARN-9853. Add number of paused containers in NodeInfo page.

2021-11-23 Thread GitBox
goiri commented on a change in pull request #3650: URL: https://github.com/apache/hadoop/pull/3650#discussion_r755355817 ## File path:

[GitHub] [hadoop] goiri commented on a change in pull request #3195: YARN-10459. containerLaunchedOnNode method not need to hold scheduler…

2021-11-23 Thread GitBox
goiri commented on a change in pull request #3195: URL: https://github.com/apache/hadoop/pull/3195#discussion_r755353230 ## File path:

[GitHub] [hadoop] goiri commented on a change in pull request #3632: YARN-10822. Containers going from New to Scheduled transition for kil…

2021-11-23 Thread GitBox
goiri commented on a change in pull request #3632: URL: https://github.com/apache/hadoop/pull/3632#discussion_r755351473 ## File path:

[jira] [Work logged] (HADOOP-18021) Provide a public wrapper of Configuration#substituteVars

2021-11-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18021?focusedWorklogId=685425=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-685425 ] ASF GitHub Bot logged work on HADOOP-18021: --- Author: ASF GitHub Bot

[jira] [Work logged] (HADOOP-18021) Provide a public wrapper of Configuration#substituteVars

2021-11-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18021?focusedWorklogId=685424=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-685424 ] ASF GitHub Bot logged work on HADOOP-18021: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #3710: HADOOP-18021. Provide a public wrapper of Configuration#substituteVars

2021-11-23 Thread GitBox
hadoop-yetus commented on pull request #3710: URL: https://github.com/apache/hadoop/pull/3710#issuecomment-976858364 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] hadoop-yetus commented on pull request #3710: HADOOP-18021. Provide a public wrapper of Configuration#substituteVars

2021-11-23 Thread GitBox
hadoop-yetus commented on pull request #3710: URL: https://github.com/apache/hadoop/pull/3710#issuecomment-976857661 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Work logged] (HADOOP-17409) Remove S3Guard - no longer needed

2021-11-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17409?focusedWorklogId=685413=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-685413 ] ASF GitHub Bot logged work on HADOOP-17409: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #3534: HADOOP-17409. Remove s3guard from S3A module

2021-11-23 Thread GitBox
hadoop-yetus commented on pull request #3534: URL: https://github.com/apache/hadoop/pull/3534#issuecomment-976828074 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] brumi1024 opened a new pull request #3715: YARN-11014. YARN incorrectly validates maximum capacity resources on …

2021-11-23 Thread GitBox
brumi1024 opened a new pull request #3715: URL: https://github.com/apache/hadoop/pull/3715 …the validation API ### Description of PR ### How was this patch tested? ### For code changes: - [ ] Does the title or this PR starts with the corresponding

[jira] [Comment Edited] (HADOOP-17996) UserGroupInformation#unprotectedRelogin sets the last login time before logging in

2021-11-23 Thread Prabhu Joseph (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17448083#comment-17448083 ] Prabhu Joseph edited comment on HADOOP-17996 at 11/23/21, 3:49 PM: ---

[jira] [Commented] (HADOOP-17996) UserGroupInformation#unprotectedRelogin sets the last login time before logging in

2021-11-23 Thread Prabhu Joseph (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17448083#comment-17448083 ] Prabhu Joseph commented on HADOOP-17996: [~surendralilhore] The issue in existing code is if a

[GitHub] [hadoop] virajjasani edited a comment on pull request #3711: HDFS-16350. Datanode start time should be set after RPC server starts successfully

2021-11-23 Thread GitBox
virajjasani edited a comment on pull request #3711: URL: https://github.com/apache/hadoop/pull/3711#issuecomment-976586442 Starttime calculation for Namenode and Router seem better than Datanode case, because it's not the main classes that have starttime defined (i.e. NameNode and

[GitHub] [hadoop] virajjasani edited a comment on pull request #3711: HDFS-16350. Datanode start time should be set after RPC server starts successfully

2021-11-23 Thread GitBox
virajjasani edited a comment on pull request #3711: URL: https://github.com/apache/hadoop/pull/3711#issuecomment-976586442 Starttime calculation for Namenode and Router seem better than Datanode case, because it's not the main classes that have starttime defined (i.e. NameNode and

[jira] [Work logged] (HADOOP-18014) CallerContext should not include some characters

2021-11-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18014?focusedWorklogId=685298=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-685298 ] ASF GitHub Bot logged work on HADOOP-18014: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #3698: HADOOP-18014. CallerContext should not include some characters.

2021-11-23 Thread GitBox
hadoop-yetus commented on pull request #3698: URL: https://github.com/apache/hadoop/pull/3698#issuecomment-976618246 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] liubingxing opened a new pull request #3714: HDFS-16352. return the real datanode numBlocks in #getDatanodeStorage…

2021-11-23 Thread GitBox
liubingxing opened a new pull request #3714: URL: https://github.com/apache/hadoop/pull/3714 JIRA: [HDFS-16352](https://issues.apache.org/jira/browse/HDFS-16352) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Work logged] (HADOOP-17409) Remove S3Guard - no longer needed

2021-11-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17409?focusedWorklogId=685291=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-685291 ] ASF GitHub Bot logged work on HADOOP-17409: --- Author: ASF GitHub Bot

[GitHub] [hadoop] steveloughran commented on pull request #3534: HADOOP-17409. Remove s3guard from S3A module

2021-11-23 Thread GitBox
steveloughran commented on pull request #3534: URL: https://github.com/apache/hadoop/pull/3534#issuecomment-976586826 HBoss contains references to local metastore & ability to set it in hadoop-testutils/src/main/java/org/apache/hadoop/hbase/oss/EmbeddedS3.java maybe we should make

[GitHub] [hadoop] virajjasani commented on pull request #3711: HDFS-16350. Datanode start time should be set after RPC server starts successfully

2021-11-23 Thread GitBox
virajjasani commented on pull request #3711: URL: https://github.com/apache/hadoop/pull/3711#issuecomment-976586442 Starttime calculation for Namenode and Router seem better than Datanode case, because it's not the main classes that have starttime defined (i.e. NameNode and DFSRouter) but

[GitHub] [hadoop] GuoPhilipse opened a new pull request #3713: HDFS-16351. add path exception information in FSNamesystem

2021-11-23 Thread GitBox
GuoPhilipse opened a new pull request #3713: URL: https://github.com/apache/hadoop/pull/3713 add path information in exception message to make message more clear in FSNamesystem -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hadoop] virajjasani edited a comment on pull request #3711: HDFS-16350. Datanode start time should be set after RPC server starts successfully

2021-11-23 Thread GitBox
virajjasani edited a comment on pull request #3711: URL: https://github.com/apache/hadoop/pull/3711#issuecomment-976548773 Thanks @tomscut. Yes this is a minor improvement in the behaviour. Basically, we should set the time according to the actual server startup time. The point is by the

[GitHub] [hadoop] virajjasani commented on pull request #3711: HDFS-16350. Datanode start time should be set after RPC server starts successfully

2021-11-23 Thread GitBox
virajjasani commented on pull request #3711: URL: https://github.com/apache/hadoop/pull/3711#issuecomment-976548773 Thanks @tomscut. Yes this is a minor improvement in the behaviour. Basically, we should set the time according to the actual server startup time. The point is by the time

[GitHub] [hadoop] sodonnel merged pull request #3694: HDFS-16343. Add some debug logs when the dfsUsed are not used during Datanode startup.

2021-11-23 Thread GitBox
sodonnel merged pull request #3694: URL: https://github.com/apache/hadoop/pull/3694 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] 9uapaw commented on a change in pull request #3660: YARN-10982

2021-11-23 Thread GitBox
9uapaw commented on a change in pull request #3660: URL: https://github.com/apache/hadoop/pull/3660#discussion_r755099357 ## File path:

[GitHub] [hadoop] hadoop-yetus commented on pull request #3694: HDFS-16343. Add some debug logs when the dfsUsed are not used during Datanode startup.

2021-11-23 Thread GitBox
hadoop-yetus commented on pull request #3694: URL: https://github.com/apache/hadoop/pull/3694#issuecomment-976496184 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] tomscut edited a comment on pull request #3711: HDFS-16350. Datanode start time should be set after RPC server starts successfully

2021-11-23 Thread GitBox
tomscut edited a comment on pull request #3711: URL: https://github.com/apache/hadoop/pull/3711#issuecomment-976471066 > @tomscut @goiri could you please take a look? Thanks Thanks @virajjasani for reminding me here. At present, both `Router` and `Namenode` obtain `startTime` in

[jira] [Work logged] (HADOOP-18016) Make certain methods LimitedPrivate in S3AUtils.java to provide proxy support

2021-11-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18016?focusedWorklogId=685222=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-685222 ] ASF GitHub Bot logged work on HADOOP-18016: --- Author: ASF GitHub Bot

[GitHub] [hadoop] mukund-thakur commented on pull request #3685: HADOOP-18016. Make certain methods LimitedPrivate in S3AUtils.java

2021-11-23 Thread GitBox
mukund-thakur commented on pull request #3685: URL: https://github.com/apache/hadoop/pull/3685#issuecomment-976476175 Yetus failed. I don't how to retrigger. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop] tomscut edited a comment on pull request #3711: HDFS-16350. Datanode start time should be set after RPC server starts successfully

2021-11-23 Thread GitBox
tomscut edited a comment on pull request #3711: URL: https://github.com/apache/hadoop/pull/3711#issuecomment-976471066 > @tomscut @goiri could you please take a look? Thanks Thanks @virajjasani for reminding me here. At present, both `Router` and `Namenode` obtain `startTime` in

[GitHub] [hadoop] tomscut edited a comment on pull request #3711: HDFS-16350. Datanode start time should be set after RPC server starts successfully

2021-11-23 Thread GitBox
tomscut edited a comment on pull request #3711: URL: https://github.com/apache/hadoop/pull/3711#issuecomment-976471066 > @tomscut @goiri could you please take a look? Thanks Thanks @virajjasani for reminding me here. At present, both router and Namenode obtain startTime in this way.

[GitHub] [hadoop] tomscut commented on pull request #3711: HDFS-16350. Datanode start time should be set after RPC server starts successfully

2021-11-23 Thread GitBox
tomscut commented on pull request #3711: URL: https://github.com/apache/hadoop/pull/3711#issuecomment-976471066 > @tomscut @goiri could you please take a look? Thanks > @tomscut @goiri could you please take a look? Thanks Thanks @virajjasani for reminding me here. At

[jira] [Work logged] (HADOOP-17975) Fallback to simple auth does not work for a secondary DistributedFileSystem instance

2021-11-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17975?focusedWorklogId=685213=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-685213 ] ASF GitHub Bot logged work on HADOOP-17975: --- Author: ASF GitHub Bot

[GitHub] [hadoop] fapifta commented on pull request #3579: HADOOP-17975 Fallback to simple auth does not work for a secondary DistributedFileSystem instance.

2021-11-23 Thread GitBox
fapifta commented on pull request #3579: URL: https://github.com/apache/hadoop/pull/3579#issuecomment-976459364 Oh, I haven't spotted that, fixed. Let's see the CI results. Thank you @sodonnel for the review! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop] sumangala-patki commented on a change in pull request #3440: ABFS: Support for Encryption Context

2021-11-23 Thread GitBox
sumangala-patki commented on a change in pull request #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r755049470 ## File path: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/security/EncryptionAdapter.java ## @@ -0,0 +1,147 @@ +/** + *

[jira] [Work logged] (HADOOP-18022) Add restrict-imports-enforcer-rule for Guava Preconditions in hadoop-main pom

2021-11-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18022?focusedWorklogId=685208=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-685208 ] ASF GitHub Bot logged work on HADOOP-18022: --- Author: ASF GitHub Bot

[jira] [Updated] (HADOOP-18022) Add restrict-imports-enforcer-rule for Guava Preconditions in hadoop-main pom

2021-11-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18022: Labels: pull-request-available (was: ) > Add restrict-imports-enforcer-rule for Guava

[GitHub] [hadoop] virajjasani opened a new pull request #3712: HADOOP-18022. Add restrict-imports-enforcer-rule for Guava Preconditions in hadoop-main pom

2021-11-23 Thread GitBox
virajjasani opened a new pull request #3712: URL: https://github.com/apache/hadoop/pull/3712 ### Description of PR Add restrict-imports-enforcer-rule for Guava Preconditions in hadoop-main pom to restrict any new import in future. Remove any remaining usages of Guava Preconditions from

[GitHub] [hadoop] sumangala-patki commented on a change in pull request #3440: ABFS: Support for Encryption Context

2021-11-23 Thread GitBox
sumangala-patki commented on a change in pull request #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r755047630 ## File path: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AbfsConfiguration.java ## @@ -906,6 +907,36 @@ public

[GitHub] [hadoop] sumangala-patki commented on a change in pull request #3440: ABFS: Support for Encryption Context

2021-11-23 Thread GitBox
sumangala-patki commented on a change in pull request #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r755045867 ## File path: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java ## @@ -113,13 +119,14 @@ private

[GitHub] [hadoop] hadoop-yetus commented on pull request #3709: YARN-9532. SLSRunner.run() throws a YarnException when it fails to cr…

2021-11-23 Thread GitBox
hadoop-yetus commented on pull request #3709: URL: https://github.com/apache/hadoop/pull/3709#issuecomment-976432240 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Created] (HADOOP-18022) Add restrict-imports-enforcer-rule for Guava Preconditions in hadoop-main pom

2021-11-23 Thread Viraj Jasani (Jira)
Viraj Jasani created HADOOP-18022: - Summary: Add restrict-imports-enforcer-rule for Guava Preconditions in hadoop-main pom Key: HADOOP-18022 URL: https://issues.apache.org/jira/browse/HADOOP-18022

[jira] [Work logged] (HADOOP-18001) Update to Jetty 9.4.44

2021-11-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18001?focusedWorklogId=685201=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-685201 ] ASF GitHub Bot logged work on HADOOP-18001: --- Author: ASF GitHub Bot

[GitHub] [hadoop] steveloughran commented on pull request #3700: HADOOP-18001. Upgrade jetty version to 9.4.44

2021-11-23 Thread GitBox
steveloughran commented on pull request #3700: URL: https://github.com/apache/hadoop/pull/3700#issuecomment-976430760 we really need to force yetus to test the yarn and hdfs test suites as they use jetty. could you extend this PR to add a newline to the end of hadoop-hdfs and hadoop-yarn

[jira] [Commented] (HADOOP-18021) Provide a public wrapper of Configuration#substituteVars

2021-11-23 Thread Andras Gyori (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447946#comment-17447946 ] Andras Gyori commented on HADOOP-18021: --- Thanks [~ste...@apache.org] for taking care of this. The

[jira] [Work logged] (HADOOP-18021) Provide a public wrapper of Configuration#substituteVars

2021-11-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18021?focusedWorklogId=685197=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-685197 ] ASF GitHub Bot logged work on HADOOP-18021: --- Author: ASF GitHub Bot

[GitHub] [hadoop] steveloughran commented on a change in pull request #3710: HADOOP-18021. Provide a public wrapper of Configuration#substituteVars

2021-11-23 Thread GitBox
steveloughran commented on a change in pull request #3710: URL: https://github.com/apache/hadoop/pull/3710#discussion_r755034309 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java ## @@ -1099,6 +1099,20 @@ private

[jira] [Updated] (HADOOP-18021) Provide a public wrapper of Configuration#substituteVars

2021-11-23 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18021: Component/s: conf > Provide a public wrapper of Configuration#substituteVars >

[jira] [Moved] (HADOOP-18021) Provide a public wrapper of Configuration#substituteVars

2021-11-23 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran moved YARN-11013 to HADOOP-18021: Key: HADOOP-18021 (was: YARN-11013) Project: Hadoop

[jira] [Comment Edited] (HADOOP-17996) UserGroupInformation#unprotectedRelogin sets the last login time before logging in

2021-11-23 Thread Surendra Singh Lilhore (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447931#comment-17447931 ] Surendra Singh Lilhore edited comment on HADOOP-17996 at 11/23/21, 11:18 AM:

[jira] [Commented] (HADOOP-17996) UserGroupInformation#unprotectedRelogin sets the last login time before logging in

2021-11-23 Thread Surendra Singh Lilhore (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447931#comment-17447931 ] Surendra Singh Lilhore commented on HADOOP-17996: - [~Sushma_28] , last login time is

[GitHub] [hadoop] virajjasani commented on pull request #3711: HDFS-16350. Datanode start time should be set after RPC server starts successfully

2021-11-23 Thread GitBox
virajjasani commented on pull request #3711: URL: https://github.com/apache/hadoop/pull/3711#issuecomment-976414780 @tomscut @goiri could you please take a look? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

  1   2   >