[jira] [Commented] (HADOOP-18429) MutableGaugeFloat#incr(float) get stuck in an infinite loop

2022-09-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17603887#comment-17603887 ] ASF GitHub Bot commented on HADOOP-18429: - huxinqiu closed pull request #4823: HADOOP-18429.

[jira] [Commented] (HADOOP-18429) MutableGaugeFloat#incr(float) get stuck in an infinite loop

2022-09-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17603888#comment-17603888 ] ASF GitHub Bot commented on HADOOP-18429: - huxinqiu opened a new pull request, #4823: URL:

[GitHub] [hadoop] huxinqiu closed pull request #4823: HADOOP-18429. fix infinite loop in MutableGaugeFloat#incr(float)

2022-09-13 Thread GitBox
huxinqiu closed pull request #4823: HADOOP-18429. fix infinite loop in MutableGaugeFloat#incr(float) URL: https://github.com/apache/hadoop/pull/4823 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (HADOOP-16769) LocalDirAllocator to provide diagnostics when file creation fails

2022-09-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17603879#comment-17603879 ] ASF GitHub Bot commented on HADOOP-16769: - ashutoshcipher commented on PR #4842: URL:

[GitHub] [hadoop] ashutoshcipher commented on pull request #4842: HADOOP-16769. LocalDirAllocator to provide diagnostics when file creation fails

2022-09-13 Thread GitBox
ashutoshcipher commented on PR #4842: URL: https://github.com/apache/hadoop/pull/4842#issuecomment-1246222534 @mehakmeet - I have the addressed the minor change suggested by @steveloughran. Please help in finishing the review/merge -- This is an automated message from the Apache Git

[jira] [Commented] (HADOOP-16769) LocalDirAllocator to provide diagnostics when file creation fails

2022-09-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17603878#comment-17603878 ] ASF GitHub Bot commented on HADOOP-16769: - ashutoshcipher commented on PR #4842: URL:

[GitHub] [hadoop] ashutoshcipher commented on pull request #4842: HADOOP-16769. LocalDirAllocator to provide diagnostics when file creation fails

2022-09-13 Thread GitBox
ashutoshcipher commented on PR #4842: URL: https://github.com/apache/hadoop/pull/4842#issuecomment-1246221454 Below UT failure is not relevant to this PR, its being tracked in different JIRA - HADOOP-18452 ``` hadoop.crypto.key.kms.server.TestKMS ``` -- This is an automated

[jira] [Commented] (HADOOP-16769) LocalDirAllocator to provide diagnostics when file creation fails

2022-09-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17603877#comment-17603877 ] ASF GitHub Bot commented on HADOOP-16769: - hadoop-yetus commented on PR #4842: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4842: HADOOP-16769. LocalDirAllocator to provide diagnostics when file creation fails

2022-09-13 Thread GitBox
hadoop-yetus commented on PR #4842: URL: https://github.com/apache/hadoop/pull/4842#issuecomment-1246219173 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4886: HDFS-16766. XML External Entity (XXE) attacks can occur while processing XML received from an untrusted source

2022-09-13 Thread GitBox
hadoop-yetus commented on PR #4886: URL: https://github.com/apache/hadoop/pull/4886#issuecomment-1246217573 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4846: YARN-11290. Improve Query Condition of FederationStateStore#getApplicationsHomeSubCluster.

2022-09-13 Thread GitBox
hadoop-yetus commented on PR #4846: URL: https://github.com/apache/hadoop/pull/4846#issuecomment-1246173571 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18452) Fix TestKMS#testKMSHAZooKeeperDelegationToken Failed By Hadoop-18427

2022-09-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17603851#comment-17603851 ] ASF GitHub Bot commented on HADOOP-18452: - hadoop-yetus commented on PR #4885: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4885: HADOOP-18452. Fix TestKMS#testKMSHAZooKeeperDelegationToken Failed By Hadoop-18427.

2022-09-13 Thread GitBox
hadoop-yetus commented on PR #4885: URL: https://github.com/apache/hadoop/pull/4885#issuecomment-1246156709 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] ashutoshcipher opened a new pull request, #4886: HDFS-16766. XML External Entity (XXE) attacks can occur while processing XML received from an untrusted source

2022-09-13 Thread GitBox
ashutoshcipher opened a new pull request, #4886: URL: https://github.com/apache/hadoop/pull/4886 ### Description of PR XML External Entity (XXE) attacks can occur while processing XML received from an untrusted source. Solution - Change done in this PR disables DTDs regardless

[jira] [Commented] (HADOOP-18444) Add Support for localized trash for ViewFileSystem in Trash.moveToAppropriateTrash

2022-09-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17603846#comment-17603846 ] ASF GitHub Bot commented on HADOOP-18444: - xinglin commented on code in PR #4869: URL:

[GitHub] [hadoop] xinglin commented on a diff in pull request #4869: HADOOP-18444 Add Support for localized trash for ViewFileSystem in Trash.moveToAppropriateTrash

2022-09-13 Thread GitBox
xinglin commented on code in PR #4869: URL: https://github.com/apache/hadoop/pull/4869#discussion_r970195382 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Trash.java: ## @@ -94,6 +96,34 @@ public static boolean moveToAppropriateTrash(FileSystem fs,

[jira] [Commented] (HADOOP-18443) Upgrade snakeyaml to 1.31 to mitigate CVE-2022-25857

2022-09-13 Thread Ashutosh Gupta (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17603841#comment-17603841 ] Ashutosh Gupta commented on HADOOP-18443: - [~brahmareddy] - I have opened the PR for 3.3 and

[GitHub] [hadoop] ashutoshcipher commented on pull request #4884: YARN-11255. Support loading alternative docker client config from system environment

2022-09-13 Thread GitBox
ashutoshcipher commented on PR #4884: URL: https://github.com/apache/hadoop/pull/4884#issuecomment-1246130128 UT Failure ``` hadoop.yarn.server.nodemanager.containermanager.logaggregation.TestLogAggregationService ``` is not relevant to this change. Tried running it in local and

[jira] [Commented] (HADOOP-18186) s3a prefetching to use SemaphoredDelegatingExecutor for submitting work

2022-09-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17603837#comment-17603837 ] ASF GitHub Bot commented on HADOOP-18186: - hadoop-yetus commented on PR #4879: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4879: HADOOP-18186. s3a prefetching to use SemaphoredDelegatingExecutor for submitting work (ADDENDUM)

2022-09-13 Thread GitBox
hadoop-yetus commented on PR #4879: URL: https://github.com/apache/hadoop/pull/4879#issuecomment-1246123370 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18444) Add Support for localized trash for ViewFileSystem in Trash.moveToAppropriateTrash

2022-09-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17603823#comment-17603823 ] ASF GitHub Bot commented on HADOOP-18444: - xinglin commented on code in PR #4869: URL:

[GitHub] [hadoop] xinglin commented on a diff in pull request #4869: HADOOP-18444 Add Support for localized trash for ViewFileSystem in Trash.moveToAppropriateTrash

2022-09-13 Thread GitBox
xinglin commented on code in PR #4869: URL: https://github.com/apache/hadoop/pull/4869#discussion_r970195382 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Trash.java: ## @@ -94,6 +96,34 @@ public static boolean moveToAppropriateTrash(FileSystem fs,

[jira] [Commented] (HADOOP-18444) Add Support for localized trash for ViewFileSystem in Trash.moveToAppropriateTrash

2022-09-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17603821#comment-17603821 ] ASF GitHub Bot commented on HADOOP-18444: - omalley commented on code in PR #4869: URL:

[GitHub] [hadoop] omalley commented on a diff in pull request #4869: HADOOP-18444 Add Support for localized trash for ViewFileSystem in Trash.moveToAppropriateTrash

2022-09-13 Thread GitBox
omalley commented on code in PR #4869: URL: https://github.com/apache/hadoop/pull/4869#discussion_r970145340 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Trash.java: ## @@ -94,6 +96,34 @@ public static boolean moveToAppropriateTrash(FileSystem fs,

[jira] [Updated] (HADOOP-18452) Fix TestKMS#testKMSHAZooKeeperDelegationToken Failed By Hadoop-18427

2022-09-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18452: Labels: pull-request-available (was: ) > Fix TestKMS#testKMSHAZooKeeperDelegationToken

[jira] [Created] (HADOOP-18452) Fix TestKMS#testKMSHAZooKeeperDelegationToken Failed By Hadoop-18427

2022-09-13 Thread fanshilun (Jira)
fanshilun created HADOOP-18452: -- Summary: Fix TestKMS#testKMSHAZooKeeperDelegationToken Failed By Hadoop-18427 Key: HADOOP-18452 URL: https://issues.apache.org/jira/browse/HADOOP-18452 Project: Hadoop

[jira] [Commented] (HADOOP-18452) Fix TestKMS#testKMSHAZooKeeperDelegationToken Failed By Hadoop-18427

2022-09-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17603808#comment-17603808 ] ASF GitHub Bot commented on HADOOP-18452: - slfan1989 opened a new pull request, #4885: URL:

[GitHub] [hadoop] slfan1989 opened a new pull request, #4885: HADOOP-18452. Fix TestKMS#testKMSHAZooKeeperDelegationToken Failed By Hadoop-18427.

2022-09-13 Thread GitBox
slfan1989 opened a new pull request, #4885: URL: https://github.com/apache/hadoop/pull/4885 JIRA: HADOOP-18452. Fix TestKMS#testKMSHAZooKeeperDelegationToken Failed By Hadoop-18427. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hadoop] simbadzina commented on a diff in pull request #4127: HDFS-16767. RBF: Support observer node from Router-Based Federation

2022-09-13 Thread GitBox
simbadzina commented on code in PR #4127: URL: https://github.com/apache/hadoop/pull/4127#discussion_r970138227 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/resolver/MembershipNamenodeResolver.java: ## @@ -371,24 +405,37 @@

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4846: YARN-11290. Improve Query Condition of FederationStateStore#getApplicationsHomeSubCluster.

2022-09-13 Thread GitBox
slfan1989 commented on code in PR #4846: URL: https://github.com/apache/hadoop/pull/4846#discussion_r970137569 ## hadoop-yarn-project/hadoop-yarn/bin/FederationStateStore/SQLServer/FederationStateStoreStoreProcs.sql: ## @@ -111,12 +111,37 @@ IF OBJECT_ID (

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4846: YARN-11290. Improve Query Condition of FederationStateStore#getApplicationsHomeSubCluster.

2022-09-13 Thread GitBox
slfan1989 commented on code in PR #4846: URL: https://github.com/apache/hadoop/pull/4846#discussion_r970137060 ## hadoop-yarn-project/hadoop-yarn/bin/FederationStateStore/MySQL/FederationStateStoreStoredProcs.sql: ## @@ -122,10 +122,21 @@ BEGIN WHERE applicationId =

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4846: YARN-11290. Improve Query Condition of FederationStateStore#getApplicationsHomeSubCluster.

2022-09-13 Thread GitBox
slfan1989 commented on code in PR #4846: URL: https://github.com/apache/hadoop/pull/4846#discussion_r970137060 ## hadoop-yarn-project/hadoop-yarn/bin/FederationStateStore/MySQL/FederationStateStoreStoredProcs.sql: ## @@ -122,10 +122,21 @@ BEGIN WHERE applicationId =

[jira] [Commented] (HADOOP-18451) Update hsqldb.version from 2.3.4 to 2.5.2

2022-09-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17603797#comment-17603797 ] ASF GitHub Bot commented on HADOOP-18451: - slfan1989 commented on PR #4880: URL:

[GitHub] [hadoop] slfan1989 commented on pull request #4880: HADOOP-18451. Update hsqldb.version from 2.3.4 to 2.5.2.

2022-09-13 Thread GitBox
slfan1989 commented on PR #4880: URL: https://github.com/apache/hadoop/pull/4880#issuecomment-1246014091 > I am not aware of any such issue which can bother us, went through the release notes and all, everything looks sorted. Though there is one regression:

[GitHub] [hadoop] simbadzina commented on a diff in pull request #4127: HDFS-16767. RBF: Support observer node from Router-Based Federation

2022-09-13 Thread GitBox
simbadzina commented on code in PR #4127: URL: https://github.com/apache/hadoop/pull/4127#discussion_r970129597 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/resolver/MembershipNamenodeResolver.java: ## @@ -73,8 +74,13 @@ /**

[GitHub] [hadoop] goiri commented on a diff in pull request #4846: YARN-11290. Improve Query Condition of FederationStateStore#getApplicationsHomeSubCluster.

2022-09-13 Thread GitBox
goiri commented on code in PR #4846: URL: https://github.com/apache/hadoop/pull/4846#discussion_r970127749 ## hadoop-yarn-project/hadoop-yarn/bin/FederationStateStore/MySQL/FederationStateStoreStoredProcs.sql: ## @@ -122,10 +122,21 @@ BEGIN WHERE applicationId =

[GitHub] [hadoop] hadoop-yetus commented on pull request #4884: YARN-11255. Support loading alternative docker client config from system environment

2022-09-13 Thread GitBox
hadoop-yetus commented on PR #4884: URL: https://github.com/apache/hadoop/pull/4884#issuecomment-1246002577 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18186) s3a prefetching to use SemaphoredDelegatingExecutor for submitting work

2022-09-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17603790#comment-17603790 ] ASF GitHub Bot commented on HADOOP-18186: - virajjasani commented on PR #4879: URL:

[GitHub] [hadoop] virajjasani commented on pull request #4879: HADOOP-18186. s3a prefetching to use SemaphoredDelegatingExecutor for submitting work (ADDENDUM)

2022-09-13 Thread GitBox
virajjasani commented on PR #4879: URL: https://github.com/apache/hadoop/pull/4879#issuecomment-1245996648 @mukund-thakur could you please also review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hadoop] simbadzina commented on a diff in pull request #4127: HDFS-16767. RBF: Support observer node from Router-Based Federation

2022-09-13 Thread GitBox
simbadzina commented on code in PR #4127: URL: https://github.com/apache/hadoop/pull/4127#discussion_r970105963 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java: ## @@ -478,8 +498,13 @@ public Object

[GitHub] [hadoop] simbadzina commented on a diff in pull request #4127: HDFS-16767. RBF: Support observer node from Router-Based Federation

2022-09-13 Thread GitBox
simbadzina commented on code in PR #4127: URL: https://github.com/apache/hadoop/pull/4127#discussion_r970105963 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java: ## @@ -478,8 +498,13 @@ public Object

[GitHub] [hadoop] simbadzina commented on a diff in pull request #4127: HDFS-16767. RBF: Support observer node from Router-Based Federation

2022-09-13 Thread GitBox
simbadzina commented on code in PR #4127: URL: https://github.com/apache/hadoop/pull/4127#discussion_r970099027 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java: ## @@ -200,6 +207,17 @@ public

[jira] [Commented] (HADOOP-18427) Improve ZKDelegationTokenSecretManager#startThead With recommended methods.

2022-09-13 Thread Jira
[ https://issues.apache.org/jira/browse/HADOOP-18427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17603761#comment-17603761 ] Íñigo Goiri commented on HADOOP-18427: -- [~slfan1989], [~ayushsaxena] mentioned that TestKMS fails

[GitHub] [hadoop] hadoop-yetus commented on pull request #4883: HDFS-13522: Add federated nameservices states to client protocol and propagate it between routers and clients.

2022-09-13 Thread GitBox
hadoop-yetus commented on PR #4883: URL: https://github.com/apache/hadoop/pull/4883#issuecomment-1245932904 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] simbadzina commented on a diff in pull request #4127: HDFS-16767. RBF: Support observer node from Router-Based Federation

2022-09-13 Thread GitBox
simbadzina commented on code in PR #4127: URL: https://github.com/apache/hadoop/pull/4127#discussion_r970059259 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RBFConfigKeys.java: ## @@ -191,6 +191,10 @@ public class

[GitHub] [hadoop] simbadzina commented on a diff in pull request #4127: HDFS-16767. RBF: Support observer node from Router-Based Federation

2022-09-13 Thread GitBox
simbadzina commented on code in PR #4127: URL: https://github.com/apache/hadoop/pull/4127#discussion_r970055917 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java: ## @@ -462,7 +481,8 @@ private

[GitHub] [hadoop] hadoop-yetus commented on pull request #4884: YARN-11255. Support loading alternative docker client config from system environment

2022-09-13 Thread GitBox
hadoop-yetus commented on PR #4884: URL: https://github.com/apache/hadoop/pull/4884#issuecomment-1245874549 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4852: YARN-11293. [Federation] StoreNewMasterKey/removeStoredMasterKey With MemoryStateStore.

2022-09-13 Thread GitBox
slfan1989 commented on code in PR #4852: URL: https://github.com/apache/hadoop/pull/4852#discussion_r970015840 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/impl/SQLFederationStateStore.java:

[GitHub] [hadoop] slfan1989 commented on pull request #4846: YARN-11290. Improve Query Condition of FederationStateStore#getApplicationsHomeSubCluster.

2022-09-13 Thread GitBox
slfan1989 commented on PR #4846: URL: https://github.com/apache/hadoop/pull/4846#issuecomment-1245869268 @goiri Please help to review the code again, thank you very much! I have provided a test report, we can refer to the following link

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4846: YARN-11290. Improve Query Condition of FederationStateStore#getApplicationsHomeSubCluster.

2022-09-13 Thread GitBox
slfan1989 commented on code in PR #4846: URL: https://github.com/apache/hadoop/pull/4846#discussion_r970008365 ## hadoop-yarn-project/hadoop-yarn/bin/FederationStateStore/MySQL/FederationStateStoreStoredProcs.sql: ## @@ -122,10 +122,26 @@ BEGIN WHERE applicationId =

[jira] [Commented] (HADOOP-18443) Upgrade snakeyaml to 1.31 to mitigate CVE-2022-25857

2022-09-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17603735#comment-17603735 ] ASF GitHub Bot commented on HADOOP-18443: - ashutoshcipher commented on PR #4873: URL:

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4846: YARN-11290. Improve Query Condition of FederationStateStore#getApplicationsHomeSubCluster.

2022-09-13 Thread GitBox
slfan1989 commented on code in PR #4846: URL: https://github.com/apache/hadoop/pull/4846#discussion_r97124 ##

[GitHub] [hadoop] ashutoshcipher commented on pull request #4873: HADOOP-18443. Upgrade snakeyaml to 1.31 to mitigate CVE-2022-25857

2022-09-13 Thread GitBox
ashutoshcipher commented on PR #4873: URL: https://github.com/apache/hadoop/pull/4873#issuecomment-1245853957 UT Failures in 2nd last build are unrelated to this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4846: YARN-11290. Improve Query Condition of FederationStateStore#getApplicationsHomeSubCluster.

2022-09-13 Thread GitBox
slfan1989 commented on code in PR #4846: URL: https://github.com/apache/hadoop/pull/4846#discussion_r96747 ##

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4846: YARN-11290. Improve Query Condition of FederationStateStore#getApplicationsHomeSubCluster.

2022-09-13 Thread GitBox
slfan1989 commented on code in PR #4846: URL: https://github.com/apache/hadoop/pull/4846#discussion_r969998465 ## hadoop-yarn-project/hadoop-yarn/bin/FederationStateStore/MySQL/FederationStateStoreStoredProcs.sql: ## @@ -122,10 +122,26 @@ BEGIN WHERE applicationId =

[GitHub] [hadoop] hadoop-yetus commented on pull request #4858: YARN-11296. [Federation] Fix SQLFederationStateStore#Sql script bug.

2022-09-13 Thread GitBox
hadoop-yetus commented on PR #4858: URL: https://github.com/apache/hadoop/pull/4858#issuecomment-1245851811 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4846: YARN-11290. Improve Query Condition of FederationStateStore#getApplicationsHomeSubCluster.

2022-09-13 Thread GitBox
slfan1989 commented on code in PR #4846: URL: https://github.com/apache/hadoop/pull/4846#discussion_r969997820 ## hadoop-yarn-project/hadoop-yarn/bin/FederationStateStore/SQLServer/FederationStateStoreStoreProcs.sql: ## @@ -111,12 +111,27 @@ IF OBJECT_ID (

[GitHub] [hadoop] hadoop-yetus commented on pull request #4882: HDFS-16771. JN should tersely print logs about NewerTxnIdException

2022-09-13 Thread GitBox
hadoop-yetus commented on PR #4882: URL: https://github.com/apache/hadoop/pull/4882#issuecomment-1245842539 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] omalley commented on a diff in pull request #4127: HDFS-16767. RBF: Support observer node from Router-Based Federation

2022-09-13 Thread GitBox
omalley commented on code in PR #4127: URL: https://github.com/apache/hadoop/pull/4127#discussion_r969970980 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcServer.java: ## @@ -337,18 +337,17 @@ public

[jira] [Commented] (HADOOP-18451) Update hsqldb.version from 2.3.4 to 2.5.2

2022-09-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17603714#comment-17603714 ] ASF GitHub Bot commented on HADOOP-18451: - hadoop-yetus commented on PR #4880: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4880: HADOOP-18451. Update hsqldb.version from 2.3.4 to 2.5.2.

2022-09-13 Thread GitBox
hadoop-yetus commented on PR #4880: URL: https://github.com/apache/hadoop/pull/4880#issuecomment-1245812610 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] simbadzina commented on a diff in pull request #4127: HDFS-16767. RBF: Support observer node from Router-Based Federation

2022-09-13 Thread GitBox
simbadzina commented on code in PR #4127: URL: https://github.com/apache/hadoop/pull/4127#discussion_r969960292 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcServer.java: ## @@ -337,18 +337,17 @@ public

[GitHub] [hadoop] omalley commented on a diff in pull request #4127: HDFS-16767. RBF: Support observer node from Router-Based Federation

2022-09-13 Thread GitBox
omalley commented on code in PR #4127: URL: https://github.com/apache/hadoop/pull/4127#discussion_r969956527 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java: ## @@ -478,8 +498,13 @@ public Object

[GitHub] [hadoop] omalley commented on a diff in pull request #4127: HDFS-16767. RBF: Support observer node from Router-Based Federation

2022-09-13 Thread GitBox
omalley commented on code in PR #4127: URL: https://github.com/apache/hadoop/pull/4127#discussion_r969937548 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java: ## @@ -200,6 +207,17 @@ public

[jira] [Commented] (HADOOP-18443) Upgrade snakeyaml to 1.31 to mitigate CVE-2022-25857

2022-09-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17603698#comment-17603698 ] ASF GitHub Bot commented on HADOOP-18443: - hadoop-yetus commented on PR #4873: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4873: HADOOP-18443. Upgrade snakeyaml to 1.31 to mitigate CVE-2022-25857

2022-09-13 Thread GitBox
hadoop-yetus commented on PR #4873: URL: https://github.com/apache/hadoop/pull/4873#issuecomment-1245762698 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] sunchao merged pull request #4794: HDFS-16686. GetJournalEditServlet fails to authorize valid Kerberos request (#4724)

2022-09-13 Thread GitBox
sunchao merged PR #4794: URL: https://github.com/apache/hadoop/pull/4794 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] ashutoshcipher opened a new pull request, #4884: YARN-11255. Support loading alternative docker client config from system environment

2022-09-13 Thread GitBox
ashutoshcipher opened a new pull request, #4884: URL: https://github.com/apache/hadoop/pull/4884 ### Description of PR Support loading alternative docker client config from system environment When using YARN docker support, although the hadoop shell supported

[GitHub] [hadoop] hadoop-yetus commented on pull request #4127: HDFS-16767. RBF: Support observer node from Router-Based Federation

2022-09-13 Thread GitBox
hadoop-yetus commented on PR #4127: URL: https://github.com/apache/hadoop/pull/4127#issuecomment-1245695271 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] simbadzina opened a new pull request, #4883: HDFS-13522: Add federated nameservices states to client protocol and propagate it between routers and clients.

2022-09-13 Thread GitBox
simbadzina opened a new pull request, #4883: URL: https://github.com/apache/hadoop/pull/4883 ### Description of PR Backporting HDFS-13522 to branch-3.3 Required cherry-picking for several other commits to make for a cleaner cherry-pick. ### How was this patch tested?

[jira] [Commented] (HADOOP-18451) Update hsqldb.version from 2.3.4 to 2.5.2

2022-09-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17603655#comment-17603655 ] ASF GitHub Bot commented on HADOOP-18451: - goiri commented on PR #4880: URL:

[GitHub] [hadoop] goiri merged pull request #4881: HDFS-16770. [Documentation] RBF: Duplicate statement to be removed for better readability.

2022-09-13 Thread GitBox
goiri merged PR #4881: URL: https://github.com/apache/hadoop/pull/4881 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] goiri commented on pull request #4880: HADOOP-18451. Update hsqldb.version from 2.3.4 to 2.5.2.

2022-09-13 Thread GitBox
goiri commented on PR #4880: URL: https://github.com/apache/hadoop/pull/4880#issuecomment-1245650322 @ayushtkn do you see any issue with this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hadoop] hadoop-yetus commented on pull request #4127: HDFS-16767. RBF: Support observer node from Router-Based Federation

2022-09-13 Thread GitBox
hadoop-yetus commented on PR #4127: URL: https://github.com/apache/hadoop/pull/4127#issuecomment-1245577338 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18446) Add a re-queue metric to RpcMetrics.java to quantify the number of re-queue RPCs

2022-09-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17603617#comment-17603617 ] ASF GitHub Bot commented on HADOOP-18446: - hadoop-yetus commented on PR #4871: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4871: HADOOP-18446. Add a re-queue metric to RpcMetrics.java to quantify the number of re-queue RPCs

2022-09-13 Thread GitBox
hadoop-yetus commented on PR #4871: URL: https://github.com/apache/hadoop/pull/4871#issuecomment-1245543824 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] ashutoshcipher commented on pull request #4248: MAPREDUCE-7370. Parallelize MultipleOutputs#close call

2022-09-13 Thread GitBox
ashutoshcipher commented on PR #4248: URL: https://github.com/apache/hadoop/pull/4248#issuecomment-1245505808 @cnauroth - Please help in reviewing the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hadoop] prasad-acit commented on pull request #4881: HDFS-16770. [Documentation] RBF: Duplicate statement to be removed for better readability.

2022-09-13 Thread GitBox
prasad-acit commented on PR #4881: URL: https://github.com/apache/hadoop/pull/4881#issuecomment-1245500124 @ayushtkn can you please help to review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (HADOOP-18449) Upgrade hadolint to 2.10.0

2022-09-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17603594#comment-17603594 ] ASF GitHub Bot commented on HADOOP-18449: - hadoop-yetus commented on PR #4876: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4876: HADOOP-18449. Upgrade hadolint to 2.10.0

2022-09-13 Thread GitBox
hadoop-yetus commented on PR #4876: URL: https://github.com/apache/hadoop/pull/4876#issuecomment-1245477101 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at

[GitHub] [hadoop] hadoop-yetus commented on pull request #4846: YARN-11290. Improve Query Condition of FederationStateStore#getApplicationsHomeSubCluster.

2022-09-13 Thread GitBox
hadoop-yetus commented on PR #4846: URL: https://github.com/apache/hadoop/pull/4846#issuecomment-1245417267 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] ZanderXu commented on pull request #4560: HDFS-16659. JournalNode should throw NewerTxnIdException when SinceTxId is bigger than HighestWrittenTxId

2022-09-13 Thread GitBox
ZanderXu commented on PR #4560: URL: https://github.com/apache/hadoop/pull/4560#issuecomment-1245257209 @xkrogen Sir, I create a new ticket HDFS-16771 to resolve this problems. If you have any good ideas, please share with me. Thanks. -- This is an automated message from the Apache Git

[GitHub] [hadoop] ZanderXu opened a new pull request, #4882: HDFS-16771. JN should tersely print logs about NewerTxnIdException

2022-09-13 Thread GitBox
ZanderXu opened a new pull request, #4882: URL: https://github.com/apache/hadoop/pull/4882 JournalNode should tersely print some logs about NewerTxnIdException. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop] ZanderXu commented on pull request #4560: HDFS-16659. JournalNode should throw NewerTxnIdException when SinceTxId is bigger than HighestWrittenTxId

2022-09-13 Thread GitBox
ZanderXu commented on PR #4560: URL: https://github.com/apache/hadoop/pull/4560#issuecomment-1245232780 @xkrogen After deep thinking and do some verifications, I found there are two places should be fixed for the case that `sinceTxId = highestTxId + 1`. Currently Journal throws one

[GitHub] [hadoop] tasanuma commented on pull request #4567: HDFS-16663. Allow block reconstruction pending timeout refreshable to increase decommission performance

2022-09-13 Thread GitBox
tasanuma commented on PR #4567: URL: https://github.com/apache/hadoop/pull/4567#issuecomment-1245153841 I forgot to add the ticket number to the commit message. Sorry. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [hadoop] hadoop-yetus commented on pull request #4858: YARN-11296. [Federation] Fix SQLFederationStateStore#Sql script bug.

2022-09-13 Thread GitBox
hadoop-yetus commented on PR #4858: URL: https://github.com/apache/hadoop/pull/4858#issuecomment-1245137721 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] aajisaka merged pull request #4878: YARN-11301. Fix NoClassDefFoundError after YARN-11269(#4771).

2022-09-13 Thread GitBox
aajisaka merged PR #4878: URL: https://github.com/apache/hadoop/pull/4878 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] aajisaka merged pull request #4777: YARN-11261. Upgrade JUnit from 4 to 5 in hadoop-yarn-server-web-proxy

2022-09-13 Thread GitBox
aajisaka merged PR #4777: URL: https://github.com/apache/hadoop/pull/4777 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4127: HDFS-16767. RBF: Support observer node from Router-Based Federation

2022-09-13 Thread GitBox
hadoop-yetus commented on PR #4127: URL: https://github.com/apache/hadoop/pull/4127#issuecomment-1245019461 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4881: HDFS-16770. [Documentation] RBF: Duplicate statement to be removed for better readability.

2022-09-13 Thread GitBox
hadoop-yetus commented on PR #4881: URL: https://github.com/apache/hadoop/pull/4881#issuecomment-1244988557 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18242) ABFS Rename Failure when tracking metadata is in incomplete state

2022-09-13 Thread Surendra Singh Lilhore (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17603393#comment-17603393 ] Surendra Singh Lilhore commented on HADOOP-18242: - Can we close this? , PR's are