[jira] [Updated] (HADOOP-18601) Fix build failure with docs profile

2023-01-29 Thread Masatake Iwasaki (Jira)


 [ 
https://issues.apache.org/jira/browse/HADOOP-18601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Masatake Iwasaki updated HADOOP-18601:
--
Status: Patch Available  (was: Open)

> Fix build failure with docs profile
> ---
>
> Key: HADOOP-18601
> URL: https://issues.apache.org/jira/browse/HADOOP-18601
> Project: Hadoop Common
>  Issue Type: Bug
>Reporter: Masatake Iwasaki
>Assignee: Masatake Iwasaki
>Priority: Major
>  Labels: pull-request-available
>
> Build with docs profile failed due to depcheck error.
> {noformat}
> $ mvn clean install -DskipTests -DskipShade -Pdocs
> ...
> [INFO] --- maven-enforcer-plugin:3.0.0:enforce (depcheck) @ hadoop-hdfs ---
> [WARNING]
> Dependency convergence error for xerces:xercesImpl:jar:2.12.2:provided paths 
> to dependency are:
> +-org.apache.hadoop:hadoop-hdfs:jar:3.4.0-SNAPSHOT
>   +-org.apache.hadoop:hadoop-common:jar:3.4.0-SNAPSHOT:provided
> +-xerces:xercesImpl:jar:2.12.2:provided
> and
> +-org.apache.hadoop:hadoop-hdfs:jar:3.4.0-SNAPSHOT
>   +-org.apache.hadoop:hadoop-common:test-jar:tests:3.4.0-SNAPSHOT:test
> +-xerces:xercesImpl:jar:2.12.2:test
> and
> +-org.apache.hadoop:hadoop-hdfs:jar:3.4.0-SNAPSHOT
>   +-org.apache.hadoop:hadoop-hdfs-client:jar:3.4.0-SNAPSHOT:provided
> +-xerces:xercesImpl:jar:2.12.2:provided
> and
> +-org.apache.hadoop:hadoop-hdfs:jar:3.4.0-SNAPSHOT
>   +-com.google.code.findbugs:findbugs:jar:3.0.1:provided
> +-jaxen:jaxen:jar:1.1.6:provided
>   +-xerces:xercesImpl:jar:2.6.2:provided
> and
> +-org.apache.hadoop:hadoop-hdfs:jar:3.4.0-SNAPSHOT
>   +-xerces:xercesImpl:jar:2.12.2:compile
> [WARNING] Rule 0: org.apache.maven.plugins.enforcer.DependencyConvergence 
> failed with message:
> Failed while enforcing releasability. See above detailed error message.
> [INFO] 
> 
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Updated] (HADOOP-18601) Fix build failure with docs profile

2023-01-29 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HADOOP-18601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated HADOOP-18601:

Labels: pull-request-available  (was: )

> Fix build failure with docs profile
> ---
>
> Key: HADOOP-18601
> URL: https://issues.apache.org/jira/browse/HADOOP-18601
> Project: Hadoop Common
>  Issue Type: Bug
>Reporter: Masatake Iwasaki
>Assignee: Masatake Iwasaki
>Priority: Major
>  Labels: pull-request-available
>
> Build with docs profile failed due to depcheck error.
> {noformat}
> $ mvn clean install -DskipTests -DskipShade -Pdocs
> ...
> [INFO] --- maven-enforcer-plugin:3.0.0:enforce (depcheck) @ hadoop-hdfs ---
> [WARNING]
> Dependency convergence error for xerces:xercesImpl:jar:2.12.2:provided paths 
> to dependency are:
> +-org.apache.hadoop:hadoop-hdfs:jar:3.4.0-SNAPSHOT
>   +-org.apache.hadoop:hadoop-common:jar:3.4.0-SNAPSHOT:provided
> +-xerces:xercesImpl:jar:2.12.2:provided
> and
> +-org.apache.hadoop:hadoop-hdfs:jar:3.4.0-SNAPSHOT
>   +-org.apache.hadoop:hadoop-common:test-jar:tests:3.4.0-SNAPSHOT:test
> +-xerces:xercesImpl:jar:2.12.2:test
> and
> +-org.apache.hadoop:hadoop-hdfs:jar:3.4.0-SNAPSHOT
>   +-org.apache.hadoop:hadoop-hdfs-client:jar:3.4.0-SNAPSHOT:provided
> +-xerces:xercesImpl:jar:2.12.2:provided
> and
> +-org.apache.hadoop:hadoop-hdfs:jar:3.4.0-SNAPSHOT
>   +-com.google.code.findbugs:findbugs:jar:3.0.1:provided
> +-jaxen:jaxen:jar:1.1.6:provided
>   +-xerces:xercesImpl:jar:2.6.2:provided
> and
> +-org.apache.hadoop:hadoop-hdfs:jar:3.4.0-SNAPSHOT
>   +-xerces:xercesImpl:jar:2.12.2:compile
> [WARNING] Rule 0: org.apache.maven.plugins.enforcer.DependencyConvergence 
> failed with message:
> Failed while enforcing releasability. See above detailed error message.
> [INFO] 
> 
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Commented] (HADOOP-18601) Fix build failure with docs profile

2023-01-29 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/HADOOP-18601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17681913#comment-17681913
 ] 

ASF GitHub Bot commented on HADOOP-18601:
-

iwasakims opened a new pull request, #5331:
URL: https://github.com/apache/hadoop/pull/5331

   https://issues.apache.org/jira/browse/HADOOP-18601
   
   build with `-Pdocs` fails due to dependency conversion errors.
   
   ```
   [WARNING]
   Dependency convergence error for xerces:xercesImpl:jar:2.12.2:provided paths 
to dependency are:
   +-org.apache.hadoop:hadoop-hdfs:jar:3.4.0-SNAPSHOT
 +-org.apache.hadoop:hadoop-common:jar:3.4.0-SNAPSHOT:provided
   +-xerces:xercesImpl:jar:2.12.2:provided
   and
   +-org.apache.hadoop:hadoop-hdfs:jar:3.4.0-SNAPSHOT
 +-org.apache.hadoop:hadoop-common:test-jar:tests:3.4.0-SNAPSHOT:test
   +-xerces:xercesImpl:jar:2.12.2:test
   and
   +-org.apache.hadoop:hadoop-hdfs:jar:3.4.0-SNAPSHOT
 +-org.apache.hadoop:hadoop-hdfs-client:jar:3.4.0-SNAPSHOT:provided
   +-xerces:xercesImpl:jar:2.12.2:provided
   and
   +-org.apache.hadoop:hadoop-hdfs:jar:3.4.0-SNAPSHOT
 +-com.google.code.findbugs:findbugs:jar:3.0.1:provided
   +-jaxen:jaxen:jar:1.1.6:provided
 +-xerces:xercesImpl:jar:2.6.2:provided
   and
   +-org.apache.hadoop:hadoop-hdfs:jar:3.4.0-SNAPSHOT
 +-xerces:xercesImpl:jar:2.12.2:compile
   ```
   
   ```
   [WARNING]
   Dependency convergence error for xml-apis:xml-apis:jar:1.0.b2:provided paths 
to dependency are:
   
+-org.apache.hadoop:hadoop-yarn-server-timelineservice-documentstore:jar:3.4.0-SNAPSHOT
 +-com.microsoft.azure:azure-cosmosdb:jar:2.4.5:compile
   +-com.microsoft.azure:azure-cosmosdb-commons:jar:2.4.5:compile
 +-commons-validator:commons-validator:jar:1.6:compile
   +-commons-digester:commons-digester:jar:1.8.1:compile
 +-xml-apis:xml-apis:jar:1.0.b2:provided
   and
   
+-org.apache.hadoop:hadoop-yarn-server-timelineservice-documentstore:jar:3.4.0-SNAPSHOT
 +-xerces:xercesImpl:jar:2.12.2:compile
   +-xml-apis:xml-apis:jar:1.4.01:compile
   ```




> Fix build failure with docs profile
> ---
>
> Key: HADOOP-18601
> URL: https://issues.apache.org/jira/browse/HADOOP-18601
> Project: Hadoop Common
>  Issue Type: Bug
>Reporter: Masatake Iwasaki
>Assignee: Masatake Iwasaki
>Priority: Major
>
> Build with docs profile failed due to depcheck error.
> {noformat}
> $ mvn clean install -DskipTests -DskipShade -Pdocs
> ...
> [INFO] --- maven-enforcer-plugin:3.0.0:enforce (depcheck) @ hadoop-hdfs ---
> [WARNING]
> Dependency convergence error for xerces:xercesImpl:jar:2.12.2:provided paths 
> to dependency are:
> +-org.apache.hadoop:hadoop-hdfs:jar:3.4.0-SNAPSHOT
>   +-org.apache.hadoop:hadoop-common:jar:3.4.0-SNAPSHOT:provided
> +-xerces:xercesImpl:jar:2.12.2:provided
> and
> +-org.apache.hadoop:hadoop-hdfs:jar:3.4.0-SNAPSHOT
>   +-org.apache.hadoop:hadoop-common:test-jar:tests:3.4.0-SNAPSHOT:test
> +-xerces:xercesImpl:jar:2.12.2:test
> and
> +-org.apache.hadoop:hadoop-hdfs:jar:3.4.0-SNAPSHOT
>   +-org.apache.hadoop:hadoop-hdfs-client:jar:3.4.0-SNAPSHOT:provided
> +-xerces:xercesImpl:jar:2.12.2:provided
> and
> +-org.apache.hadoop:hadoop-hdfs:jar:3.4.0-SNAPSHOT
>   +-com.google.code.findbugs:findbugs:jar:3.0.1:provided
> +-jaxen:jaxen:jar:1.1.6:provided
>   +-xerces:xercesImpl:jar:2.6.2:provided
> and
> +-org.apache.hadoop:hadoop-hdfs:jar:3.4.0-SNAPSHOT
>   +-xerces:xercesImpl:jar:2.12.2:compile
> [WARNING] Rule 0: org.apache.maven.plugins.enforcer.DependencyConvergence 
> failed with message:
> Failed while enforcing releasability. See above detailed error message.
> [INFO] 
> 
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[GitHub] [hadoop] iwasakims opened a new pull request, #5331: HADOOP-18601. Fix build failure with docs profile.

2023-01-29 Thread via GitHub


iwasakims opened a new pull request, #5331:
URL: https://github.com/apache/hadoop/pull/5331

   https://issues.apache.org/jira/browse/HADOOP-18601
   
   build with `-Pdocs` fails due to dependency conversion errors.
   
   ```
   [WARNING]
   Dependency convergence error for xerces:xercesImpl:jar:2.12.2:provided paths 
to dependency are:
   +-org.apache.hadoop:hadoop-hdfs:jar:3.4.0-SNAPSHOT
 +-org.apache.hadoop:hadoop-common:jar:3.4.0-SNAPSHOT:provided
   +-xerces:xercesImpl:jar:2.12.2:provided
   and
   +-org.apache.hadoop:hadoop-hdfs:jar:3.4.0-SNAPSHOT
 +-org.apache.hadoop:hadoop-common:test-jar:tests:3.4.0-SNAPSHOT:test
   +-xerces:xercesImpl:jar:2.12.2:test
   and
   +-org.apache.hadoop:hadoop-hdfs:jar:3.4.0-SNAPSHOT
 +-org.apache.hadoop:hadoop-hdfs-client:jar:3.4.0-SNAPSHOT:provided
   +-xerces:xercesImpl:jar:2.12.2:provided
   and
   +-org.apache.hadoop:hadoop-hdfs:jar:3.4.0-SNAPSHOT
 +-com.google.code.findbugs:findbugs:jar:3.0.1:provided
   +-jaxen:jaxen:jar:1.1.6:provided
 +-xerces:xercesImpl:jar:2.6.2:provided
   and
   +-org.apache.hadoop:hadoop-hdfs:jar:3.4.0-SNAPSHOT
 +-xerces:xercesImpl:jar:2.12.2:compile
   ```
   
   ```
   [WARNING]
   Dependency convergence error for xml-apis:xml-apis:jar:1.0.b2:provided paths 
to dependency are:
   
+-org.apache.hadoop:hadoop-yarn-server-timelineservice-documentstore:jar:3.4.0-SNAPSHOT
 +-com.microsoft.azure:azure-cosmosdb:jar:2.4.5:compile
   +-com.microsoft.azure:azure-cosmosdb-commons:jar:2.4.5:compile
 +-commons-validator:commons-validator:jar:1.6:compile
   +-commons-digester:commons-digester:jar:1.8.1:compile
 +-xml-apis:xml-apis:jar:1.0.b2:provided
   and
   
+-org.apache.hadoop:hadoop-yarn-server-timelineservice-documentstore:jar:3.4.0-SNAPSHOT
 +-xerces:xercesImpl:jar:2.12.2:compile
   +-xml-apis:xml-apis:jar:1.4.01:compile
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Commented] (HADOOP-18601) Fix build failure with docs profile

2023-01-29 Thread Masatake Iwasaki (Jira)


[ 
https://issues.apache.org/jira/browse/HADOOP-18601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17681899#comment-17681899
 ] 

Masatake Iwasaki commented on HADOOP-18601:
---

another error on hadoop-yarn-server-timelineservice-documentstore.
{noformat}
[WARNING]
Dependency convergence error for xml-apis:xml-apis:jar:1.0.b2:provided paths to 
dependency are:
+-org.apache.hadoop:hadoop-yarn-server-timelineservice-documentstore:jar:3.4.0-SNAPSHOT
  +-com.microsoft.azure:azure-cosmosdb:jar:2.4.5:compile
+-com.microsoft.azure:azure-cosmosdb-commons:jar:2.4.5:compile
  +-commons-validator:commons-validator:jar:1.6:compile
+-commons-digester:commons-digester:jar:1.8.1:compile
  +-xml-apis:xml-apis:jar:1.0.b2:provided
and
+-org.apache.hadoop:hadoop-yarn-server-timelineservice-documentstore:jar:3.4.0-SNAPSHOT
  +-xerces:xercesImpl:jar:2.12.2:compile
+-xml-apis:xml-apis:jar:1.4.01:compile
{noformat}

> Fix build failure with docs profile
> ---
>
> Key: HADOOP-18601
> URL: https://issues.apache.org/jira/browse/HADOOP-18601
> Project: Hadoop Common
>  Issue Type: Bug
>Reporter: Masatake Iwasaki
>Assignee: Masatake Iwasaki
>Priority: Major
>
> Build with docs profile failed due to depcheck error.
> {noformat}
> $ mvn clean install -DskipTests -DskipShade -Pdocs
> ...
> [INFO] --- maven-enforcer-plugin:3.0.0:enforce (depcheck) @ hadoop-hdfs ---
> [WARNING]
> Dependency convergence error for xerces:xercesImpl:jar:2.12.2:provided paths 
> to dependency are:
> +-org.apache.hadoop:hadoop-hdfs:jar:3.4.0-SNAPSHOT
>   +-org.apache.hadoop:hadoop-common:jar:3.4.0-SNAPSHOT:provided
> +-xerces:xercesImpl:jar:2.12.2:provided
> and
> +-org.apache.hadoop:hadoop-hdfs:jar:3.4.0-SNAPSHOT
>   +-org.apache.hadoop:hadoop-common:test-jar:tests:3.4.0-SNAPSHOT:test
> +-xerces:xercesImpl:jar:2.12.2:test
> and
> +-org.apache.hadoop:hadoop-hdfs:jar:3.4.0-SNAPSHOT
>   +-org.apache.hadoop:hadoop-hdfs-client:jar:3.4.0-SNAPSHOT:provided
> +-xerces:xercesImpl:jar:2.12.2:provided
> and
> +-org.apache.hadoop:hadoop-hdfs:jar:3.4.0-SNAPSHOT
>   +-com.google.code.findbugs:findbugs:jar:3.0.1:provided
> +-jaxen:jaxen:jar:1.1.6:provided
>   +-xerces:xercesImpl:jar:2.6.2:provided
> and
> +-org.apache.hadoop:hadoop-hdfs:jar:3.4.0-SNAPSHOT
>   +-xerces:xercesImpl:jar:2.12.2:compile
> [WARNING] Rule 0: org.apache.maven.plugins.enforcer.DependencyConvergence 
> failed with message:
> Failed while enforcing releasability. See above detailed error message.
> [INFO] 
> 
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[GitHub] [hadoop] hadoop-yetus commented on pull request #5330: HDFS-16898. Make write lock fine-grain in method processCommandFromActor

2023-01-29 Thread via GitHub


hadoop-yetus commented on PR #5330:
URL: https://github.com/apache/hadoop/pull/5330#issuecomment-1407759554

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 36s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  |  The patch doesn't appear to include 
any new or modified tests. Please justify why no new tests are needed for this 
patch. Also please list what manual steps were performed to verify this patch.  
|
    _ trunk Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  43m 27s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   1m 26s |  |  trunk passed with JDK 
Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04  |
   | +1 :green_heart: |  compile  |   1m 23s |  |  trunk passed with JDK 
Private Build-1.8.0_352-8u352-ga-1~20.04-b08  |
   | +1 :green_heart: |  checkstyle  |   1m  7s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   1m 31s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   1m  7s |  |  trunk passed with JDK 
Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04  |
   | +1 :green_heart: |  javadoc  |   1m 33s |  |  trunk passed with JDK 
Private Build-1.8.0_352-8u352-ga-1~20.04-b08  |
   | +1 :green_heart: |  spotbugs  |   3m 25s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  25m 28s |  |  branch has no errors 
when building and testing our client artifacts.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   1m 23s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 18s |  |  the patch passed with JDK 
Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04  |
   | +1 :green_heart: |  javac  |   1m 18s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 13s |  |  the patch passed with JDK 
Private Build-1.8.0_352-8u352-ga-1~20.04-b08  |
   | +1 :green_heart: |  javac  |   1m 13s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   0m 53s | 
[/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5330/1/artifact/out/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt)
 |  hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 15 unchanged - 
0 fixed = 16 total (was 15)  |
   | +1 :green_heart: |  mvnsite  |   1m 21s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 49s |  |  the patch passed with JDK 
Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04  |
   | +1 :green_heart: |  javadoc  |   1m 25s |  |  the patch passed with JDK 
Private Build-1.8.0_352-8u352-ga-1~20.04-b08  |
   | +1 :green_heart: |  spotbugs  |   3m 13s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  25m 32s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | -1 :x: |  unit  | 299m 25s | 
[/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5330/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt)
 |  hadoop-hdfs in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m 49s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 416m 26s |  |  |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hdfs.TestLeaseRecovery2 |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5330/1/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/5330 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
   | uname | Linux c83292b63478 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 
18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / 75f1c4cc2c665f4780164b7da0776c94910a7ca9 |
   | Default Java | Private Build-1.8.0_352-8u352-ga-1~20.04-b08 |
   | Multi-JDK versions | 
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 
/usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5330/1/testReport/ |
   | Max. process+thread count | 3646 (vs. ulimit of 5500) |
   | modules | C: 

[GitHub] [hadoop] hfutatzhanghb commented on pull request #5330: HDFS-16898. Make write lock fine-grain in method processCommandFromActor

2023-01-29 Thread via GitHub


hfutatzhanghb commented on PR #5330:
URL: https://github.com/apache/hadoop/pull/5330#issuecomment-1407662711

   hi, @srinivasst,@ayushtkn ,@goiri, @tomscut . could you please help me 
review the code ? does this modification is right?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[GitHub] [hadoop] hfutatzhanghb opened a new pull request, #5330: HDFS-16898. Make write lock fine-grain in method processCommandFromActor

2023-01-29 Thread via GitHub


hfutatzhanghb opened a new pull request, #5330:
URL: https://github.com/apache/hadoop/pull/5330

   Now in method processCommandFromActor,  we have code like below:
   
   ```java
   writeLock();
   try {
 if (actor == bpServiceToActive) {
   return processCommandFromActive(cmd, actor);
 } else {
   return processCommandFromStandby(cmd, actor);
 }
   } finally {
 writeUnlock();
   } 
   ```
   
   if method processCommandFromActive costs much time, the write lock would not 
release.
   
   
   It maybe block the `updateActorStatesFromHeartbeat` method in 
offerService,furthermore, it can cause the lastcontact of datanode very high, 
even dead when lastcontact beyond 600s.
   
   ```java
   bpos.updateActorStatesFromHeartbeat(
   this, resp.getNameNodeHaState());
   ```
   
   here we can make write lock fine-grain in processCommandFromActor method to 
address this problem


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[GitHub] [hadoop] fanluoo commented on pull request #5329: HDFS-16897. fix abundant Broken pipe exception in BlockSender

2023-01-29 Thread via GitHub


fanluoo commented on PR #5329:
URL: https://github.com/apache/hadoop/pull/5329#issuecomment-1407649400

   @ayushtkn could you help to review, it seems jenkins failed not related to 
this pr


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[GitHub] [hadoop] hadoop-yetus commented on pull request #5329: fix abundant Broken pipe exception in BlockSender

2023-01-29 Thread via GitHub


hadoop-yetus commented on PR #5329:
URL: https://github.com/apache/hadoop/pull/5329#issuecomment-1407646008

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 56s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  |  The patch doesn't appear to include 
any new or modified tests. Please justify why no new tests are needed for this 
patch. Also please list what manual steps were performed to verify this patch.  
|
    _ trunk Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  44m 10s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   1m 25s |  |  trunk passed with JDK 
Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04  |
   | +1 :green_heart: |  compile  |   1m 19s |  |  trunk passed with JDK 
Private Build-1.8.0_352-8u352-ga-1~20.04-b08  |
   | +1 :green_heart: |  checkstyle  |   1m  7s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   1m 30s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   1m  8s |  |  trunk passed with JDK 
Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04  |
   | +1 :green_heart: |  javadoc  |   1m 32s |  |  trunk passed with JDK 
Private Build-1.8.0_352-8u352-ga-1~20.04-b08  |
   | +1 :green_heart: |  spotbugs  |   3m 28s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  25m 51s |  |  branch has no errors 
when building and testing our client artifacts.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   1m 24s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 17s |  |  the patch passed with JDK 
Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04  |
   | +1 :green_heart: |  javac  |   1m 17s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 15s |  |  the patch passed with JDK 
Private Build-1.8.0_352-8u352-ga-1~20.04-b08  |
   | +1 :green_heart: |  javac  |   1m 15s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   0m 52s |  |  the patch passed  |
   | +1 :green_heart: |  mvnsite  |   1m 19s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 49s |  |  the patch passed with JDK 
Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04  |
   | +1 :green_heart: |  javadoc  |   1m 28s |  |  the patch passed with JDK 
Private Build-1.8.0_352-8u352-ga-1~20.04-b08  |
   | +1 :green_heart: |  spotbugs  |   3m 12s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  25m 29s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | -1 :x: |  unit  | 418m 23s | 
[/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5329/2/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt)
 |  hadoop-hdfs in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m 49s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 536m 27s |  |  |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hdfs.server.balancer.TestBalancerService |
   |   | hadoop.hdfs.TestLeaseRecovery2 |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5329/2/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/5329 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
   | uname | Linux 8578812cacd4 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 
18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / 2a1f61cd7914a7f96c84bbb18278ed6e5da48ed1 |
   | Default Java | Private Build-1.8.0_352-8u352-ga-1~20.04-b08 |
   | Multi-JDK versions | 
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 
/usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5329/2/testReport/ |
   | Max. process+thread count | 2780 (vs. ulimit of 5500) |
   | modules | C: hadoop-hdfs-project/hadoop-hdfs U: 
hadoop-hdfs-project/hadoop-hdfs |
   | Console output | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5329/2/console |
   | versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2