[jira] [Commented] (HADOOP-19103) Add logic for verifying that the STS URL is in the correct format

2024-03-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824286#comment-17824286 ] ASF GitHub Bot commented on HADOOP-19103: - shameersss1 commented on code in PR #6615: URL:

Re: [PR] HADOOP-19103 : Add logic for verifying that the STS URL is in the correct format [hadoop]

2024-03-06 Thread via GitHub
shameersss1 commented on code in PR #6615: URL: https://github.com/apache/hadoop/pull/6615#discussion_r1515670775 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/auth/STSClientFactory.java: ## @@ -125,6 +125,14 @@ public static StsClientBuilder builder(

[jira] [Commented] (HADOOP-19103) Add logic for verifying that the STS URL is in the correct format

2024-03-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824284#comment-17824284 ] ASF GitHub Bot commented on HADOOP-19103: - shameersss1 commented on code in PR #6615: URL:

Re: [PR] HADOOP-19103 : Add logic for verifying that the STS URL is in the correct format [hadoop]

2024-03-06 Thread via GitHub
shameersss1 commented on code in PR #6615: URL: https://github.com/apache/hadoop/pull/6615#discussion_r1515667380 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/auth/delegation/DelegationConstants.java: ## @@ -160,6 +160,18 @@ public final class

[jira] [Commented] (HADOOP-19103) Add logic for verifying that the STS URL is in the correct format

2024-03-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824282#comment-17824282 ] ASF GitHub Bot commented on HADOOP-19103: - hadoop-yetus commented on PR #6615: URL:

Re: [PR] HADOOP-19103 : Add logic for verifying that the STS URL is in the correct format [hadoop]

2024-03-06 Thread via GitHub
hadoop-yetus commented on PR #6615: URL: https://github.com/apache/hadoop/pull/6615#issuecomment-1982725960 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17395. [FGL] Use FSLock to protect ErasureCodingPolicy related operations [hadoop]

2024-03-06 Thread via GitHub
ZanderXu merged PR #6579: URL: https://github.com/apache/hadoop/pull/6579 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HDFS-17395. [FGL] Use FSLock to protect ErasureCodingPolicy related operations [hadoop]

2024-03-06 Thread via GitHub
ZanderXu commented on PR #6579: URL: https://github.com/apache/hadoop/pull/6579#issuecomment-1982496558 Thanks @ferhui and @haiyang1987 for your review. Merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (HADOOP-19052) Hadoop use Shell command to get the count of the hard link which takes a lot of time

2024-03-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824262#comment-17824262 ] ASF GitHub Bot commented on HADOOP-19052: - hadoop-yetus commented on PR #6587: URL:

Re: [PR] HADOOP-19052.Hadoop use Shell command to get the count of the hard link which takes a lot of time [hadoop]

2024-03-06 Thread via GitHub
hadoop-yetus commented on PR #6587: URL: https://github.com/apache/hadoop/pull/6587#issuecomment-1982488808 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Updated] (HADOOP-19103) Add logic for verifying that the STS URL is in the correct format

2024-03-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-19103: Labels: pull-request-available (was: ) > Add logic for verifying that the STS URL is in

[jira] [Commented] (HADOOP-19103) Add logic for verifying that the STS URL is in the correct format

2024-03-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824261#comment-17824261 ] ASF GitHub Bot commented on HADOOP-19103: - vnhive opened a new pull request, #6615: URL:

[PR] HADOOP-19103 : Add logic for verifying that the STS URL is in the correct format [hadoop]

2024-03-06 Thread via GitHub
vnhive opened a new pull request, #6615: URL: https://github.com/apache/hadoop/pull/6615 At present an invalid URL can be supplied as an STS endpoint. It will attempt to create an STSClient with it and then fail with, > java.net.UnknownHostException: request session

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-06 Thread via GitHub
hadoop-yetus commented on PR #6614: URL: https://github.com/apache/hadoop/pull/6614#issuecomment-1982453381 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Created] (HADOOP-19103) Add logic for verifying that the STS URL is in the correct format

2024-03-06 Thread Narayanan Venkateswaran (Jira)
Narayanan Venkateswaran created HADOOP-19103: Summary: Add logic for verifying that the STS URL is in the correct format Key: HADOOP-19103 URL: https://issues.apache.org/jira/browse/HADOOP-19103

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file (… [hadoop]

2024-03-06 Thread via GitHub
hadoop-yetus commented on PR #6613: URL: https://github.com/apache/hadoop/pull/6613#issuecomment-1982313394 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-06 Thread via GitHub
hadoop-yetus commented on PR #6612: URL: https://github.com/apache/hadoop/pull/6612#issuecomment-1982297366 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-15984) Update jersey from 1.19 to 2.x

2024-03-06 Thread Shilun Fan (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824239#comment-17824239 ] Shilun Fan commented on HADOOP-15984: - I have removed the git bot (it will be added back later). I

[PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-06 Thread via GitHub
ritegarg opened a new pull request, #6614: URL: https://github.com/apache/hadoop/pull/6614 ### Description of PR ### How was this patch tested? ### For code changes: - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g.

Re: [PR] HDFS-17401. EC: Excess internal block may not be able to be deleted correctly when it's stored in fallback storage [hadoop]

2024-03-06 Thread via GitHub
haiyang1987 commented on code in PR #6597: URL: https://github.com/apache/hadoop/pull/6597#discussion_r1515435820 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestReconstructStripedBlocks.java: ## @@ -575,5 +576,82 @@ public void

Re: [PR] HDFS-17352. Add configuration to control whether DN delete this replica from disk when client requests a missing block [hadoop]

2024-03-06 Thread via GitHub
haiyang1987 commented on code in PR #6559: URL: https://github.com/apache/hadoop/pull/6559#discussion_r1515437309 ## hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml: ## @@ -3982,6 +3982,17 @@ + + dfs.datanode.delete.corrupt.replica.from.disk.enable

Re: [PR] HDFS-17395. [FGL] Use FSLock to protect ErasureCodingPolicy related operations [hadoop]

2024-03-06 Thread via GitHub
haiyang1987 commented on PR #6579: URL: https://github.com/apache/hadoop/pull/6579#issuecomment-1982276440 LGTM. +1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] HDFS-17380. FsImageValidation: remove inaccessible nodes. [hadoop]

2024-03-06 Thread via GitHub
hadoop-yetus commented on PR #6549: URL: https://github.com/apache/hadoop/pull/6549#issuecomment-1982197837 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-15984) Update jersey from 1.19 to 2.x

2024-03-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824227#comment-17824227 ] ASF GitHub Bot commented on HADOOP-15984: - hadoop-yetus commented on PR #6606: URL:

Re: [PR] HADOOP-15984. Update jersey from 1.19 to 2.x [hadoop]

2024-03-06 Thread via GitHub
hadoop-yetus commented on PR #6606: URL: https://github.com/apache/hadoop/pull/6606#issuecomment-1982178875 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[PR] HDFS-17299. Adding rack failure tolerance when creating a new file (… [hadoop]

2024-03-06 Thread via GitHub
ritegarg opened a new pull request, #6613: URL: https://github.com/apache/hadoop/pull/6613 …#6566) ### Description of PR ### How was this patch tested? ### For code changes: - [ ] Does the title or this PR starts with the corresponding JIRA issue

[PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-06 Thread via GitHub
ritegarg opened a new pull request, #6612: URL: https://github.com/apache/hadoop/pull/6612 ### Description of PR ### How was this patch tested? ### For code changes: - [ ] Does the title or this PR starts with the corresponding JIRA issue id

Re: [PR] HDFS-17401. EC: Excess internal block may not be able to be deleted correctly when it's stored in fallback storage [hadoop]

2024-03-06 Thread via GitHub
hadoop-yetus commented on PR #6597: URL: https://github.com/apache/hadoop/pull/6597#issuecomment-1981846301 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19090) Update Protocol Buffers installation to 3.23.4

2024-03-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824184#comment-17824184 ] ASF GitHub Bot commented on HADOOP-19090: - pjfanning commented on PR #6593: URL:

Re: [PR] HADOOP-19090. Use protobuf-java 3.23.4. [hadoop]

2024-03-06 Thread via GitHub
pjfanning commented on PR #6593: URL: https://github.com/apache/hadoop/pull/6593#issuecomment-1981822779 Some of the test issues relate to `java.lang.OutOfMemoryError: unable to create new native thread` ``` [ERROR] Tests run: 10, Failures: 0, Errors: 5, Skipped: 0, Time elapsed:

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-06 Thread via GitHub
shahrs87 merged PR #6566: URL: https://github.com/apache/hadoop/pull/6566 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (HADOOP-19090) Update Protocol Buffers installation to 3.23.4

2024-03-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824172#comment-17824172 ] ASF GitHub Bot commented on HADOOP-19090: - hadoop-yetus commented on PR #6593: URL:

Re: [PR] HADOOP-19090. Use protobuf-java 3.23.4. [hadoop]

2024-03-06 Thread via GitHub
hadoop-yetus commented on PR #6593: URL: https://github.com/apache/hadoop/pull/6593#issuecomment-1981753960 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19101) Vectored Read into off-heap buffer broken in fallback implementation

2024-03-06 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824167#comment-17824167 ] Steve Loughran commented on HADOOP-19101: - Code review update * Iceberg is safe reading parquet

[jira] [Commented] (HADOOP-19101) Vectored Read into off-heap buffer broken in fallback implementation

2024-03-06 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824166#comment-17824166 ] Steve Loughran commented on HADOOP-19101: - * tests didn't validate the default impl, just

Re: [PR] HDFS-17395. [FGL] Use FSLock to protect ErasureCodingPolicy related operations [hadoop]

2024-03-06 Thread via GitHub
hadoop-yetus commented on PR #6579: URL: https://github.com/apache/hadoop/pull/6579#issuecomment-1981604508 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19085) Compatibility Benchmark over HCFS Implementations

2024-03-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824114#comment-17824114 ] ASF GitHub Bot commented on HADOOP-19085: - hadoop-yetus commented on PR #6602: URL:

Re: [PR] HADOOP-19085 Add hadoop-compat-bench [hadoop]

2024-03-06 Thread via GitHub
hadoop-yetus commented on PR #6602: URL: https://github.com/apache/hadoop/pull/6602#issuecomment-1981500882 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19085) Compatibility Benchmark over HCFS Implementations

2024-03-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824107#comment-17824107 ] ASF GitHub Bot commented on HADOOP-19085: - hadoop-yetus commented on PR #6602: URL:

Re: [PR] HADOOP-19085 Add hadoop-compat-bench [hadoop]

2024-03-06 Thread via GitHub
hadoop-yetus commented on PR #6602: URL: https://github.com/apache/hadoop/pull/6602#issuecomment-1981464918 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-06 Thread via GitHub
shahrs87 commented on PR #6566: URL: https://github.com/apache/hadoop/pull/6566#issuecomment-1981347404 Will merge the PR later today. FYI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (HADOOP-19101) Vectored Read into off-heap buffer broken in fallback implementation

2024-03-06 Thread Harshit Gupta (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824079#comment-17824079 ] Harshit Gupta commented on HADOOP-19101: [~ste...@apache.org] how did you discover this issue?

Re: [PR] YARN-11626. Optimize ResourceManager's operations on Zookeeper metadata [hadoop]

2024-03-06 Thread via GitHub
hadoop-yetus commented on PR #6577: URL: https://github.com/apache/hadoop/pull/6577#issuecomment-1981087718 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19093) add load tests for abfs rename resilience

2024-03-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824028#comment-17824028 ] ASF GitHub Bot commented on HADOOP-19093: - steveloughran commented on PR #6596: URL:

Re: [PR] HADOOP-19093. [ABFS] ILoadTestRenameRecovery [hadoop]

2024-03-06 Thread via GitHub
steveloughran commented on PR #6596: URL: https://github.com/apache/hadoop/pull/6596#issuecomment-1980987839 When `mapreduce.manifest.committer.validate.output` I am going to add pre-rename validation phase we scan the task attempt to directory tree to make sure everything is there and

[jira] [Commented] (HADOOP-19085) Compatibility Benchmark over HCFS Implementations

2024-03-06 Thread Han Liu (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824022#comment-17824022 ] Han Liu commented on HADOOP-19085: -- Thanks a lot for detailed comments from [~drankye]  All

[jira] [Commented] (HADOOP-19093) add load tests for abfs rename resilience

2024-03-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824020#comment-17824020 ] ASF GitHub Bot commented on HADOOP-19093: - steveloughran commented on code in PR #6596: URL:

Re: [PR] HADOOP-19093. [ABFS] ILoadTestRenameRecovery [hadoop]

2024-03-06 Thread via GitHub
steveloughran commented on code in PR #6596: URL: https://github.com/apache/hadoop/pull/6596#discussion_r1514542657 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/functional/TaskPool.java: ## @@ -545,7 +545,8 @@ private void resetStatisticsContext()

Re: [PR] HDFS-17390. [FGL] FSDirectory supports this fine-grained locking [hadoop]

2024-03-06 Thread via GitHub
ferhui commented on PR #6573: URL: https://github.com/apache/hadoop/pull/6573#issuecomment-1980905254 Thanks for the patch. Merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] HDFS-17390. [FGL] FSDirectory supports this fine-grained locking [hadoop]

2024-03-06 Thread via GitHub
ferhui merged PR #6573: URL: https://github.com/apache/hadoop/pull/6573 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HDFS-17390. [FGL] FSDirectory supports this fine-grained locking [hadoop]

2024-03-06 Thread via GitHub
ferhui commented on PR #6573: URL: https://github.com/apache/hadoop/pull/6573#issuecomment-1980904344 Failed cases are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] HDFS-17390. [FGL] FSDirectory supports this fine-grained locking [hadoop]

2024-03-06 Thread via GitHub
hadoop-yetus commented on PR #6573: URL: https://github.com/apache/hadoop/pull/6573#issuecomment-1980762546 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Updated] (HADOOP-19033) S3A: disable checksums when fs.s3a.checksum.validation = false

2024-03-06 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-19033: Fix Version/s: (was: 3.4.1) > S3A: disable checksums when fs.s3a.checksum.validation

[jira] [Updated] (HADOOP-19033) S3A: disable checksums when fs.s3a.checksum.validation = false

2024-03-06 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-19033: Summary: S3A: disable checksums when fs.s3a.checksum.validation = false (was: S3A:

Re: [PR] HDFS-17146. [Addendum] Enhance test readability with assertJ. [hadoop]

2024-03-06 Thread via GitHub
hadoop-yetus commented on PR #6595: URL: https://github.com/apache/hadoop/pull/6595#issuecomment-1980650952 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19098) Vector IO: consistent specified rejection of overlapping ranges

2024-03-06 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823966#comment-17823966 ] Steve Loughran commented on HADOOP-19098: - PR for this contains tests and fix for

[jira] [Updated] (HADOOP-19101) Vectored Read into off-heap buffer broken in fallback implementation

2024-03-06 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-19101: Description: {{VectoredReadUtils.readInDirectBuffer()}} always starts off reading at

[jira] [Updated] (HADOOP-19101) Vectored Read into off-heap buffer broken in fallback implementation

2024-03-06 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-19101: Summary: Vectored Read into off-heap buffer broken in fallback implementation (was:

[jira] [Commented] (HADOOP-15984) Update jersey from 1.19 to 2.x

2024-03-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823958#comment-17823958 ] ASF GitHub Bot commented on HADOOP-15984: - hadoop-yetus commented on PR #6606: URL:

Re: [PR] HADOOP-15984. Update jersey from 1.19 to 2.x [hadoop]

2024-03-06 Thread via GitHub
hadoop-yetus commented on PR #6606: URL: https://github.com/apache/hadoop/pull/6606#issuecomment-1980575783 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Updated] (HADOOP-19102) [ABFS]: FooterReadBufferSize should not be greater than readBufferSize

2024-03-06 Thread Pranav Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pranav Saxena updated HADOOP-19102: --- Fix Version/s: 3.4.0 3.5.0 > [ABFS]: FooterReadBufferSize should not be

[jira] [Created] (HADOOP-19102) [ABFS]: FooterReadBufferSize should not be greater than readBufferSize

2024-03-06 Thread Pranav Saxena (Jira)
Pranav Saxena created HADOOP-19102: -- Summary: [ABFS]: FooterReadBufferSize should not be greater than readBufferSize Key: HADOOP-19102 URL: https://issues.apache.org/jira/browse/HADOOP-19102

Re: [PR] HDFS-17401. EC: Excess internal block may not be able to be deleted correctly when it's stored in fallback storage [hadoop]

2024-03-06 Thread via GitHub
zhangshuyan0 commented on code in PR #6597: URL: https://github.com/apache/hadoop/pull/6597#discussion_r1514212224 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestReconstructStripedBlocks.java: ## @@ -27,13 +27,7 @@ import

Re: [PR] HDFS-17146. [Addendum] Enhance test readability with assertJ. [hadoop]

2024-03-06 Thread via GitHub
zhtttylz commented on code in PR #6595: URL: https://github.com/apache/hadoop/pull/6595#discussion_r1514181677 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDFSAdmin.java: ## @@ -1377,7 +1377,8 @@ public Boolean get() { }

Re: [PR] HDFS-17345. Add a metrics to record block report creating cost time. [hadoop]

2024-03-06 Thread via GitHub
hfutatzhanghb commented on PR #6475: URL: https://github.com/apache/hadoop/pull/6475#issuecomment-1980485362 @zhangshuyan0 Sir, Thanks a lot for your reviewing and merging~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Commented] (HADOOP-19090) Update Protocol Buffers installation to 3.23.4

2024-03-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823932#comment-17823932 ] ASF GitHub Bot commented on HADOOP-19090: - pjfanning commented on code in PR #6593: URL:

Re: [PR] HADOOP-19090. Use protobuf-java 3.23.4. [hadoop]

2024-03-06 Thread via GitHub
pjfanning commented on code in PR #6593: URL: https://github.com/apache/hadoop/pull/6593#discussion_r1514120462 ## pom.xml: ## @@ -57,6 +57,13 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/x ${distMgmtSnapshotsName}

Re: [PR] HDFS-17345. Add a metrics to record block report creating cost time. [hadoop]

2024-03-06 Thread via GitHub
zhangshuyan0 commented on PR #6475: URL: https://github.com/apache/hadoop/pull/6475#issuecomment-1980384103 Committed to trunk. Thanks for your contribution @hfutatzhanghb . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] HDFS-17345. Add a metrics to record block report creating cost time. [hadoop]

2024-03-06 Thread via GitHub
zhangshuyan0 merged PR #6475: URL: https://github.com/apache/hadoop/pull/6475 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-06 Thread via GitHub
hadoop-yetus commented on PR #6566: URL: https://github.com/apache/hadoop/pull/6566#issuecomment-1980368491 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |