[GitHub] [hadoop] hadoop-yetus commented on pull request #5147: HDFS-16848. RBF: Improve StateStoreZooKeeperImpl performance

2023-01-20 Thread via GitHub
hadoop-yetus commented on PR #5147: URL: https://github.com/apache/hadoop/pull/5147#issuecomment-1398761764 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hchaverri closed pull request #5159: HADOOP-18535. Implement token storage solution based on MySQL

2023-01-20 Thread via GitHub
hchaverri closed pull request #5159: HADOOP-18535. Implement token storage solution based on MySQL URL: https://github.com/apache/hadoop/pull/5159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hadoop] virajjasani commented on pull request #5294: HADOOP-18592 Sasl connection failure should log remote address

2023-01-20 Thread via GitHub
virajjasani commented on PR #5294: URL: https://github.com/apache/hadoop/pull/5294#issuecomment-1399022473 @cnauroth @steveloughran Does this look good to go? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop] omalley commented on a diff in pull request #5298: HDFS-16890: RBF: Ensures router periodically refreshes its record of a namespace's state.

2023-01-20 Thread via GitHub
omalley commented on code in PR #5298: URL: https://github.com/apache/hadoop/pull/5298#discussion_r1083100964 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java: ## @@ -1730,4 +1750,39 @@ private static boole

[GitHub] [hadoop] virajjasani commented on pull request #5054: HADOOP-18399 Prefetch - SingleFilePerBlockCache to use LocalDirAllocator for file allocation

2023-01-20 Thread via GitHub
virajjasani commented on PR #5054: URL: https://github.com/apache/hadoop/pull/5054#issuecomment-1399034705 @mehakmeet @mukund-thakur if you have some cycles to review this PR. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hadoop] hadoop-yetus commented on pull request #5319: HADOOP-18598. maven site generation doesn't include javadocs.

2023-01-20 Thread via GitHub
hadoop-yetus commented on PR #5319: URL: https://github.com/apache/hadoop/pull/5319#issuecomment-1399062237 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] simbadzina commented on a diff in pull request #5298: HDFS-16890: RBF: Ensures router periodically refreshes its record of a namespace's state.

2023-01-20 Thread via GitHub
simbadzina commented on code in PR #5298: URL: https://github.com/apache/hadoop/pull/5298#discussion_r1083133346 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java: ## @@ -211,13 +222,19 @@ public RouterRpcCl

[GitHub] [hadoop] goiri commented on a diff in pull request #5272: YARN-11217. [Federation] Add dumpSchedulerLogs REST APIs for Router.

2023-01-20 Thread via GitHub
goiri commented on code in PR #5272: URL: https://github.com/apache/hadoop/pull/5272#discussion_r1083135742 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/FederationInterceptorREST.java: #

[GitHub] [hadoop] hadoop-yetus commented on pull request #5298: HDFS-16890: RBF: Ensures router periodically refreshes its record of a namespace's state.

2023-01-20 Thread via GitHub
hadoop-yetus commented on PR #5298: URL: https://github.com/apache/hadoop/pull/5298#issuecomment-1399132189 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5272: YARN-11217. [Federation] Add dumpSchedulerLogs REST APIs for Router.

2023-01-20 Thread via GitHub
slfan1989 commented on code in PR #5272: URL: https://github.com/apache/hadoop/pull/5272#discussion_r1083220366 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/FederationInterceptorREST.java: #

[GitHub] [hadoop] hadoop-yetus commented on pull request #5298: HDFS-16890: RBF: Ensures router periodically refreshes its record of a namespace's state.

2023-01-20 Thread via GitHub
hadoop-yetus commented on PR #5298: URL: https://github.com/apache/hadoop/pull/5298#issuecomment-1399144199 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5298: HDFS-16890: RBF: Ensures router periodically refreshes its record of a namespace's state.

2023-01-20 Thread via GitHub
hadoop-yetus commented on PR #5298: URL: https://github.com/apache/hadoop/pull/5298#issuecomment-1399173161 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #5288: YARN-11394. Fix hadoop-yarn-server-resourcemanager module Java Doc Errors.

2023-01-20 Thread via GitHub
hadoop-yetus commented on PR #5288: URL: https://github.com/apache/hadoop/pull/5288#issuecomment-1399188342 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] howzi commented on pull request #5147: HDFS-16848. RBF: Improve StateStoreZooKeeperImpl performance

2023-01-20 Thread via GitHub
howzi commented on PR #5147: URL: https://github.com/apache/hadoop/pull/5147#issuecomment-1399192561 Just fixed all above problems, thanks for your suggestions @ZanderXu @goiri . BTW, today is Chinese New Year, happy Chinese New Year! -- This is an automated message from the Apache Git

[GitHub] [hadoop] hadoop-yetus commented on pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

2023-01-21 Thread via GitHub
hadoop-yetus commented on PR #5315: URL: https://github.com/apache/hadoop/pull/5315#issuecomment-1399313706 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] brahmareddybattula commented on pull request #5229: HADOOP-18578. Bump netty to the latest 4.1.86

2023-01-21 Thread via GitHub
brahmareddybattula commented on PR #5229: URL: https://github.com/apache/hadoop/pull/5229#issuecomment-1399413606 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [hadoop] susheel-gupta opened a new pull request, #5320: YARN-11416. FS2CS should use CapacitySchedulerConfiguration in FSQueueConverterBuilder

2023-01-22 Thread via GitHub
susheel-gupta opened a new pull request, #5320: URL: https://github.com/apache/hadoop/pull/5320 …CapacitySchedulerConfiguration object Change-Id: Ifdab821bee6f0f6db4f8b17208d01cf3901820b7 ### Description of PR ### How was this patch tested? ### For

[GitHub] [hadoop] brumi1024 commented on a diff in pull request #5278: YARN-11408. Add a check of autoQueueCreation is disabled for emitDefaultUserLimitFactor method

2023-01-23 Thread via GitHub
brumi1024 commented on code in PR #5278: URL: https://github.com/apache/hadoop/pull/5278#discussion_r1083821014 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/converter/T

[GitHub] [hadoop] brumi1024 commented on a diff in pull request #5278: YARN-11408. Add a check of autoQueueCreation is disabled for emitDefaultUserLimitFactor method

2023-01-23 Thread via GitHub
brumi1024 commented on code in PR #5278: URL: https://github.com/apache/hadoop/pull/5278#discussion_r1083821014 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/converter/T

[GitHub] [hadoop] brumi1024 commented on a diff in pull request #5320: YARN-11416. FS2CS should use CapacitySchedulerConfiguration in FSQueueConverterBuilder

2023-01-23 Thread via GitHub
brumi1024 commented on code in PR #5320: URL: https://github.com/apache/hadoop/pull/5320#discussion_r1083831502 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/converter/T

[GitHub] [hadoop] hadoop-yetus commented on pull request #5320: YARN-11416. FS2CS should use CapacitySchedulerConfiguration in FSQueueConverterBuilder

2023-01-23 Thread via GitHub
hadoop-yetus commented on PR #5320: URL: https://github.com/apache/hadoop/pull/5320#issuecomment-1400097285 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5308: HADOOP-18596. Distcp -update to use modification time while checking for file skip.

2023-01-23 Thread via GitHub
hadoop-yetus commented on PR #5308: URL: https://github.com/apache/hadoop/pull/5308#issuecomment-1400145282 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

2023-01-23 Thread via GitHub
hadoop-yetus commented on PR #5315: URL: https://github.com/apache/hadoop/pull/5315#issuecomment-1400566112 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

2023-01-23 Thread via GitHub
virajjasani commented on code in PR #5315: URL: https://github.com/apache/hadoop/pull/5315#discussion_r1081711742 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/IOUtils.java: ## @@ -256,7 +255,7 @@ public static void skipFully(InputStream in, long len)

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

2023-01-23 Thread via GitHub
virajjasani commented on code in PR #5315: URL: https://github.com/apache/hadoop/pull/5315#discussion_r1084419111 ## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestJarFinder.java: ## @@ -39,14 +38,6 @@ public class TestJarFinder { - @Test Rev

[GitHub] [hadoop] hadoop-yetus commented on pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

2023-01-23 Thread via GitHub
hadoop-yetus commented on PR #5315: URL: https://github.com/apache/hadoop/pull/5315#issuecomment-1400896533 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] slfan1989 opened a new pull request, #5321: YARN-11424. [Federation] Router Supports DeregisterSubCluster.

2023-01-23 Thread via GitHub
slfan1989 opened a new pull request, #5321: URL: https://github.com/apache/hadoop/pull/5321 JIRA: YARN-11424. [Federation] Router Supports DeregisterSubCluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [hadoop] hadoop-yetus commented on pull request #5312: YARN-11375. [Federation] Support refreshAdminAcls、refreshServiceAcls API's for Federation.

2023-01-23 Thread via GitHub
hadoop-yetus commented on PR #5312: URL: https://github.com/apache/hadoop/pull/5312#issuecomment-1401420638 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] mccormickt12 opened a new pull request, #5322: HDFS-16896 clear ignoredNodes list when we clear deadnode list on ref…

2023-01-23 Thread via GitHub
mccormickt12 opened a new pull request, #5322: URL: https://github.com/apache/hadoop/pull/5322 …etchLocations. ignoredNodes list is only used on hedged read codepath ### Description of PR clear ignoredNodes list when we clear deadnode list on refetchLocations. ignoredNodes

[GitHub] [hadoop] hadoop-yetus commented on pull request #5322: HDFS-16896 clear ignoredNodes list when we clear deadnode list on ref…

2023-01-24 Thread via GitHub
hadoop-yetus commented on PR #5322: URL: https://github.com/apache/hadoop/pull/5322#issuecomment-1401628815 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] tomicooler opened a new pull request, #5323: HADOOP-18602. Remove netty3 dependency

2023-01-24 Thread via GitHub
tomicooler opened a new pull request, #5323: URL: https://github.com/apache/hadoop/pull/5323 Change-Id: Ib9eb8a325364a60988b4b8dbb2fa7f6ee5a96f58 ### For code changes: - [x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR t

[GitHub] [hadoop] hadoop-yetus commented on pull request #5321: YARN-11424. [Federation] Router Supports DeregisterSubCluster.

2023-01-24 Thread via GitHub
hadoop-yetus commented on PR #5321: URL: https://github.com/apache/hadoop/pull/5321#issuecomment-1401747166 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5317: YARN-11420 Stabilize TestNMClient

2023-01-24 Thread via GitHub
hadoop-yetus commented on PR #5317: URL: https://github.com/apache/hadoop/pull/5317#issuecomment-1401947268 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] slfan1989 commented on pull request #5321: YARN-11424. [Federation] Router Supports DeregisterSubCluster.

2023-01-24 Thread via GitHub
slfan1989 commented on PR #5321: URL: https://github.com/apache/hadoop/pull/5321#issuecomment-1401992725 @goiri Can you help review this pr? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop] slfan1989 commented on pull request #5312: YARN-11375. [Federation] Support refreshAdminAcls、refreshServiceAcls API's for Federation.

2023-01-24 Thread via GitHub
slfan1989 commented on PR #5312: URL: https://github.com/apache/hadoop/pull/5312#issuecomment-1401993618 @goiri Can you help review this pr? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop] slfan1989 commented on pull request #5284: YARN-11218. [Federation] Add getActivities, getBulkActivities REST APIs for Router.

2023-01-24 Thread via GitHub
slfan1989 commented on PR #5284: URL: https://github.com/apache/hadoop/pull/5284#issuecomment-1402000904 @goiri Can you help to merge this pr into the trunk branch? Thank you very much! I will continue to follow up YARN-11222. -- This is an automated message from the Apache Git Service. T

[GitHub] [hadoop] khancon commented on pull request #4572: HADOOP-18330-S3AFileSystem removes Path when calling createS3Client

2023-01-24 Thread via GitHub
khancon commented on PR #4572: URL: https://github.com/apache/hadoop/pull/4572#issuecomment-1402091270 Hi, I would appreciate a response to this question above. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [hadoop] hadoop-yetus commented on pull request #5272: YARN-11217. [Federation] Add dumpSchedulerLogs REST APIs for Router.

2023-01-24 Thread via GitHub
hadoop-yetus commented on PR #5272: URL: https://github.com/apache/hadoop/pull/5272#issuecomment-1402178990 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hchaverri opened a new pull request, #5324: HDFS-16895. NamenodeHeartbeatService should use credentials of logged…

2023-01-24 Thread via GitHub
hchaverri opened a new pull request, #5324: URL: https://github.com/apache/hadoop/pull/5324 … in user ### Description of PR Ensuring that the NamenodeHeartbeatService uses the credentials of the logged in user before calling the JMX API. Without this fix, requests to secur

[GitHub] [hadoop] hchaverri opened a new pull request, #5325: HADOOP-18535. Implement token storage solution based on MySQL

2023-01-24 Thread via GitHub
hchaverri opened a new pull request, #5325: URL: https://github.com/apache/hadoop/pull/5325 ### Description of PR These changes follow the same logic used in the existing ZK based secret manager implementation. 1. Minor changes to DelegationTokenInformation class so it's ea

[GitHub] [hadoop] hadoop-yetus commented on pull request #5324: HDFS-16895. NamenodeHeartbeatService should use credentials of logged…

2023-01-24 Thread via GitHub
hadoop-yetus commented on PR #5324: URL: https://github.com/apache/hadoop/pull/5324#issuecomment-1402586542 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5325: HADOOP-18535. Implement token storage solution based on MySQL

2023-01-24 Thread via GitHub
hadoop-yetus commented on PR #5325: URL: https://github.com/apache/hadoop/pull/5325#issuecomment-1402833279 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] cnauroth merged pull request #5251: HADOOP-18582. skip unnecessary cleanup logic in distcp

2023-01-24 Thread via GitHub
cnauroth merged PR #5251: URL: https://github.com/apache/hadoop/pull/5251 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hado

[GitHub] [hadoop] hadoop-yetus commented on pull request #5321: YARN-11424. [Federation] Router Supports DeregisterSubCluster.

2023-01-24 Thread via GitHub
hadoop-yetus commented on PR #5321: URL: https://github.com/apache/hadoop/pull/5321#issuecomment-1402849275 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5321: YARN-11424. [Federation] Router Supports DeregisterSubCluster.

2023-01-24 Thread via GitHub
hadoop-yetus commented on PR #5321: URL: https://github.com/apache/hadoop/pull/5321#issuecomment-1402852203 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5324: HDFS-16895. NamenodeHeartbeatService should use credentials of logged…

2023-01-24 Thread via GitHub
hadoop-yetus commented on PR #5324: URL: https://github.com/apache/hadoop/pull/5324#issuecomment-1402852609 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5323: HADOOP-18602. Remove netty3 dependency

2023-01-24 Thread via GitHub
hadoop-yetus commented on PR #5323: URL: https://github.com/apache/hadoop/pull/5323#issuecomment-1403084312 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5325: HADOOP-18535. Implement token storage solution based on MySQL

2023-01-24 Thread via GitHub
hadoop-yetus commented on PR #5325: URL: https://github.com/apache/hadoop/pull/5325#issuecomment-1403088440 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] tomscut commented on pull request #5296: HDFS-16888. BlockManager#maxReplicationStreams, replicationStreamsHardLimit, blocksReplWorkMultiplier and PendingReconstructionBlocks#timeout

2023-01-24 Thread via GitHub
tomscut commented on PR #5296: URL: https://github.com/apache/hadoop/pull/5296#issuecomment-1403184129 Hi @haiyang1987 , because this PR is quite old, can you rebase it? Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hadoop] slfan1989 opened a new pull request, #5326: YARN-11425. [Federation] Router Supports SubClusterCleaner.

2023-01-25 Thread via GitHub
slfan1989 opened a new pull request, #5326: URL: https://github.com/apache/hadoop/pull/5326 JIRA: YARN-11425. [Federation] Router Supports SubClusterCleaner. In YARN-Federation mode, once a SubCluster is registered, the SubCluster is always in the RUNNING state, even if the SubCluster

[GitHub] [hadoop] slfan1989 commented on pull request #5244: YARN-11349. [Federation] Router Support DelegationToken With SQL.

2023-01-25 Thread via GitHub
slfan1989 commented on PR #5244: URL: https://github.com/apache/hadoop/pull/5244#issuecomment-1403352045 > SQL Server 2008 R2 Enterprise > select @@version ``` Microsoft SQL Server 2008 R2 (SP3) - 10.50.6000.34 (X64) Aug 19 2014 12:21:34 Copyright (c) Micros

[GitHub] [hadoop] hadoop-yetus commented on pull request #5320: YARN-11416. FS2CS should use CapacitySchedulerConfiguration in FSQueueConverterBuilder

2023-01-25 Thread via GitHub
hadoop-yetus commented on PR #5320: URL: https://github.com/apache/hadoop/pull/5320#issuecomment-1403399970 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] susheel-gupta commented on a diff in pull request #5320: YARN-11416. FS2CS should use CapacitySchedulerConfiguration in FSQueueConverterBuilder

2023-01-25 Thread via GitHub
susheel-gupta commented on code in PR #5320: URL: https://github.com/apache/hadoop/pull/5320#discussion_r1086487425 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/convert

[GitHub] [hadoop] hadoop-yetus commented on pull request #5321: YARN-11424. [Federation] Router Supports DeregisterSubCluster.

2023-01-25 Thread via GitHub
hadoop-yetus commented on PR #5321: URL: https://github.com/apache/hadoop/pull/5321#issuecomment-1403465967 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5326: YARN-11425. [Federation] Router Supports SubClusterCleaner.

2023-01-25 Thread via GitHub
hadoop-yetus commented on PR #5326: URL: https://github.com/apache/hadoop/pull/5326#issuecomment-1403510708 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4967: HDFS-16791 WIP - client protocol and Filesystem apis implemented and …

2023-01-25 Thread via GitHub
hadoop-yetus commented on PR #4967: URL: https://github.com/apache/hadoop/pull/4967#issuecomment-1403526896 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] slfan1989 commented on pull request #5326: YARN-11425. [Federation] Router Supports SubClusterCleaner.

2023-01-25 Thread via GitHub
slfan1989 commented on PR #5326: URL: https://github.com/apache/hadoop/pull/5326#issuecomment-1403569117 @goiri Can you help review this PR? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop] szilard-nemeth commented on pull request #5295: YARN-11404. Add junit5 dependency to hadoop-mapreduce-client-app to fix few unit test failure

2023-01-25 Thread via GitHub
szilard-nemeth commented on PR #5295: URL: https://github.com/apache/hadoop/pull/5295#issuecomment-1403678232 Thanks @susheel-gupta for working on this. Latest patch LGTM, committed to trunk -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [hadoop] szilard-nemeth closed pull request #5295: YARN-11404. Add junit5 dependency to hadoop-mapreduce-client-app to fix few unit test failure

2023-01-25 Thread via GitHub
szilard-nemeth closed pull request #5295: YARN-11404. Add junit5 dependency to hadoop-mapreduce-client-app to fix few unit test failure URL: https://github.com/apache/hadoop/pull/5295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [hadoop] szilard-nemeth commented on pull request #5119: YARN-5607. Document TestContainerResourceUsage#waitForContainerCompletion

2023-01-25 Thread via GitHub
szilard-nemeth commented on PR #5119: URL: https://github.com/apache/hadoop/pull/5119#issuecomment-1403689047 Thanks @susheel-gupta for working on this. Latest patch LGTM, committed to trunk. Thanks @K0K0V0K for the review. -- This is an automated message from the Apache Git Service.

[GitHub] [hadoop] szilard-nemeth closed pull request #5119: YARN-5607. Document TestContainerResourceUsage#waitForContainerCompletion

2023-01-25 Thread via GitHub
szilard-nemeth closed pull request #5119: YARN-5607. Document TestContainerResourceUsage#waitForContainerCompletion URL: https://github.com/apache/hadoop/pull/5119 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [hadoop] hadoop-yetus commented on pull request #5326: YARN-11425. [Federation] Router Supports SubClusterCleaner.

2023-01-25 Thread via GitHub
hadoop-yetus commented on PR #5326: URL: https://github.com/apache/hadoop/pull/5326#issuecomment-1403856616 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] szilard-nemeth commented on pull request #5113: YARN-6971 Clean up different ways to create resources

2023-01-25 Thread via GitHub
szilard-nemeth commented on PR #5113: URL: https://github.com/apache/hadoop/pull/5113#issuecomment-1403888682 Thanks @riyakhdl for working on this. Latest patch LGTM, committed to trunk. Thanks @K0K0V0K and @ashutoshcipher for the reviews. -- This is an automated message from the

[GitHub] [hadoop] szilard-nemeth closed pull request #5113: YARN-6971 Clean up different ways to create resources

2023-01-25 Thread via GitHub
szilard-nemeth closed pull request #5113: YARN-6971 Clean up different ways to create resources URL: https://github.com/apache/hadoop/pull/5113 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [hadoop] ashutoshcipher commented on pull request #4539: HADOOP-17649. Update wildfly openssl to 2.2.1.Final

2023-01-25 Thread via GitHub
ashutoshcipher commented on PR #4539: URL: https://github.com/apache/hadoop/pull/4539#issuecomment-1403934316 > catching up on this. its' too late for 3.3.5, but we can get it into branch-3.3. for the successor. can you rebase? @steveloughran , I have rebased. Please help in review.

[GitHub] [hadoop] ashutoshcipher commented on pull request #5023: MAPREDUCE-7413. Upgrade Junit 4 to 5 in hadoop-mapreduce-client-hs-plugins

2023-01-25 Thread via GitHub
ashutoshcipher commented on PR #5023: URL: https://github.com/apache/hadoop/pull/5023#issuecomment-1403935034 Thanks @aajisaka for review and merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hadoop] mkuchenbecker commented on a diff in pull request #4967: HDFS-16791 WIP - client protocol and Filesystem apis implemented and …

2023-01-25 Thread via GitHub
mkuchenbecker commented on code in PR #4967: URL: https://github.com/apache/hadoop/pull/4967#discussion_r1086894151 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFs.java: ## @@ -1477,5 +1478,18 @@ public void setStoragePolicy(Path path, Str

[GitHub] [hadoop] szilard-nemeth commented on a diff in pull request #5317: YARN-11420 Stabilize TestNMClient

2023-01-25 Thread via GitHub
szilard-nemeth commented on code in PR #5317: URL: https://github.com/apache/hadoop/pull/5317#discussion_r1086928113 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java: ## @@ -456,6 +456

[GitHub] [hadoop] szilard-nemeth commented on pull request #5317: YARN-11420 Stabilize TestNMClient

2023-01-25 Thread via GitHub
szilard-nemeth commented on PR #5317: URL: https://github.com/apache/hadoop/pull/5317#issuecomment-1404008860 @K0K0V0K I will go through the changes in TestNMClient tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hadoop] jojochuang commented on a diff in pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

2023-01-25 Thread via GitHub
jojochuang commented on code in PR #5315: URL: https://github.com/apache/hadoop/pull/5315#discussion_r1087030863 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java: ## @@ -360,7 +358,8 @@ public class DataNode extends Reconfigur

[GitHub] [hadoop] mccormickt12 commented on a diff in pull request #4967: HDFS-16791 WIP - client protocol and Filesystem apis implemented and …

2023-01-25 Thread via GitHub
mccormickt12 commented on code in PR #4967: URL: https://github.com/apache/hadoop/pull/4967#discussion_r1087062926 ## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractContractGetEnclosingRoot.java: ## @@ -0,0 +1,100 @@ +/** + * Licensed to

[GitHub] [hadoop] mccormickt12 commented on a diff in pull request #4967: HDFS-16791 WIP - client protocol and Filesystem apis implemented and …

2023-01-25 Thread via GitHub
mccormickt12 commented on code in PR #4967: URL: https://github.com/apache/hadoop/pull/4967#discussion_r1087063872 ## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractContractGetEnclosingRoot.java: ## @@ -0,0 +1,100 @@ +/** + * Licensed to

[GitHub] [hadoop] mccormickt12 commented on a diff in pull request #4967: HDFS-16791 WIP - client protocol and Filesystem apis implemented and …

2023-01-25 Thread via GitHub
mccormickt12 commented on code in PR #4967: URL: https://github.com/apache/hadoop/pull/4967#discussion_r1087064216 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFs.java: ## @@ -1477,5 +1478,18 @@ public void setStoragePolicy(Path path, Stri

[GitHub] [hadoop] mccormickt12 commented on a diff in pull request #4967: HDFS-16791 WIP - client protocol and Filesystem apis implemented and …

2023-01-25 Thread via GitHub
mccormickt12 commented on code in PR #4967: URL: https://github.com/apache/hadoop/pull/4967#discussion_r1087065955 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestEnclosingRoot.java: ## @@ -92,11 +92,14 @@ protected void setProvider() { @After

[GitHub] [hadoop] mccormickt12 commented on a diff in pull request #4967: HDFS-16791 WIP - client protocol and Filesystem apis implemented and …

2023-01-25 Thread via GitHub
mccormickt12 commented on code in PR #4967: URL: https://github.com/apache/hadoop/pull/4967#discussion_r1087067420 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java: ## @@ -4917,7 +4917,6 @@ public CompletableFuture build() throws IOExcep

[GitHub] [hadoop] mccormickt12 commented on a diff in pull request #4967: HDFS-16791 WIP - client protocol and Filesystem apis implemented and …

2023-01-25 Thread via GitHub
mccormickt12 commented on code in PR #4967: URL: https://github.com/apache/hadoop/pull/4967#discussion_r1087071885 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFs.java: ## @@ -1477,5 +1478,18 @@ public void setStoragePolicy(Path path, Stri

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

2023-01-25 Thread via GitHub
virajjasani commented on code in PR #5315: URL: https://github.com/apache/hadoop/pull/5315#discussion_r1087096464 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java: ## @@ -360,7 +358,8 @@ public class DataNode extends Reconfigu

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

2023-01-25 Thread via GitHub
virajjasani commented on code in PR #5315: URL: https://github.com/apache/hadoop/pull/5315#discussion_r1087115942 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/LogAdapter.java: ## @@ -17,62 +17,34 @@ */ package org.apache.hadoop.util; -import o

[GitHub] [hadoop] 9uapaw commented on a diff in pull request #3470: YARN-10965. Centralize queue resource calculation based on CapacityVectors

2023-01-25 Thread via GitHub
9uapaw commented on code in PR #3470: URL: https://github.com/apache/hadoop/pull/3470#discussion_r1087132529 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacitySc

[GitHub] [hadoop] 9uapaw commented on a diff in pull request #3470: YARN-10965. Centralize queue resource calculation based on CapacityVectors

2023-01-25 Thread via GitHub
9uapaw commented on code in PR #3470: URL: https://github.com/apache/hadoop/pull/3470#discussion_r1087133894 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacitySc

[GitHub] [hadoop] hadoop-yetus commented on pull request #5244: YARN-11349. [Federation] Router Support DelegationToken With SQL.

2023-01-25 Thread via GitHub
hadoop-yetus commented on PR #5244: URL: https://github.com/apache/hadoop/pull/5244#issuecomment-1404267749 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5325: HADOOP-18535. Implement token storage solution based on MySQL

2023-01-25 Thread via GitHub
hadoop-yetus commented on PR #5325: URL: https://github.com/apache/hadoop/pull/5325#issuecomment-1404269165 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5325: HADOOP-18535. Implement token storage solution based on MySQL

2023-01-25 Thread via GitHub
hadoop-yetus commented on PR #5325: URL: https://github.com/apache/hadoop/pull/5325#issuecomment-1404294389 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #3470: YARN-10965. Centralize queue resource calculation based on CapacityVectors

2023-01-25 Thread via GitHub
hadoop-yetus commented on PR #3470: URL: https://github.com/apache/hadoop/pull/3470#issuecomment-1404405227 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5216: HDFS-16864. Drop cache behind entire block on close

2023-01-25 Thread via GitHub
hadoop-yetus commented on PR #5216: URL: https://github.com/apache/hadoop/pull/5216#issuecomment-1404497942 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5204: HDFS-16864. Drop cache behind entire block on close

2023-01-25 Thread via GitHub
hadoop-yetus commented on PR #5204: URL: https://github.com/apache/hadoop/pull/5204#issuecomment-1404561494 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5322: HDFS-16896 clear ignoredNodes list when we clear deadnode list on ref…

2023-01-26 Thread via GitHub
hadoop-yetus commented on PR #5322: URL: https://github.com/apache/hadoop/pull/5322#issuecomment-1404685864 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4967: HDFS-16791 WIP - client protocol and Filesystem apis implemented and …

2023-01-26 Thread via GitHub
hadoop-yetus commented on PR #4967: URL: https://github.com/apache/hadoop/pull/4967#issuecomment-1404723829 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4539: HADOOP-17649. Update wildfly openssl to 2.2.1.Final

2023-01-26 Thread via GitHub
hadoop-yetus commented on PR #4539: URL: https://github.com/apache/hadoop/pull/4539#issuecomment-1404838245 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] p-szucs commented on a diff in pull request #5320: YARN-11416. FS2CS should use CapacitySchedulerConfiguration in FSQueueConverterBuilder

2023-01-26 Thread via GitHub
p-szucs commented on code in PR #5320: URL: https://github.com/apache/hadoop/pull/5320#discussion_r1087762346 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/converter/Tes

[GitHub] [hadoop] p-szucs commented on a diff in pull request #5320: YARN-11416. FS2CS should use CapacitySchedulerConfiguration in FSQueueConverterBuilder

2023-01-26 Thread via GitHub
p-szucs commented on code in PR #5320: URL: https://github.com/apache/hadoop/pull/5320#discussion_r1087764208 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/converter/Tes

[GitHub] [hadoop] p-szucs commented on a diff in pull request #5320: YARN-11416. FS2CS should use CapacitySchedulerConfiguration in FSQueueConverterBuilder

2023-01-26 Thread via GitHub
p-szucs commented on code in PR #5320: URL: https://github.com/apache/hadoop/pull/5320#discussion_r1087762346 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/converter/Tes

[GitHub] [hadoop] hadoop-yetus commented on pull request #4967: HDFS-16791 WIP - client protocol and Filesystem apis implemented and …

2023-01-26 Thread via GitHub
hadoop-yetus commented on PR #4967: URL: https://github.com/apache/hadoop/pull/4967#issuecomment-1404910003 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] p-szucs commented on a diff in pull request #5320: YARN-11416. FS2CS should use CapacitySchedulerConfiguration in FSQueueConverterBuilder

2023-01-26 Thread via GitHub
p-szucs commented on code in PR #5320: URL: https://github.com/apache/hadoop/pull/5320#discussion_r1087770675 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/converter/Tes

[GitHub] [hadoop] p-szucs commented on a diff in pull request #5320: YARN-11416. FS2CS should use CapacitySchedulerConfiguration in FSQueueConverterBuilder

2023-01-26 Thread via GitHub
p-szucs commented on code in PR #5320: URL: https://github.com/apache/hadoop/pull/5320#discussion_r1087778061 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/converter/Tes

[GitHub] [hadoop] p-szucs commented on a diff in pull request #5320: YARN-11416. FS2CS should use CapacitySchedulerConfiguration in FSQueueConverterBuilder

2023-01-26 Thread via GitHub
p-szucs commented on code in PR #5320: URL: https://github.com/apache/hadoop/pull/5320#discussion_r1087784312 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/converter/Tes

[GitHub] [hadoop] p-szucs commented on a diff in pull request #5320: YARN-11416. FS2CS should use CapacitySchedulerConfiguration in FSQueueConverterBuilder

2023-01-26 Thread via GitHub
p-szucs commented on code in PR #5320: URL: https://github.com/apache/hadoop/pull/5320#discussion_r1087785053 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/converter/Tes

[GitHub] [hadoop] p-szucs commented on pull request #5320: YARN-11416. FS2CS should use CapacitySchedulerConfiguration in FSQueueConverterBuilder

2023-01-26 Thread via GitHub
p-szucs commented on PR #5320: URL: https://github.com/apache/hadoop/pull/5320#issuecomment-1404951874 I added some comments where I saw further possibilities for using the convenience get methods beside the fixed ones. I also saw that there are some config settings in the FsQueueConverter

[GitHub] [hadoop] hadoop-yetus commented on pull request #3618: YARN-11000. Replace queue resource calculation logic in updateClusterResource

2023-01-26 Thread via GitHub
hadoop-yetus commented on PR #3618: URL: https://github.com/apache/hadoop/pull/3618#issuecomment-1405017142 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] szilard-nemeth commented on a diff in pull request #3470: YARN-10965. Centralize queue resource calculation based on CapacityVectors

2023-01-26 Thread via GitHub
szilard-nemeth commented on code in PR #3470: URL: https://github.com/apache/hadoop/pull/3470#discussion_r1087885157 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/Ca

  1   2   3   4   5   6   7   8   9   10   >