[jira] [Commented] (HADOOP-14670) Increase minimum cmake version for all platforms
[ https://issues.apache.org/jira/browse/HADOOP-14670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168714#comment-16168714 ] Allen Wittenauer commented on HADOOP-14670: --- Opened HADOOP-14873 > Increase minimum cmake version for all platforms > > > Key: HADOOP-14670 > URL: https://issues.apache.org/jira/browse/HADOOP-14670 > Project: Hadoop Common > Issue Type: Improvement > Components: build >Affects Versions: 3.0.0-beta1 >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer > Fix For: 3.0.0-beta1 > > Attachments: HADOOP-14670.00.patch, HADOOP-14670.01.patch, > HADOOP-14670.02.patch, HADOOP-14670.03.patch > > > cmake 2.6 is old at this point and I'd be greatly surprised if anyone is > actually using it or testing against it. It's probably time to upgrade to > something approaching modern. Plus: > * Mac OS X already requires 3.0 > * If HADOOP-14667 gets committed, Windows bumps to 3.1 > * There is special handling in at least one CMakeLists.txt for versions less > than 3.1 > Given the last two points, I'd propose making the minimum 3.1, if not > something higher due to compiler support for newer compilers across all > platforms. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14670) Increase minimum cmake version for all platforms
[ https://issues.apache.org/jira/browse/HADOOP-14670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168713#comment-16168713 ] Wangda Tan commented on HADOOP-14670: - Sure, let's move discussion to a new JIRA for this. > Increase minimum cmake version for all platforms > > > Key: HADOOP-14670 > URL: https://issues.apache.org/jira/browse/HADOOP-14670 > Project: Hadoop Common > Issue Type: Improvement > Components: build >Affects Versions: 3.0.0-beta1 >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer > Fix For: 3.0.0-beta1 > > Attachments: HADOOP-14670.00.patch, HADOOP-14670.01.patch, > HADOOP-14670.02.patch, HADOOP-14670.03.patch > > > cmake 2.6 is old at this point and I'd be greatly surprised if anyone is > actually using it or testing against it. It's probably time to upgrade to > something approaching modern. Plus: > * Mac OS X already requires 3.0 > * If HADOOP-14667 gets committed, Windows bumps to 3.1 > * There is special handling in at least one CMakeLists.txt for versions less > than 3.1 > Given the last two points, I'd propose making the minimum 3.1, if not > something higher due to compiler support for newer compilers across all > platforms. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14670) Increase minimum cmake version for all platforms
[ https://issues.apache.org/jira/browse/HADOOP-14670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168710#comment-16168710 ] Allen Wittenauer commented on HADOOP-14670: --- At this point, we need to open a *new* JIRA for this. > Increase minimum cmake version for all platforms > > > Key: HADOOP-14670 > URL: https://issues.apache.org/jira/browse/HADOOP-14670 > Project: Hadoop Common > Issue Type: Improvement > Components: build >Affects Versions: 3.0.0-beta1 >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer > Fix For: 3.0.0-beta1 > > Attachments: HADOOP-14670.00.patch, HADOOP-14670.01.patch, > HADOOP-14670.02.patch, HADOOP-14670.03.patch > > > cmake 2.6 is old at this point and I'd be greatly surprised if anyone is > actually using it or testing against it. It's probably time to upgrade to > something approaching modern. Plus: > * Mac OS X already requires 3.0 > * If HADOOP-14667 gets committed, Windows bumps to 3.1 > * There is special handling in at least one CMakeLists.txt for versions less > than 3.1 > Given the last two points, I'd propose making the minimum 3.1, if not > something higher due to compiler support for newer compilers across all > platforms. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14670) Increase minimum cmake version for all platforms
[ https://issues.apache.org/jira/browse/HADOOP-14670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168704#comment-16168704 ] Allen Wittenauer commented on HADOOP-14670: --- === test-gpu-module.cc === Um, that's not getting built by a C compiler. So whoever added that code pretty much broke the universe by requiring a C++ compiler and not setting the appropriate flags. > Increase minimum cmake version for all platforms > > > Key: HADOOP-14670 > URL: https://issues.apache.org/jira/browse/HADOOP-14670 > Project: Hadoop Common > Issue Type: Improvement > Components: build >Affects Versions: 3.0.0-beta1 >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer > Fix For: 3.0.0-beta1 > > Attachments: HADOOP-14670.00.patch, HADOOP-14670.01.patch, > HADOOP-14670.02.patch, HADOOP-14670.03.patch > > > cmake 2.6 is old at this point and I'd be greatly surprised if anyone is > actually using it or testing against it. It's probably time to upgrade to > something approaching modern. Plus: > * Mac OS X already requires 3.0 > * If HADOOP-14667 gets committed, Windows bumps to 3.1 > * There is special handling in at least one CMakeLists.txt for versions less > than 3.1 > Given the last two points, I'd propose making the minimum 3.1, if not > something higher due to compiler support for newer compilers across all > platforms. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14670) Increase minimum cmake version for all platforms
[ https://issues.apache.org/jira/browse/HADOOP-14670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168697#comment-16168697 ] Wangda Tan commented on HADOOP-14670: - I want to check if the macro takes effect or not, so I set it to old standard to see will it cause build failure or not. Not sure if I have any misunderstandings of the macro. > Increase minimum cmake version for all platforms > > > Key: HADOOP-14670 > URL: https://issues.apache.org/jira/browse/HADOOP-14670 > Project: Hadoop Common > Issue Type: Improvement > Components: build >Affects Versions: 3.0.0-beta1 >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer > Fix For: 3.0.0-beta1 > > Attachments: HADOOP-14670.00.patch, HADOOP-14670.01.patch, > HADOOP-14670.02.patch, HADOOP-14670.03.patch > > > cmake 2.6 is old at this point and I'd be greatly surprised if anyone is > actually using it or testing against it. It's probably time to upgrade to > something approaching modern. Plus: > * Mac OS X already requires 3.0 > * If HADOOP-14667 gets committed, Windows bumps to 3.1 > * There is special handling in at least one CMakeLists.txt for versions less > than 3.1 > Given the last two points, I'd propose making the minimum 3.1, if not > something higher due to compiler support for newer compilers across all > platforms. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14670) Increase minimum cmake version for all platforms
[ https://issues.apache.org/jira/browse/HADOOP-14670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168689#comment-16168689 ] Allen Wittenauer commented on HADOOP-14670: --- bq. set (CMAKE_C_STANDARD 90) What did you expect this to do? > Increase minimum cmake version for all platforms > > > Key: HADOOP-14670 > URL: https://issues.apache.org/jira/browse/HADOOP-14670 > Project: Hadoop Common > Issue Type: Improvement > Components: build >Affects Versions: 3.0.0-beta1 >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer > Fix For: 3.0.0-beta1 > > Attachments: HADOOP-14670.00.patch, HADOOP-14670.01.patch, > HADOOP-14670.02.patch, HADOOP-14670.03.patch > > > cmake 2.6 is old at this point and I'd be greatly surprised if anyone is > actually using it or testing against it. It's probably time to upgrade to > something approaching modern. Plus: > * Mac OS X already requires 3.0 > * If HADOOP-14667 gets committed, Windows bumps to 3.1 > * There is special handling in at least one CMakeLists.txt for versions less > than 3.1 > Given the last two points, I'd propose making the minimum 3.1, if not > something higher due to compiler support for newer compilers across all > platforms. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14670) Increase minimum cmake version for all platforms
[
https://issues.apache.org/jira/browse/HADOOP-14670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168683#comment-16168683
]
Wangda Tan commented on HADOOP-14670:
-
[~aw] / [~chris.douglas],
I just checked changes of this JIRA doesn't relate to issues I saw, I tried to
revert this patch but issue is still the same.
{color:red}It seems the {{set (CMAKE_C_STANDARD)}} doesn't work for the
nodemanager project.
{color}
I hardcoded to change {{set (CMAKE_C_STANDARD 99)}} to {{set (CMAKE_C_STANDARD
90)}} in nodemanager project.
I tried on two different environment:
1) Centos 6, cmake version 3.1.0, gcc 4.4.7
For both 99/90 standard, all fail.
2) OSX v10.12.4, cmake version 3.5.2, cc = "Apple LLVM version 8.1.0
(clang-802.0.42)".
For both 99/90 standard, all succeeded.
At least for the for loop in gpu-module.c is C99 only:
{code}
for (int i = 0; i < n_minor_devices_to_block; i++) {
// ...
}
{code}
Could you share some thoughts?
Thanks,
> Increase minimum cmake version for all platforms
>
>
> Key: HADOOP-14670
> URL: https://issues.apache.org/jira/browse/HADOOP-14670
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
>Affects Versions: 3.0.0-beta1
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
> Fix For: 3.0.0-beta1
>
> Attachments: HADOOP-14670.00.patch, HADOOP-14670.01.patch,
> HADOOP-14670.02.patch, HADOOP-14670.03.patch
>
>
> cmake 2.6 is old at this point and I'd be greatly surprised if anyone is
> actually using it or testing against it. It's probably time to upgrade to
> something approaching modern. Plus:
> * Mac OS X already requires 3.0
> * If HADOOP-14667 gets committed, Windows bumps to 3.1
> * There is special handling in at least one CMakeLists.txt for versions less
> than 3.1
> Given the last two points, I'd propose making the minimum 3.1, if not
> something higher due to compiler support for newer compilers across all
> platforms.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14670) Increase minimum cmake version for all platforms
[
https://issues.apache.org/jira/browse/HADOOP-14670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168571#comment-16168571
]
Allen Wittenauer commented on HADOOP-14670:
---
It's basically:
{code}
if(CMAKE_VERSION VERSION_LESS 3.1)
message( FATAL_ERROR "Your CMake version is so old, it ran on a VIC-20." )
endif()
{code}
or whatever.
> Increase minimum cmake version for all platforms
>
>
> Key: HADOOP-14670
> URL: https://issues.apache.org/jira/browse/HADOOP-14670
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
>Affects Versions: 3.0.0-beta1
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
> Fix For: 3.0.0-beta1
>
> Attachments: HADOOP-14670.00.patch, HADOOP-14670.01.patch,
> HADOOP-14670.02.patch, HADOOP-14670.03.patch
>
>
> cmake 2.6 is old at this point and I'd be greatly surprised if anyone is
> actually using it or testing against it. It's probably time to upgrade to
> something approaching modern. Plus:
> * Mac OS X already requires 3.0
> * If HADOOP-14667 gets committed, Windows bumps to 3.1
> * There is special handling in at least one CMakeLists.txt for versions less
> than 3.1
> Given the last two points, I'd propose making the minimum 3.1, if not
> something higher due to compiler support for newer compilers across all
> platforms.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14670) Increase minimum cmake version for all platforms
[ https://issues.apache.org/jira/browse/HADOOP-14670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168569#comment-16168569 ] Chris Douglas commented on HADOOP-14670: For simplicity of tracking, let's move this to a followup JIRA. Forcing failure for versions less than 3.1 will just add a few lines. No reason to add reverts or double-commits to the history. > Increase minimum cmake version for all platforms > > > Key: HADOOP-14670 > URL: https://issues.apache.org/jira/browse/HADOOP-14670 > Project: Hadoop Common > Issue Type: Improvement > Components: build >Affects Versions: 3.0.0-beta1 >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer > Fix For: 3.0.0-beta1 > > Attachments: HADOOP-14670.00.patch, HADOOP-14670.01.patch, > HADOOP-14670.02.patch, HADOOP-14670.03.patch > > > cmake 2.6 is old at this point and I'd be greatly surprised if anyone is > actually using it or testing against it. It's probably time to upgrade to > something approaching modern. Plus: > * Mac OS X already requires 3.0 > * If HADOOP-14667 gets committed, Windows bumps to 3.1 > * There is special handling in at least one CMakeLists.txt for versions less > than 3.1 > Given the last two points, I'd propose making the minimum 3.1, if not > something higher due to compiler support for newer compilers across all > platforms. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14670) Increase minimum cmake version for all platforms
[ https://issues.apache.org/jira/browse/HADOOP-14670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168559#comment-16168559 ] Wangda Tan commented on HADOOP-14670: - Thanks comments [~aw]/[~chris.douglas], I will investigate on my local build environment to see what's the best option. Downgrading priority to major. > Increase minimum cmake version for all platforms > > > Key: HADOOP-14670 > URL: https://issues.apache.org/jira/browse/HADOOP-14670 > Project: Hadoop Common > Issue Type: Improvement > Components: build >Affects Versions: 3.0.0-beta1 >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer >Priority: Blocker > Fix For: 3.0.0-beta1 > > Attachments: HADOOP-14670.00.patch, HADOOP-14670.01.patch, > HADOOP-14670.02.patch, HADOOP-14670.03.patch > > > cmake 2.6 is old at this point and I'd be greatly surprised if anyone is > actually using it or testing against it. It's probably time to upgrade to > something approaching modern. Plus: > * Mac OS X already requires 3.0 > * If HADOOP-14667 gets committed, Windows bumps to 3.1 > * There is special handling in at least one CMakeLists.txt for versions less > than 3.1 > Given the last two points, I'd propose making the minimum 3.1, if not > something higher due to compiler support for newer compilers across all > platforms. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14670) Increase minimum cmake version for all platforms
[ https://issues.apache.org/jira/browse/HADOOP-14670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168558#comment-16168558 ] Allen Wittenauer commented on HADOOP-14670: --- bq. What C standard does cmake use if this is isn't fatal? Whatever the compiler defaults to. bq. It might be hard for users to debug, if they don't get a clear error message using old tooling... Welcome to native compilation, regardless of the project. ;) bq. Would it be too pedantic to add an explicit failure directive? This could be a followup JIRA, though. A follow-up JIRA is the way to do this. It's like 4 lines of code in HadoopCommon.cmake. (I think everything imports that now.) > Increase minimum cmake version for all platforms > > > Key: HADOOP-14670 > URL: https://issues.apache.org/jira/browse/HADOOP-14670 > Project: Hadoop Common > Issue Type: Improvement > Components: build >Affects Versions: 3.0.0-beta1 >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer >Priority: Blocker > Fix For: 3.0.0-beta1 > > Attachments: HADOOP-14670.00.patch, HADOOP-14670.01.patch, > HADOOP-14670.02.patch, HADOOP-14670.03.patch > > > cmake 2.6 is old at this point and I'd be greatly surprised if anyone is > actually using it or testing against it. It's probably time to upgrade to > something approaching modern. Plus: > * Mac OS X already requires 3.0 > * If HADOOP-14667 gets committed, Windows bumps to 3.1 > * There is special handling in at least one CMakeLists.txt for versions less > than 3.1 > Given the last two points, I'd propose making the minimum 3.1, if not > something higher due to compiler support for newer compilers across all > platforms. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14670) Increase minimum cmake version for all platforms
[ https://issues.apache.org/jira/browse/HADOOP-14670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168554#comment-16168554 ] Chris Douglas commented on HADOOP-14670: What C standard does cmake use if this is isn't fatal? YARN-5719 was trying to make sure we picked something. It might be hard for users to debug, if they don't get a clear error message using old tooling... Would it be too pedantic to add an explicit failure directive? This could be a followup JIRA, though. > Increase minimum cmake version for all platforms > > > Key: HADOOP-14670 > URL: https://issues.apache.org/jira/browse/HADOOP-14670 > Project: Hadoop Common > Issue Type: Improvement > Components: build >Affects Versions: 3.0.0-beta1 >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer >Priority: Blocker > Fix For: 3.0.0-beta1 > > Attachments: HADOOP-14670.00.patch, HADOOP-14670.01.patch, > HADOOP-14670.02.patch, HADOOP-14670.03.patch > > > cmake 2.6 is old at this point and I'd be greatly surprised if anyone is > actually using it or testing against it. It's probably time to upgrade to > something approaching modern. Plus: > * Mac OS X already requires 3.0 > * If HADOOP-14667 gets committed, Windows bumps to 3.1 > * There is special handling in at least one CMakeLists.txt for versions less > than 3.1 > Given the last two points, I'd propose making the minimum 3.1, if not > something higher due to compiler support for newer compilers across all > platforms. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14670) Increase minimum cmake version for all platforms
[ https://issues.apache.org/jira/browse/HADOOP-14670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168522#comment-16168522 ] Allen Wittenauer commented on HADOOP-14670: --- Given that the compile will fail either way, does it matter? > Increase minimum cmake version for all platforms > > > Key: HADOOP-14670 > URL: https://issues.apache.org/jira/browse/HADOOP-14670 > Project: Hadoop Common > Issue Type: Improvement > Components: build >Affects Versions: 3.0.0-beta1 >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer >Priority: Blocker > Fix For: 3.0.0-beta1 > > Attachments: HADOOP-14670.00.patch, HADOOP-14670.01.patch, > HADOOP-14670.02.patch, HADOOP-14670.03.patch > > > cmake 2.6 is old at this point and I'd be greatly surprised if anyone is > actually using it or testing against it. It's probably time to upgrade to > something approaching modern. Plus: > * Mac OS X already requires 3.0 > * If HADOOP-14667 gets committed, Windows bumps to 3.1 > * There is special handling in at least one CMakeLists.txt for versions less > than 3.1 > Given the last two points, I'd propose making the minimum 3.1, if not > something higher due to compiler support for newer compilers across all > platforms. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14670) Increase minimum cmake version for all platforms
[
https://issues.apache.org/jira/browse/HADOOP-14670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168517#comment-16168517
]
Wangda Tan commented on HADOOP-14670:
-
[~aw], we just saw issue of building trunk includes this patch has compilation
issue. (succeeded in centos 7 but failed in centos 7).
According to
https://cmake.org/cmake/help/v3.0/command/cmake_minimum_required.html, FATAL
parameter ignored by cmake with newer version.
Failure message looks like:
{code}
[WARNING]
.../hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/modules/gpu/gpu-module.c:107:
error: ‘for’ loop initial declarations are only allowed in C99 mode
{code}
It looks like we need to either find a better way to fail build with lower
versioned cmake, or we need to add set C99 macros back.
> Increase minimum cmake version for all platforms
>
>
> Key: HADOOP-14670
> URL: https://issues.apache.org/jira/browse/HADOOP-14670
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
>Affects Versions: 3.0.0-beta1
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Blocker
> Fix For: 3.0.0-beta1
>
> Attachments: HADOOP-14670.00.patch, HADOOP-14670.01.patch,
> HADOOP-14670.02.patch, HADOOP-14670.03.patch
>
>
> cmake 2.6 is old at this point and I'd be greatly surprised if anyone is
> actually using it or testing against it. It's probably time to upgrade to
> something approaching modern. Plus:
> * Mac OS X already requires 3.0
> * If HADOOP-14667 gets committed, Windows bumps to 3.1
> * There is special handling in at least one CMakeLists.txt for versions less
> than 3.1
> Given the last two points, I'd propose making the minimum 3.1, if not
> something higher due to compiler support for newer compilers across all
> platforms.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14670) Increase minimum cmake version for all platforms
[ https://issues.apache.org/jira/browse/HADOOP-14670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148452#comment-16148452 ] Hudson commented on HADOOP-14670: - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12281 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/12281/]) HADOOP-14670. Increase minimum cmake version for all platforms (aw: rev 71bbb86d69ac474596f5619d22718e9f7ff5f9dc) * (edit) dev-support/docker/Dockerfile * (edit) hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/fuse-dfs/CMakeLists.txt * (edit) hadoop-common-project/hadoop-common/HadoopCommon.cmake * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/CMakeLists.txt * (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/CMakeLists.txt * (edit) start-build-env.sh * (edit) BUILDING.txt * (edit) hadoop-tools/hadoop-pipes/src/CMakeLists.txt * (edit) hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/compress/bzip2/org_apache_hadoop_io_compress_bzip2.h * (edit) hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfs/CMakeLists.txt * (edit) hadoop-hdfs-project/hadoop-hdfs-native-client/src/CMakeLists.txt * (edit) hadoop-maven-plugins/src/main/java/org/apache/hadoop/maven/plugin/cmakebuilder/CompileMojo.java * (edit) hadoop-common-project/hadoop-common/src/CMakeLists.txt * (edit) hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfs-tests/CMakeLists.txt > Increase minimum cmake version for all platforms > > > Key: HADOOP-14670 > URL: https://issues.apache.org/jira/browse/HADOOP-14670 > Project: Hadoop Common > Issue Type: Improvement > Components: build >Affects Versions: 3.0.0-beta1 >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer > Fix For: 3.0.0-beta1 > > Attachments: HADOOP-14670.00.patch, HADOOP-14670.01.patch, > HADOOP-14670.02.patch, HADOOP-14670.03.patch > > > cmake 2.6 is old at this point and I'd be greatly surprised if anyone is > actually using it or testing against it. It's probably time to upgrade to > something approaching modern. Plus: > * Mac OS X already requires 3.0 > * If HADOOP-14667 gets committed, Windows bumps to 3.1 > * There is special handling in at least one CMakeLists.txt for versions less > than 3.1 > Given the last two points, I'd propose making the minimum 3.1, if not > something higher due to compiler support for newer compilers across all > platforms. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14670) Increase minimum cmake version for all platforms
[ https://issues.apache.org/jira/browse/HADOOP-14670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148259#comment-16148259 ] Chris Douglas commented on HADOOP-14670: Checked that this removed YARN-5719, which this makes redundant. +1 skimmed the patch and lgtm. > Increase minimum cmake version for all platforms > > > Key: HADOOP-14670 > URL: https://issues.apache.org/jira/browse/HADOOP-14670 > Project: Hadoop Common > Issue Type: Improvement > Components: build >Affects Versions: 3.0.0-beta1 >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer > Attachments: HADOOP-14670.00.patch, HADOOP-14670.01.patch, > HADOOP-14670.02.patch, HADOOP-14670.03.patch > > > cmake 2.6 is old at this point and I'd be greatly surprised if anyone is > actually using it or testing against it. It's probably time to upgrade to > something approaching modern. Plus: > * Mac OS X already requires 3.0 > * If HADOOP-14667 gets committed, Windows bumps to 3.1 > * There is special handling in at least one CMakeLists.txt for versions less > than 3.1 > Given the last two points, I'd propose making the minimum 3.1, if not > something higher due to compiler support for newer compilers across all > platforms. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14670) Increase minimum cmake version for all platforms
[ https://issues.apache.org/jira/browse/HADOOP-14670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148159#comment-16148159 ] Allen Wittenauer commented on HADOOP-14670: --- HADOOP-14816 has nearly the same Dockerfile changes. > Increase minimum cmake version for all platforms > > > Key: HADOOP-14670 > URL: https://issues.apache.org/jira/browse/HADOOP-14670 > Project: Hadoop Common > Issue Type: Improvement > Components: build >Affects Versions: 3.0.0-beta1 >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer > Attachments: HADOOP-14670.00.patch, HADOOP-14670.01.patch, > HADOOP-14670.02.patch, HADOOP-14670.03.patch > > > cmake 2.6 is old at this point and I'd be greatly surprised if anyone is > actually using it or testing against it. It's probably time to upgrade to > something approaching modern. Plus: > * Mac OS X already requires 3.0 > * If HADOOP-14667 gets committed, Windows bumps to 3.1 > * There is special handling in at least one CMakeLists.txt for versions less > than 3.1 > Given the last two points, I'd propose making the minimum 3.1, if not > something higher due to compiler support for newer compilers across all > platforms. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14670) Increase minimum cmake version for all platforms
[
https://issues.apache.org/jira/browse/HADOOP-14670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148106#comment-16148106
]
Hadoop QA commented on HADOOP-14670:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 15m
12s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
28s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 20m
36s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 22m
22s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
42s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 16m
55s{color} | {color:green} trunk passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-tools/hadoop-pipes .
{color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m
21s{color} | {color:red}
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
in trunk has 1 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 7m
37s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
24s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 23m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 17m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 17m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 17m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 16m
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
0s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} shelldocs {color} | {color:green} 0m
11s{color} | {color:green} There were no new shelldocs issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-tools/hadoop-pipes .
{color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 7m
35s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 18m 12s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
49s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}208m 32s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.fs.viewfs.TestViewFileSystemWithAuthorityLocalFileSystem |
| | hadoop.net.TestDNS |
| | hadoop.security.TestRaceWhenRelogin |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:14b5c93 |
| JIRA Issue | HADOOP-14670 |
| JIRA
[jira] [Commented] (HADOOP-14670) Increase minimum cmake version for all platforms
[
https://issues.apache.org/jira/browse/HADOOP-14670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148104#comment-16148104
]
Hadoop QA commented on HADOOP-14670:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 25m
59s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
22s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 20m
26s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 22m
19s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
43s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 16m
59s{color} | {color:green} trunk passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-tools/hadoop-pipes .
{color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m
23s{color} | {color:red}
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
in trunk has 1 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 7m
37s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
27s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 23m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 17m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 17m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 17m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 16m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
0s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} shelldocs {color} | {color:green} 0m
10s{color} | {color:green} There were no new shelldocs issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-tools/hadoop-pipes .
{color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 7m
42s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 17m 50s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
49s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}218m 12s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.security.TestRaceWhenRelogin |
| | hadoop.ipc.TestIPC |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:14b5c93 |
| JIRA Issue | HADOOP-14670 |
| JIRA Patch URL |
[jira] [Commented] (HADOOP-14670) Increase minimum cmake version for all platforms
[
https://issues.apache.org/jira/browse/HADOOP-14670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147803#comment-16147803
]
Hadoop QA commented on HADOOP-14670:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 16m
35s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
20s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 13m
38s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 14m
52s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 11m
22s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
19s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 16m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 11m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 11m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 11m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 11m
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
0s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} shelldocs {color} | {color:green} 0m
9s{color} | {color:green} There were no new shelldocs issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 14m 22s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
35s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}112m 36s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.security.TestKDiag |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:14b5c93 |
| JIRA Issue | HADOOP-14670 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12884507/HADOOP-14670.01.patch
|
| Optional Tests | asflicense shellcheck shelldocs compile cc mvnsite
javac unit |
| uname | Linux bc58d494d31c 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7
11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / a20e710 |
| Default Java | 1.8.0_144 |
| shellcheck | v0.4.6 |
| unit |
https://builds.apache.org/job/PreCommit-HADOOP-Build/13135/artifact/patchprocess/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/13135/testReport/ |
| modules | C: hadoop-common-project/hadoop-common
hadoop-hdfs-project/hadoop-hdfs-native-client
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask
hadoop-tools/hadoop-pipes . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/13135/console |
| Powered by | Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Increase minimum cmake version for all platforms
>
>
> Key: HADOOP-14670
> URL: https://issues.apache.org/jira/browse/HADOOP-14670
> Project: Hadoop
[jira] [Commented] (HADOOP-14670) Increase minimum cmake version for all platforms
[ https://issues.apache.org/jira/browse/HADOOP-14670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147744#comment-16147744 ] Hadoop QA commented on HADOOP-14670: (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/PreCommit-HADOOP-Build/13137/console in case of problems. > Increase minimum cmake version for all platforms > > > Key: HADOOP-14670 > URL: https://issues.apache.org/jira/browse/HADOOP-14670 > Project: Hadoop Common > Issue Type: Improvement > Components: build >Affects Versions: 3.0.0-beta1 >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer > Attachments: HADOOP-14670.00.patch, HADOOP-14670.01.patch, > HADOOP-14670.02.patch, HADOOP-14670.03.patch > > > cmake 2.6 is old at this point and I'd be greatly surprised if anyone is > actually using it or testing against it. It's probably time to upgrade to > something approaching modern. Plus: > * Mac OS X already requires 3.0 > * If HADOOP-14667 gets committed, Windows bumps to 3.1 > * There is special handling in at least one CMakeLists.txt for versions less > than 3.1 > Given the last two points, I'd propose making the minimum 3.1, if not > something higher due to compiler support for newer compilers across all > platforms. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14670) Increase minimum cmake version for all platforms
[ https://issues.apache.org/jira/browse/HADOOP-14670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147716#comment-16147716 ] Hadoop QA commented on HADOOP-14670: (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/PreCommit-HADOOP-Build/13136/console in case of problems. > Increase minimum cmake version for all platforms > > > Key: HADOOP-14670 > URL: https://issues.apache.org/jira/browse/HADOOP-14670 > Project: Hadoop Common > Issue Type: Improvement > Components: build >Affects Versions: 3.0.0-beta1 >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer > Attachments: HADOOP-14670.00.patch, HADOOP-14670.01.patch, > HADOOP-14670.02.patch > > > cmake 2.6 is old at this point and I'd be greatly surprised if anyone is > actually using it or testing against it. It's probably time to upgrade to > something approaching modern. Plus: > * Mac OS X already requires 3.0 > * If HADOOP-14667 gets committed, Windows bumps to 3.1 > * There is special handling in at least one CMakeLists.txt for versions less > than 3.1 > Given the last two points, I'd propose making the minimum 3.1, if not > something higher due to compiler support for newer compilers across all > platforms. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14670) Increase minimum cmake version for all platforms
[ https://issues.apache.org/jira/browse/HADOOP-14670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147599#comment-16147599 ] Hadoop QA commented on HADOOP-14670: (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/PreCommit-HADOOP-Build/13135/console in case of problems. > Increase minimum cmake version for all platforms > > > Key: HADOOP-14670 > URL: https://issues.apache.org/jira/browse/HADOOP-14670 > Project: Hadoop Common > Issue Type: Improvement > Components: build >Affects Versions: 3.0.0-beta1 >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer > Attachments: HADOOP-14670.00.patch, HADOOP-14670.01.patch > > > cmake 2.6 is old at this point and I'd be greatly surprised if anyone is > actually using it or testing against it. It's probably time to upgrade to > something approaching modern. Plus: > * Mac OS X already requires 3.0 > * If HADOOP-14667 gets committed, Windows bumps to 3.1 > * There is special handling in at least one CMakeLists.txt for versions less > than 3.1 > Given the last two points, I'd propose making the minimum 3.1, if not > something higher due to compiler support for newer compilers across all > platforms. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14670) Increase minimum cmake version for all platforms
[
https://issues.apache.org/jira/browse/HADOOP-14670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16146916#comment-16146916
]
Steve Loughran commented on HADOOP-14670:
-
update seems a reasonable idea, but looks like yetus is still on the older
versions
{code}
[WARNING] CMake Error at CMakeLists.txt:23 (cmake_minimum_required):
[WARNING] CMake 3.1 or higher is required. You are running version 2.8.12.2
{code}
> Increase minimum cmake version for all platforms
>
>
> Key: HADOOP-14670
> URL: https://issues.apache.org/jira/browse/HADOOP-14670
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
>Affects Versions: 3.0.0-beta1
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
> Attachments: HADOOP-14670.00.patch
>
>
> cmake 2.6 is old at this point and I'd be greatly surprised if anyone is
> actually using it or testing against it. It's probably time to upgrade to
> something approaching modern. Plus:
> * Mac OS X already requires 3.0
> * If HADOOP-14667 gets committed, Windows bumps to 3.1
> * There is special handling in at least one CMakeLists.txt for versions less
> than 3.1
> Given the last two points, I'd propose making the minimum 3.1, if not
> something higher due to compiler support for newer compilers across all
> platforms.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14670) Increase minimum cmake version for all platforms
[
https://issues.apache.org/jira/browse/HADOOP-14670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16146617#comment-16146617
]
Hadoop QA commented on HADOOP-14670:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
18s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
41s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 14m
9s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 18m
24s{color} | {color:green} trunk passed {color} |
| {color:red}-1{color} | {color:red} mvnsite {color} | {color:red} 1m
53s{color} | {color:red} root in trunk failed. {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
15s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 17m
9s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
50s{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} cc {color} | {color:red} 0m 50s{color} |
{color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 50s{color}
| {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvnsite {color} | {color:red} 1m
37s{color} | {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 8m 22s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
32s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 65m 53s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:14b5c93 |
| JIRA Issue | HADOOP-14670 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12884315/HADOOP-14670.00.patch
|
| Optional Tests | asflicense compile cc mvnsite javac unit |
| uname | Linux 1d7e64476e3a 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26
18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / 8201ed8 |
| Default Java | 1.8.0_144 |
| mvnsite |
https://builds.apache.org/job/PreCommit-HADOOP-Build/13127/artifact/patchprocess/branch-mvnsite-root.txt
|
| compile |
https://builds.apache.org/job/PreCommit-HADOOP-Build/13127/artifact/patchprocess/patch-compile-root.txt
|
| cc |
https://builds.apache.org/job/PreCommit-HADOOP-Build/13127/artifact/patchprocess/patch-compile-root.txt
|
| javac |
https://builds.apache.org/job/PreCommit-HADOOP-Build/13127/artifact/patchprocess/patch-compile-root.txt
|
| mvnsite |
https://builds.apache.org/job/PreCommit-HADOOP-Build/13127/artifact/patchprocess/patch-mvnsite-root.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HADOOP-Build/13127/artifact/patchprocess/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/13127/testReport/ |
| modules | C: hadoop-common-project/hadoop-common
hadoop-hdfs-project/hadoop-hdfs-native-client
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask
hadoop-tools/hadoop-pipes . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/13127/console |
| Powered by | Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Increase minimum cmake version for all platforms
>
