[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4341: YARN-10487. Support getQueueUserAcls, listReservations, getApplicationAttempts, getContainerReport, getContainers, getResourceTyp
slfan1989 commented on code in PR #4341: URL: https://github.com/apache/hadoop/pull/4341#discussion_r883144071 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/resources/capacity-scheduler.xml: ## @@ -97,6 +97,15 @@ + +yarn.scheduler.capacity.root.decided.reservable Review Comment: Considering that I need to complete the following methods in the future, I modified capacity-scheduler.xml in the resource of test. The methods involved are as follows(submit new pr later to solve): ``` getNewReservation submitReservation updateReservation deleteReservation ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4341: YARN-10487. Support getQueueUserAcls, listReservations, getApplicationAttempts, getContainerReport, getContainers, getResourceTyp
slfan1989 commented on code in PR #4341: URL: https://github.com/apache/hadoop/pull/4341#discussion_r883144071 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/resources/capacity-scheduler.xml: ## @@ -97,6 +97,15 @@ + +yarn.scheduler.capacity.root.decided.reservable Review Comment: Considering that I need to complete the following methods in the future, I modified capacity-scheduler.xml in the resource of test. The methods involved are as follows: ``` getNewReservation submitReservation listReservations updateReservation deleteReservation ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4341: YARN-10487. Support getQueueUserAcls, listReservations, getApplicationAttempts, getContainerReport, getContainers, getResourceTyp
slfan1989 commented on code in PR #4341: URL: https://github.com/apache/hadoop/pull/4341#discussion_r883144071 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/resources/capacity-scheduler.xml: ## @@ -97,6 +97,15 @@ + +yarn.scheduler.capacity.root.decided.reservable Review Comment: Considering that I need to complete the following methods in the future, I modified capacity-scheduler.xml in the resource of test· The methods involved are as follows: ``` getNewReservation submitReservation listReservations updateReservation deleteReservation ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4341: YARN-10487. Support getQueueUserAcls, listReservations, getApplicationAttempts, getContainerReport, getContainers, getResourceTyp
slfan1989 commented on code in PR #4341: URL: https://github.com/apache/hadoop/pull/4341#discussion_r883144071 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/resources/capacity-scheduler.xml: ## @@ -97,6 +97,15 @@ + +yarn.scheduler.capacity.root.decided.reservable Review Comment: Considering that I need to complete the following methods in the future, I modified capacity-scheduler.xml in the resource of test· The methods involved are as follows: ``` getNewReservation submitReservation listReservations updateReservation deleteReservation ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4341: YARN-10487. Support getQueueUserAcls, listReservations, getApplicationAttempts, getContainerReport, getContainers, getResourceTyp
slfan1989 commented on code in PR #4341: URL: https://github.com/apache/hadoop/pull/4341#discussion_r883141883 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/resources/capacity-scheduler.xml: ## @@ -97,6 +97,15 @@ + +yarn.scheduler.capacity.root.decided.reservable Review Comment: ListReservations Methods requires the queue to open the Reservation System, so during the junit test, i need to add configuration information. If the queue does not add this configuration, the following information will be prompted. ``` Caused by: org.apache.hadoop.yarn.exceptions.YarnException: The specified queue: root.decided is not managed by reservation system. Please try again with a valid reservable queue. ``` for configuration information, please refer to the following page [Configuring_ReservationSystem](https://hadoop.apache.org/docs/stable/hadoop-yarn/hadoop-yarn-site/CapacityScheduler.html#Configuring_ReservationSystem_with_CapacityScheduler) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4341: YARN-10487. Support getQueueUserAcls, listReservations, getApplicationAttempts, getContainerReport, getContainers, getResourceTyp
slfan1989 commented on code in PR #4341: URL: https://github.com/apache/hadoop/pull/4341#discussion_r883141883 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/resources/capacity-scheduler.xml: ## @@ -97,6 +97,15 @@ + +yarn.scheduler.capacity.root.decided.reservable Review Comment: ListReservations Methods requires the queue to open the Reservation System, so during the junit test, you need to add configuration information. If the queue does not add this configuration, the following information will be prompted. ``` Caused by: org.apache.hadoop.yarn.exceptions.YarnException: The specified queue: root.decided is not managed by reservation system. Please try again with a valid reservable queue. ``` for configuration information, please refer to the following page [Configuring_ReservationSystem](https://hadoop.apache.org/docs/stable/hadoop-yarn/hadoop-yarn-site/CapacityScheduler.html#Configuring_ReservationSystem_with_CapacityScheduler) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4341: YARN-10487. Support getQueueUserAcls, listReservations, getApplicationAttempts, getContainerReport, getContainers, getResourceTyp
slfan1989 commented on code in PR #4341: URL: https://github.com/apache/hadoop/pull/4341#discussion_r882556636 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/resources/capacity-scheduler.xml: ## @@ -97,6 +97,15 @@ + +yarn.scheduler.capacity.root.default.reservable Review Comment: I newly set the `root.decided` queue for Junit Test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4341: YARN-10487. Support getQueueUserAcls, listReservations, getApplicationAttempts, getContainerReport, getContainers, getResourceTyp
slfan1989 commented on code in PR #4341: URL: https://github.com/apache/hadoop/pull/4341#discussion_r882212021 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/resources/capacity-scheduler.xml: ## @@ -97,6 +97,15 @@ + +yarn.scheduler.capacity.root.default.reservable Review Comment: Hi, @goiri , testListReservations junit test needs the queue to be reservable, I set root.default reservable = true. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4341: YARN-10487. Support getQueueUserAcls, listReservations, getApplicationAttempts, getContainerReport, getContainers, getResourceTyp
slfan1989 commented on code in PR #4341:
URL: https://github.com/apache/hadoop/pull/4341#discussion_r881159169
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/clientrm/TestFederationClientInterceptor.java:
##
@@ -435,13 +437,10 @@ public void testGetApplicationEmptyRequest()
@Test
public void testGetApplicationAttemptReport()
throws YarnException, IOException, InterruptedException {
-LOG.info("Test FederationClientInterceptor: " +
-"Get ApplicationAttempt Report");
+LOG.info("Test FederationClientInterceptor: Get ApplicationAttempt
Report.");
ApplicationId appId =
-ApplicationId.newInstance(System.currentTimeMillis(), 1);
-ApplicationAttemptId appAttemptId =
-ApplicationAttemptId.newInstance(appId, 1);
Review Comment:
ApplicationAttemptId needs to be queried in Yarn RM and cannot be generated
directly.
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/clientrm/TestFederationClientInterceptor.java:
##
@@ -435,13 +437,10 @@ public void testGetApplicationEmptyRequest()
@Test
public void testGetApplicationAttemptReport()
throws YarnException, IOException, InterruptedException {
-LOG.info("Test FederationClientInterceptor: " +
-"Get ApplicationAttempt Report");
+LOG.info("Test FederationClientInterceptor: Get ApplicationAttempt
Report.");
ApplicationId appId =
-ApplicationId.newInstance(System.currentTimeMillis(), 1);
-ApplicationAttemptId appAttemptId =
-ApplicationAttemptId.newInstance(appId, 1);
Review Comment:
ApplicationAttemptId needs to be queried in yarn and cannot be generated
directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4341: YARN-10487. Support getQueueUserAcls, listReservations, getApplicationAttempts, getContainerReport, getContainers, getResourceTyp
slfan1989 commented on code in PR #4341:
URL: https://github.com/apache/hadoop/pull/4341#discussion_r881159169
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/clientrm/TestFederationClientInterceptor.java:
##
@@ -435,13 +437,10 @@ public void testGetApplicationEmptyRequest()
@Test
public void testGetApplicationAttemptReport()
throws YarnException, IOException, InterruptedException {
-LOG.info("Test FederationClientInterceptor: " +
-"Get ApplicationAttempt Report");
+LOG.info("Test FederationClientInterceptor: Get ApplicationAttempt
Report.");
ApplicationId appId =
-ApplicationId.newInstance(System.currentTimeMillis(), 1);
-ApplicationAttemptId appAttemptId =
-ApplicationAttemptId.newInstance(appId, 1);
Review Comment:
ApplicationAttemptId needs to be queried in Yarn and cannot be generated
directly. It is found during testing that the query will fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4341: YARN-10487. Support getQueueUserAcls, listReservations, getApplicationAttempts, getContainerReport, getContainers, getResourceTyp
slfan1989 commented on code in PR #4341:
URL: https://github.com/apache/hadoop/pull/4341#discussion_r881106167
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/RouterMetrics.java:
##
@@ -238,6 +255,16 @@ public long getNumSucceededAppAttemptReportRetrieved(){
return totalSucceededAppAttemptReportRetrieved.lastStat().numSamples();
}
+ @VisibleForTesting
+ public long getNumSucceededGetQueueUserAclsRetrieved(){
Review Comment:
Thanks for the suggestion, I will add Test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4341: YARN-10487. Support getQueueUserAcls, listReservations, getApplicationAttempts, getContainerReport, getContainers, getResourceTyp
slfan1989 commented on code in PR #4341: URL: https://github.com/apache/hadoop/pull/4341#discussion_r881103578 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/clientrm/RouterYarnClientUtils.java: ## @@ -295,5 +297,25 @@ public static GetClusterNodeLabelsResponse mergeClusterNodeLabelsResponse( nodeLabelsResponse.setNodeLabelList(new ArrayList<>(nodeLabelsList)); return nodeLabelsResponse; } + + /** + * Merges a list of GetQueueUserAclsInfoResponse. + * + * @param responses a list of GetQueueUserAclsInfoResponse to merge. + * @return the merged GetQueueUserAclsInfoResponse. + */ + public static GetQueueUserAclsInfoResponse mergeQueueUserAcls( Review Comment: Hi, @goiri Thanks for your help to review the code, I will add test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
