steveloughran merged PR #6144:
URL: https://github.com/apache/hadoop/pull/6144
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
hadoop-yetus commented on PR #6144:
URL: https://github.com/apache/hadoop/pull/6144#issuecomment-1915921653
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #6144:
URL: https://github.com/apache/hadoop/pull/6144#issuecomment-1915611296
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
steveloughran commented on PR #6144:
URL: https://github.com/apache/hadoop/pull/6144#issuecomment-1915231977
thanks. not sure what is up with docker. will rebase and force push with
test run
--
This is an automated message from the Apache Git Service.
To respond to the message, please
hadoop-yetus commented on PR #6144:
URL: https://github.com/apache/hadoop/pull/6144#issuecomment-1915042017
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
steveloughran commented on code in PR #6144:
URL: https://github.com/apache/hadoop/pull/6144#discussion_r1469632159
##
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/select/ITestSelectUnsupported.java:
##
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache Software
ahmarsuhail commented on code in PR #6144:
URL: https://github.com/apache/hadoop/pull/6144#discussion_r1466371581
##
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/select/package-info.java:
##
@@ -17,7 +17,12 @@
*/
/**
- * Support for S3 Select.
+ * Was the
steveloughran commented on PR #6144:
URL: https://github.com/apache/hadoop/pull/6144#issuecomment-1908714315
@ahmarsuhail @mukund-thakur can I get this in? it'll help on test time...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
hadoop-yetus commented on PR #6144:
URL: https://github.com/apache/hadoop/pull/6144#issuecomment-1879075825
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
steveloughran commented on PR #6144:
URL: https://github.com/apache/hadoop/pull/6144#issuecomment-1878842405
rebased pr with retest. failures unrelated; the signing one has an active pr
to fix, the committer one looks like my config is at fault (bucket overrides
not being cut)
```
hadoop-yetus commented on PR #6144:
URL: https://github.com/apache/hadoop/pull/6144#issuecomment-1848422873
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
steveloughran commented on PR #6144:
URL: https://github.com/apache/hadoop/pull/6144#issuecomment-1847657341
latest change is just a rebase; not retested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
hadoop-yetus commented on PR #6144:
URL: https://github.com/apache/hadoop/pull/6144#issuecomment-1809917406
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #6144:
URL: https://github.com/apache/hadoop/pull/6144#issuecomment-1773995577
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #6144:
URL: https://github.com/apache/hadoop/pull/6144#issuecomment-1772223357
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
steveloughran commented on PR #6144:
URL: https://github.com/apache/hadoop/pull/6144#issuecomment-1771335503
keeping but moving csv file. it's actually very useful in places; in
cloudstore we use it in places like "bandwidth" to track block upload times. so
it may be useful in
steveloughran commented on code in PR #6144:
URL: https://github.com/apache/hadoop/pull/6144#discussion_r1363570103
##
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/index.md:
##
@@ -35,7 +35,6 @@ full details.
* [Encryption](./encryption.html)
*
ahmarsuhail commented on PR #6144:
URL: https://github.com/apache/hadoop/pull/6144#issuecomment-1766391559
And agree with your comment, should cut
`org.apache.hadoop.fs.s3a.select.BlockingEnumeration` and add the commit to the
package-info.
--
This is an automated message from the
ahmarsuhail commented on code in PR #6144:
URL: https://github.com/apache/hadoop/pull/6144#discussion_r1362087831
##
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/index.md:
##
@@ -35,7 +35,6 @@ full details.
* [Encryption](./encryption.html)
*
hadoop-yetus commented on PR #6144:
URL: https://github.com/apache/hadoop/pull/6144#issuecomment-1757656449
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #6144:
URL: https://github.com/apache/hadoop/pull/6144#issuecomment-1755466189
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
steveloughran commented on PR #6144:
URL: https://github.com/apache/hadoop/pull/6144#issuecomment-1753482819
with this PR
* all s3 select code is stripped
* all imports of its classes are gone
* docs say this
* path capability returns false
* openFile with select options raise
steveloughran commented on PR #6144:
URL: https://github.com/apache/hadoop/pull/6144#issuecomment-1753472645
Tested s3 london `Dparallel-tests -DtestsThreadCount=10 -Dscale -Dprefetch`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
hadoop-yetus commented on PR #6144:
URL: https://github.com/apache/hadoop/pull/6144#issuecomment-1743650238
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
steveloughran commented on PR #6144:
URL: https://github.com/apache/hadoop/pull/6144#issuecomment-1743442467
Given I wrote this it's kind of sad, but openFile() will outlive it as it
has many more uses.
--
This is an automated message from the Apache Git Service.
To respond to the
steveloughran opened a new pull request, #6144:
URL: https://github.com/apache/hadoop/pull/6144
Cut out S3 Select
* leave public/unstable constants alone
* s3guard tool will fail with error
* s3afs. path capability will fail
* openFile() will fail with specific error
* s3
26 matches
Mail list logo
