jojochuang commented on PR #6194:
URL: https://github.com/apache/hadoop/pull/6194#issuecomment-1775736859
Merged. Thanks @dombizita for the PR and @ferdelyi @brumi1024 @fapifta for
review and comments.
--
This is an automated message from the Apache Git Service.
To respond to the
jojochuang merged PR #6194:
URL: https://github.com/apache/hadoop/pull/6194
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
hadoop-yetus commented on PR #6194:
URL: https://github.com/apache/hadoop/pull/6194#issuecomment-1774052185
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #6194:
URL: https://github.com/apache/hadoop/pull/6194#issuecomment-1773960682
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
jojochuang commented on PR #6194:
URL: https://github.com/apache/hadoop/pull/6194#issuecomment-1773424194
LGTM test failure fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
hadoop-yetus commented on PR #6194:
URL: https://github.com/apache/hadoop/pull/6194#issuecomment-1772460758
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
fapifta commented on PR #6194:
URL: https://github.com/apache/hadoop/pull/6194#issuecomment-1771845122
@jojochuang @dombizita checking into the failures, I firmly believe that
they were failing because in the meantime there was a bump in Zookeeper
version, 3.6.3->3.6.4 and after the
jojochuang commented on PR #6194:
URL: https://github.com/apache/hadoop/pull/6194#issuecomment-1771407719
@dombizita a few test failures may be related TestActiveStandbyElector,
TestZKCuratorManager, TestSecureZKCuratorManager
--
This is an automated message from the Apache Git Service.
brumi1024 commented on PR #6194:
URL: https://github.com/apache/hadoop/pull/6194#issuecomment-1770392954
> Unrelated question... in
[HADOOP-18709](https://github.com/apache/hadoop/pull/5638/files#top) a new
dependency was added (netty-transport-native-epoll) it's a native lib for Netty
to
jojochuang commented on code in PR #6194:
URL: https://github.com/apache/hadoop/pull/6194#discussion_r1364515887
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java:
##
@@ -786,4 +789,96 @@ public static List
hadoop-yetus commented on PR #6194:
URL: https://github.com/apache/hadoop/pull/6194#issuecomment-1769285674
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
dombizita commented on code in PR #6194:
URL: https://github.com/apache/hadoop/pull/6194#discussion_r1363567945
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java:
##
@@ -786,4 +789,96 @@ public static List
hadoop-yetus commented on PR #6194:
URL: https://github.com/apache/hadoop/pull/6194#issuecomment-1767075251
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
jojochuang commented on code in PR #6194:
URL: https://github.com/apache/hadoop/pull/6194#discussion_r1362493253
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java:
##
@@ -786,4 +789,96 @@ public static List
jojochuang commented on PR #6194:
URL: https://github.com/apache/hadoop/pull/6194#issuecomment-1766842223
Unrelated question... in
[HADOOP-18709](https://github.com/apache/hadoop/pull/5638/files#top) a new
dependency was added (netty-transport-native-epoll) it's a native lib for Netty
to
ferdelyi commented on PR #6194:
URL: https://github.com/apache/hadoop/pull/6194#issuecomment-1766546738
> Could you take a look at this @ferdelyi? I saw that you worked on both
#5638 and #6114.
>
> I moved some code that you added from ZKCuratorManager to SecurityUtil, so
I could
dombizita commented on PR #6194:
URL: https://github.com/apache/hadoop/pull/6194#issuecomment-1766365751
Could you take a look at this @ferdelyi? I saw that you worked on both #5638
and #6114.
I moved some code that you added from ZKCuratorManager to SecurityUtil, so I
could use it
17 matches
Mail list logo
