[jira] [Commented] (HADOOP-10232) More options to HttpServer Builder

2014-01-27 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-10232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13883217#comment-13883217 ] Haohui Mai commented on HADOOP-10232: - Just for clarification, I confused myself

[jira] [Commented] (HADOOP-10232) More options to HttpServer Builder

2014-01-15 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-10232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13872359#comment-13872359 ] stack commented on HADOOP-10232: [~echarles] The + protected String logDir; is needed

[jira] [Commented] (HADOOP-10232) More options to HttpServer Builder

2014-01-15 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-10232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13872360#comment-13872360 ] stack commented on HADOOP-10232: Otherwise patch lgtm. More options to HttpServer

[jira] [Commented] (HADOOP-10232) More options to HttpServer Builder

2014-01-15 Thread Eric Charles (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-10232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13872379#comment-13872379 ] Eric Charles commented on HADOOP-10232: --- [~stack] yes, the logDir is needed to do

[jira] [Commented] (HADOOP-10232) More options to HttpServer Builder

2014-01-15 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-10232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13872392#comment-13872392 ] stack commented on HADOOP-10232: bq. I already had issues with mixed mortaby (6.x) and

[jira] [Commented] (HADOOP-10232) More options to HttpServer Builder

2014-01-15 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-10232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13872428#comment-13872428 ] Haohui Mai commented on HADOOP-10232: - bq. Would your life be easier Mr Eric Charles

[jira] [Commented] (HADOOP-10232) More options to HttpServer Builder

2014-01-15 Thread Eric Charles (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-10232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13872452#comment-13872452 ] Eric Charles commented on HADOOP-10232: --- Sounds like we can close this and copy

[jira] [Commented] (HADOOP-10232) More options to HttpServer Builder

2014-01-15 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-10232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13872487#comment-13872487 ] stack commented on HADOOP-10232: bq. +1 for the decoupling. The class is an internal

[jira] [Commented] (HADOOP-10232) More options to HttpServer Builder

2014-01-15 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-10232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13872574#comment-13872574 ] Haohui Mai commented on HADOOP-10232: - I added the annotation in 2.2 just to

[jira] [Commented] (HADOOP-10232) More options to HttpServer Builder

2014-01-15 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-10232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13872836#comment-13872836 ] stack commented on HADOOP-10232: bq. I added the annotation in 2.2 just to indicate that

[jira] [Commented] (HADOOP-10232) More options to HttpServer Builder

2014-01-15 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-10232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13872878#comment-13872878 ] Haohui Mai commented on HADOOP-10232: - Jetty 6 has been definitely a pain so far. My

[jira] [Commented] (HADOOP-10232) More options to HttpServer Builder

2014-01-15 Thread Eric Charles (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-10232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13873043#comment-13873043 ] Eric Charles commented on HADOOP-10232: --- Thx git to tell us the truth. My 2 cents