[
https://issues.apache.org/jira/browse/HADOOP-10949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14735411#comment-14735411
]
Babak Behzad commented on HADOOP-10949:
---
Ok, based on comments from [~raviprak], [~aw], [~steve_l]
[
https://issues.apache.org/jira/browse/HADOOP-10949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14735495#comment-14735495
]
Hadoop QA commented on HADOOP-10949:
\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-10949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14729437#comment-14729437
]
Steve Loughran commented on HADOOP-10949:
-
I'm confused. I'm thinking of {{/hadoop-tools/*}}
[
https://issues.apache.org/jira/browse/HADOOP-10949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14729464#comment-14729464
]
Allen Wittenauer commented on HADOOP-10949:
---
bq. Are you talking about the how the tarball
[
https://issues.apache.org/jira/browse/HADOOP-10949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14729377#comment-14729377
]
Allen Wittenauer commented on HADOOP-10949:
---
hadoop-tools still suffers from the same sorts of
[
https://issues.apache.org/jira/browse/HADOOP-10949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730110#comment-14730110
]
Babak Behzad commented on HADOOP-10949:
---
I have attached the patch with [~steve_l]'s comment of
[
https://issues.apache.org/jira/browse/HADOOP-10949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730193#comment-14730193
]
Hadoop QA commented on HADOOP-10949:
\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-10949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14725921#comment-14725921
]
Steve Loughran commented on HADOOP-10949:
-
-1 to adding kafka on the hadoop-common classpath;
[
https://issues.apache.org/jira/browse/HADOOP-10949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14717339#comment-14717339
]
Babak Behzad commented on HADOOP-10949:
---
The patch that I just uploaded
[
https://issues.apache.org/jira/browse/HADOOP-10949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14717459#comment-14717459
]
Hadoop QA commented on HADOOP-10949:
\\
\\
| (/) *{color:green}+1 overall{color}* |
[
https://issues.apache.org/jira/browse/HADOOP-10949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14715909#comment-14715909
]
Hadoop QA commented on HADOOP-10949:
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
[
https://issues.apache.org/jira/browse/HADOOP-10949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14715894#comment-14715894
]
Haohui Mai commented on HADOOP-10949:
-
I'm concerned on putting Kafka as a
[
https://issues.apache.org/jira/browse/HADOOP-10949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14709595#comment-14709595
]
Ravi Prakash commented on HADOOP-10949:
---
1. {{dateFormat}} and {{timeFormat}} can
[
https://issues.apache.org/jira/browse/HADOOP-10949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14709938#comment-14709938
]
Hadoop QA commented on HADOOP-10949:
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
[
https://issues.apache.org/jira/browse/HADOOP-10949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14707380#comment-14707380
]
Abin Shahab commented on HADOOP-10949:
--
[~raviprakash] Added all the changes you've
[
https://issues.apache.org/jira/browse/HADOOP-10949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14705549#comment-14705549
]
Hadoop QA commented on HADOOP-10949:
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
[
https://issues.apache.org/jira/browse/HADOOP-10949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14705744#comment-14705744
]
Ravi Prakash commented on HADOOP-10949:
---
Also, please version your patch files.
[
https://issues.apache.org/jira/browse/HADOOP-10949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14705741#comment-14705741
]
Ravi Prakash commented on HADOOP-10949:
---
1. You're sending the same message to
[
https://issues.apache.org/jira/browse/HADOOP-10949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14705750#comment-14705750
]
Ravi Prakash commented on HADOOP-10949:
---
Please also document test code. What is
[
https://issues.apache.org/jira/browse/HADOOP-10949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14703544#comment-14703544
]
Hadoop QA commented on HADOOP-10949:
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
[
https://issues.apache.org/jira/browse/HADOOP-10949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14703874#comment-14703874
]
Hadoop QA commented on HADOOP-10949:
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
[
https://issues.apache.org/jira/browse/HADOOP-10949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14702695#comment-14702695
]
Hadoop QA commented on HADOOP-10949:
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
[
https://issues.apache.org/jira/browse/HADOOP-10949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14701828#comment-14701828
]
Hadoop QA commented on HADOOP-10949:
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
[
https://issues.apache.org/jira/browse/HADOOP-10949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14702235#comment-14702235
]
Hadoop QA commented on HADOOP-10949:
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
[
https://issues.apache.org/jira/browse/HADOOP-10949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14701979#comment-14701979
]
Hadoop QA commented on HADOOP-10949:
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
[
https://issues.apache.org/jira/browse/HADOOP-10949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14700394#comment-14700394
]
Ravi Prakash commented on HADOOP-10949:
---
1. Please try using exclusions in the pom
[
https://issues.apache.org/jira/browse/HADOOP-10949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14700402#comment-14700402
]
Ravi Prakash commented on HADOOP-10949:
---
Also init should probably match the way
[
https://issues.apache.org/jira/browse/HADOOP-10949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14700362#comment-14700362
]
Hadoop QA commented on HADOOP-10949:
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
[
https://issues.apache.org/jira/browse/HADOOP-10949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14700701#comment-14700701
]
Abin Shahab commented on HADOOP-10949:
--
Send in this class does not return any
[
https://issues.apache.org/jira/browse/HADOOP-10949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14700065#comment-14700065
]
Allen Wittenauer commented on HADOOP-10949:
---
* Is there a reason the version
[
https://issues.apache.org/jira/browse/HADOOP-10949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14700145#comment-14700145
]
Ravi Prakash commented on HADOOP-10949:
---
This new dependency that you want to add
[
https://issues.apache.org/jira/browse/HADOOP-10949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14700150#comment-14700150
]
Abin Shahab commented on HADOOP-10949:
--
[~raviprakash], should I specify a branch
[
https://issues.apache.org/jira/browse/HADOOP-10949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14306657#comment-14306657
]
Hadoop QA commented on HADOOP-10949:
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HADOOP-10949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14160393#comment-14160393
]
Babak Behzad commented on HADOOP-10949:
---
[~aw]: The reason that it does not
[
https://issues.apache.org/jira/browse/HADOOP-10949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14160411#comment-14160411
]
Allen Wittenauer commented on HADOOP-10949:
---
Yup, patch the pom.xml as well.
[
https://issues.apache.org/jira/browse/HADOOP-10949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14159703#comment-14159703
]
Babak Behzad commented on HADOOP-10949:
---
I attached my first patch available for
[
https://issues.apache.org/jira/browse/HADOOP-10949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14159708#comment-14159708
]
Hadoop QA commented on HADOOP-10949:
{color:red}-1 overall{color}. Here are the
37 matches
Mail list logo
