[jira] [Commented] (HADOOP-15362) Review of Configuration.java

2018-04-17 Thread BELUGA BEHR (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16441370#comment-16441370 ] BELUGA BEHR commented on HADOOP-15362: -- [~ajayydv] Are you able to review this once more and

[jira] [Commented] (HADOOP-15362) Review of Configuration.java

2018-04-13 Thread BELUGA BEHR (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437553#comment-16437553 ] BELUGA BEHR commented on HADOOP-15362: -- [~ajayydv], the generated Checkstyles are "LineLength"

[jira] [Commented] (HADOOP-15362) Review of Configuration.java

2018-04-12 Thread Ajay Kumar (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436762#comment-16436762 ] Ajay Kumar commented on HADOOP-15362: - [~belugabehr] missed private identifier for class :).  +1

[jira] [Commented] (HADOOP-15362) Review of Configuration.java

2018-04-11 Thread BELUGA BEHR (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434852#comment-16434852 ] BELUGA BEHR commented on HADOOP-15362: -- [~ajayydv] A public constructor in a private class, is

[jira] [Commented] (HADOOP-15362) Review of Configuration.java

2018-04-11 Thread Ajay Kumar (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434365#comment-16434365 ] Ajay Kumar commented on HADOOP-15362: - Hi [~belugabehr], patch v5 changes access for Resource

[jira] [Commented] (HADOOP-15362) Review of Configuration.java

2018-04-10 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433228#comment-16433228 ] genericqa commented on HADOOP-15362: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-15362) Review of Configuration.java

2018-04-10 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432840#comment-16432840 ] genericqa commented on HADOOP-15362: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-15362) Review of Configuration.java

2018-04-10 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432519#comment-16432519 ] genericqa commented on HADOOP-15362: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-15362) Review of Configuration.java

2018-04-09 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16431743#comment-16431743 ] genericqa commented on HADOOP-15362: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-15362) Review of Configuration.java

2018-04-09 Thread BELUGA BEHR (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16431627#comment-16431627 ] BELUGA BEHR commented on HADOOP-15362: -- New patch should fix whitespace issues. > Review of

[jira] [Commented] (HADOOP-15362) Review of Configuration.java

2018-04-04 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426071#comment-16426071 ] genericqa commented on HADOOP-15362: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||