[jira] [Commented] (HADOOP-15072) Upgrade Apache Kerby version to 1.1.0

2017-11-29 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270376#comment-16270376 ] genericqa commented on HADOOP-15072: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-14964) AliyunOSS: backport Aliyun OSS module to branch-2

2017-11-29 Thread SammiChen (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-14964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270412#comment-16270412 ] SammiChen commented on HADOOP-14964: Hi [~chris.douglas], thanks for summarize the discussion here.

[jira] [Commented] (HADOOP-14475) Metrics of S3A don't print out when enable it in Hadoop metrics property file

2017-11-29 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270527#comment-16270527 ] Steve Loughran commented on HADOOP-14475: - bq. let's maybe handle that as a distinct issue from

[jira] [Commented] (HADOOP-14475) Metrics of S3A don't print out when enable it in Hadoop metrics property file

2017-11-29 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270532#comment-16270532 ] Steve Loughran commented on HADOOP-14475: - bq. Quick glance at code, looks like instrumentation

[jira] [Updated] (HADOOP-15056) Fix TestUnbuffer#testUnbufferException failure

2017-11-29 Thread John Zhuge (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Zhuge updated HADOOP-15056: Summary: Fix TestUnbuffer#testUnbufferException failure (was: Fix for

[jira] [Updated] (HADOOP-15056) Fix TestUnbuffer#testUnbufferException failure

2017-11-29 Thread John Zhuge (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Zhuge updated HADOOP-15056: Attachment: HADOOP-15056.002.patch Hi [~jackbearden], I think StreamCapabilitiesPolicy#unbuffer

[jira] [Created] (HADOOP-15075) Implement KnoxSSO for hadoop web UIs (hdfs, yarn, history server etc.)

2017-11-29 Thread madhu raghavendra (JIRA)
madhu raghavendra created HADOOP-15075: -- Summary: Implement KnoxSSO for hadoop web UIs (hdfs, yarn, history server etc.) Key: HADOOP-15075 URL: https://issues.apache.org/jira/browse/HADOOP-15075

[jira] [Updated] (HADOOP-15073) SequenceFile.Reader will unexpectedly quit next() iterator while the file ends with sync and appended

2017-11-29 Thread Howard Lee (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard Lee updated HADOOP-15073: External issue URL: (was: https://issues.apache.org/jira/browse/HADOOP-7139) >

[jira] [Created] (HADOOP-15073) SequenceFile.Reader will unexpectedly quit next() iterator while the file ends with sync and appended

2017-11-29 Thread Howard Lee (JIRA)
Howard Lee created HADOOP-15073: --- Summary: SequenceFile.Reader will unexpectedly quit next() iterator while the file ends with sync and appended Key: HADOOP-15073 URL:

[jira] [Updated] (HADOOP-15073) SequenceFile.Reader will unexpectedly quit next() iterator while the file ends with sync and appended

2017-11-29 Thread Howard Lee (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Howard Lee updated HADOOP-15073: External issue URL: https://issues.apache.org/jira/browse/HADOOP-7139 > SequenceFile.Reader will

[jira] [Created] (HADOOP-15074) SequenceFile#Writer flush does not update the length of the written file.

2017-11-29 Thread Mukul Kumar Singh (JIRA)
Mukul Kumar Singh created HADOOP-15074: -- Summary: SequenceFile#Writer flush does not update the length of the written file. Key: HADOOP-15074 URL: https://issues.apache.org/jira/browse/HADOOP-15074

[jira] [Updated] (HADOOP-15075) Implement KnoxSSO for hadoop web UIs (hdfs, yarn, history server etc.)

2017-11-29 Thread madhu raghavendra (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] madhu raghavendra updated HADOOP-15075: --- Description: Need to implement Knox SSO login feature for hadoop webUIs like HDFS

[jira] [Resolved] (HADOOP-15075) Implement KnoxSSO for hadoop web UIs (hdfs, yarn, history server etc.)

2017-11-29 Thread Larry McCay (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Larry McCay resolved HADOOP-15075. -- Resolution: Not A Problem Closing as not a problem - since JWTRedirectAuthenticationHandler

[jira] [Updated] (HADOOP-15027) AliyunOSS: Improvements for Hadoop read from AliyunOSS

2017-11-29 Thread wujinhu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wujinhu updated HADOOP-15027: - Summary: AliyunOSS: Improvements for Hadoop read from AliyunOSS (was: Improvements for Hadoop read

[jira] [Commented] (HADOOP-14556) S3A to support Delegation Tokens

2017-11-29 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-14556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270744#comment-16270744 ] Steve Loughran commented on HADOOP-14556: - Daryn, got that patch for this yet? > S3A to support

[jira] [Commented] (HADOOP-15056) Fix TestUnbuffer#testUnbufferException failure

2017-11-29 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270689#comment-16270689 ] genericqa commented on HADOOP-15056: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-15059) 3.0 deployment cannot work with old version MR tar ball which break rolling upgrade

2017-11-29 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270899#comment-16270899 ] Jason Lowe commented on HADOOP-15059: - Thanks for taking a look, Daryn! bq. Not to mention we are

[jira] [Updated] (HADOOP-15059) 3.0 deployment cannot work with old version MR tar ball which break rolling upgrade

2017-11-29 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Lowe updated HADOOP-15059: Attachment: HADOOP-15059.004.patch Thanks for joining the conversation, Allen, and for pointing

[jira] [Commented] (HADOOP-15059) 3.0 deployment cannot work with old version MR tar ball which break rolling upgrade

2017-11-29 Thread Allen Wittenauer (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271067#comment-16271067 ] Allen Wittenauer commented on HADOOP-15059: --- bq. Yes, and writing that version does enable

[jira] [Commented] (HADOOP-15054) upgrade hadoop dependency on commons-codec to 1.11

2017-11-29 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271212#comment-16271212 ] Hudson commented on HADOOP-15054: - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13289 (See

[jira] [Commented] (HADOOP-14742) Document multi-URI replication Inode for ViewFS

2017-11-29 Thread Gera Shegalov (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-14742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271347#comment-16271347 ] Gera Shegalov commented on HADOOP-14742: Apologies for the delay. Yes, HADOOP-12077 is obviously

[jira] [Commented] (HADOOP-15059) 3.0 deployment cannot work with old version MR tar ball which break rolling upgrade

2017-11-29 Thread Allen Wittenauer (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271346#comment-16271346 ] Allen Wittenauer commented on HADOOP-15059: --- bq. Do you know of existing use cases that are

[jira] [Updated] (HADOOP-15054) upgrade hadoop dependency on commons-codec to 1.11

2017-11-29 Thread Wei-Chiu Chuang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HADOOP-15054: - Resolution: Fixed Fix Version/s: 3.1.0 Status: Resolved (was: Patch

[jira] [Updated] (HADOOP-15075) Implement KnoxSSO for hadoop web UIs (hdfs, yarn, history server etc.)

2017-11-29 Thread madhu raghavendra (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] madhu raghavendra updated HADOOP-15075: --- Component/s: security > Implement KnoxSSO for hadoop web UIs (hdfs, yarn, history

[jira] [Commented] (HADOOP-15075) Implement KnoxSSO for hadoop web UIs (hdfs, yarn, history server etc.)

2017-11-29 Thread Larry McCay (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270672#comment-16270672 ] Larry McCay commented on HADOOP-15075: -- [~rmadhu877] - Please take a look at using

[jira] [Commented] (HADOOP-14556) S3A to support Delegation Tokens

2017-11-29 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-14556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270747#comment-16270747 ] Steve Loughran commented on HADOOP-14556: - Oh, as this doesn't work with session tokens as the

[jira] [Updated] (HADOOP-15042) Azure PageBlobInputStream.skip() can return negative value when numberOfPagesRemaining is 0

2017-11-29 Thread Arpit Agarwal (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arpit Agarwal updated HADOOP-15042: --- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 2.10.0

[jira] [Commented] (HADOOP-15056) Fix TestUnbuffer#testUnbufferException failure

2017-11-29 Thread Jack Bearden (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271676#comment-16271676 ] Jack Bearden commented on HADOOP-15056: --- Forgive me if I am being too pedantic... The way I see

[jira] [Commented] (HADOOP-14475) Metrics of S3A don't print out when enable it in Hadoop metrics property file

2017-11-29 Thread Aaron Fabbri (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271668#comment-16271668 ] Aaron Fabbri commented on HADOOP-14475: --- I added some instrumentation to detect use after close

[jira] [Commented] (HADOOP-13974) S3a CLI to support list/purge of pending multipart commits

2017-11-29 Thread Aaron Fabbri (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271677#comment-16271677 ] Aaron Fabbri commented on HADOOP-13974: --- This patch probably needs significant rewrite now that

[jira] [Updated] (HADOOP-14444) New implementation of ftp and sftp filesystems

2017-11-29 Thread Lukas Waldmann (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukas Waldmann updated HADOOP-1: Status: In Progress (was: Patch Available) > New implementation of ftp and sftp

[jira] [Commented] (HADOOP-15056) Fix TestUnbuffer#testUnbufferException failure

2017-11-29 Thread John Zhuge (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271601#comment-16271601 ] John Zhuge commented on HADOOP-15056: - StreamCapabilities was added by HDFS-11644. It is considered

[jira] [Commented] (HADOOP-15058) create-release site build outputs dummy shaded jars due to skipShade

2017-11-29 Thread Andrew Wang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271638#comment-16271638 ] Andrew Wang commented on HADOOP-15058: -- [~aw] do you mind reviewing this? > create-release site

[jira] [Updated] (HADOOP-14444) New implementation of ftp and sftp filesystems

2017-11-29 Thread Lukas Waldmann (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukas Waldmann updated HADOOP-1: Attachment: HADOOP-1.11.patch > New implementation of ftp and sftp filesystems >

[jira] [Commented] (HADOOP-15059) 3.0 deployment cannot work with old version MR tar ball which break rolling upgrade

2017-11-29 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271579#comment-16271579 ] genericqa commented on HADOOP-15059: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-10768) Optimize Hadoop RPC encryption performance

2017-11-29 Thread Dapeng Sun (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-10768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272082#comment-16272082 ] Dapeng Sun commented on HADOOP-10768: - HmacSHA1: {noformat} Total calls per second: 49716.0 CPU time

[jira] [Commented] (HADOOP-15059) 3.0 deployment cannot work with old version MR tar ball which break rolling upgrade

2017-11-29 Thread Vinod Kumar Vavilapalli (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272093#comment-16272093 ] Vinod Kumar Vavilapalli commented on HADOOP-15059: -- Tx for taking this up [~jlowe]!

[jira] [Commented] (HADOOP-13493) Compatibility Docs should clarify the policy for what takes precedence when a conflict is found

2017-11-29 Thread Andrew Wang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-13493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271942#comment-16271942 ] Andrew Wang commented on HADOOP-13493: -- Hey folks, is this still planned for 3.0.0? The blockers

[jira] [Commented] (HADOOP-15059) 3.0 deployment cannot work with old version MR tar ball which break rolling upgrade

2017-11-29 Thread Allen Wittenauer (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272105#comment-16272105 ] Allen Wittenauer commented on HADOOP-15059: --- bq. I can't tell my customers "I'm sorry, we're

[jira] [Commented] (HADOOP-15039) move SemaphoredDelegatingExecutor to hadoop-common

2017-11-29 Thread Genmao Yu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272132#comment-16272132 ] Genmao Yu commented on HADOOP-15039: [~drankye] Could you please keep an eye on it. IMHO, this patch

[jira] [Commented] (HADOOP-15056) Fix TestUnbuffer#testUnbufferException failure

2017-11-29 Thread Jack Bearden (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272135#comment-16272135 ] Jack Bearden commented on HADOOP-15056: --- Ah ok, I understand. What are your thoughts on something

[jira] [Commented] (HADOOP-15073) SequenceFile.Reader will unexpectedly quit next() iterator while the file ends with sync and appended

2017-11-29 Thread Howard Lee (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272090#comment-16272090 ] Howard Lee commented on HADOOP-15073: - There could be several SYNC MARK continuously, when you open

[jira] [Commented] (HADOOP-15056) Fix TestUnbuffer#testUnbufferException failure

2017-11-29 Thread John Zhuge (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272192#comment-16272192 ] John Zhuge commented on HADOOP-15056: - IMHO, it is not a good idea to swallow CCE and just log. In

[jira] [Commented] (HADOOP-15056) Fix TestUnbuffer#testUnbufferException failure

2017-11-29 Thread Jack Bearden (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272219#comment-16272219 ] Jack Bearden commented on HADOOP-15056: --- What about the streams that call unbuffer() without the

[jira] [Updated] (HADOOP-15056) Fix TestUnbuffer#testUnbufferException failure

2017-11-29 Thread Jack Bearden (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jack Bearden updated HADOOP-15056: -- Attachment: HADOOP-15056.003.patch > Fix TestUnbuffer#testUnbufferException failure >

[jira] [Commented] (HADOOP-15056) Fix TestUnbuffer#testUnbufferException failure

2017-11-29 Thread Jack Bearden (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272261#comment-16272261 ] Jack Bearden commented on HADOOP-15056: --- Submitted patch #3 based on our latest comments. Let me

[jira] [Updated] (HADOOP-14444) New implementation of ftp and sftp filesystems

2017-11-29 Thread Lukas Waldmann (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukas Waldmann updated HADOOP-1: Status: Patch Available (was: In Progress) Rebase on top of latest trunk. Removal of

[jira] [Commented] (HADOOP-15059) 3.0 deployment cannot work with old version MR tar ball which break rolling upgrade

2017-11-29 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271842#comment-16271842 ] Daryn Sharp commented on HADOOP-15059: -- I'm +1 on Jason's patch – with the minor suggestion of the

[jira] [Commented] (HADOOP-14444) New implementation of ftp and sftp filesystems

2017-11-29 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272071#comment-16272071 ] genericqa commented on HADOOP-1: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-10768) Optimize Hadoop RPC encryption performance

2017-11-29 Thread Dapeng Sun (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-10768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272053#comment-16272053 ] Dapeng Sun commented on HADOOP-10768: - Hi [~daryn] and [~atm], here is the hash

[jira] [Commented] (HADOOP-15056) Fix TestUnbuffer#testUnbufferException failure

2017-11-29 Thread John Zhuge (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272100#comment-16272100 ] John Zhuge commented on HADOOP-15056: - No worry. Good discussion. IMPALA-5909 complained excessive

[jira] [Commented] (HADOOP-15056) Fix TestUnbuffer#testUnbufferException failure

2017-11-29 Thread Jack Bearden (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271432#comment-16271432 ] Jack Bearden commented on HADOOP-15056: --- Hey [~jzhuge], hope your vacation was great. Thanks for

[jira] [Commented] (HADOOP-15059) 3.0 deployment cannot work with old version MR tar ball which break rolling upgrade

2017-11-29 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271494#comment-16271494 ] Jason Lowe commented on HADOOP-15059: - bq. We should verify dtutil can actually do a translation

[jira] [Commented] (HADOOP-14742) Document multi-URI replication Inode for ViewFS

2017-11-29 Thread Zhe Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-14742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271339#comment-16271339 ] Zhe Zhang commented on HADOOP-14742: Looks like the Description of HADOOP-12077 is a good starting

[jira] [Commented] (HADOOP-15059) 3.0 deployment cannot work with old version MR tar ball which break rolling upgrade

2017-11-29 Thread Ray Chiang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271327#comment-16271327 ] Ray Chiang commented on HADOOP-15059: - [~daryn]'s suggestion for 3.0->3.1 bridging isn't a perfect