[GitHub] [hadoop] mukund-thakur opened a new pull request #2187: HADOOP-17167 Skipping ITestS3AEncryptionWithDefaultS3Settings.testEncryptionOverRename

2020-08-03 Thread GitBox
mukund-thakur opened a new pull request #2187: URL: https://github.com/apache/hadoop/pull/2187 Tested by running this test only against ap-south-1 bucket configured with all three encryption algo. This is an automated

[GitHub] [hadoop] mukund-thakur commented on pull request #2187: HADOOP-17167 Skipping ITestS3AEncryptionWithDefaultS3Settings.testEncryptionOverRename

2020-08-03 Thread GitBox
mukund-thakur commented on pull request #2187: URL: https://github.com/apache/hadoop/pull/2187#issuecomment-668124897 CC @steveloughran This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hadoop] szetszwo commented on a change in pull request #2175: HDFS-15497. Make snapshot limit on global as well per snapshot root directory configurable

2020-08-03 Thread GitBox
szetszwo commented on a change in pull request #2175: URL: https://github.com/apache/hadoop/pull/2175#discussion_r464571396 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/snapshot/SnapshotManager.java ## @@ -99,13 +99,15 @@

[GitHub] [hadoop] bshashikant commented on a change in pull request #2175: HDFS-15497. Make snapshot limit on global as well per snapshot root directory configurable

2020-08-03 Thread GitBox
bshashikant commented on a change in pull request #2175: URL: https://github.com/apache/hadoop/pull/2175#discussion_r464581693 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java ## @@ -498,9 +498,14 @@ public static final

[GitHub] [hadoop] aajisaka commented on pull request #2177: YARN-10366. Fix Yarn rmadmin Markdown document

2020-08-03 Thread GitBox
aajisaka commented on pull request #2177: URL: https://github.com/apache/hadoop/pull/2177#issuecomment-667922145 Hi @kevinzhao1661 , would you file a new issue in the ASF JIRA? > Please create an issue in ASF JIRA before opening a pull request, and you need to set the title of the

[GitHub] [hadoop] swamirishi commented on a change in pull request #2133: HADOOP-17122: Preserving Directory Attributes in DistCp with Atomic Copy

2020-08-03 Thread GitBox
swamirishi commented on a change in pull request #2133: URL: https://github.com/apache/hadoop/pull/2133#discussion_r464329525 ## File path: hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/mapred/TestCopyCommitter.java ## @@ -160,10 +160,10 @@ public void

[jira] [Commented] (HADOOP-17122) Bug in preserving Directory Attributes in DistCp with Atomic Copy

2020-08-03 Thread Swaminathan Balachandran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169892#comment-17169892 ] Swaminathan Balachandran commented on HADOOP-17122: --- [~mukund-thakur] I have replied

[GitHub] [hadoop] swamirishi commented on a change in pull request #2133: HADOOP-17122: Preserving Directory Attributes in DistCp with Atomic Copy

2020-08-03 Thread GitBox
swamirishi commented on a change in pull request #2133: URL: https://github.com/apache/hadoop/pull/2133#discussion_r464388213 ## File path: hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/mapred/TestCopyCommitter.java ## @@ -160,10 +160,10 @@ public void

[GitHub] [hadoop] aajisaka commented on a change in pull request #2177: YARN-10366. Fix Yarn rmadmin Markdown document

2020-08-03 Thread GitBox
aajisaka commented on a change in pull request #2177: URL: https://github.com/apache/hadoop/pull/2177#discussion_r464302520 ## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/YarnCommands.md ## @@ -238,7 +238,7 @@ Usage: | -getGroups [username]

[GitHub] [hadoop] mukund-thakur commented on a change in pull request #2133: HADOOP-17122: Preserving Directory Attributes in DistCp with Atomic Copy

2020-08-03 Thread GitBox
mukund-thakur commented on a change in pull request #2133: URL: https://github.com/apache/hadoop/pull/2133#discussion_r464386889 ## File path: hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/mapred/TestCopyCommitter.java ## @@ -160,10 +160,10 @@ public void

[GitHub] [hadoop] mukund-thakur commented on a change in pull request #2133: HADOOP-17122: Preserving Directory Attributes in DistCp with Atomic Copy

2020-08-03 Thread GitBox
mukund-thakur commented on a change in pull request #2133: URL: https://github.com/apache/hadoop/pull/2133#discussion_r464288595 ## File path: hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/mapred/TestCopyCommitter.java ## @@ -160,10 +160,10 @@ public void

[GitHub] [hadoop] bshashikant commented on a change in pull request #2175: HDFS-15497. Make snapshot limit on global as well per snapshot root directory configurable

2020-08-03 Thread GitBox
bshashikant commented on a change in pull request #2175: URL: https://github.com/apache/hadoop/pull/2175#discussion_r464420469 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/snapshot/SnapshotManager.java ## @@ -117,23

[GitHub] [hadoop] hadoop-yetus commented on pull request #2185: HADOOP-15891. provide Regex Based Mount Point In Inode Tree

2020-08-03 Thread GitBox
hadoop-yetus commented on pull request #2185: URL: https://github.com/apache/hadoop/pull/2185#issuecomment-667912969 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hadoop] aajisaka commented on a change in pull request #2177: YARN-10366. Fix Yarn rmadmin Markdown document

2020-08-03 Thread GitBox
aajisaka commented on a change in pull request #2177: URL: https://github.com/apache/hadoop/pull/2177#discussion_r464302520 ## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/YarnCommands.md ## @@ -238,7 +238,7 @@ Usage: | -getGroups [username]

[GitHub] [hadoop] kevinzhao1661 commented on pull request #2177: YARN-10383. Fix Yarn rmadmin Markdown document

2020-08-03 Thread GitBox
kevinzhao1661 commented on pull request #2177: URL: https://github.com/apache/hadoop/pull/2177#issuecomment-667949459 @aajisaka A new issue for this PR.YARN-10383 This is an automated message from the Apache Git Service.

[GitHub] [hadoop] zhouyuan commented on pull request #1947: HDFS-14950. fix missing libhdfspp lib in dist-package

2020-08-03 Thread GitBox
zhouyuan commented on pull request #1947: URL: https://github.com/apache/hadoop/pull/1947#issuecomment-667989252 @aajisaka thanks for the help! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop] mukund-thakur commented on pull request #2133: HADOOP-17122: Preserving Directory Attributes in DistCp with Atomic Copy

2020-08-03 Thread GitBox
mukund-thakur commented on pull request #2133: URL: https://github.com/apache/hadoop/pull/2133#issuecomment-668043087 Looks good from my side. Though there is one checkstyle issue. Please address that. @steveloughran will be able to merge as he only has merge access.

[GitHub] [hadoop] hangc0276 commented on a change in pull request #2182: HDFS-15505. Fix NullPointerException when call getAdditionalDatanode method with null extendedBlock parameter

2020-08-03 Thread GitBox
hangc0276 commented on a change in pull request #2182: URL: https://github.com/apache/hadoop/pull/2182#discussion_r464437130 ## File path: hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolTranslatorPB.java ## @@

[jira] [Commented] (HADOOP-17122) Bug in preserving Directory Attributes in DistCp with Atomic Copy

2020-08-03 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169869#comment-17169869 ] Hadoop QA commented on HADOOP-17122: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[GitHub] [hadoop] aajisaka commented on pull request #2177: YARN-10366. Fix Yarn rmadmin Markdown document

2020-08-03 Thread GitBox
aajisaka commented on pull request #2177: URL: https://github.com/apache/hadoop/pull/2177#issuecomment-667930221 > do I need to mention a new jira? Yes This is an automated message from the Apache Git Service. To respond

[GitHub] [hadoop] aajisaka edited a comment on pull request #2177: YARN-10366. Fix Yarn rmadmin Markdown document

2020-08-03 Thread GitBox
aajisaka edited a comment on pull request #2177: URL: https://github.com/apache/hadoop/pull/2177#issuecomment-667930221 > do I need to mention a new jira? Yes This is an automated message from the Apache Git Service.

[GitHub] [hadoop] kevinzhao1661 commented on pull request #2177: YARN-10366. Fix Yarn rmadmin Markdown document

2020-08-03 Thread GitBox
kevinzhao1661 commented on pull request #2177: URL: https://github.com/apache/hadoop/pull/2177#issuecomment-667929028 @aajisaka This change is a supplement to YARN-10366, do I need to mention a new jira? This is an

[jira] [Commented] (HADOOP-17181) ITestS3AContractUnbuffer failure -stream.read didn't return all data

2020-08-03 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170351#comment-17170351 ] Steve Loughran commented on HADOOP-17181: - {code} [ERROR]

[jira] [Created] (HADOOP-17181) ITestS3AContractUnbuffer failure -stream.read didn't return all data

2020-08-03 Thread Steve Loughran (Jira)
Steve Loughran created HADOOP-17181: --- Summary: ITestS3AContractUnbuffer failure -stream.read didn't return all data Key: HADOOP-17181 URL: https://issues.apache.org/jira/browse/HADOOP-17181

[jira] [Updated] (HADOOP-15891) Provide Regex Based Mount Point In Inode Tree

2020-08-03 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HADOOP-15891: --- Component/s: (was: fs) viewfs > Provide Regex Based Mount Point In

[GitHub] [hadoop] steveloughran commented on pull request #2148: HADOOP-17131 Moving listing to use operation callback

2020-08-03 Thread GitBox
steveloughran commented on pull request #2148: URL: https://github.com/apache/hadoop/pull/2148#issuecomment-668216731 yetus doesn't seem to be live right now, so we don't have a final check. But some of its earlier comments are still there by the look of things, especially ```

[GitHub] [hadoop] liuml07 commented on pull request #2185: HADOOP-15891. provide Regex Based Mount Point In Inode Tree

2020-08-03 Thread GitBox
liuml07 commented on pull request #2185: URL: https://github.com/apache/hadoop/pull/2185#issuecomment-668274867 This seems an interesting feature. Do we need to update the `ViewFs.md` user guide? This is an automated

[GitHub] [hadoop] bshashikant commented on a change in pull request #2175: HDFS-15497. Make snapshot limit on global as well per snapshot root directory configurable

2020-08-03 Thread GitBox
bshashikant commented on a change in pull request #2175: URL: https://github.com/apache/hadoop/pull/2175#discussion_r464587720 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/snapshot/SnapshotManager.java ## @@ -99,13 +99,15

[GitHub] [hadoop] JohnZZGithub commented on pull request #2185: HADOOP-15891. provide Regex Based Mount Point In Inode Tree

2020-08-03 Thread GitBox
JohnZZGithub commented on pull request #2185: URL: https://github.com/apache/hadoop/pull/2185#issuecomment-668288316 @liuml07 Thanks, this is a feature adopted inside our company for almost two years. The code is almost as same as our internal branch except I removed some refactored code

[GitHub] [hadoop] JohnZZGithub commented on pull request #2185: HADOOP-15891. provide Regex Based Mount Point In Inode Tree

2020-08-03 Thread GitBox
JohnZZGithub commented on pull request #2185: URL: https://github.com/apache/hadoop/pull/2185#issuecomment-668314560 @templedf It will be great if you could help with the review, thanks. This is an automated message from

[GitHub] [hadoop] huangtianhua opened a new pull request #2189: HDFS-15025. Applying NVDIMM storage media to HDFS

2020-08-03 Thread GitBox
huangtianhua opened a new pull request #2189: URL: https://github.com/apache/hadoop/pull/2189 The non-volatile memory NVDIMM is faster than SSD, it can be used simultaneously with RAM, DISK and SSD. Storing the data of HDFS on NVDIMM directly will get better response rate and

[GitHub] [hadoop] liuml07 opened a new pull request #2188: HDFS-15499. Clean up httpfs/pom.xml to remove aws-java-sdk-s3 exclusion

2020-08-03 Thread GitBox
liuml07 opened a new pull request #2188: URL: https://github.com/apache/hadoop/pull/2188 ## NOTICE Please create an issue in ASF JIRA before opening a pull request, and you need to set the title of the pull request which starts with the corresponding JIRA issue number. (e.g.

[GitHub] [hadoop] aajisaka merged pull request #2177: YARN-10383. Fix Yarn rmadmin Markdown document

2020-08-03 Thread GitBox
aajisaka merged pull request #2177: URL: https://github.com/apache/hadoop/pull/2177 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Updated] (HADOOP-14056) Update maven-javadoc-plugin to 2.10.4

2020-08-03 Thread Akira Ajisaka (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-14056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka updated HADOOP-14056: --- Cherry-picked to branch-2.10 to support javadoc-no-fork goal, which is used in precommit jobs

[jira] [Updated] (HADOOP-14056) Update maven-javadoc-plugin to 2.10.4

2020-08-03 Thread Akira Ajisaka (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-14056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka updated HADOOP-14056: --- Fix Version/s: 2.10.1 > Update maven-javadoc-plugin to 2.10.4 >

[GitHub] [hadoop] huangtianhua closed pull request #2109: HDFS-15025. Applying NVDIMM storage media to HDFS

2020-08-03 Thread GitBox
huangtianhua closed pull request #2109: URL: https://github.com/apache/hadoop/pull/2109 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hadoop] hadoop-yetus commented on pull request #2175: HDFS-15497. Make snapshot limit on global as well per snapshot root directory configurable

2020-08-03 Thread GitBox
hadoop-yetus commented on pull request #2175: URL: https://github.com/apache/hadoop/pull/2175#issuecomment-668390729 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Created] (HADOOP-17179) [JDK 11] Fix javadoc error while detecting Java API link

2020-08-03 Thread Akira Ajisaka (Jira)
Akira Ajisaka created HADOOP-17179: -- Summary: [JDK 11] Fix javadoc error while detecting Java API link Key: HADOOP-17179 URL: https://issues.apache.org/jira/browse/HADOOP-17179 Project: Hadoop Common

[jira] [Updated] (HADOOP-17179) [JDK 11] Fix javadoc error in Java API link detection

2020-08-03 Thread Akira Ajisaka (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka updated HADOOP-17179: --- Summary: [JDK 11] Fix javadoc error in Java API link detection (was: [JDK 11] Fix

[GitHub] [hadoop] swamirishi commented on a change in pull request #2133: HADOOP-17122: Preserving Directory Attributes in DistCp with Atomic Copy

2020-08-03 Thread GitBox
swamirishi commented on a change in pull request #2133: URL: https://github.com/apache/hadoop/pull/2133#discussion_r464256899 ## File path: hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/mapred/TestCopyCommitter.java ## @@ -177,6 +177,44 @@ public void

[jira] [Updated] (HADOOP-17179) [JDK 11] Fix javadoc error while detecting Java API link

2020-08-03 Thread Akira Ajisaka (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka updated HADOOP-17179: --- Parent: HADOOP-16795 Issue Type: Sub-task (was: Bug) > [JDK 11] Fix javadoc error

[jira] [Commented] (HADOOP-17179) [JDK 11] Fix javadoc error while detecting Java API link

2020-08-03 Thread Akira Ajisaka (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169775#comment-17169775 ] Akira Ajisaka commented on HADOOP-17179: In HADOOP-17091, I set the source version to 8 to fix

[jira] [Updated] (HADOOP-17179) [JDK 11] Fix javadoc error in Java API link detection

2020-08-03 Thread Akira Ajisaka (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka updated HADOOP-17179: --- Status: Patch Available (was: Open) > [JDK 11] Fix javadoc error in Java API link

[GitHub] [hadoop] aajisaka opened a new pull request #2186: HADOOP-17179. [JDK 11] Fix javadoc error while detecting Java API link

2020-08-03 Thread GitBox
aajisaka opened a new pull request #2186: URL: https://github.com/apache/hadoop/pull/2186 JIRA: https://issues.apache.org/jira/browse/HADOOP-17179 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop] swamirishi commented on a change in pull request #2133: HADOOP-17122: Preserving Directory Attributes in DistCp with Atomic Copy

2020-08-03 Thread GitBox
swamirishi commented on a change in pull request #2133: URL: https://github.com/apache/hadoop/pull/2133#discussion_r464243407 ## File path: hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/mapred/TestCopyCommitter.java ## @@ -177,6 +177,44 @@ public void

[jira] [Created] (HADOOP-17180) S3Guard: Include 500 DynamoDB system errors in exponential backoff retries

2020-08-03 Thread David Kats (Jira)
David Kats created HADOOP-17180: --- Summary: S3Guard: Include 500 DynamoDB system errors in exponential backoff retries Key: HADOOP-17180 URL: https://issues.apache.org/jira/browse/HADOOP-17180 Project:

[jira] [Comment Edited] (HADOOP-17122) Bug in preserving Directory Attributes in DistCp with Atomic Copy

2020-08-03 Thread Swaminathan Balachandran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169819#comment-17169819 ] Swaminathan Balachandran edited comment on HADOOP-17122 at 8/3/20, 8:37 AM:

[jira] [Commented] (HADOOP-17122) Bug in preserving Directory Attributes in DistCp with Atomic Copy

2020-08-03 Thread Swaminathan Balachandran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169819#comment-17169819 ] Swaminathan Balachandran commented on HADOOP-17122: --- [~ste...@apache.org] I see I