[jira] [Commented] (HADOOP-15836) Review of AccessControlList.java

2018-10-19 Thread JIRA
[ https://issues.apache.org/jira/browse/HADOOP-15836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16657407#comment-16657407 ] Íñigo Goiri commented on HADOOP-15836: -- +1 on [^HADOOP-15836.1.patch]. > Review of

[jira] [Commented] (HADOOP-15836) Review of AccessControlList.java

2018-10-19 Thread BELUGA BEHR (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16657350#comment-16657350 ] BELUGA BEHR commented on HADOOP-15836: -- I though about this previously. This information can be

[jira] [Commented] (HADOOP-15836) Review of AccessControlList.java

2018-10-19 Thread JIRA
[ https://issues.apache.org/jira/browse/HADOOP-15836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16657332#comment-16657332 ] Íñigo Goiri commented on HADOOP-15836: -- I've seen dependencies on the order of the hashes in unit

[jira] [Commented] (HADOOP-15836) Review of AccessControlList.java

2018-10-19 Thread BELUGA BEHR (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16657309#comment-16657309 ] BELUGA BEHR commented on HADOOP-15836: -- ... the {{TreeSet}} enforces the user and group names to

[jira] [Commented] (HADOOP-15836) Review of AccessControlList.java

2018-10-19 Thread BELUGA BEHR (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16657307#comment-16657307 ] BELUGA BEHR commented on HADOOP-15836: -- [~elgoiri] Good eyes. All things equal, I'd prefer a

[jira] [Commented] (HADOOP-15836) Review of AccessControlList.java

2018-10-19 Thread JIRA
[ https://issues.apache.org/jira/browse/HADOOP-15836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16657150#comment-16657150 ] Íñigo Goiri commented on HADOOP-15836: -- These changes are easier to check than the previous ones

[jira] [Commented] (HADOOP-15836) Review of AccessControlList.java

2018-10-19 Thread BELUGA BEHR (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16656912#comment-16656912 ] BELUGA BEHR commented on HADOOP-15836: -- [~elgoiri] You see what happens when you are too kind? :)

[jira] [Commented] (HADOOP-15836) Review of AccessControlList.java

2018-10-09 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16644126#comment-16644126 ] Hadoop QA commented on HADOOP-15836: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||