Re: [PR] HADOOP-19103 : Add logic for verifying that the STS URL is in the correct format [hadoop]

2024-04-24 Thread via GitHub
hadoop-yetus commented on PR #6615: URL: https://github.com/apache/hadoop/pull/6615#issuecomment-2076140834 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HADOOP-19103 : Add logic for verifying that the STS URL is in the correct format [hadoop]

2024-03-13 Thread via GitHub
ahmarsuhail commented on code in PR #6615: URL: https://github.com/apache/hadoop/pull/6615#discussion_r1523052340 ## hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3ATemporaryCredentials.java: ## @@ -325,16 +356,13 @@ public void

Re: [PR] HADOOP-19103 : Add logic for verifying that the STS URL is in the correct format [hadoop]

2024-03-06 Thread via GitHub
shameersss1 commented on code in PR #6615: URL: https://github.com/apache/hadoop/pull/6615#discussion_r1515670775 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/auth/STSClientFactory.java: ## @@ -125,6 +125,14 @@ public static StsClientBuilder builder(

Re: [PR] HADOOP-19103 : Add logic for verifying that the STS URL is in the correct format [hadoop]

2024-03-06 Thread via GitHub
shameersss1 commented on code in PR #6615: URL: https://github.com/apache/hadoop/pull/6615#discussion_r1515667380 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/auth/delegation/DelegationConstants.java: ## @@ -160,6 +160,18 @@ public final class

Re: [PR] HADOOP-19103 : Add logic for verifying that the STS URL is in the correct format [hadoop]

2024-03-06 Thread via GitHub
hadoop-yetus commented on PR #6615: URL: https://github.com/apache/hadoop/pull/6615#issuecomment-1982725960 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |