RE: [collections][PATCH] SequencedHashMap violates Map contract, has poor performance -- BufferCache, SequencedHastable, MRUMap and LRUMap .

2002-02-03 Thread Michael Smith
I was talking about the one in cvs. I was trying to point out that there are other classes that suffer from the same problem that you are fixing and that there are other problems with one of the LRU implementations. See the other emails. ok. I've looked over some of the classes you

RE: [collections][PATCH] SequencedHashMap violates Map contract, has poor performance -- BufferCache, SequencedHastable, MRUMap and LRUMap .

2002-02-03 Thread Aaron Smuts
-Original Message- From: Michael Smith [mailto:[EMAIL PROTECTED]] Sent: Sunday, February 03, 2002 11:30 AM To: Jakarta Commons Developers List Subject: RE: [collections][PATCH] SequencedHashMap violates Map contract, has poor performance -- BufferCache, SequencedHastable, MRUMap

RE: [collections][PATCH] SequencedHashMap violates Map contract, has poor performance -- BufferCache, SequencedHastable, MRUMap and LRUMap .

2002-02-03 Thread Aaron Smuts
-Original Message- From: Michael Smith [mailto:[EMAIL PROTECTED]] Sent: Sunday, February 03, 2002 5:17 PM To: Jakarta Commons Developers List; [EMAIL PROTECTED] Subject: RE: [collections][PATCH] SequencedHashMap violates Map contract, has poor performance -- BufferCache

RE: [collections][PATCH] SequencedHashMap violates Map contract, has poor performance -- BufferCache, SequencedHastable, MRUMap and LRUMap .

2002-02-03 Thread Michael Smith
Aaron Smuts [mailto:[EMAIL PROTECTED]] wrote: I'm looking for new memory management algorithms for JCS. The LRU I'm using, which is basically the LRUStore I added, is good, but I'd like something more efficient for huge collections of objects. Basically, every get results in a reshuffling

Re: [collections][PATCH] SequencedHashMap violates Map contract, has poor performance

2002-02-01 Thread James Strachan
+1 Sounds good to me. James - Original Message - From: Remy Maucherat [EMAIL PROTECTED] I've submitted this patch twice now (once back in mid-November, once a week ago), but it still has yet to be committed. If nobody has time to apply or look at Michael's patches, how about

RE: [collections][PATCH] SequencedHashMap violates Map contract, has poor performance

2002-02-01 Thread Paulo Gaspar
] SequencedHashMap violates Map contract, has poor performance +1 Sounds good to me. James - Original Message - From: Remy Maucherat [EMAIL PROTECTED] I've submitted this patch twice now (once back in mid-November, once a week ago), but it still has yet to be committed. If nobody has

RE: [collections][PATCH] SequencedHashMap violates Map contract, has poor performance

2002-02-01 Thread Michael Smith
Strachan [mailto:[EMAIL PROTECTED]] Sent: Friday, February 01, 2002 2:01 PM To: Jakarta Commons Developers List Subject: Re: [collections][PATCH] SequencedHashMap violates Map contract, has poor performance +1 Sounds good to me. James - Original Message - From: Remy

RE: [collections][PATCH] SequencedHashMap violates Map contract, has poor performance -- BufferCache, SequencedHastable, MRUMap and LRUMap.

2002-02-01 Thread Aaron Smuts
: Friday, February 01, 2002 9:25 AM To: Jakarta Commons Developers List Subject: RE: [collections][PATCH] SequencedHashMap violates Map contract, has poor performance -Original Message- I just took a look at the code. There were a couple of details that are still not clear

RE: [collections][PATCH] SequencedHashMap violates Map contract, has poor performance

2002-02-01 Thread Paulo Gaspar
-Original Message- From: Michael Smith [mailto:[EMAIL PROTECTED]] Sent: Friday, February 01, 2002 3:25 PM To: Jakarta Commons Developers List Subject: RE: [collections][PATCH] SequencedHashMap violates Map contract, has poor performance -Original Message- I just took

Re: [collections][PATCH] SequencedHashMap violates Map contract, has poor performance

2002-02-01 Thread Remy Maucherat
Just 2 comments: - I understand the use of the sentinel but in the very fast glance I took at the code I still did not understand a couple of bits of code related to it. Since it was a very fast glance, it is very probable that everything is ok and that I just didn't get it yet.

RE: [collections][PATCH] SequencedHashMap violates Map contract, has poor performance -- BufferCache, SequencedHastable, MRUMap and LRUMap.

2002-02-01 Thread Michael A. Smith
On Fri, 1 Feb 2002, Aaron Smuts wrote: The SequencedHashMap has the same problem with the LinkedList remove operation which executes in O(N) time as BufferCache, SequencedHastable, and MRUMap. Umm... I'm a bit confused. Are you referring to the SequencedHashMap that exists in current CVS,

Re: [collections][PATCH] SequencedHashMap violates Map contract,has poor performance

2002-02-01 Thread Michael A. Smith
On Fri, 1 Feb 2002, Remy Maucherat wrote: No, there's no general rule and no Coding Style Police either :-) If you contribute to a component, the general rule is that you're supposed to follow the component's coding style. that's rule number one in the Elements of Java Style. :) michael

RE: [collections][PATCH] SequencedHashMap violates Map contract, has poor performance

2002-02-01 Thread Scott Sanders
Developers List Subject: RE: [collections][PATCH] SequencedHashMap violates Map contract, has poor performance +1 -Original Message- From: Scott Sanders [mailto:[EMAIL PROTECTED]] Sent: Friday, February 01, 2002 7:25 PM To: Jakarta Commons Developers List Subject: RE

RE: [collections][PATCH] SequencedHashMap violates Map contract,has poor performance

2002-02-01 Thread Scott Sanders
: RE: [collections][PATCH] SequencedHashMap violates Map contract,has poor performance On Fri, 1 Feb 2002, Scott Sanders wrote: Michael, looks like you have made it to committer status in Commons. Do you want it? If so, do you have an apache id, and if so, what is it? why

RE: [collections][PATCH] SequencedHashMap violates Map contract,has poor performance

2002-02-01 Thread Michael A. Smith
- From: Paulo Gaspar [mailto:[EMAIL PROTECTED]] Sent: Friday, February 01, 2002 11:59 AM To: Jakarta Commons Developers List Subject: RE: [collections][PATCH] SequencedHashMap violates Map contract, has poor performance +1 -Original Message- From: Scott Sanders [mailto