[commons-sandbox-net] Re: [devel-netcomponents] Patch for TFTP to ignore remote address

2002-05-27 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], yschimke writes: I've uploaded a tar file containing the modified TFTPClient.java file and some junit test cases. Since I don't have apache commit rights, could someone take on the duty of validating my changes and committing them. Patches should go to

Re: [patch] NetComponents - TelnetInputStream.java threading issue

2002-09-19 Thread Daniel F. Savarese
I wrote: In the patch, making __hasReachedEOF and __isClosed volatile doesn't do anything. Those are not static variables. Changing the notify() to Er, what I meant to say is that assignments to those variables are already protected by critical sections. Your patch removed one of those

Re: [patch] NetComponents - FTPClient's restart functionality

2002-09-20 Thread Daniel F. Savarese
This is a patch to fix the restart functionality in FTPClient. Following is the summary of changes: Thanks! I for some reason thought we had applied this when you first brought it up, but I guess not. I applied it with one minor change. I allowed the offset to be reset to zero. You might

Re: next possible commons project - [regexp]

2002-09-26 Thread Daniel F. Savarese
Stephen Colebourne writes: In the same way as [logging], by not being a regexp package itself. Of course it may just not be appropriate... I just want to point out that jakarta-oro is more than just a regular expression package and already contains the generic interfaces to wrap other packages

Re: next possible commons project - [regexp]

2002-09-26 Thread Daniel F. Savarese
Steve Downey wrote: The odds of having two projects that require regexp packages that can also tolerate having the definition of regular expression changed underneath them approaches zero. I agree with this as far as most applications are concerned. I don't know the original motivation for

Re: [GUMP] Build Failure - commons-net

2002-10-04 Thread Daniel F. Savarese
BUILD FAILED file:/home/rubys/jakarta/jakarta-commons-sandbox/net/build.xml:76: /home/rubys/jakarta/jakarta-commons-sandbox/net/lib not found. I'm currently Maven impaired and am afraid I'll break something if I try to fix whatever the autogeneration of the build.xml file. Jeff if you have a

[NET] FTP Client, release quality? (fwd)

2002-10-11 Thread Daniel F. Savarese
It looks like this message should have gone to commons-dev. --- Forwarded Message From: [EMAIL PROTECTED] Subject: FTP Client, release quality? To: [EMAIL PROTECTED] X-Mailer: Lotus Notes Release 5.0.6 December 14, 2000 Message-ID: [EMAIL PROTECTED] Date: Fri, 11 Oct 2002 09:14:36 -0500

Re: [net] momentum for promotion?

2003-01-26 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], Jeffrey D. Brekke writes: The above two items are completed. If there are any problems, let me know but the main project and proposal are building for me ok after a clean check-out. The site has been regenerated and redeployed. I tried to do a fresh checkout to

Re: [net] momentum for promotion?

2003-01-27 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], Jeffrey D. Brekke writes: I performed your statement from above and all dirs under proposal/ftp/src have group writeable set now. Thanks. I successfully did a fresh check out and build. Sorry about that, I hate messing about in the repo, but there's no other good

Re: [net] Refactoring of ftp2

2003-01-28 Thread Daniel F. Savarese
Steve Cohen writes: I may be oversimplifying slightly, but this scheme would allow all the new parsing functionality I introduced to integrate seamlessly with the old system while totally preserving backward compatibility. I think it would be much easier for end-users to understand than the ftp2

Re: [VOTE] Promote net from commons sandbox to commons

2003-01-28 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], robert burr ell donkin writes: sorry i pushed this vote a bit too early. I don't think it's prematur. I think a call for a new vote had to come from someone other than Jeff or myself to reflect the itch out there for a formal release. Clearly, within Apache, at

Re: [net] TelnetClient on Solaris - timeout problem

2003-01-30 Thread Daniel F. Savarese
In message p05210200ba5e86b720c2@[192.168.1.50], =?iso-8859-1?Q?J=F8rgen?= =? iso-8859-1?Q?_?= =?iso-8859-1?Q?N=F8rgaard?= writes: On Solaris however all connections using commons-net timeout after around 4 mins. The only way I see to do something on Solaris is to use jdk1.4.x which has a more

Re: [codec] RE: more common classes need a home

2003-02-03 Thread Daniel F. Savarese
I tried to read to the end of the thread so far before replying. If the feeling is that the classes will see more use distributed separately from HttpClient, I concur with Henri's assessment below. In message [EMAIL PROTECTED], Hen ri Yandell writes: I'm +1 to commons-uri. As Tim points out,

Re: [RESULT] [net] is promoted to the commons

2003-02-04 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], robert burr ell donkin writes: you and Daniel are now entitled to commons karma (but you might need to ask someone to get it). I'll send a request in a minute to the PMC cc'ed to commons-dev asking for Jeff and myself to be added to the avail entry for

Re: [RESULT] [net] is promoted to the commons

2003-02-04 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], robert burr ell donkin writes: by my count, we now have 3 +1's, 3 +0's and no -0's or -1's. therefore, net is promoted to the commons. Dear Jakarta PMC, Jakarta Commons has just completed a vote, promoting jakarta-commons-sandbox/net out of the Sandbox and into

[net] action items

2003-02-04 Thread Daniel F. Savarese
Just figured I'd start a new thread to mark off items as they're completed. If I missed any of the TODOs that have been mentioned, just add 'em. [x] Get dfs and brekke commit privileges. [x] Move cvs repository from sandbox to commons proper. [x] Move project pages from sandbox to commons

Re: [net] action items

2003-02-04 Thread Daniel F. Savarese
I updated the gump descriptors, cutting and pasting. Leveraging the time I've spent lurking on alexandria-dev and now gump¸ I got gen.sh to work and built commons-net, verifying my descriptor changes with update.sh jakarta-ant build.sh bootstrap-ant update.sh jakarta-commons build.sh

Re: [net] action items

2003-02-08 Thread Daniel F. Savarese
I added an announcement to jakarta-site2/xdocs/site/news.xml, emailed an announcement to announcements@jakarta and commons-user and submitted a newsletter item to general@jakarta. Feel free to tweak the announcements. I just wrote something up quickly while I had some time. I think we've

Re: [net] action items: Version Number

2003-02-11 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], Jeffrey D. Brekke writes: I'll start with a vocie for a version number of 1.0.0 following the commons gu idelines for versioning. We already have the migration how-to setup for moving from NetComponents 1.3.8 to Commons/Net 1.0.0 Sounds good to me. My bias is

Re: [VOTE}[net] Release 1.0.0 of Commons/Net

2003-02-17 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], Jeffrey D. Brekke writes: Vote: Commons/Net 1.0.0 Release [X] +1 I am in favor of the release, and will help support it. daniel - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional

Re: [VOTE}[net] Steve Cohen as committer

2003-02-17 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], Jeffrey D. Brekke writes: Steve Cohen commiter for Commons/Net +1 daniel - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: [ANNOUNCE] Commons Net 1.0.0 Released

2003-02-23 Thread Daniel F. Savarese
Thanks Jeff and Robert for taking the time out of your schedules to get this release out the door! daniel - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: Problems using maven site:deploy

2003-02-28 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], robert burre ll donkin writes: AFAIK jakarta.apache is www.apache.org which is daedelus. IIRC brian asked that only people that really need daedelus accounts (eg release managers) apply for them (since the server is overstretched). if you don't have an account and

Re: [NET] Here's an Ant bug that we should look into fixing

2003-03-09 Thread Daniel F. Savarese
I had thought I might hear some replies to this. The silence has been = deafening. I haven't said anything because 1. no time and 2. it was a feature request and not a bug :) As you indicated, FTP listings can take on any arbitrary format. We can only hope to handle the most common cases and

Re: Adding TERMINAL-TYPE option to TelnetClient

2003-03-10 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], =?iso-8859-1?Q [EMAIL PROTECTED] writes: I think this functionality could potentially be interesting for other users of the library, so I would like to propose that the updated sources be included You forgot to include a patch :) I think it goes without saying that

Re: [PATCH] performance problem w/ FTPClient

2003-03-15 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], Patrick Schoon veld writes: long to upload. The problem turned out to be in the __storeFileStream function where the class, by default, filters for line separator characters. ... I added a function to optionally turn this feature off. I'm not sure if it's useful for

Re: [PATCH] performance problem w/ FTPClient

2003-03-15 Thread Daniel F. Savarese
I forgot to add that my comment doesn't mean that the ASCII transfers couldn't be optimized. It's probably better to read the file in big chunks, scan the chunks and translate to another buffer (twice the size to handle the degenerate case of every character being a line feed), and write that

Re: [VFS] FtpFileSystem and passive connections

2003-03-16 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], Mario Ivankovits wr ites: 1) switch to passive mode by environment setting and code this in = FTPClient.createConnection() - this is an global setting, but it might depend on the destination host = what of active/passive has to be selected There is no

Re: [NET] listing formats

2003-03-16 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], St eve Cohen writes: Another RFC document of interest is = http://www.rfc-editor.org/rfc/rfc2640.txt. I at first thought that this document might be heading down the paths I = was looking at, but alas, it is approaching i18n only from the point of = view of character

Re: [VFS] FtpFileSystem and passive connections

2003-03-18 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], Mario Ivankovits wr ites: So maybe VFS should be able to handle such urls ftp://[EMAIL PROTECTED]@proxy:proxyport/ Do you agree. That's one for the VFS folks, but I do think the issues you've brought up lie in VFS, above the Commons Net layer. daniel

Re: [net][patch] jdk 1.4 specific call in VMSFTPEntryParser.java

2003-08-09 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], Jeffrey D. Brekke writes: I saw this and meant to ask about it. Where can I find more info on this? I used emacs for quite a while and still do, but the refactoring tools in eclipse are too attractive ;) I still like to use emacs for quick editing and want to know

Re: [net][patch] jdk 1.4 specific call in VMSFTPEntryParser.java

2003-08-14 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], Jeffrey D. Brekke writes: I've committed some changes to the VMSFTPEntryParser tests. The tests that went with the last patch didn't really test the methods correctly. Now the parseFileList() method is tested. Support for versions is not tested at this time and

Re: [net][patch] jdk 1.4 specific call in VMSFTPEntryParser.java

2003-08-14 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], Daniel F. Savar ese writes: I'm having a heck of a time applying the patch (patch keeps on spouting patch: `' expected at line 10 of patch for some reason) and don't want to run the risk of error by inserting the lines manually. Can you post the patch in

Re: [net][patch] jdk 1.4 specific call in VMSFTPEntryParser.java

2003-08-14 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], R ory Winston writes: I've cleaned up a bit (applied my changes to a fresh checkout) and generated a diff file. I've taken out the XHDR addition for now, as XOVER seems to be the preferred mechanism for this kind of thing. The functionality added is: This is great,

Re: [net][patch] jdk 1.4 specific call in VMSFTPEntryParser.java

2003-08-15 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], Daniel F. Savar ese writes: In message [EMAIL PROTECTED], R ory Winston writes: I've cleaned up a bit (applied my changes to a fresh checkout) and generated a diff file. I've taken out the XHDR addition for now, as XOVER seems to be the preferred mechanism for this

Re: [lang][all?] LICENSE.txt spelling acknowlegement

2003-08-17 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], Ga ry Gregory writes: MS-Word says acknowlegement is not spelled correctly; it should be acknowledgement (missing d). Is this a spelling error or another US-Eng vs. British-Eng? That's a spelling error. The only two accepted spellings for acknowledgement (in the

Re: FW: [net][patch] extended NNTP commands

2003-08-25 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], R ory Winston writes: Hi Daniel Did you recieve this patch OK? Sorry, I've fallen way behind on email. There was no patch in your email. I'm tying up loose ends with jakarta stuff I'm involved with, so if you could send it to me today or tomorrow I can apply it

Re: UnixFTPEntryParser - small fix (?)

2003-08-25 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], =?iso-8859-1 ?Q?Matthieu_Recouly?= writes: Your parser does not allow to retrieve files list on a ftp server that uses weird Unix listing style as described on http://www.javaworld.com/javaworld/jw-04-2003/jw-0404-ftp-p2.html This is when user has no group, your

[net] Re: NNTP Patches

2003-09-04 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], R ory Winston writes: Sorry to send this to you directly - I just wanted to find out if you had any problems applying the NNTP patch that I sent to you? I'm behind on many Jakarta obligations. Thanks for the resend. I was able to apply it today (sending it as an

Re: [VOTE] Sort of new committer:

2003-09-11 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], Shapi ra, Yoav writes: I'd like to nominate I would like to propose Jean-Frederic Clere ([EMAIL PROTECTED]) as a new commons committer. He's already a +1 - To unsubscribe, e-mail: [EMAIL

Re: [net][patch] Added more robust SocketClient setup/cleanu

2003-09-14 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], Jason Mathews writes: But checking if a socket is null in the close() for example is good practice. Often a programmer will close the Socket, JDBC connection, etc in a finally block whether or not is was or still is connected. The Socket or SocketClient class in

Re: [net][patch] Added more robust SocketClient setup/cleanu

2003-09-22 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], Jeffrey D. Brekke writes: Applying the patch and cutting a RC1 gets a +1 from me. I'd say after Wed./RC1, leave the RC1 out for a week, then if no issues show up do a 1.1 release? I didn't get around to applying the changes suggested by the patch until today.

Re: [PATCH][NET] org.apache.commons.net.PingICMP

2003-09-26 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], rufio writes: So here it is, my 1st contribution. Thanks for your contribution. We'll review the patch along with the NTP patches after the 1.1 release. thanks! daniel - To unsubscribe,

[general] Maven-generated pages don't point to mailing list page

2003-10-02 Thread Daniel F. Savarese
I just noticed that Maven-generated Commons (sub)project pages don't point to: http://jakarta.apache.org/site/mail.html for mailing lists and instead allow you to directly subscribe or unsubscribe without reading the mailing list guidelines. If I've accidentally dredged up an old topic, just

Re: [VOTE][NET] Release Commons/Net v1.1.0

2003-10-14 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], Jeffrey D. Brekke writes: This is a call for a vote to release version 1.1.0 of Commons/Net. Links to the release canidate and changes may be found on the Commons/Net web site. +1 - To

Re: FTPClient related bugs: 30970 and 31122

2004-09-09 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], Joseph Hindsley writes: I had submitted a patch last week for the FTP and FTPClient classes (http://issues.apache.org/bugzilla/show_bug.cgi?id=30970) that doesn't seem to have had any activity. The patch changes FTP to extend SocketClient instead of TelnetClient

Re: [net] can commons ftp api cause files to be set with wrong owner on server?

2004-09-22 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], =?iso-8859-1?q ?jo=FFe3o=20Paulo=20souza?= writes: I´m using commons.net.ftp package to make the ftp transaction of files from one server to other.I´m connecting for example with an id = bla. So all files stored by the method storeFile from ftpClient class

Re: DO NOT REPLY [Bug 27437] - FTP get and list tasks fail

2004-09-23 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], [EMAIL PROTECTED] .org writes: --- Additional Comments From [EMAIL PROTECTED] 2004-09-23 15:00 --- Sorry, my bad. I didn't realize that Daniel has an AIX parser in there already . I don't think I wrote any of the parsers other than the original default one

Re: DO NOT REPLY [Bug 23488] - OS400 FTP server directory listing is not being parsed properly in FTPFile class.

2004-09-23 Thread Daniel F. Savarese
http://issues.apache.org/bugzilla/show_bug.cgi?id=23488 OS400 FTP server directory listing is not being parsed properly in FTPFile cla ss. --- Additional Comments From [EMAIL PROTECTED] 2004-09-23 13:25 --- Should this bug be marked as FIXED? I can see that we have an OS400 parser in

Re: DO NOT REPLY [Bug 31272] - TelnetInputStream zombie thread memory leak, FTPClient TelnetClient

2004-09-25 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], Rory Winston w rites: Actually, just having a quick perusal, I think this may be the culprit ... I've fixed, tested, + committed. Thanks. That's the second straight sloppy patch I've made. I always tell myself I shouldn't touch code after midnight :) I must have

Re: [net] SNTP support?

2004-09-25 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], Rory Winston w rites: Has there been any code contributed re: (S)NTP? I feel I may have a use for this in my day-to-day, and I am just wondering if there has been any movs toward including this. I see there is a TODO on the list that says review (S)NTP code, which

Re: [email] and net

2004-10-28 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], Vic Cekvenich writes: to the people of thinking of releaseing email: I think a lot more work is in net's smtp package such as simple emailer. So, maybe build on that,that is a superset. I didn't notice the original message this was in reply to, but I thought

Re: [net] Push for 1.3.0 release

2004-12-04 Thread Daniel F. Savarese
Rory Winston writes: I think we should push out a 1.3.0 release pre-xmas. There are many, many enhancements and fixes, and also a new component in HEAD. +1 BTW, thanks for all the work you've done going through and addressing all of those issue reports. daniel

Re: [NET] [PATCH] DefaultFTPFileListParser: ftp servers returning ger man date format

2003-12-05 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], J.M [EMAIL PROTECTED] writes: this is a patch for the DefaultFTPFileListParser.java file which = enables=20 The patch isn't in the email you sent. If you forgot to attach it, could you resend it to the mailing list? If you did attach it and it was stripped by

Re: [codec] [proposal] Moving To Apache Commons

2003-12-23 Thread Daniel F. Savarese
In message [EMAIL PROTECTED] .com.au, [EMAIL PROTECTED] writes: I think something folks are missing is that if J-C moves to A-C, then all J-C committers become A-C PMC Members and can change the rules that don't make sense once A-C has incorporated J-C. For example, and it's I'm failing to

Re: Commons - TLP

2003-12-23 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], Dirk Verbeeck writes: The point I wanted to make was only about how I would try to attract more active developers and not about the usefulness of the mentioned projects. Point taken. I'm totally on the same page as you and agree with all of your suggestions.

Re: [NET] VMSFTPEntryParser bug?

2003-12-30 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], steve cohen writes : failing but on a different line. I'm not sure what platform Jeff is on when he did the build, but I think I should rewrite this test in a way that doesn't assume any particular order since this seems to be JDK-implementation dependent. The

Re: [net] VMSFTPEntryParser bug?

2003-12-31 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], Steve Cohen writes: But what about my point that what we have now is NOT 1.1 compatible? VMSFTPEntryParser broke that, although it could, if necessary, be reimplemented to use Hashtable instead of HashMap. I misread your email (unfortunately an increasingly common

Re: Moving up to JVM 1.4+

2003-12-31 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], Geir Magnusson Jr writes: Don't forget that not all platforms have 1.4 or a mature 1.4 that people trust. it too a while for apple to get 1.4 out to OS X - I wouldn't use OS X in production of course, but it's my development platform... Absolutely. J2SE 1.4

Re: [net] Branching

2003-12-31 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], Jeffrey D. Brekke writes: After we make a 1.1 compatible release and tag, that will be the branch point for any 1.1 fixes. Next we can make a release with 1.2 support and tag, that will be the branch point for any 1.2 related fixes. All development then proceeds on

Re: [net] Branching

2003-12-31 Thread Daniel F. Savarese
I wrote: In message [EMAIL PROTECTED], Jeffrey D. Brekke writes: Its just a suggestion. I can live with an experimental branch also, just in other projects I've been involved with, if HEAD isn't the focal point of new development, it get confusing where to put stuff, what is working, etc. I

Re: Next Steps - WAS Re: [net] VMSFTPEntryParser bug?

2003-12-31 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], steve cohen writes: I am not completely CVS-literate and setting up the branches is beyond my current level of experience but probably would be good experience for me. In my response to Jeffrey's email, I asked about whether we wanted to replace the existing

Re: [net] Branching

2003-12-31 Thread Daniel F. Savarese
I wrote: Sanity check the steps to make sure this is what we want: o rename NET_1_1_0 tag to something else, let's say FOO o tag FOO as NET_1_1_0, this time with the -b flag to make it a branch tag I left out delete the FOO tag ... If that seems like not a good thing, another option is to

Re: [net] Branching

2004-01-02 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], Jeffrey D. Brekke writes: Daniel, I agree with all your ideas, but it seems to me you can branch from any tagged point in the revision history so I'm not sure what the idea is behind deleting/renaming the tags. All I was getting at was what to name the tag. My

Re: Next Steps - WAS Re: [net] VMSFTPEntryParser bug?

2004-01-02 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], steve cohen writes: Seems to me the HashMap --- Hashtable change could be made against HEAD. It's only NECESSARY for 1.1 compatibility but it poses no great problem for a 1.2 compatible version; it isn't as if this would impact some functionality deep in the

Re: Next Steps - WAS Re: [net] VMSFTPEntryParser bug?

2004-01-02 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], steve cohen writes: This code was calling a method in ORO that returned a Collection, also not JDK1.1 compatible. Since the older ORO method that returned a Vector had been deprecated, I looked at what it was doing, which was simply splitting a string on a comma.

Re: [net] Tag NET_1_1_1 created

2004-01-02 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], steve cohen writes: On Thursday 01 January 2004 04:17 pm, Jeffrey D. Brekke wrote: Should we roll out a release of this version? +1. We clearly have lazy consensus, but we need a formal vote cc'ed to the PMC list for all to be kosher. I guess so. It should be

Re: Ready for promotion? Was: [io] release plans?

2004-01-02 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], Hen ri Yandell writes: What do people think about calling a vote for promotion out of the sandbox now? +1 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL

Re: [net] Branching

2004-01-02 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], Martin Cooper writes: On Fri, 2 Jan 2004, Daniel F. Savarese wrote: All I was getting at was what to name the tag. My understanding was that a tag needs to be created as a branch. I should have used ... to point out that there are two distinct types of tags

Re: [net] Let's get rid of org.apache.commons.net.ftp.ftp2

2004-01-02 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], steve cohen writes: Is there a recommended way to go about this? It was doubtful to me that anyone had ever used these packages, but I now see that I was wrong. Someone went and implemented an AIXFTPEntryParser in the ftp2.parser package (and not on the main

Re: AIXFTPEntryParser

2004-01-02 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], steve cohen writes: In looking over the source to AIXFTPEntryParser, I see the following comment, apparently from the author, ([EMAIL PROTECTED]): It sounds like you're already doing the detective work, so I'll leave it to you. I seriously must wonder if this is a

Re: [net] checked in parser factory implementation

2004-01-05 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], steve cohen writes: Problem is, the current implementations of FTPFileEntryParser, also, for reasons of backward compatibility, implement FTPFileListParser. I don't remember exactly why I did that but there was a reason. But the problem is that deprecating

[net] 1.2 release (Re: [net] checked in parser factory implementation)

2004-01-05 Thread Daniel F. Savarese
I forgot to add that I think we need a beta release for 1.2 to give us a chance to back out or fix anything that we discover is suboptimal before we set the stuff in stone in the API. Mostly I'm thinking of method signatures. Anyway, to recap the proposed deprecation list: interfaces:

Re: [net] Let's get rid of org.apache.commons.net.ftp.ftp2

2004-01-05 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], steve cohen writes: On the fresh checkout I did, there was an ftp2 directory but it was empty. Is that another reason to get away from CVS - that it's too hard to get rid of directories? Yep. CVS doesn't treat directories the same as files. I have -P flags next to

Re: [net] checked in parser factory implementation

2004-01-06 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], steve cohen writes: 1) deprecate listFiles() methods that take a FileEntryParser parameter. 2) reimplement listFiles() to do what getFileList(null) now does. 3) reimplement listFiles(String pathname) to do what getFileList(null, pathname) now does. 4) rename

Re: [net] 1.2 release (Re: [net] checked in parser factory implementation)

2004-01-06 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], Daniel F. Savar ese writes: I forgot to add that I think we need a beta release for 1.2 to give us I also forgot to add that there's at least one pending code submission/patch that we need to review and include before a 1.2 release. I believe it was the NTP/SNTP

Re: [net] 1.2 release (Re: [net] checked in parser factory implementation)

2004-01-06 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], steve cohen writes: There's still one problem with deprecating FTPFileListParser. The one method of this interface (parseFileList()) is used in the VMSFTPEntryParser. There is an implementation here that is distinct from the default one in FTPFileListParserImpl.

Re: [net] 1.2 release (Re: [net] checked in parser factory implementation)

2004-01-06 Thread Daniel F. Savarese
I wrote: Looking at the code, I would have to agree that parseFileList should be preserved and move into FTPFileEntryParser. That allows us to rewrite createFileList to call parseFileList instead of FTPFileList.create, which allows the VMSFTPEntryParser to continue doing its thing. Scratch

Re: [net] 1.2 release (Re: [net] checked in parser factory implementation)

2004-01-06 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], steve cohen writes: Except for the issue outlined below (re FTPFileListParser deprecation) my latest commit have implemented everything that Daniel discussed earlier today: Great! I added caching of the system name to avoid issuing SYST to the server for every

Re: [net] 1.2 release (Re: [net] checked in parser factory implementation)

2004-01-06 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], steve cohen writes: After looking at the code, I have a different idea. Reimplementing createFileList() in terms of parseFileList() would negate the whole reason for inventing createFileList() in the first place - your suggestion wishing Agreed. I'm lagging

Re: [net] 1.2 release (Re: [net] checked in parser factory implementation)

2004-01-06 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], steve cohen writes: Almost right, Daniel. I think it filters out dupes when versioning is turned on. I thought that's what you said before, but I saw if (versioning) { files = super.parseFileList(listingStream); } else { in

Re: [net] 1.2 release (Re: [net] checked in parser factory implementation)

2004-01-07 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], steve cohen writes: I keep coming back to the ant use case and how we'd handle it there. I suppose we could add yet another parameter to the ant ftp task to handle this odd case, but I'd rather not. I'm still not happy with this but I don't have a better

Re: [net] 1.2 release (Re: [net] checked in parser factory implementation)

2004-01-07 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], Jeffrey D. Brekke writes: [Alternatives to VMS Parser/Version issue] Another alternative is to create another parser, creating two VMS parsers, potentially sub-classing one VMS parser to avoid code duplication. A specialized VMS parser that will filter off multiple

Re: [net] 1.2 release (Re: [net] checked in parser factory implementation)

2004-01-09 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], steve cohen writes: I also agree that there is a need for postfiltering (to solve the most recent version only problem), although, actually, I think prefiltering out the dupes may be the way to go. Either way, some kind of hook will be necessary, one that's a

Re: [net] Solved VMS duplicates problem and simplified system

2004-01-11 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], steve cohen writes: Oops! CVS doesn't have undelete, does it? :-( Sorry for not knowing/understanding this rule. Do we add it back in (losing history) or is there some way to put that back as well? What is best way to proceed? It looks like you already took

Re: [net][vote]Steve Cohen to manage release of v1.2.0 of commons.net

2004-01-20 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], Jeffrey D. Brekke writes: I think any committer could be the release manager, +1. I haven't had time to look at the code changes deeply. Based on what I've seen and what was discussed, I'm +0 on the release of 1.2.0, but I do think that a jdk 1.1 compatible version

Re: [net] JDK 1.1 question

2004-01-23 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], Steve Cohen writes: Question - primarily for Daniel: Do you think it makes sense to dial back to using jakarta-oro-2.0.1 in commons-net.1.1.1 to preserve JDK 1.1. compatibility? What features/bug fixes would be lost? Unless we either do this or rewrite, we

Re: Incorrect documentation of FTP task [net]

2004-02-17 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], Steve Cohen writes: You've built an interface to encapsulate the choice in regex implementations with automatic checking. Sweet! Perhaps we could port it to commons-net - ... Perhaps this checker mechanism could be ported to commons (a la commons-logging). Then

Re: Incorrect documentation of FTP task [net]

2004-02-18 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], Dom inique Devienne writes: Probably not... I simply try to avoid having twice the same functionality on my classpath, and JDK1.4+ fulfills my regexp needs (albeit simple) just fine. I've read a few times that ORO is superior to the JDK's regexp impl, so it's not a

Re: Incorrect documentation of FTP task [net]

2004-02-18 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], Steve Cohen writes: This is all true, Daniel, but I think the initial motivation of Dominique Devienne was to REMOVE the requirement that oro be on ant's runtime classpath I wrote: wrapper and J2SE 1.4 autodetection, in which case I would hope the point would

Re: cvs commit: jakarta-commons/net/src/java/org/apache/commons/net/ftp/parser VMSFTPEntryParser.java

2004-02-19 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], [EMAIL PROTECTED] writes: FTPFile[] results; if ((socket = _openDataConnection_(FTPCommand.LIST, pathname)) == null) -return null; +return new FTPFile[0]; I don't think that's the right

Re: Commons::Net Wiki

2004-04-14 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], Rory Winston w rites: Whereas the new Wiki is: http://wiki.apache.org/old/CommonsNet/FrequentlyAskedQuestions I'm confused. That page is not editable (it's listed as an immutable page) and does not appear on the list of wikis at http://wiki.apache.org/ The page

Re: [all] time to move to the new wiki...? [WAS Re: Commons::Net Wiki]

2004-04-15 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], robert burr ell donkin writes: is it time for jakarta commons to move to the new wiki...? +1 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: Commons::Net Wiki

2004-04-15 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], Rory Winston writes: well - day job permitting). I am not a committer as of yet - I do realize that you mentioned making me a committer before - what would it take to get myself on the committers list? AIUI, it's a voting process by existing committers? We just need

[VOTE] Rory Winston as a Commons commiter

2004-04-15 Thread Daniel F. Savarese
[ ] +1 Welcome Rory! [ ] 0 No comment. [ ] -1 Not yet, because ... Rory Winston has contributed significant functionality additions to the Commons Net NNTP package in the form of patches over the past year: http://marc.theaimsgroup.com/?l=jakarta-commons-devm=105360087319228w=2

Re: [VOTE][NET] Release commons-net 1.2.0

2004-04-24 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], Steve Cohen writes: The candidate release is available at http://cvs.apache.org/~scohen/ ... Please vote on this release. If the vote passes I will produce the release. +1 - To unsubscribe,

Re: [net] commons-net.1.2.0-rc1

2004-04-24 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], Jeffrey D. Brekke writes: standard stuff won't do. Or better yet, lets just put the two lines from the NOTICE.txt into the README.txt. We can't do that because putting it in NOTICE is required by the Apache License. If I didn't miss anything, we're talking about

Re: [net] commons-net.1.2.0-rc1

2004-04-25 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], Jeffrey D. Brekke writes: postgoal and pregoal allow for hooking onto goals. I think we can extend the preparation of the tar dists with postgoal/. Inside the postgoal, copy the NOTICE file into the correct directory. I'll try it soon. Thanks for the education.

Re: [VOTE][NET] Release commons-net 1.2.0

2004-04-28 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], Steve Cohen writes: Where do we stand on this? Hey, you called the vote, you're supposed to know :) I have two +1s from known committers to the project, another +1 from Mario, who I don't believe is a committer on this project but may be one for some other

Re: [net] minimum jdk version?

2004-05-04 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], Steve Cohen writes: I think a fix release is needed for this. Guys, what should the name of such a version be? 1.2.1 Are there any guidelines about releasing a fix version for such a small but vital thing? Just roll another release. Here's my +1 in advance.

  1   2   >