Stephen Warren wrote:
Phil Dibowitz wrote:
One comment on ** vs *. The code tends to use * in any non-public API, and
** only for public functions since C requires that. You converted various
private APIs to **, and I prefer to leave them * to be consistent with the
entire rest of the
So today while I was testing Stephen's patch, I ctrl-c'd a config update in
the middle of erasing the config. This left the remote in a state in which
the get_identity() calls could were failing. As such I could not being a
config update again, or a firmware update, or anything else. I tried
Phil Dibowitz wrote:
Stephen Warren wrote:
Phil Dibowitz wrote:
One comment on ** vs *. The code tends to use * in any non-public API, and
** only for public functions since C requires that. You converted various
private APIs to **, and I prefer to leave them * to be consistent with the
Stephen Warren wrote:
Phil Dibowitz wrote:
Stephen Warren wrote:
Phil Dibowitz wrote:
One comment on ** vs *. The code tends to use * in any non-public API,
and
** only for public functions since C requires that. You converted various
private APIs to **, and I prefer to leave them * to be
Is it possible to add a --with-libconcord=/path/to/it option to
concordance's configure script?
The reason is that I typically build, but don't install, libconcord,
then build concordance against it, using a configure command like this:
CFLAGS=-ggdb -I../libconcord LDFLAGS=-L../libconcord/.libs
Under Fedora 8 at least (and I'm sure others), compiling concordance.c
gives this warning:
concordance.c: In function ‘parse_options’:
concordance.c:589: warning: implicit declaration of function 'strdup'
Theoretically, strdup is prototyped by the include of string.h.
However, since concordance
Stephen Warren wrote:
Under Fedora 8 at least (and I'm sure others), compiling concordance.c
gives this warning:
concordance.c: In function ‘parse_options’:
concordance.c:589: warning: implicit declaration of function 'strdup'
I've seen this - didn't really bother to deal with it since it's
Phil Dibowitz wrote:
Stephen Warren wrote:
Is it possible to add a --with-libconcord=/path/to/it option to
concordance's configure script?
I'd be happy to. I gotta remember how to do that with autoconf, shouldn't be
hard.
Keep in mind that you won't be able to do
GetTag has an issue because it checks whether found is NULL before
assigning to it, but now it's a reference, so that check doesn't make
sense, and this renders the found value invalid, which breaks a lot of
things. The attached patch fixes this.
? concordance/.concordance.c.swp
?
