Re: [concordance-devel] [PATCH] Fix perl bindings

2014-03-18 Thread Phil Dibowitz
On 03/18/2014 06:21 AM, Scott Talbert wrote: > On Mon, 17 Mar 2014, Phil Dibowitz wrote: > >> This patch fixes the perl bindings and the perl test script. >> >> All extraneous stuff that made it into previous versions of this patch have >> been pulled out into separate patches. > > I don't really

Re: [concordance-devel] [PATCH] Fix perl bindings

2014-03-18 Thread Scott Talbert
On Mon, 17 Mar 2014, Phil Dibowitz wrote: > This patch fixes the perl bindings and the perl test script. > > All extraneous stuff that made it into previous versions of this patch have > been pulled out into separate patches. I don't really know Perl very well, so I can't speak to those changes.

Re: [concordance-devel] [PATCH] Fix Perl Bindings

2014-03-18 Thread Scott Talbert
On Mon, 17 Mar 2014, Phil Dibowitz wrote: >> BTW, while you're around, do you want to take a look at the Harmony Touch >> patch? We're still working on getting it working, but I think the >> concordance/libconcord pieces are probably finished - those haven't >> changed in quite a while. If so, I

[concordance-devel] [PATCH] Fix perl bindings

2014-03-17 Thread Phil Dibowitz
This patch fixes the perl bindings and the perl test script. All extraneous stuff that made it into previous versions of this patch have been pulled out into separate patches. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of

Re: [concordance-devel] [PATCH] Fix Perl Bindings

2014-03-17 Thread Phil Dibowitz
On 03/17/2014 09:13 PM, Phil Dibowitz wrote: > On 03/17/2014 04:17 PM, Scott Talbert wrote: >> On Mon, 17 Mar 2014, Phil Dibowitz wrote: >> I actually meant the part where you (I think you) had checked for an INFORMATION tag to "sanity check" - and now I fall through that if we don't

Re: [concordance-devel] [PATCH] Fix Perl Bindings

2014-03-17 Thread Phil Dibowitz
On 03/17/2014 04:17 PM, Scott Talbert wrote: > On Mon, 17 Mar 2014, Phil Dibowitz wrote: > >>> I actually meant the part where you (I think you) had checked for an >>> INFORMATION tag to "sanity check" - and now I fall through that if we don't >>> find that tag... because otherwise we never recogn

Re: [concordance-devel] [PATCH] Fix Perl Bindings

2014-03-17 Thread Scott Talbert
On Mon, 17 Mar 2014, Phil Dibowitz wrote: >> I actually meant the part where you (I think you) had checked for an >> INFORMATION tag to "sanity check" - and now I fall through that if we don't >> find that tag... because otherwise we never recognize our own FW dump files. >> >> Alternatively, I co

Re: [concordance-devel] [PATCH] Fix Perl Bindings

2014-03-17 Thread Phil Dibowitz
On 03/17/2014 12:33 AM, Phil Dibowitz wrote: > On 03/16/2014 08:20 PM, Scott Talbert wrote: >> On Sun, 16 Mar 2014, Phil Dibowitz wrote: >> Attached patch fixes the perl bindings... But it also fixes a bug in operationfile that couldn't handle firmware dump files we created. >>>

Re: [concordance-devel] [PATCH] Fix Perl Bindings

2014-03-17 Thread Phil Dibowitz
On 03/16/2014 08:20 PM, Scott Talbert wrote: > On Sun, 16 Mar 2014, Phil Dibowitz wrote: > >>> Attached patch fixes the perl bindings... >>> >>> But it also fixes a bug in operationfile that couldn't handle firmware dump >>> files we created. >> >> BTW, any objections on the operationfile changes?

Re: [concordance-devel] [PATCH] Fix Perl Bindings

2014-03-16 Thread Scott Talbert
On Sun, 16 Mar 2014, Phil Dibowitz wrote: >> Attached patch fixes the perl bindings... >> >> But it also fixes a bug in operationfile that couldn't handle firmware dump >> files we created. > > BTW, any objections on the operationfile changes? If not, I'll merge. My only question about that is ab

Re: [concordance-devel] [PATCH] Fix Perl Bindings

2014-03-16 Thread Phil Dibowitz
On 03/15/2014 09:27 PM, Phil Dibowitz wrote: > Attached patch fixes the perl bindings... > > But it also fixes a bug in operationfile that couldn't handle firmware dump > files we created. BTW, any objections on the operationfile changes? If not, I'll merge. -- Phil Dibowitz

[concordance-devel] [PATCH] Fix Perl Bindings

2014-03-15 Thread Phil Dibowitz
Attached patch fixes the perl bindings... But it also fixes a bug in operationfile that couldn't handle firmware dump files we created. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/