Re: DHCP & hostname faceplant

2015-10-21 Thread Daniel Wagner
On 10/21/2015 12:19 PM, Patrik Flykt wrote: > On Thu, 2015-10-08 at 01:31 -0600, Daniel Wagner wrote: >> I have uploaded two traces. Both created on my Linux machine. >> >> - This one is with an unmodified ConnMan: >> >>http://www.monom.org/connman/dhcp-not-wo

Re: [PATCH v2] openvpn: Add MTU related options

2015-10-21 Thread Daniel Wagner
On 10/21/2015 12:25 PM, Patrik Flykt wrote: > On Wed, 2015-10-21 at 12:12 +0200, Daniel Wagner wrote: > >> The use of the different MTU options depend on you server and link >> configuration. I don't think you can derive it. OpenVPN seems to offer >> an option to learn th

Re: [PATCH v2] openvpn: Add MTU related options

2015-10-21 Thread Daniel Wagner
On 10/21/2015 12:45 PM, Sven Schwedas wrote: > On 2015-10-21 12:30, Daniel Wagner wrote: >> On 10/21/2015 12:25 PM, Patrik Flykt wrote: >>> On Wed, 2015-10-21 at 12:12 +0200, Daniel Wagner wrote: >>> >>>> The use of the different MTU options depend on yo

[PATCH v2] openvpn: Add MTU related options

2015-10-16 Thread Daniel Wagner
OpenVPN has several command line option to configure how to handle the MTU of packets. The plugin accepts a OpenVPN.MTU options which is translated to '--mtu'. This options not available (has it ever existed?) since 2.0. We recommend at least version 2.2 of OpenVPN. It looks like no one is using

Re: DHCP & hostname faceplant

2015-10-08 Thread Daniel Wagner
Hi Patrik, On 09/22/2015 12:12 AM, Patrik Flykt wrote: On Fri, 2015-09-18 at 02:50 +, Daniel Wagner wrote: The WiFi APs provided by the local ISP here in Utah does not like the hostname in the DHCP Request packet. Without it the hostname I get the ACK instead of the NACK as respond. Any

DHCP & hostname faceplant

2015-09-17 Thread Daniel Wagner
Hi, The WiFi APs provided by the local ISP here in Utah does not like the hostname in the DHCP Request packet. Without it the hostname I get the ACK instead of the NACK as respond. Any ideas how we could handle this problem? E.g. stop sending the hostname after the first round of retries

Re: Question on NAT solution

2015-09-09 Thread Daniel Wagner
User A? > > Thanks in advance for the support > Gianfranco > > On Thu, Sep 3, 2015 at 3:19 PM, Daniel Wagner <w...@monom.org > <mailto:w...@monom.org>> wrote: > > >>> There is a difference respect what we were discussing i.e.: -m mark > --m

Re: Question on NAT solution

2015-09-09 Thread Daniel Wagner
On 09/09/2015 03:43 PM, Patrik Flykt wrote: > On Wed, 2015-09-09 at 15:22 +0200, Gianfranco Casanova wrote: >> Which ROUTE is chosen by ConnMan for UID if: >> 1.\ ETH OnLine WiFi Ready? >> 2.\ WiFi OnLine ETH Ready? >> >> I’m expecting the Route marked as OnLine is all the time chosen, can >> you

Re: Question on NAT solution

2015-09-09 Thread Daniel Wagner
On 09/09/2015 04:41 PM, Gianfranco Casanova wrote: > Even having the configuration of Session overwriting the ConnMan, > which is the order that has to be considered by the ConnMan for the > AllowedBarer? > I do not see any PRIO in the policy file, I’m right? As I said this was left out on

Re: Question on NAT solution

2015-09-09 Thread Daniel Wagner
On 09/09/2015 04:33 PM, Patrik Flykt wrote: > On Wed, 2015-09-09 at 16:15 +0200, Daniel Wagner wrote: >> - Only autoconnect if there is a session asking for connection >> - refcounting, how many times Sessions asked for a connection. >> When no Session wants a connection

Re: Question on NAT solution

2015-09-03 Thread Daniel Wagner
test the patch below? With that we should at least solved the routing. If I understood you correctly, we still need to figure out why rp_filter sometimes needs to be disabled. >From 2df313ec4dac570dc378fc70a7a5f6307cd48e2e Mon Sep 17 00:00:00 2001 From: Daniel Wagner <daniel.wag...@bmw

Re: HowTo ConnMan to use two different technologies and services at the same time

2015-09-02 Thread Daniel Wagner
On 08/27/2015 08:36 AM, Gianfranco Casanova wrote: > Hi guys I tested the last version provided by Daniel, containing the > patch for the NAT table but it is not working properly i.e.; the IP used > by the two users is the same. > Attached both the CMD and the LOG from iptables of ConnMan. Thanks

Re: Question on NAT solution

2015-09-02 Thread Daniel Wagner
On 09/02/2015 01:31 PM, Gianfranco Casanova wrote: >> On 02 Sep 2015, at 12:09, Daniel Wagner <w...@monom.org> wrote: >> The reason why we need to send the packets through SNAT is that the >> rerouting lookup will only happen if the packets have been touched by >> the

Re: Question on NAT solution

2015-09-02 Thread Daniel Wagner
On 09/02/2015 11:44 AM, Gianfranco Casanova wrote: >> On 02 Sep 2015, at 09:10, Daniel Wagner <w...@monom.org> wrote: >> On 08/25/2015 04:39 PM, Gianfranco Casanova wrote: >>> I try to understand better the mechanism of Routing and Source Address >>> Selection.

Re: [PATCH v2 2/4] iptables: Add basic --protocol parser support

2015-08-12 Thread Daniel Wagner
Hi Patrik, On 08/12/2015 01:08 PM, Patrik Flykt wrote: On Tue, 2015-08-11 at 09:00 +0200, Daniel Wagner wrote: static int prepare_getopt_args(const char *str, struct parse_context *ctx) @@ -1804,6 +1805,12 @@ static int parse_xt_modules(int c, bool invert, { struct xtables_match *m

[PATCH v3 2/4] iptables: Add basic --protocol parser support

2015-08-12 Thread Daniel Wagner
The SNAT extension wants to know which protocol is used. We need to pass in a valid ipt_entry with the protocol set for this reason. The parser is keept minimal, which means it does not support all fancy features as iptables offers. Though for our main purposes is it enough which is

[PATCH v2 3/4] firewall: Add support for single rule add/remove operations

2015-08-11 Thread Daniel Wagner
We like to add and remove rules while the firewall is up and running. For example we need to insert per Session rule in the global NAT table. That could also be implemented destroying the whole table and recreate it when need but that is quite an overhead. Instead of taking down the whole table

[PATCH v2 4/4] session: Add SNAT rules per session

2015-08-11 Thread Daniel Wagner
The policy routing doesn't work because: (local process) - (routing decision) - [raw:output] - contrack - [mangle:output] - (reroute check) - [nat:output] - [filter:output] - ... When the local process generates a packet, the network stack takes the routing decision really early on. In our

[PATCH v2 0/4] Session: per application routing

2015-08-11 Thread Daniel Wagner
the problem. Install a SNAT rule and update it whenever we change something in the session, e.g. changing the bearer. This stuff works now on my system. Please give it a try and report back any problems you find. cheers, daniel Cc: Gianfranco Casanova gianfranco.casan...@gmail.com Daniel

[PATCH v2 2/4] iptables: Add basic --protocol parser support

2015-08-11 Thread Daniel Wagner
The SNAT extension wants to know which protocol is used. We need to pass in a valid ipt_entry with the protocol set for this reason. The parser is keept minimal, which means it does not support all fancy features as iptables offers. Though for our main purposes is it enough which is

[PATCH v2 1/4] session_policy_local: Set defaults when using policy file

2015-08-11 Thread Daniel Wagner
When the policy file doesn't define all values of the policy some of the values are not properly initialized or set to sane defaults. Setting all values to defaults and then overwrite all or partially is what most people would expect. Let's do it this way. --- plugins/session_policy_local.c | 4

Re: HowTo ConnMan to use two different technologies and services at the same time

2015-08-11 Thread Daniel Wagner
Hi Gianfranco Please keep the mailing list in the CC. On 08/06/2015 03:49 PM, Gianfranco Casanova wrote: Hi Daniel sorry for the delay. We retested the ConnMan with the patches but we are not able to have the two route at the same time. The first problem is that: connmanctl session on

Re: [PATCH 2/2] vpn-config: monitor IN_MOVED_FROM and IN_MOVED_TO

2015-07-29 Thread Daniel Wagner
Hi Jaakko, On 07/28/2015 02:48 PM, Jaakko Hannikainen wrote: If a file is moved to or from a config directory, IN_DELETE and IN_MODIFY events are not fired, so IN_MOVED_FROM and IN_MOVED_TO events have to be monitored. --- vpn/vpn-config.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH v2 2/2] vpn-config: monitor IN_MOVED_FROM and IN_MOVED_TO

2015-07-29 Thread Daniel Wagner
Hi Jaakko, Both patches applied. Thanks, Daniel ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman

[PATCH v1 4/4] session: Add SNAT rules per session

2015-07-28 Thread Daniel Wagner
The policy routing doesn't work because: (local process) - (routing decision) - [raw:output] - contrack - [mangle:output] - (reroute check) - [nat:output] - [filter:output] - ... When the local process generates a packet, the network stack takes the routing decision really early on. In our

[PATCH v1 2/4] iptables: Add basic --protocol parser support

2015-07-28 Thread Daniel Wagner
The SNAT extension wants to know which protocol is used. We need to pass in a valid ipt_entry with the protocol set for this reason. The parser is keept minimal, which means it does not support all fancy features as iptables offers. Though for our main purposes is it enough which is

[PATCH v1 0/4] Session: per application routing

2015-07-28 Thread Daniel Wagner
. changing the bearer. This stuff works now on my system. Please give it a try and report back any problems you find. cheers, daniel Cc: Gianfranco Casanova gianfranco.casan...@gmail.com Daniel Wagner (4): session_policy_local: Set defaults when using policy file iptables: Add basic --protocol

Re: [PATCH] doc: Update service documentation about Immutable

2015-07-28 Thread Daniel Wagner
ACK from me. patch applied. thanks, daniel ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman

Re: [PATCH] ntp: Fix print format for timeval and make debug output more informative

2015-07-28 Thread Daniel Wagner
All three patches applied. Thanks, Daniel ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman

Re: [PATCH v1 3/4] firewall: Add support for single rule add/remove operations

2015-07-28 Thread Daniel Wagner
Hi Jukka, On 07/28/2015 11:25 AM, Jukka Rissanen wrote: +static int firewall_enable_rule(struct fw_rule *rule) +{ +int err; + Should we check if the rule is already enabled here? Good point. I'll add the check. cheers, daniel ___ connman

[PATCH v1 1/4] session_policy_local: Set defaults when using policy file

2015-07-28 Thread Daniel Wagner
When the policy file doesn't define all values of the polcy some of the values are not properly initialized or set to sane defaults. Setting all values to defaults and then overwrite all or partially is what most people would expect. Let's do it this way. --- plugins/session_policy_local.c | 2 +-

[PATCH v1 3/4] firewall: Add support for single rule add/remove operations

2015-07-28 Thread Daniel Wagner
We like to add and remove rules while the firewall is up and running. For example we need to insert per Session rule in the global NAT table. That could also be implemented destroying the whole table and recreate it when need but that is quite an overhead. Instead of taking down the whole table

Re: [PATCH v1 1/4] session_policy_local: Set defaults when using policy file

2015-07-28 Thread Daniel Wagner
On 07/28/2015 11:21 AM, Rissanen, Jukka wrote: Hi Daniel, minor typo still, no need to send a new patch version for this. Just fix it when applying the patch. On ti, 2015-07-28 at 08:57 +0200, Daniel Wagner wrote: When the policy file doesn't define all values of the polcy polcy

Re: [PATCH] vpn: Fix NULL dereferencing in vpn_set_state

2015-07-28 Thread Daniel Wagner
Good catch, ACK to this. patched applied. thanks, daniel ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman

[PATCH v0 1/4] session_policy_local: Set defaults when using policy file

2015-07-27 Thread Daniel Wagner
When the policy file doesn't define all values of the polcies some of the values are not properly initialized or set to sane defaults. Setting all values to defaults and then overwrite all or partially is what most people would expect. Let's do it this way. --- plugins/session_policy_local.c | 2

[PATCH v0 3/4] firewall: Add support for single rule add/remove operations

2015-07-27 Thread Daniel Wagner
We like to add and remove rules while the filewall is up and running. For example we need to insert per Session rule in the global NAT table. That could also be implemented destroying the whole table and recreate it when need but that is quite an overhead. Instead of taking down the whole table

[PATCH v0 0/4] Session: per application routing

2015-07-27 Thread Daniel Wagner
...@gmail.com Daniel Wagner (4): session_policy_local: Set defaults when using policy file iptables: Add basic --protocol parser support firewall: Add support for single rule add/remove operations session: Add SNAT rules per session plugins/session_policy_local.c | 2 +- src/connman.h

[PATCH v0 4/4] session: Add SNAT rules per session

2015-07-27 Thread Daniel Wagner
The policy routing doesn't work because: (local process) - (routing decision) - [raw:output] - contrack - [mangle:output] - (reroute check) - [nat:output] - [filter:output] - ... When the local process generates a packet, the network stack takes the routing decision really early on. In our

[PATCH v0 2/4] iptables: Add basic --protocol parser support

2015-07-27 Thread Daniel Wagner
The SNAT extension wants to know which protocol is used. We need to pass in a valid ipt_entry with the protocol set for this reason. The parser is keept minimal, which means it does not support all fancy features as iptables offers. Though for our main purposes is it enough which is

Re: HowTo ConnMan to use two different technologies and services at the same time

2015-07-27 Thread Daniel Wagner
explanation correctly. Please find my doubts inline. Those are mainly related to the NAT vs Routing Policy. On 24 Jul 2015, at 16:03, Daniel Wagner w...@monom.org mailto:w...@monom.org wrote: I figured out the main problem: (local process) - (routing decision) - [raw:output] - contrack

Re: [PATCH v0 3/4] firewall: Add support for single rule add/remove operations

2015-07-27 Thread Daniel Wagner
Hi Jukka, On 07/27/2015 05:03 PM, Jukka Rissanen wrote: On ma, 2015-07-27 at 14:47 +0200, Daniel Wagner wrote: We like to add and remove rules while the filewall is up and running. filewall - firewall fixed as well :) __connman_firewall_remove_rule() and __connman_firewall_enable_rule

Re: [PATCH v0 1/4] session_policy_local: Set defaults when using policy file

2015-07-27 Thread Daniel Wagner
On 07/27/2015 04:55 PM, Jukka Rissanen wrote: On ma, 2015-07-27 at 14:47 +0200, Daniel Wagner wrote: When the policy file doesn't define all values of the polcies polcies - policy fixed. ___ connman mailing list connman@connman.net https

Re: HowTo ConnMan to use two different technologies and services at the same time

2015-07-24 Thread Daniel Wagner
On 07/03/2015 03:41 PM, Daniel Wagner wrote: On 07/03/2015 03:18 PM, Gianfranco Casanova wrote: root@ale:/var/log# ip rule show 0: from all lookup local 32764: from all fwmark 0x101 lookup 257 32765: from all fwmark 0x100 lookup 256 32766

Re: HowTo ConnMan to use two different technologies and services at the same time

2015-07-24 Thread Daniel Wagner
I figured out the main problem: (local process) - (routing decision) - [raw:output] - contrack - [mangle:output] - (reroute check) - [nat:output] - [filter:output] - ... When the local process generates a packet, the network stack takes the routing decision really early on. In our case

Re: [PATCH 3/3] gdhcp: Fix use-after-free issue when g_dhcp_client_start() is called from restart_dhcp()

2015-07-22 Thread Daniel Wagner
All three patches applied. Thanks, Daniel ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman

Re: [PATCH] service: Send hidden wifi SSID request to sender

2015-07-22 Thread Daniel Wagner
On 07/21/2015 03:33 PM, Jaakko Hannikainen wrote: Previously when querying the SSID from client through the agent api, the request was sent to default agent rather than sender, as get_dbus_sender returns NULL if service-pending is NULL, causing a request to the default agent. Patch applied.

Re: [PATCH] doc: Clarify the VPN routes description for IPv6

2015-07-22 Thread Daniel Wagner
On 07/22/2015 09:51 AM, Jukka Rissanen wrote: For VPN UserRoutes and ServerRoutes properties, the Netmask field is the IPv4 netmask (like 255.255.255.0) for IPv4 routes. For IPv6 routes it is the prefix length (like 64) instead. Reported by Jaakko Hannikainen. Patch applied. Thanks, Daniel

Re: [PATCH 0/6] VPN fixes

2015-07-22 Thread Daniel Wagner
On 07/21/2015 01:27 PM, Jukka Rissanen wrote: Hi, these patches fix multiple issues in VPN connectivity. Thanks to Jaakko Hannikainen for finding these issues. Patch 1 fixes a crash issue in connman-vpnd. User is able to cause segfault via connmanctl. Another serious issue is found in

Re: HowTo ConnMan to use two different technologies and services at the same time

2015-07-06 Thread Daniel Wagner
Hi [html formated mails are almost certainly blocked on this mailing list] On 07/03/2015 04:29 PM, Gianfranco Casanova wrote: Hi all In the end we’ve got it working. Following the missing steps from ConnMan. Nice to hear. Supposing the WiFi is online and ETH is ready connmanctl

Re: HowTo ConnMan to use two different technologies and services at the same time

2015-07-03 Thread Daniel Wagner
On 07/03/2015 12:27 PM, Patrik Flykt wrote: On Fri, 2015-07-03 at 10:31 +0200, Daniel Wagner wrote: I am afraid, but the work for getting it routed to the right interface is not finished yet. So the initial plan was to go with SO_MARK set via a cgroup controller if you don't want to touch

Re: HowTo ConnMan to use two different technologies and services at the same time

2015-07-03 Thread Daniel Wagner
On 07/03/2015 01:15 PM, Daniel Wagner wrote: Yes, you are right. I got confused about the matching. Hmm, I just wonder how we get the packets coming from the application into the policy routing table. Something needs to set the SO_MARK/fwmark. The connman-OUTPUT iptables chain is too late

Re: HowTo ConnMan to use two different technologies and services at the same time

2015-07-02 Thread Daniel Wagner
Hi Gianfranco, On 07/01/2015 04:15 PM, Gianfranco Casanova wrote: we have a couple of questions about “ConnMan” capability. Actually we are using it (succesfully) in a GENIVI based Automotive project and we Nice to hear :) have now new requirements to deal with. We read a lot of posts

Re: Connman without iptables

2015-06-18 Thread Daniel Wagner
On 06/18/2015 10:35 AM, Patrik Flykt wrote: On Thu, 2015-06-18 at 13:48 +0530, Sukanya Ch wrote: With these changes I am not able to run connman daemon..Here I am providing the logs. connmand[4691]: src/ipconfig.c:__connman_ipconfig_init() connmand[4691]: src/rtnl.c:__connman_rtnl_init()

Re: connman support for 802.11x based WLAN connections

2015-05-19 Thread Daniel Wagner
On 05/19/2015 01:30 PM, Vidhya Govindan wrote: Can we add our scanning and triggering algorithm to connect to WLAN within connman framework (bypassing or overriding connman's algorithm)? Have a ook at the session_policy_local.c plugin. There is also an out of tree toy plugin for this:

Fwd: Re: Network devroom call for participation

2014-11-17 Thread Daniel Wagner
Hi, Not sure if everyone has gotten this one. cheers, daniel Forwarded Message Subject: Re: Network devroom call for participation Date: Sun, 16 Nov 2014 15:16:21 -0500 From: Dave Neary dne...@redhat.com To: network-devr...@lists.fosdem.org Hi everyone, A gentle reminder

Fwd: New Defects reported by Coverity Scan for ConnMan

2014-08-11 Thread Daniel Wagner
Hi, I just did a run with coverity again on ConnMan. Here the results. cheers, daniel Original Message Subject: New Defects reported by Coverity Scan for ConnMan Date: Mon, 11 Aug 2014 01:22:44 -0700 From: scan-ad...@coverity.com Hi, Please find the latest report on new

Re: [PATCH 1/1] Update p2p scan status, when disabling wifi

2014-07-29 Thread Daniel Wagner
On 07/29/2014 12:23 PM, Tomasz Bursztyka wrote: Hi Eduardo, Can you add wifi: as a prefix of your commit title? I noticed that your 2 previous accepted patches lacked this prefix rule also. (and got applied, but that's not your mistake) Sorry, my bad.

Re: [PATCH 0/2 v2] Avoid segfault on connman deinitialization

2014-07-24 Thread Daniel Wagner
On 07/24/2014 02:55 PM, Tomasz Bursztyka wrote: Hi Eduardo, ACK on this patchset. Patches applied. Thanks, Daniel ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman

[PATCH v1 6/7] unit: Fix copyright statement

2014-07-22 Thread Daniel Wagner
From: Daniel Wagner daniel.wag...@bmw-carit.de The copyright statement for my company is not consistent or even wrongly spelled. s/All rights reserved// s/CarIT/Car IT/ s/BWM/BMW/ s/GbmH/GmbH/ --- unit/test-ippool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/unit/test

[PATCH v1 2/7] plugins: Fix copyright statement

2014-07-22 Thread Daniel Wagner
From: Daniel Wagner daniel.wag...@bmw-carit.de The copyright statement for my company is not consistent or even wrongly spelled. s/All rights reserved// s/CarIT/Car IT/ s/BWM/BMW/ s/GbmH/GmbH/ --- plugins/dundee.c | 2 +- plugins/ofono.c| 2 +- plugins

[PATCH v1 0/7] Fix copyright statement

2014-07-22 Thread Daniel Wagner
From: Daniel Wagner daniel.wag...@bmw-carit.de Hi, I was told by Thibault GUITTET there are some incosistency in the copyright statements I wrote. Let's get them fixed. BTW, First I blame emacs for ctrl-t and second my dyslexia :p cheers, daniel v0: - initial version v1: - updated

[PATCH v1 5/7] tools: Fix copyright statement

2014-07-22 Thread Daniel Wagner
From: Daniel Wagner daniel.wag...@bmw-carit.de The copyright statement for my company is not consistent or even wrongly spelled. s/All rights reserved// s/CarIT/Car IT/ s/BWM/BMW/ s/GbmH/GmbH/ --- tools/iptables-unit.c | 2 +- tools/manager-api.c | 2 +- tools/netlink-test.c | 2 +- tools

[PATCH v1 1/7] include: Fix copyright statement

2014-07-22 Thread Daniel Wagner
From: Daniel Wagner daniel.wag...@bmw-carit.de The copyright statement for my company is not consistent or even wrongly spelled. s/All rights reserved// s/CarIT/Car IT/ s/BWM/BMW/ s/GbmH/GmbH/ --- include/inotify.h | 2 +- include/session.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions

[PATCH v1 3/7] scripts: Fix copyright statement

2014-07-22 Thread Daniel Wagner
From: Daniel Wagner daniel.wag...@bmw-carit.de The copyright statement for my company is not consistent or even wrongly spelled. s/All rights reserved// s/CarIT/Car IT/ s/BWM/BMW/ s/GbmH/GmbH/ --- scripts/openvpn-script.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v1 7/7] vpn: Fix copyright statement

2014-07-22 Thread Daniel Wagner
From: Daniel Wagner daniel.wag...@bmw-carit.de The copyright statement for my company is not consistent or even wrongly spelled. s/All rights reserved// s/CarIT/Car IT/ s/BWM/BMW/ s/GbmH/GmbH/ --- vpn/plugins/l2tp.c| 2 +- vpn/plugins/openvpn.c | 2 +- vpn/plugins/pptp.c| 2 +- vpn

[PATCH v1 4/7] src: Fix copyright statement

2014-07-22 Thread Daniel Wagner
From: Daniel Wagner daniel.wag...@bmw-carit.de The copyright statement for my company is not consistent or even wrongly spelled. s/All rights reserved// s/CarIT/Car IT/ s/BWM/BMW/ s/GbmH/GmbH/ --- src/bridge.c | 2 +- src/connection.c | 2 +- src/inotify.c| 2 +- src

Re: [PATCH v1 0/7] Fix copyright statement

2014-07-22 Thread Daniel Wagner
After Jukka's ACK on IRC I pushed them. ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman

Re: [PATCH] gsupplicant: Reassign best_bss pointer when that bss is removed

2014-07-21 Thread Daniel Wagner
Hi, On 07/21/2014 02:41 PM, Jukka Rissanen wrote: On ma, 2014-07-21 at 13:09 +0300, Hannu Mallat wrote: When the bss to which best_bss points to is removed, the pointer also needs to be reassigned, or reference to already deallocated memory may happen later on. [...] Good catch, ACK to

Re: [PATCH] scripts: Build libppp-plugin as a plain .so file

2014-07-21 Thread Daniel Wagner
Hi Jukka, On 07/21/2014 04:15 PM, Jukka Rissanen wrote: There is no need to have module versioning for libppp-plugin.so file so build the plugin same way as other vpn plugins. This issue was seen when building ConnMan for Yocto. --- Makefile.plugins | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH 0/5 v2] Handle P2P dhcp role properly

2014-07-17 Thread Daniel Wagner
Hi Tomasz, On 07/17/2014 03:00 PM, Tomasz Bursztyka wrote: Hello, - v2: Applied comments from Jukka about v1 Looks good. I went ahead and applied this version. Thanks, Daniel ___ connman mailing list connman@connman.net

Re: [PATCH v4] gdhcp: Request an actual IP address when rebinding

2014-07-17 Thread Daniel Wagner
Hi Justin, On 07/17/2014 03:47 PM, Jukka Rissanen wrote: Hi Justin, On ke, 2014-07-16 at 11:12 -0700, Justin Maggard wrote: We need to specify a requested IP address when our DHCP client state is REBINDING as well as REQUESTING and REBOOTING; or else we end up sending a DHCP request for

Re: [PATCH] gdhcp: adjust discovery/request timeout and retry values

2014-07-17 Thread Daniel Wagner
Hi Pasi, On 07/17/2014 04:36 PM, Jukka Rissanen wrote: On ke, 2014-07-16 at 22:30 +0300, pasi.sjoh...@jolla.com wrote: From: Pasi Sjöholm pasi.sjoh...@jollamobile.com Some dhcp servers are acting lazy (eg. Buffalo WBMR-G125) therefore 3 second timeout value for discovery or request is not

Re: [PATCHi v2] doc: Add informations about the experimental P2P Peer services support

2014-07-15 Thread Daniel Wagner
Hi Tomasz On 07/08/2014 02:52 PM, Tomasz Bursztyka wrote: As soon as p2p technology is present, whether it is enabled or not, it will be possible to register and un-register P2P Peer services. These will be served once p2p technology gets enabled. When scanning for Peers is possible, Peer

Re: [PATCH v2] gdhcp: Save the DHCP server IP when REBOOTING

2014-07-15 Thread Daniel Wagner
Hi, On 07/15/2014 12:48 PM, Jukka Rissanen wrote: Hi Justin, On ma, 2014-07-14 at 10:27 -0700, Justin Maggard wrote: We need to save the server IP when REBOOTING as well as SELECTING. Without this, DHCP renew will never work, because we don't know where to send the unicast renew packets.

Re: [PATCH] dhcpv6: Check if network is already disconnected in DAD reply

2014-07-15 Thread Daniel Wagner
Hi Jukka, On 07/15/2014 01:37 PM, Jukka Rissanen wrote: It is possible that the network is disconnected while we are waiting DAD (Duplicate Address Detection) to finish. DAD is done quite fast (timeout is 1 sec) so this is quite unlikely to trigger but possible as seen by this valgrind

Re: [PATCH 00/32 v2] Basic implementation of P2P Peer's Connect/Disconnect

2014-07-11 Thread Daniel Wagner
Hi Tomasz, Applying: gsupplicant: Use StopFind instead of Flush to detect P2P support Applying: gsupplicant: Check whether or not a peer support WPS PBC Applying: gsupplicant: Add a function to set the P2P device name Applying: gsupplicant: Always call peer_lost callback when removing a peer

Re: [PATCH 00/32 v3] Basic implementation of P2P Peer's Connect/Disconnect

2014-07-11 Thread Daniel Wagner
Hi Tomasz, On 07/11/2014 10:04 AM, Tomasz Bursztyka wrote: - v3: patch 6 was breaking patch 9. Small optimization in patch 5 - v2: Applied comments from Daniel Wagner on patches 2, 3, 5, 6, 8 and 19 I pushed this version. Let's see if we have regressions. I think I found already one which

Re: [PATCH] service: Changes to favorite property also affect the autoconnect property.

2014-07-11 Thread Daniel Wagner
Hi Aaron, On 07/11/2014 05:16 AM, Aaron McCarthy wrote: The AutoConnect property is always reported as false if Favorite is false. Emit property changed for AutoConnect when Favorite changes. Unfortantly, I can't apply it: Applying: service: Changes to favorite property also affect the

Re: [PATCH] client: Add error handling when populating hashes

2014-07-11 Thread Daniel Wagner
Hi Alexandru, On 07/11/2014 02:11 PM, Alexandru Costache wrote: Check if dbus message was of type error before populating hashes to avoid a couple of crashes Patch applied. Thanks, Daniel ___ connman mailing list connman@connman.net

Re: [PATCH] client: Add error handling when populating hashes

2014-07-11 Thread Daniel Wagner
Hi Alexandru, On 07/11/2014 02:38 PM, Alexandru Costache wrote: Hi Daniel, Thanks for applying. I forgot to mention that these were found and tested on connman 1.23, although I'm sure they should occur on the current HEAD too. Yes, that is very likely. Just as a note, they looked like:

Re: [PATCH 02/32] gsupplicant: Check whether or not a peer support WPS PBC

2014-07-10 Thread Daniel Wagner
Hi Tomasz, On 07/09/2014 02:36 PM, Tomasz Bursztyka wrote: This will be used to request the proper wps method when connecting to the peer. --- gsupplicant/gsupplicant.h | 4 gsupplicant/supplicant.c | 28 2 files changed, 32 insertions(+) diff --git

Re: [PATCH 03/32] gsupplicant: Add a function to set the P2P device name

2014-07-10 Thread Daniel Wagner
Hi Tomasz, On 07/09/2014 02:36 PM, Tomasz Bursztyka wrote: The wifi plugin will use this function to specify the P2P device name, and will set it according to the hostname. --- gsupplicant/gsupplicant.h | 2 ++ gsupplicant/supplicant.c | 60

Re: [PATCH 05/32] gsupplicant: Add P2P group related signal handlers

2014-07-10 Thread Daniel Wagner
Hi Tomasz, On 07/09/2014 02:36 PM, Tomasz Bursztyka wrote: These handlers make the link between the requested connection and the interface of the group instanciated in case of a successful group negociation. --- gsupplicant/gsupplicant.h | 5 ++ gsupplicant/supplicant.c | 174

Re: [PATCH 02/32] gsupplicant: Check whether or not a peer support WPS PBC

2014-07-10 Thread Daniel Wagner
Hi Tomasz, On 07/10/2014 10:33 AM, Tomasz Bursztyka wrote: +++ b/gsupplicant/gsupplicant.h @@ -78,6 +78,8 @@ extern C { #define G_SUPPLICANT_WPS_PIN(1 2) #define G_SUPPLICANT_WPS_REGISTRAR (1 3) +#define G_SUPPLICANT_WPS_CONFIG_PBC0x0080 + Is there a special

Re: [PATCH 03/32] gsupplicant: Add a function to set the P2P device name

2014-07-10 Thread Daniel Wagner
On 07/10/2014 10:42 AM, Tomasz Bursztyka wrote: Hi Daniel, +static void p2p_device_config_result(const char *error, +DBusMessageIter *iter, void *user_data) +{ +struct supplicant_p2p_dev_config *config = user_data; + +if (error) +SUPPLICANT_DBG(Unable

Re: [PATCH 19/32] dhcp: Make dhcp running on ipconfig so network is optional

2014-07-10 Thread Daniel Wagner
Hi Tomasz, On 07/09/2014 02:36 PM, Tomasz Bursztyka wrote: Thus dhcp code will be usable in peer, where there is no service nor network objects. --- src/connman.h | 8 +- src/dhcp.c| 364 +- src/network.c | 19 ++- 3 files

Re: [PATCH 00/32] Basic implementation of P2P Peer's Connect/Disconnect

2014-07-10 Thread Daniel Wagner
Hi Tomasz, On 07/09/2014 02:36 PM, Tomasz Bursztyka wrote: Hello, Here is the preliminary logic for Connect/Disconnect for P2P Peers. What it does: - Provide DBus Connect/Disconnect method for Peer object - connects a peer properly ONLY when the peer ends up as a group client* - Using WPS

Re: [PATCH] dnsproxy: Fix pointer alignment

2014-07-10 Thread Daniel Wagner
Hi Mario, On 07/10/2014 03:39 PM, Mario Schuknecht wrote: Pointer access with uint32_t pointer works only when pointer is 4-byte aligned. Use direct assignment, since it is not guaranteed that the pointer is 4-byte aligned. The same applies to memory access with uint16_t pointer. Patch

Re: [PATCH] dnsproxy: Prefer responses with ancount0 if append_domain is true

2014-07-08 Thread Daniel Wagner
Hi Pasi, On 07/06/2014 10:39 AM, pasi.sjoh...@jolla.com wrote: From: Pasi Sjöholm pasi.sjoh...@jollamobile.com If domain_append is true and a valid domain tld (eg. com. net. bz.) is queried we need to make sure that responses with ancount0 are preferred over ones with ancount==0. This is

Re: [PATCH] dhcp: Keep the retry timeout nor the ipv4ll task in dhcp_invalidate

2014-07-08 Thread Daniel Wagner
Hi Thomasz, On 07/08/2014 02:42 PM, Tomasz Bursztyka wrote: dhcp_invalidate is called it no_lease_cb, which one actually starts the retry callback and the ipv4ll task, thus this is bogus to remove them right after. I was too fast and applied this version. Sorry about that. cheers, daniel

Re: [PATCH 0/2] DNS queries without domain part fail

2014-07-07 Thread Daniel Wagner
Good Morning Jukka, On 07/04/2014 12:35 PM, Jukka Rissanen wrote: Hi, The commit fa7141ae55aad fixed the dns queries without domain part. Unfortunately there was a bug in that commit which is now fixed by patch 1. The labels in the dns query were uncompressed which changes the label length

Re: [PATCH v2 0/3] Handle VPN restart properly

2014-07-02 Thread Daniel Wagner
Hi Jukka On 07/02/2014 09:50 AM, Jukka Rissanen wrote: Hi, v2: - changing patch 7 (now called patch 1), to use g_new0() instead of g_try_new0() so that program aborts if allocation of small memory area fails. v1: VPN does not handle restart case properly. When the VPN connection

Re: [PATCH] wispr: Handle status codes 505 and 000 by the browser

2014-07-02 Thread Daniel Wagner
Hi Pasi, On 07/01/2014 03:43 PM, Pasi Sjöholm wrote: Sometimes captive portal system might return these status codes when continuing with g_web_request_get after the initial 302 status code. Let the browser handle these cases. 000 is seen with http://www.hotspotsystem.com/ 505 is seen with

Re: dhcp: fix further crashes when no dhcp available

2014-07-02 Thread Daniel Wagner
Hi Alexandru, On 07/02/2014 10:18 AM, Alexandru Costache wrote: Hi, Further testing revealed that d099d36c8654260524c423eff4edcad0171e24aa http://git.kernel.org/cgit/network/connman/connman.git/commit/?id=d099d36c8654260524c423eff4edcad0171e24aa does not fix all crashing conditions when

Re: dhcp: fix further crashes when no dhcp available

2014-07-02 Thread Daniel Wagner
Hi Alexandru, On 07/02/2014 11:32 AM, Alexandru Costache wrote: src/dhcp.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/dhcp.c b/src/dhcp.c index c717f84..7048731 100644 --- a/src/dhcp.c +++ b/src/dhcp.c @@ -70,6 +70,8 @@ static void dhcp_free(struct connman_dhcp

Re: [PATCH] dhcp: Fix further crashes when connected to network without dhcp

2014-07-02 Thread Daniel Wagner
Hi Alexandru, On 07/02/2014 03:23 PM, Alexandru Costache wrote: There are several crashing conditions in dhcp_retry_cb() and in ipv4ll_available_cb(), when service is NULL or dhcp-network is either NULL or has been freed. Fixed all by removing timeout and ipv4ll callback when invalidating

Re: [PATCH] dhcp: Remove leftover source if service has been freed

2014-07-01 Thread Daniel Wagner
Hi Alexandru, On 06/28/2014 11:31 AM, Alexandru Costache wrote: I was getting the following trace when connecting my system to a switch. The system was not connected to a wifi AP and also the switch was not connected to any other network, so no dhcp services were available. I added a patch

Re: [PATCH 07/12] ipaddress: Add support function that copies the whole IP address struct

2014-07-01 Thread Daniel Wagner
Hi Jukka On 07/01/2014 02:25 PM, Jukka Rissanen wrote: This is needed by later patch when vpnd needs to remember the previous used IP address. --- include/ipaddress.h | 1 + src/ipaddress.c | 25 +++-- 2 files changed, 24 insertions(+), 2 deletions(-) diff --git

Re: [PATCH 00/12] Handle VPN restart properly

2014-07-01 Thread Daniel Wagner
Hi Jukka, On 07/01/2014 02:25 PM, Jukka Rissanen wrote: Hi, VPN does not handle restart case properly. When the VPN connection is disconnected because of network glitches, it needs to be restarted. Then we must make sure that if the IP address changes, the old address is removed properly

Re: Difficulty using ConnMan 0.55

2014-06-27 Thread Daniel Wagner
Hi JP, On 06/26/2014 07:33 PM, Jose Pablo Carballo wrote: I am using ConnMan 0.55 to be compatible with the software stack that is running in my embedded system. Newer versions of ConnMan would require newer versions of libresolv, glib, and others, so my plan is to continue with 0.55. 0.55

  1   2   3   4   5   6   7   8   9   10   >