[PATCH 02/32] gsupplicant: Check whether or not a peer support WPS PBC

2014-07-10 Thread Tomasz Bursztyka
This will be used to request the proper wps method when connecting to the peer. --- gsupplicant/gsupplicant.h | 4 gsupplicant/supplicant.c | 28 2 files changed, 32 insertions(+) diff --git a/gsupplicant/gsupplicant.h b/gsupplicant/gsupplicant.h index 7a3c843.

[PATCH 01/32] gsupplicant: Use StopFind instead of Flush to detect P2P support

2014-07-10 Thread Tomasz Bursztyka
Flush implies a full reset of P2P status on the interface. When this is not a problem on a normal interface, it actually is one on a sub-interface created when connecting to a P2P peer. --- gsupplicant/supplicant.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/gsuppli

[PATCH 03/32] gsupplicant: Add a function to set the P2P device name

2014-07-10 Thread Tomasz Bursztyka
The wifi plugin will use this function to specify the P2P device name, and will set it according to the hostname. --- gsupplicant/gsupplicant.h | 2 ++ gsupplicant/supplicant.c | 62 +++ 2 files changed, 64 insertions(+) diff --git a/gsupplicant/gsupp

[PATCH 04/32] gsupplicant: Always call peer_lost callback when removing a peer

2014-07-10 Thread Tomasz Bursztyka
Wpa_supplicant might stop without signaling the peer to be lost, thus when cleaning up it's up to remove_peer() to call peer_lost callback so the wifi plugin can handle it properly. --- gsupplicant/supplicant.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gsupplicant/suppl

[PATCH 00/32 v2] Basic implementation of P2P Peer's Connect/Disconnect

2014-07-10 Thread Tomasz Bursztyka
o it should not generate collateral damage. Only patches 19-20 have some implications though I did not get any error while testing. (*: ConnMan sets the go intent to 7 by default, so for testing: make sure the other end as a higher go intent. At least for now.) Tomasz Bursztyka (32): gsupplican

Re: [PATCH 19/32] dhcp: Make dhcp running on ipconfig so network is optional

2014-07-10 Thread Tomasz Bursztyka
Hi Daniel, +int __connman_dhcp_start(struct connman_ipconfig *ipconfig, >+ struct connman_network *opt_network, dhcp_cb callback); I don't know if we should encode if a parameter is optional. Looks a bit strange. Looks ugly actually yes I'll see for separating network/ipco

Re: [PATCH 05/32] gsupplicant: Add P2P group related signal handlers

2014-07-10 Thread Tomasz Bursztyka
Hi Daniel, GSupplicantInterface *interface; char *path; unsigned char device_address[6]; + unsigned char iface_address[6]; I know it is too late but I would prefer a define ETH_ALEN from if_ether.h Not too late no :) I'll change device_address too. +

Re: [PATCH 03/32] gsupplicant: Add a function to set the P2P device name

2014-07-10 Thread Tomasz Bursztyka
Hi Daniel, +static void p2p_device_config_result(const char *error, + DBusMessageIter *iter, void *user_data) +{ + struct supplicant_p2p_dev_config *config = user_data; + + if (error) + SUPPLICANT_DBG("Unable to set P2P Device confi

Re: [PATCH 02/32] gsupplicant: Check whether or not a peer support WPS PBC

2014-07-10 Thread Tomasz Bursztyka
Hi Daniel, +++ b/gsupplicant/gsupplicant.h @@ -78,6 +78,8 @@ extern "C" { #define G_SUPPLICANT_WPS_PIN(1 << 2) #define G_SUPPLICANT_WPS_REGISTRAR (1 << 3) +#define G_SUPPLICANT_WPS_CONFIG_PBC 0x0080 + Is there a special reason it is not like the defines above (1 << x)?

[PATCH 12/32] peer: Make a relation between a peer and a device

2014-07-09 Thread Tomasz Bursztyka
This will be necessary for a connection/disconnection request to work in the relevant wifi plugin. --- include/peer.h | 6 +- plugins/wifi.c | 9 +++-- src/peer.c | 43 --- 3 files changed, 48 insertions(+), 10 deletions(-) diff --git a/includ

[PATCH 28/32] wifi: Handle incoming p2p device chicken and egg problem

2014-07-09 Thread Tomasz Bursztyka
When connecting with P2P, a new wifi device will be created and detected by both connman and wpa_supplicant. This last one will automatically create an interface out of it, thus the need to hold connman creating it itself through the DBus API. Instead, the device is put into a pending device list,

[PATCH 16/32] dbus: Factorize pending reply generic functions out of service.c

2014-07-09 Thread Tomasz Bursztyka
This function, not directly related to service, is used for instance in network.c and will be used elsewhere when implementing more peer logic. --- Makefile.am| 5 +++-- include/dbus.h | 3 +++ src/connman.h | 2 -- src/dbus.c | 32 src/network.c | 2

[PATCH 17/32] peer: Fix peers list change notification

2014-07-09 Thread Tomasz Bursztyka
Be sure the current peer is registered and not part of removed peers. --- src/peer.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/peer.c b/src/peer.c index 145ab78..a2c8eeb 100644 --- a/src/peer.c +++ b/src/peer.c @@ -126,12 +126,15 @@ static void append_existing_and

[PATCH 18/32] peer: Add the basic logic for peer state handling

2014-07-09 Thread Tomasz Bursztyka
This will permit to change the peer's state relevantly either from the wifi plugin or after configuring the ipconfig which will come later. Currently only connect and disconnect basics are handled. --- include/peer.h | 12 src/peer.c | 87 +

[PATCH 19/32] dhcp: Make dhcp running on ipconfig so network is optional

2014-07-09 Thread Tomasz Bursztyka
Thus dhcp code will be usable in peer, where there is no service nor network objects. --- src/connman.h | 8 +- src/dhcp.c| 364 +- src/network.c | 19 ++- 3 files changed, 203 insertions(+), 188 deletions(-) diff --git a/src/connman.

[PATCH 23/32] peer: Connect and Disconnect methods implementation

2014-07-09 Thread Tomasz Bursztyka
As for service, it keeps track of pending DBus calls and so on. --- src/peer.c | 118 +++-- 1 file changed, 116 insertions(+), 2 deletions(-) diff --git a/src/peer.c b/src/peer.c index 0ff312f..0dcb970 100644 --- a/src/peer.c +++ b/src/peer.

[PATCH 29/32] wifi: Support peer's state changed when connecting or being notified

2014-07-09 Thread Tomasz Bursztyka
Apply state changing depending on current status and events. --- plugins/wifi.c | 121 +++-- 1 file changed, 110 insertions(+), 11 deletions(-) diff --git a/plugins/wifi.c b/plugins/wifi.c index c1b4cfd..0d5d51d 100644 --- a/plugins/wifi.c +++ b

[PATCH 24/32] peer: Add the notion of sub-device used when connected.

2014-07-09 Thread Tomasz Bursztyka
A peer might get connected through a newly created specific device, thus the ipconfig needs to be aware of its index so it will set the ip address on the right interface. --- include/peer.h | 2 ++ src/peer.c | 17 + 2 files changed, 19 insertions(+) diff --git a/include/peer

[PATCH 14/32] peer: Add the ability to register/unregister a peer driver

2014-07-09 Thread Tomasz Bursztyka
This will be necessary for connecting or disconnecting a peer. --- include/peer.h | 8 src/peer.c | 20 2 files changed, 28 insertions(+) diff --git a/include/peer.h b/include/peer.h index 0304438..5c1d1ec 100644 --- a/include/peer.h +++ b/include/peer.h @@ -43,

[PATCH 30/32] wifi: Set the sub-device for the connecting peer

2014-07-09 Thread Tomasz Bursztyka
Thus the peer will use the proper device when running dhcp. --- plugins/wifi.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/plugins/wifi.c b/plugins/wifi.c index 0d5d51d..ba4ce66 100644 --- a/plugins/wifi.c +++ b/plugins/wifi.c @@ -2361,6 +2361,21 @@ static void peer_change

[PATCH 10/32] gsupplicant: Provide an accessor for a peer to get it's group interface

2014-07-09 Thread Tomasz Bursztyka
This will be useful on a proper peer_changed() event to finally make the relation of a Peer and the newly instanciated interface, and thus the proper iface index to work with when running dhcp. --- gsupplicant/gsupplicant.h | 1 + gsupplicant/supplicant.c | 8 2 files changed, 9 insertio

[PATCH 13/32] peer: Add a function to get the peer identifier

2014-07-09 Thread Tomasz Bursztyka
This will be useful for the wifi plugin, and then gsupplicant, to retrieve the proper peer wpa_supplicant object path when connecting or disconnecting. --- include/peer.h | 1 + src/peer.c | 8 2 files changed, 9 insertions(+) diff --git a/include/peer.h b/include/peer.h index e069f4

[PATCH 31/32] test: Improve p2p test script to handle Peer's signal plus fixes

2014-07-09 Thread Tomasz Bursztyka
- Peer objects can send a PropertiesChanged signal, thus handling it - Fixing an issues on GroupFinished (my mistake actually) - p2p_peer get the up-to-date properties of the peer object --- test/p2p-on-supplicant | 33 +++-- 1 file changed, 23 insertions(+), 10 deletio

[PATCH 25/32] wifi: Technology driver registration returns 0 on success

2014-07-09 Thread Tomasz Bursztyka
Fixes current return value handling which does the contrary. --- plugins/wifi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/wifi.c b/plugins/wifi.c index 3c8f26f..9afff4e 100644 --- a/plugins/wifi.c +++ b/plugins/wifi.c @@ -1897,7 +1897,7 @@ static void p2p_support(

[PATCH 32/32] client: Add suport for connecting and disconnecting a peer

2014-07-09 Thread Tomasz Bursztyka
Use the same command as for service, discinction will be made against object's name: starting with peer_ or service_. --- client/commands.c | 33 ++--- client/dbus_helpers.c | 2 +- 2 files changed, 23 insertions(+), 12 deletions(-) diff --git a/client/commands.c

[PATCH 15/32] peer: Add a reference counting mechanism for peer objects

2014-07-09 Thread Tomasz Bursztyka
This will be used on asynchronous call. E.g. DBus call Connect() etc... --- include/peer.h | 12 +- plugins/wifi.c | 4 +++- src/peer.c | 71 +- 3 files changed, 65 insertions(+), 22 deletions(-) diff --git a/include/peer.h b/in

[PATCH 26/32] wifi: Set the proper P2P device name if P2P is supported

2014-07-09 Thread Tomasz Bursztyka
Setting it always as the hostname. --- plugins/wifi.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/plugins/wifi.c b/plugins/wifi.c index 9afff4e..7efaa33 100644 --- a/plugins/wifi.c +++ b/plugins/wifi.c @@ -54,6 +54,7 @@ #include #include #include +#inclu

[PATCH 20/32] dhcp: Make possible to provide user data when starting dhcp

2014-07-09 Thread Tomasz Bursztyka
The dhcp callback had already a pointer for such user data, but it could not be set anywhere. Thus adding an extra parameter to __connman_dhcp_start so it is possible to provide such user_data. --- src/connman.h | 5 +++-- src/dhcp.c| 11 --- src/network.c | 5 +++-- 3 files changed,

[PATCH 27/32] wifi: Provide a peer driver to connect/disconnect a peer

2014-07-09 Thread Tomasz Bursztyka
This implement the logic to link the core to gsupplicant against peer connection and disconnection. --- plugins/wifi.c | 83 +- 1 file changed, 82 insertions(+), 1 deletion(-) diff --git a/plugins/wifi.c b/plugins/wifi.c index 7efaa33..03719

[PATCH 21/32] peer: Basic integration of ipconfig within a peer

2014-07-09 Thread Tomasz Bursztyka
Currently, only the peer as a client is supported. As a P2P peer is always in IPv4 via DHCP there is just one ipconfig object, only handled through dhcpv4. --- plugins/wifi.c | 5 ++- src/peer.c | 120 + 2 files changed, 124 insertions(

[PATCH 11/32] gsupplicant: Add function to connect/disconnect a peer

2014-07-09 Thread Tomasz Bursztyka
Connection interface should be the master wifi interface. Disconnection interface should be the p2p wifi interface createn during connection. --- gsupplicant/gsupplicant.h | 20 +- gsupplicant/supplicant.c | 155 +- 2 files changed, 172 insertions(

[PATCH 22/32] peer: Add DBus support for peer's ipconfig object

2014-07-09 Thread Tomasz Bursztyka
Thus it is possible now to get peer's IPv4 ipconfig: - the IP address - the netmask - and the method --- src/peer.c | 28 +++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/src/peer.c b/src/peer.c index 80120fc..0ff312f 100644 --- a/src/peer.c +++ b/src/peer

[PATCH 04/32] gsupplicant: Always call peer_lost callback when removing a peer

2014-07-09 Thread Tomasz Bursztyka
Wpa_supplicant might stop without signaling the peer to be lost, thus when cleaning up it's up to remove_peer() to call peer_lost callback so the wifi plugin can handle it properly. --- gsupplicant/supplicant.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gsupplicant/suppl

[PATCH 09/32] gsupplicant: Relate the connecting peer with the newly started group

2014-07-09 Thread Tomasz Bursztyka
This is mandatory for 2 reasons: - to get the current connecting peer's group relationship - this provides also the peer's connection interface: the group interface (if different than the originated connection interface) will help the wifi plugin to set the connection device to the Peer objec

[PATCH 08/32] gsupplicant: Add a callback and helpers to get peer's status

2014-07-09 Thread Tomasz Bursztyka
These will let the wifi plugin know whether the peer could connect, is connected or has disconnected. --- gsupplicant/gsupplicant.h | 12 gsupplicant/supplicant.c | 38 ++ 2 files changed, 50 insertions(+) diff --git a/gsupplicant/gsupplicant.h b/

[PATCH 01/32] gsupplicant: Use StopFind instead of Flush to detect P2P support

2014-07-09 Thread Tomasz Bursztyka
Flush implies a full reset of P2P status on the interface. When this is not a problem on a normal interface, it actually is one on a sub-interface created when connecting to a P2P peer. --- gsupplicant/supplicant.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/gsuppli

[PATCH 07/32] gsupplicant: Add PeerJoined and PeerDisconnected group signals handlers

2014-07-09 Thread Tomasz Bursztyka
These signals are sent if only the group is the GO. This will let us know which peer successfully joined our group and thus - later - will help to declare a peer as being connected (even though we did not specifically asked to be connected to it). --- gsupplicant/supplicant.c | 59

[PATCH 02/32] gsupplicant: Check whether or not a peer support WPS PBC

2014-07-09 Thread Tomasz Bursztyka
This will be used to request the proper wps method when connecting to the peer. --- gsupplicant/gsupplicant.h | 4 gsupplicant/supplicant.c | 28 2 files changed, 32 insertions(+) diff --git a/gsupplicant/gsupplicant.h b/gsupplicant/gsupplicant.h index 7a3c843.

[PATCH 03/32] gsupplicant: Add a function to set the P2P device name

2014-07-09 Thread Tomasz Bursztyka
The wifi plugin will use this function to specify the P2P device name, and will set it according to the hostname. --- gsupplicant/gsupplicant.h | 2 ++ gsupplicant/supplicant.c | 60 +++ 2 files changed, 62 insertions(+) diff --git a/gsupplicant/gsupp

[PATCH 05/32] gsupplicant: Add P2P group related signal handlers

2014-07-09 Thread Tomasz Bursztyka
These handlers make the link between the requested connection and the interface of the group instanciated in case of a successful group negociation. --- gsupplicant/gsupplicant.h | 5 ++ gsupplicant/supplicant.c | 174 ++ 2 files changed, 179 insertio

[PATCH 06/32] gsupplicant: Add support for peer PropertiesChanged signal

2014-07-09 Thread Tomasz Bursztyka
This is an important signal as it will clearly help to tell to which group this peer belongs, and thus to be able to determine if this peer is connected or not. --- gsupplicant/supplicant.c | 97 1 file changed, 97 insertions(+) diff --git a/gsuppl

[PATCH 00/32] Basic implementation of P2P Peer's Connect/Disconnect

2014-07-09 Thread Tomasz Bursztyka
ations though I did not get any error while testing. (*: ConnMan sets the go intent to 7 by default, so for testing: make sure the other end as a higher go intent. At least for now.) Tomasz Bursztyka (32): gsupplicant: Use StopFind instead of Flush to detect P2P support gsupplicant: Check w

Re: [RFC] Exposing network credentials to an application

2014-07-09 Thread Tomasz Bursztyka
Hi Grant, As for use cases, I believe Drew and I have just presented a very real world and credible use case. This use case, when measured in shipping unit volumes that likely continues to make it one of the largest single (and possibly aggregate) connman implementations, is all the more real

Re: [PATCH] wispr: request browser with status_url if redirect_url is not set

2014-07-09 Thread Tomasz Bursztyka
Hi, Nack on that patch, see below. From: Pasi Sjöholm Sometimes captive portal intercepts status_url-query without doing 302-redirect. It makes no sense to request browser with NULL as an url, therefore we need to use the status_url. --- src/wispr.c | 13 +++-- 1 file changed, 11 i

[PATCH 1/2 v2] dhcp: Keep the retry timeout nor the ipv4ll task in dhcp_invalidate

2014-07-08 Thread Tomasz Bursztyka
This patch reverts part of a8e5f414f68defa2e07d5a38d56c283ab3036826. dhcp_invalidate is called by no_lease_cb. This one actually starts the retry callback and the ipv4ll task, thus this is bogus to remove them right after in dhcp_invalidate. --- src/dhcp.c | 8 1 file changed, 8 deletion

[PATCHi v2] doc: Add informations about the experimental P2P Peer services support

2014-07-08 Thread Tomasz Bursztyka
As soon as p2p technology is present, whether it is enabled or not, it will be possible to register and un-register P2P Peer services. These will be served once p2p technology gets enabled. When scanning for Peers is possible, Peer objects will show the proposed services of those if some are prese

[PATCH] dhcp: Keep the retry timeout nor the ipv4ll task in dhcp_invalidate

2014-07-08 Thread Tomasz Bursztyka
dhcp_invalidate is called it no_lease_cb, which one actually starts the retry callback and the ipv4ll task, thus this is bogus to remove them right after. --- src/dhcp.c | 8 1 file changed, 8 deletions(-) diff --git a/src/dhcp.c b/src/dhcp.c index bc47c8a..3cacb6a 100644 --- a/src/dhcp.

Re: [RFC] Exposing network credentials to an application

2014-07-08 Thread Tomasz Bursztyka
Too few real use cases, which could be themselves be solved out of ConnMan. too many "be" in this sentence... ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman

Re: [RFC] Exposing network credentials to an application

2014-07-08 Thread Tomasz Bursztyka
Hi, Thanks Grant for the reply. The config option sounds right to me as a general solution. Connman folks, thoughts? I don't think we will ever put this PassPhrase property back again. And we don't do #ifdef here and there for small configurable parts. Too few real use cases, which could be t

Re: More detailed wifi service information

2014-07-07 Thread Tomasz Bursztyka
Hi, What about hidden SSIDs? Is a single hidden network shown in the list? If not how can a user understand which one is the one he wants to connect to? ConnMan make services based on SSID and security specs (wep, wpa/wpa2, etc...). So if 2 AP shares the same SSID but with different security

Re: More detailed wifi service information

2014-07-07 Thread Tomasz Bursztyka
Hi, Hello, found out about connman after having some problems with connecting to a network with wicd, and it's awesome. Since I liked it so much I started working on a Ruby library to interface with the daemon and a bundled fancy CLI. There is already (with newer version of connman) a nice CL

Re: [PATCH] doc: Add informations about the experimental P2P Peer services support

2014-07-07 Thread Tomasz Bursztyka
Hi Daniel, Hi Tomasz, On 07/04/2014 03:05 PM, Tomasz Bursztyka wrote: As soon as p2p technology is present, whether it is enabled or not, it will be possible to register and un-register P2P Peer services. These will be served once p2p technology gets enabled. When scanning for Peers is

[PATCH] doc: Add informations about the experimental P2P Peer services support

2014-07-04 Thread Tomasz Bursztyka
As soon as p2p technology is present, whether it is enabled or not, it will be possible to register and un-register P2P Peer services. These will be served once p2p technology gets enabled. When scanning for Peers is possible, Peer objects will show the proposed services of those if some are pres

Re: [PATCH] wispr: Handle status codes 505 and 000 by the browser

2014-07-02 Thread Tomasz Bursztyka
Hi Pasi, + case 505: >>+ DBG("HTTP version not supported, hand over to the browser"); >Anyway, though handling this status 505 like you propose is fine, it >would be great to know what/where/how made this status to fix gweb then >(if there is something to be fixed there). I

Re: [PATCH] wispr: Handle status codes 505 and 000 by the browser

2014-07-02 Thread Tomasz Bursztyka
Thanks Pasi, ACK from me. Tomasz ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman

Re: [PATCH] wispr: Handle status codes 505 and 000 by the browser

2014-06-30 Thread Tomasz Bursztyka
Hi Pasi, Minor comments, Sometimes captive portal system might return these status codes when continuing with g_web_request_get after the initial 302 status code. Let the browser handle these cases. 000 is seen with http://www.hotspotsystem.com/ 505 is seen with http://nextmesh.net/ Special t

Re: [PATCH] service: cancel agent requests prior to deleting wispr context

2014-06-26 Thread Tomasz Bursztyka
Hi, - connman_agent_cancel(service); >+__connman_wispr_stop(service); Just adding __connman_wispr_stop() should do the trick here. It could. However, if connman_agent_cancel() must be invoked every time __connman_wispr_stop() is called then it should be impossible to call __connman_

Re: [PATCH] service: cancel agent requests prior to deleting wispr context

2014-06-26 Thread Tomasz Bursztyka
Hi, - connman_agent_cancel(service); >+ __connman_wispr_stop(service); Just adding __connman_wispr_stop() should do the trick here. Tomasz ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman

Re: [PATCH] service: check service->pending for NULL

2014-06-24 Thread Tomasz Bursztyka
Hi #0 __GI_raise (sig=6) at raise.c:67 #1 __GI_abort () at abort.c:91 #2 _dbus_abort () at dbus-sysdeps.c:94 #3 _dbus_warn_check_failed (format=0x403492c4 "arguments to %s() were incorrect, assertion \"%s\" failed in file %s line %d.\nThis is normally a bug in some application using the D-B

Re: [PATCH] service: check service->pending for NULL

2014-06-24 Thread Tomasz Bursztyka
Hi, +++ b/src/service.c @@ -4022,8 +4022,10 @@ static DBusMessage *connect_service(DBusConnection *conn, if (err == -EINPROGRESS) return NULL; - dbus_message_unref(service->pending); - service->pending = NULL; + if (service->pending) { + dbus

Re: Configuring DHCP Server

2014-06-18 Thread Tomasz Bursztyka
Hi, FallBackNameserver are used only if you don't have any other dns from >>other connection like 3g. Correct? > > >That's correct, but it is also used by default (if present) as the dns >settings when tethering. >Have a look at src/tethering.c from line 234 to 261 > I was thinking that it's o

Re: Configuring DHCP Server

2014-06-18 Thread Tomasz Bursztyka
Hi, >>Can you try setting the FallbackNameservers in /etc/connman/main.conf? > FallBackNameserver are used only if you don't have any other dns from other connection like 3g. Correct? That's correct, but it is also used by default (if present) as the dns settings when tethering. Have a loo

Re: Configuring DHCP Server

2014-06-18 Thread Tomasz Bursztyka
Hi, I didn't want dnsproxy. I already have a DNS service on my device, so I want that the nameserver configured in the final device by DHCP set to the same ip as the default gateway Is that possible? Can you try setting the FallbackNameservers in /etc/connman/main.conf? Tomasz

Re: Configuring DHCP Server

2014-06-18 Thread Tomasz Bursztyka
Hi, Have you built connman with dnsproxy support? Tomasz ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman

Re: [PATCH] Change the threshold for background scanning, -45 is actually very good RSSI.

2014-06-18 Thread Tomasz Bursztyka
Hi Pasi, With quite many Qualcomm based Android devices WCNSS settings have: gNeighborLookupThreshold=76 gNeighborReassocThreshold=81 So having -65dBm instead of -45dBm should be still reasonable. Depends on the chip, antenna, driver... It's really particular to all hw. Myself at 3m, I have

Re: [PATCH] Change the threshold for background scanning, -45 is actually very good RSSI.

2014-06-17 Thread Tomasz Bursztyka
Hi Pasi, How did you evaluated that -65dbm is better than -45dbm? On scanning events amount? -65 is usually already low signal. (relatively to the noise however) Depends on what you are trying to achieve, a better user experience (better connectivity) or better battery life. I bet such backgro

Re: Connman crashes when loosing network

2014-05-21 Thread Tomasz Bursztyka
Hi Marcel, Your patch works but that basically skips all multi line headers, so I think you have some coding to do;-) If you want to support multi line headers of course. Sure, the patch was just to verify the crash origin. There is indeed a bit of work to get it right now. Thanks for repo

Re: Connman crashes when loosing network

2014-05-16 Thread Tomasz Bursztyka
Hi Marcel, connmand[30944]: WEB: gweb/gweb.c:received_data() web 0xd5ae0 [header] connmand[30944]: WEB: gweb/gweb.c:received_data() web 0xd5ae0 [header] connmand[30944]: WEB: gweb/gweb.c:received_data() web 0xd5ae0 [header] connmand[30944]: WEB: gweb/gweb.c:received_data() web 0xd5ae0 [header

[PATCH] gweb: Do not lookup for a NULL key in a hash table

2014-05-15 Thread Tomasz Bursztyka
At this position, no key might have been provided yet. Reported by Marcel Mulder --- Hi Marcel, Does that helps? Btw the logs you provided are missing the gweb parts. Could you run connman like: CONNMAN_WEB_DEBUG=1 connmnand Thanks, gweb/gweb.c | 3 +++ 1 file changed, 3 insertions(+) dif

Re: Connman crashes when loosing network

2014-05-15 Thread Tomasz Bursztyka
Hi Marcel, I narrowed the problem down to this. In function handle_multi_line (gweb.c:809) a call is made to g_hash_table_lookup but session->result.last_key is NULL. (gdb) print session->result.last_key $1 = (gchar *) 0x0 Is there anything I can do to help you guys further? Interesting. It

Re: Unreachable favorite network

2014-05-14 Thread Tomasz Bursztyka
Hi Julien, Often they think they remove all the favorite networks in the UI list, and they don't understand that some networks are still stored. What do they want to do? Selectively removing some known networks, or removing all known ones? If it's the later, a small script could just do that

[PATCH 2/3] technology: Fix a false positive null dereference

2014-05-14 Thread Tomasz Bursztyka
P2P technology cannot exist without wifi technology, so if P2P is present, wifi is present as well. Thus what coverity thinks is a null dereference is a false positive here. Reported by Daniel Wagner --- src/technology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tec

[PATCH 3/3] wifi: Check the returned code when registering the P2P technology driver

2014-05-14 Thread Tomasz Bursztyka
Reported by Daniel Wagner --- plugins/wifi.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/plugins/wifi.c b/plugins/wifi.c index 7c412ef..988ca1a 100644 --- a/plugins/wifi.c +++ b/plugins/wifi.c @@ -1885,8 +1885,11 @@ static void p2p_support(GSupplicantInterface *inte

[PATCH 1/3] gsupplicant: Fix an emptyness test on an array

2014-05-14 Thread Tomasz Bursztyka
Reported by Daniel Wagner --- gsupplicant/supplicant.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/gsupplicant/supplicant.c b/gsupplicant/supplicant.c index 8a16663..b483f9b 100644 --- a/gsupplicant/supplicant.c +++ b/gsupplicant/supplicant.c @@ -2411,10 +2411,12 @@ sta

[PATCH 0/3 v2] Various fixes around P2P

2014-05-14 Thread Tomasz Bursztyka
My first version of the patchset was made on top of up-coming patches... Tomasz Bursztyka (3): gsupplicant: Fix an emptyness test on an array technology: Fix a false positive null dereference wifi: Check the returned code when registering the P2P technology driver gsupplicant

Re: [PATCH 2/2] test: Arg parsing for p2p-on-supplication

2014-05-13 Thread Tomasz Bursztyka
Hi Eduardo, Minor issue: @@ -100,37 +105,33 @@ class Wpa_s: bus.add_signal_receiver(self.__InterfaceRemoved, path=WPA_PATH, signal_name='InterfaceRemoved') self.__reset() + +self.debug = False unnecessary since it's done below alre

[PATCH] test: Improve p2p-on-supplicant test script for P2P connection

2014-05-12 Thread Tomasz Bursztyka
- Provide a device name for the local p2p device - join or negociate for a group according to distant peer - GroupFinished signal handler added by Eduardo Abinader --- test/p2p-on-supplicant | 175 +++-- 1 file changed, 156 insertions(+), 19 deletion

[PATCH 0/3] Various fixes around P2P

2014-05-12 Thread Tomasz Bursztyka
Thanks to Daniel Wagner and his Coverity report, here are 3 fixes on P2P support Tomasz Bursztyka (3): gsupplicant: Fix an emptyness test on an array technology: Fix a false positive null dereference wifi: Check the returned code when registering the P2P technology driver gsupplicant

[PATCH 2/3] technology: Fix a false positive null dereference

2014-05-12 Thread Tomasz Bursztyka
P2P technology cannot exist without wifi technology, so if P2P is present, wifi is present as well. Thus what coverity thinks is a null dereference is a false positive here. Reported by Daniel Wagner --- src/technology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tec

[PATCH 1/3] gsupplicant: Fix an emptyness test on an array

2014-05-12 Thread Tomasz Bursztyka
Reported by Daniel Wagner --- gsupplicant/supplicant.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/gsupplicant/supplicant.c b/gsupplicant/supplicant.c index 2be773e..b8c89ad 100644 --- a/gsupplicant/supplicant.c +++ b/gsupplicant/supplicant.c @@ -2427,10 +2427,12 @@ sta

[PATCH 3/3] wifi: Check the returned code when registering the P2P technology driver

2014-05-12 Thread Tomasz Bursztyka
Reported by Daniel Wagner --- plugins/wifi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/wifi.c b/plugins/wifi.c index e169692..2dd5dc4 100644 --- a/plugins/wifi.c +++ b/plugins/wifi.c @@ -2025,8 +2025,8 @@ static void p2p_support(GSupplicantInterface *interfac

[PATCH v2] ntp: Reset the source id after removal

2014-05-09 Thread Tomasz Bursztyka
Fixes this issue: connmand[3288]: src/ntp.c:__connman_ntp_stop() (connmand:3288): GLib-CRITICAL **: Source ID 144 was not found when attempting to remove it --- src/ntp.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/ntp.c b/src/ntp.c index c3bef65..b4fe63a 10064

[PATCH] ntp: Reset the source id after removal

2014-05-09 Thread Tomasz Bursztyka
Fixes this issue: connmand[3288]: src/ntp.c:__connman_ntp_stop() (connmand:3288): GLib-CRITICAL **: Source ID 144 was not found when attempting to remove it --- src/ntp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/ntp.c b/src/ntp.c index c3bef65..e72bc1a 100644 ---

Re: [PATCH 2/2] Avoid network duplicate unref for eth_dev_remote

2014-04-17 Thread Tomasz Bursztyka
Thanks, Now it's possible to pin point which part is bogus: - connman_network_create() network 0x749d890 - connman_network_ref_debug() 0x749d890 name Wired ref 2 by src/device.c:858:connman_device_add_network() - connman_network_ref_debug() 0x749d890 name Wired ref 3 by src/service.c:6670:upda

Re: [PATCH 2/2] Avoid network duplicate unref for eth_dev_remote

2014-04-17 Thread Tomasz Bursztyka
Hi Eduardo, As you mentioned, the network reference device is freeing is the the one it creates, in this case, it is created in eth_newlink. I could not see any network referenced by eth which is not via device, so that's the reason I patched by removing network_unref and letting device manage i

Re: [PATCH 2/2] Avoid network duplicate unref for eth_dev_remote

2014-04-17 Thread Tomasz Bursztyka
Hi Eduardo, Network unreference is already being done by free_network, called by g_hash_table_remove. This patche prevents from an invalid read during nework removal. I would be curious to see your valgrind output. The reference ethernet.c is removing is the one which is set when the network

Re: [PATCH] Configurable IPv4/6-status urls & support for http-status response code 204 for online checks.

2014-04-17 Thread Tomasz Bursztyka
Hi Pasi, Could you resend the patch, through git send-email, so it's under the proper format? With a proper commit message and so on. My comments below. Mostly code style issues but also one fix that should be in another patch: --- diff --git a/include/setting.h b/include/setting.h index a

Re: 'Not supported' message

2014-04-11 Thread Tomasz Bursztyka
Hi Cliff, As you're aware one can install four .service files with supplicant. /lib/systemd/system/wpa_supplicant.service has to be enabled if D-Bus interface was built into wpa_supplicant, so that wpa_supplicant D-Bus interface can be started at boot instead of being automatically activated

Re: WiFi Tethering question

2014-04-10 Thread Tomasz Bursztyka
Hi, so what can I do if client device want to connect the AP using WPS >method(both PBC and PIN)? WPS is not supported on the tethering interface. It requires some amount of planning and work to implement. wpa_supplicant's AP mode exposes the necessary parameters to set this up. It would requ

Re: 'Not supported' message

2014-04-09 Thread Tomasz Bursztyka
Hi Cliff, Okay, so let's get this right. Supplicant is started by D-bus when Connman contacts D-bus? So there is no need for start up files for supplicant or any of that? Is there anyway Connman could be at fault here by not contacting D-bus properly? No it works properly. There is surely

Re: Access Point mode set freq

2014-04-09 Thread Tomasz Bursztyka
Hi Michael, Sorry for the late answer Can you point me to your patch in wpa_supplicant? Here: http://lists.shmoo.com/pipermail/hostap/2013-September/028460.html But it probably does not apply anymore. And there had been a lot more patches around ACS recently, and one disabling the interface

Re: 'Not supported' message

2014-04-09 Thread Tomasz Bursztyka
Hi Cliff, No, but if I start supplicant manually, then I can connect, otherwise I get the error. For some reason connman is not requesting supplicant. Still starting connman from source dir. ConnMan does not request supplicant, it requests its dbus interface. And if wpa_supplicant is proper

Re: 'Not supported' message

2014-04-08 Thread Tomasz Bursztyka
Hi Cliff, But if I run 'wpa_supplicant -Dnl80211 -iwlan0 -c/etc/wpa_supplicant.conf' and then 'connmand -n -d' from the connman source, I get the familiar 'Error /net/connman/technology/wifi: Not supported' Again there is no soft blocking anymore - why I don't know. Never run wpa_supplicant

Re: 'Not supported' message

2014-04-07 Thread Tomasz Bursztyka
Hi, I'm sending four attachments to your email to avoid mailing to the list. But I think I have the reason why I had no wifi; Connman is soft blocking the card when it starts. If I unblock using rfkill, I can scan and connect! Log 1 is with card blocked, Log 2 after I unblock. So how is thi

Re: 'Not supported' message

2014-04-07 Thread Tomasz Bursztyka
Ok then it's really weird: ConnMan should not show up the wifi technology in this case. Let's revisit this from scratch: - give me your hardware specification of the wifi card - what kernel version? - get the latest version of ConnMan from git (1.23), built it with bootstrap-configure (adapt

Re: 'Not supported' message

2014-04-06 Thread Tomasz Bursztyka
Hi Cliff, >Do you have a wifi technology appearing in connmanctl ? (technologies >command) Yes, 'connmanctl technologies' gives: /net/connman/technology/wifi Name = WiFi Type = wifi Powered = True Connected = False Tethering = False ConnMan should not show up wifi technology

[PATCH] technology: Do not refcount P2P technology as it is dependent on wifi

2014-04-04 Thread Tomasz Bursztyka
P2P technology exists if only wifi technology exists and does not own any devices. Thus it's unnecessary to refcount it more than once. Reported by Eduardo Abinader --- src/technology.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/technology.c b/src/technology.c inde

Re: [PATCH 1/1] Fix p2p driver probe

2014-04-04 Thread Tomasz Bursztyka
Hi Eduardo, + struct connman_technology *technology; Useless var, see below. for (list = driver_list; list; list = list->next) { if (list->data == driver) @@ -1254,8 +1255,11 @@ int connman_technology_driver_register(struct connman_technology_driver *driver)

Re: 'Not supported' message

2014-04-04 Thread Tomasz Bursztyka
Hi Cliff, >Got to see you logs and something is weird: there is no messages coming >from plugins/wifi.c >You did not filtered out the logs, did you? No, not at all, but what is strange is that I have no plugins dir and hence no wifi.c! Maybe you built all as builtin. But in your case I don't

[PATCH v2] gsupplicant: Output a relevant warning about P2P support

2014-04-03 Thread Tomasz Bursztyka
Identify which part does not support P2P: wpa_supplicant or the interface itself. --- gsupplicant/supplicant.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/gsupplicant/supplicant.c b/gsupplicant/supplicant.c index cd35012..9734e48 100644 --- a/gsupplicant/supplican

<    1   2   3   4   5   6   7   8   9   10   >