Re: [PATCH 1/2] gresolv: added the capability to restrict the results to a specific address family.

2011-07-01 Thread Marcel Holtmann
Hi Tomasz, please shorten the subject line. If anything that is show via git log goes over 78 characters terminal wide then it don't like it. Better have a short subject and a detailed explanation. General rule is that subjects should not be more than 60 characters. > --- > gweb/gresolv.c | 26

[PATCH 1/2] gresolv: added the capability to restrict the results to a specific address family.

2011-07-01 Thread Tomasz Bursztyka
--- gweb/gresolv.c | 26 ++ gweb/gresolv.h |2 ++ 2 files changed, 28 insertions(+), 0 deletions(-) diff --git a/gweb/gresolv.c b/gweb/gresolv.c index a334d84..42a3757 100644 --- a/gweb/gresolv.c +++ b/gweb/gresolv.c @@ -62,6 +62,8 @@ struct resolv_lookup { G

Re: [PATCH 1/2] gresolv: added the capability to restrict the results to a specific address family.

2011-07-01 Thread Marcel Holtmann
Hi Tomasz, > >> gboolean g_resolv_cancel_lookup(GResolv *resolv, guint id); > >> > >> +gboolean g_resolv_set_result_address_family(GResolv *resolv, int family); > >> + > > why is not using g_web_set_address_family() enough and just restrict > > outgoing and result at the same time? > gweb is no

Re: [PATCH 1/2] gresolv: added the capability to restrict the results to a specific address family.

2011-07-01 Thread Tomasz Bursztyka
Hi Marcel, >> gboolean g_resolv_cancel_lookup(GResolv *resolv, guint id); >> >> +gboolean g_resolv_set_result_address_family(GResolv *resolv, int family); >> + > why is not using g_web_set_address_family() enough and just restrict > outgoing and result at the same time? gweb is not used in wpad

Re: [PATCH 1/2] gresolv: added the capability to restrict the results to a specific address family.

2011-06-30 Thread Marcel Holtmann
Hi Tomasz, > diff --git a/gweb/gresolv.h b/gweb/gresolv.h > index 1bcaf44..589237c 100644 > --- a/gweb/gresolv.h > +++ b/gweb/gresolv.h > @@ -67,6 +67,8 @@ guint g_resolv_lookup_hostname(GResolv *resolv, const char > *hostname, > > gboolean g_resolv_cancel_lookup(GResolv *resolv, guint id);

[PATCH 1/2] gresolv: added the capability to restrict the results to a specific address family.

2011-06-30 Thread Tomasz Bursztyka
--- gweb/gresolv.c | 26 ++ gweb/gresolv.h |2 ++ 2 files changed, 28 insertions(+), 0 deletions(-) diff --git a/gweb/gresolv.c b/gweb/gresolv.c index a334d84..27de74e 100644 --- a/gweb/gresolv.c +++ b/gweb/gresolv.c @@ -62,6 +62,8 @@ struct resolv_lookup { G