Re: [controller-dev] Deleting a node from MD-SAL that doesn't exist / already deleted

Robert and other controller/mdsal experts, On Tue, Sep 19, 2017 at 6:45 PM, Michael Vorburger wrote: > Robert & Tom, > > Faseela reminded us (thank you) in genius of this thread in the context of > the ongoing review of https://git.opendaylight.org/gerrit/#/c/63118/, >

Re: [controller-dev] Deleting a node from MD-SAL that doesn't exist / already deleted

Robert & Tom, Faseela reminded us (thank you) in genius of this thread in the context of the ongoing review of https://git.opendaylight.org/gerrit/#/c/63118/, where there appears to be some disagreement (suneel verma) as to whether a delete() must be preceded by an exists check to avoid some

Re: [controller-dev] Deleting a node from MD-SAL that doesn't exist / already deleted

Specifically in this case it's not in a shutdown flow, and even if it was and my example is bad, it doesn't prove my point is wrong. There are obviously many examples where this permissive mode is bad, and this is why the default should behave as of today. I'm trying to argue that there are

Re: [controller-dev] Deleting a node from MD-SAL that doesn't exist / already deleted

On 01/22/2017 09:16 AM, Sela, Guy wrote: > Hi > I totally agree with you that it might indicate there is a cleanup code that > runs in an un-coordinated fashion. > There is no value in explaining what causes this problem in this specific > case, because it is probably solvable. > My point was

Re: [controller-dev] Deleting a node from MD-SAL that doesn't exist / already deleted

On 01/20/2017 10:13 AM, Sela, Guy wrote: > My suggestion was not to change the current delete, but to add to it another > flag, which will "silence" the exceptions in the case where the transaction > started when the Node existed, and ended when it didn't exist anymore. > Default behavior would

Re: [controller-dev] Deleting a node from MD-SAL that doesn't exist / already deleted

I understand you points and thanks for the clarification about the meaning of the exception. My suggestion was not to change the current delete, but to add to it another flag, which will "silence" the exceptions in the case where the transaction started when the Node existed, and ended when it

Re: [controller-dev] Deleting a node from MD-SAL that doesn't exist / already deleted

er-dev@lists.opendaylight.org; mdsal-...@lists.opendaylight.org; Tom Pantelis <tompante...@gmail.com> Subject: [controller-dev] Deleting a node from MD-SAL that doesn't exist / already deleted When submitting a delete transaction on a node that doesn't exist, MD-SAL's behavior

Re: [controller-dev] Deleting a node from MD-SAL that doesn't exist / already deleted

On 01/19/2017 07:03 PM, Robert Varga wrote: > The question you need to answer to solve the problem you are seeing is: > why has the path disappeared? ... and please don't get me wrong, I am not inherently opposed to defining new operations, but it is an immensely expensive change. This would

Re: [controller-dev] Deleting a node from MD-SAL that doesn't exist / already deleted

On 01/19/2017 05:59 PM, Sela, Guy wrote: > When submitting a delete transaction on a node that doesn’t exist, > MD-SAL’s behavior is to throw ModifiedNodeNotExists Exception. Are you referring to ModifiedNodeDoesNotExistException? If so, then... > There are many usecases where there is a

[controller-dev] Deleting a node from MD-SAL that doesn't exist / already deleted

When submitting a delete transaction on a node that doesn't exist, MD-SAL's behavior is to throw ModifiedNodeNotExists Exception. There are many usecases where there is a "cleanup" code that tries to delete some state even though it is not 100% there, just for the sake of cleanup. I saw it in