Re: Sponsoring getting 5015163 "(str) String merge/join that is the inverse of String.split()" into JDK 7

2009-10-27 Thread Ulf Zibis
Neal, thanks for your patience. Yes, these are the arguments I understand. Thanks a lot, -Ulf Am 27.10.2009 17:36, Neal Gafter schrieb: Ulf- Very good. How what happens if you change the return type, or add a throws clause, or change its access modifier (JLS 8.4.8.3)? In all three cases

Re: Review request for 6895456: Eliminate dependency on java.io.ObjectStreamClass during boot

2009-10-27 Thread Alan Bateman
Mandy Chung wrote: Duplicating this method may be a better option for this case (that I typically try to avoid). I can make this change. The new webrev at: http://cr.openjdk.java.net/~mchung/6895456/webrev.01/ OK, I think I can live with this. While you are there, maybe we should replace C

Re: Sponsoring getting 5015163 "(str) String merge/join that is the inverse of String.split()" into JDK 7

2009-10-27 Thread Neal Gafter
Ulf- Very good. How what happens if you change the return type, or add a throws clause, or change its access modifier (JLS 8.4.8.3)? In all three cases it must be a compile-time error. -Neal On Tue, Oct 27, 2009 at 8:13 AM, Ulf Zibis wrote: > It works fine too. > Is coded: > > > public class

Re: Sponsoring getting 5015163 "(str) String merge/join that is the inverse of String.split()" into JDK 7

2009-10-27 Thread Ulf Zibis
It works fine too. Is coded: public class MyClass1 { private final int value; public MyClass1(int value) { this.value = value; } public static int hashCode(Object key) { return 3; } //public static int hashCode(MyClass1 obj) { //return 3 * obj.value; //

Re: Review request for 6895456: Eliminate dependency on java.io.ObjectStreamClass during boot

2009-10-27 Thread Mandy Chung
Duplicating this method may be a better option for this case (that I typically try to avoid). I can make this change. The new webrev at: http://cr.openjdk.java.net/~mchung/6895456/webrev.01/ Mandy

Re: Sponsoring getting 5015163 "(str) String merge/join that is the inverse of String.split()" into JDK 7

2009-10-27 Thread Neal Gafter
Try adding public static hashCode(Object key) { return 3; } to MyClass. Such a class is broken by the proposed change. On Tue, Oct 27, 2009 at 2:49 AM, Ulf Zibis wrote: > Correction: > > > public class MyClass1 { > private final int value; > > public MyClass1(int value) { > t

Re: Review request for 6895456: Eliminate dependency on java.io.ObjectStreamClass during boot

2009-10-27 Thread Mandy Chung
Alan Bateman wrote: I agree it would be good to avoid loading/initializing ObjectStreamClass (as you say, we have to load ObjectStreamField as the serialPersistentFields is part of Class, String, and other APIs). My only concern is that ObjectStreamField doesn't seem to be the right place for

Re: Are the faster versions of HashMap and BigInteger going into jdk7?

2009-10-27 Thread Andrew John Hughes
2009/10/27 Alan Eliasen : > On 10/23/2009 11:01 AM, Andrew John Hughes wrote: >> >> 6622432 is the one of the ones I just pointed to i.e. it's in JDK7. >> If Alan has a further patch and hasn't even submitted it for >> inclusion, it's obviously not in. > >   I had just queried Joe Darcy at Sun abou

Re: Sponsoring getting 5015163 "(str) String merge/join that is the inverse of String.split()" into JDK 7

2009-10-27 Thread Ulf Zibis
Correction: public class MyClass1 { private final int value; public MyClass1(int value) { this.value = value; } public static int hashCode(MyClass1 obj) { return 3 * obj.value; } public static void main(String... args) { MyClass1 c = new MyClass1(99); System

Re: Sponsoring getting 5015163 "(str) String merge/join that is the inverse of String.split()" into JDK 7

2009-10-27 Thread Ulf Zibis
Am 26.10.2009 18:43, Joseph D. Darcy schrieb: Neal Gafter wrote: You can hardly add any methods to Object, event static methods, without breaking compatibility, because they get added to every the overload set if the name is used for methods in existing code. Indeed, which is why these method

hg: jdk7/tl/jdk: 6888179: Separate out dependency on CORBA

2009-10-27 Thread alan . bateman
Changeset: 244a6868b440 Author:alanb Date: 2009-10-27 08:55 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/244a6868b440 6888179: Separate out dependency on CORBA Reviewed-by: dfuchs + src/share/classes/com/sun/jmx/remote/internal/IIOPHelper.java + src/share/classes/com/sun/j

Re: Review request for 6895456: Eliminate dependency on java.io.ObjectStreamClass during boot

2009-10-27 Thread Alan Bateman
Mandy Chung wrote: Fixed 6895456: Eliminate dependency on java.io.ObjectStreamClass during boot Webrev at: http://cr.openjdk.java.net/~mchung/6895456/webrev.00/ java.io.ObjectStreamClass is not needed if not doing serialization. Move getSignatureClass static method to java.io.ObjectStreamF

Re: Are the faster versions of HashMap and BigInteger going into jdk7?

2009-10-27 Thread Alan Eliasen
On 10/23/2009 11:01 AM, Andrew John Hughes wrote: 6622432 is the one of the ones I just pointed to i.e. it's in JDK7. If Alan has a further patch and hasn't even submitted it for inclusion, it's obviously not in. I had just queried Joe Darcy at Sun about reviewing my patches for Karatsuba a