Alan,
webrev has been updated to use the sun.zip.disableMemoryMapping
http://cr.openjdk.java.net/~sherman/6929479/webrev
Please review.
Thanks,
Sherman
Alan Bateman wrote:
Xueming Shen wrote:
:
The webrev has been updated to use "sun.zip.disableMmapping", I guess
you meant "sun.zip.disable
I couldn't resist making a similar change to isValidCodePoint.
@@ -2678,7 +2678,8 @@
* @since 1.5
*/
public static boolean isValidCodePoint(int codePoint) {
-return codePoint >= MIN_CODE_POINT && codePoint <= MAX_CODE_POINT;
+int plane = codePoint >>> 16;
+
On Wed, Mar 10, 2010 at 09:58, Ulf Zibis wrote:
> Hi Martin,
>
> there wasn't enough time today, so please wait for tomorrow.
>
> In brief:
> - I wouldn't rename to isBMPCodePoint(), because there are many other names
> in Surrogate class that don't sync to Character and and a usages search in
> s
On Wed, Mar 10, 2010 at 01:58, Goktug Gokdogan wrote:
> Similarly,
> BitSet.ensureCapacity
I don't think BitSet has this problem, because the bits are stored in longs,
so the array can never overflow. But don't believe me - prove me wrong!
> AbstractStringBuilder.expandCapacity
Yup.
> V
On Wed, Mar 10, 2010 at 09:36, Ulf Zibis wrote:
> Am 10.03.2010 00:22, schrieb Martin Buchholz:
>>
>> On Tue, Mar 9, 2010 at 15:11, Ulf Zibis wrote:
>>
>>
>>>
>>> Can you explain the mystery about "+ 2" ?
>>>
>>
>> It's exactly the same as the old resizing behavior.
>
> In detail I meant, if you
Changeset: 9871ce4fd56f
Author:jjg
Date: 2010-03-10 16:23 -0800
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/9871ce4fd56f
6933914: fix missing newlines
Reviewed-by: ohair
! test/tools/javac/OverrideChecks/6738538/T6738538a.java
! test/tools/javac/OverrideChecks/6738538/T67
Changeset: 467484e025d6
Author:martin
Date: 2010-03-10 14:53 -0800
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/467484e025d6
6931812: A better implementation of sun.nio.cs.Surrogate.isBMP(int)
Summary: uc >> 16 == 0 is superior to (int) (char) uc == uc
Reviewed-by: sherman
Contri
approved.
I don't have a spare ws right now.so please just push, it's almost there:-)
sherman
Martin Buchholz wrote:
Here's the proposed fix for
6931812: A better implementation of sun.nio.cs.Surrogate.isBMP(int)
http://cr.openjdk.java.net/~martin/webrevs/openjdk7/isBMPCodePoint/
I changed t
Hi Martin,
there wasn't enough time today, so please wait for tomorrow.
In brief:
- I wouldn't rename to isBMPCodePoint(), because there are many other
names in Surrogate class that don't sync to Character and and a usages
search in sun.nio.cs.* or where ever else could be omitted. Better add
Am 10.03.2010 00:22, schrieb Martin Buchholz:
On Tue, Mar 9, 2010 at 15:11, Ulf Zibis wrote:
Can you explain the mystery about "+ 2" ?
It's exactly the same as the old resizing behavior.
In detail I meant, if you have any idea, why the original designers
could have chosen the "+1
Changeset: 47958f76babc
Author:chegar
Date: 2010-03-10 14:44 +
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/47958f76babc
6933618: java/net/MulticastSocket/NoLoopbackPackets.java fails when rerun
Reviewed-by: alanb
! test/java/net/MulticastSocket/NoLoopbackPackets.java
Similarly,
BitSet.ensureCapacity
AbstractStringBuilder.expandCapacity
Vector.ensureCapacityHelper
methods need to have similar checks and/or throw proper exceptions.
By the way, I did not understand why IdentityHashMap and HashMap have
different MAXIMUM_CAPACITY and different logic to handle
12 matches
Mail list logo
