Re: Code review request for 4881419 The type of X[].clone() should be X[]

I think I still don't understand. :-( The compile-time behaviour is well documented in JLSv3 6.4.5. But where is the run-time behaviour documented? Isn't the javadoc of class Object a good place? With the term 'spec' you mean the JLS or the javadoc of class Object? -Ulf Am 04.09.2010 01:34,

Re: Code review request for 4881419 The type of X[].clone() should be X[]

On Fri, Sep 3, 2010 at 16:13, Ulf Zibis wrote: > , > > the whole enclosing paragraph talks about class, object and instance, so > why talk about type for the array case? > > Because the array types don't have their own javadoc, there is no other obvious place to document the compile-time behavi

Re: Code review request for 4881419 The type of X[].clone() should be X[]

188 * The method {...@code clone} for*class* {...@code Object} performs a 189 * specific cloning operation. First, if the*class* of this*object*does 190 * not implement the interface {...@code Cloneable}, then a 191 * {...@code CloneNotSupportedException} is thrown. No

Re: Code review request for 4881419 The type of X[].clone() should be X[]

Ulf, The spec needs to talk about *both* class (runtime) and type (compile-time). And now it does. Martin On Fri, Sep 3, 2010 at 15:31, Ulf Zibis wrote: > Am 04.09.2010 00:05, schrieb Joe Darcy: > > Ulf Zibis wrote: >> >>> Am 03.09.2010 12:31, schrieb Ulf Zibis: >>> I think the que

Re: Code review request for 4881419 The type of X[].clone() should be X[]

Am 04.09.2010 00:05, schrieb Joe Darcy: Ulf Zibis wrote: Am 03.09.2010 12:31, schrieb Ulf Zibis: I think the question of variable types belongs to the spec, but here in Object class's javadoc we should speak about objects. So I now suggest: "...and that the returned object of the {...@code c

Re: Code review request for 4881419 The type of X[].clone() should be X[]

Ulf Zibis wrote: Am 03.09.2010 12:31, schrieb Ulf Zibis: I think the question of variable types belongs to the spec, but here in Object class's javadoc we should speak about objects. So I now suggest: "...and that the returned object of the {...@code clone} method of an array object of class

Re: Code review request for 4881419 The type of X[].clone() should be X[]

Martin Buchholz wrote: On Thu, Sep 2, 2010 at 17:50, Joe Darcy > wrote: Martin Buchholz wrote: The usage T[] suggests that T is a reference type, as with generics, which is not the case here. More precisely, both the runtime types and

hg: jdk7/tl/jdk: 4881419: The type of X[].clone() should be X[]

Changeset: a6c142240837 Author:darcy Date: 2010-09-03 15:00 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a6c142240837 4881419: The type of X[].clone() should be X[] Reviewed-by: martin ! src/share/classes/java/lang/Object.java

hg: jdk7/tl/jdk: 2 new changesets

Changeset: 174916d435c9 Author:alanb Date: 2010-09-03 13:11 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/174916d435c9 6965072: Need API to create SDP sockets Reviewed-by: michaelm ! make/com/Makefile + make/com/oracle/Makefile + make/com/oracle/net/Makefile ! make/docs/NON

hg: jdk7/tl/langtools: 7 new changesets

Changeset: 112fcc00659d Author:cl Date: 2010-08-13 11:38 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/112fcc00659d Added tag jdk7-b105 for changeset aaecac256d39 ! .hgtags Changeset: 2c1c657f69a4 Author:cl Date: 2010-08-19 15:13 -0700 URL: http://hg.o

hg: jdk7/tl/jdk: 18 new changesets

Changeset: 9ad95be9deae Author:cl Date: 2010-08-13 11:38 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9ad95be9deae Added tag jdk7-b105 for changeset 3b0abcb51280 ! .hgtags Changeset: f8bbf376595c Author:yhuang Date: 2010-08-11 02:22 -0700 URL: http://hg.ope

hg: jdk7/tl/jaxws: 4 new changesets

Changeset: bc45ccc5bcca Author:cl Date: 2010-08-13 11:38 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/bc45ccc5bcca Added tag jdk7-b105 for changeset 39eb4f3031f4 ! .hgtags Changeset: 017612ea6af4 Author:cl Date: 2010-08-19 15:13 -0700 URL: http://hg.openj

hg: jdk7/tl/jaxp: 4 new changesets

Changeset: 5ba8469212a6 Author:cl Date: 2010-08-13 11:38 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/5ba8469212a6 Added tag jdk7-b105 for changeset 3233b9a4c12e ! .hgtags Changeset: 20ee37c1372a Author:cl Date: 2010-08-19 15:13 -0700 URL: http://hg.openjd

hg: jdk7/tl/hotspot: 65 new changesets

Changeset: 3dc64719cf18 Author:cl Date: 2010-08-13 11:38 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/3dc64719cf18 Added tag jdk7-b105 for changeset 6709c14587c2 ! .hgtags Changeset: a81afd9c293c Author:alanb Date: 2010-07-16 13:14 +0100 URL: http://hg.

hg: jdk7/tl/corba: 3 new changesets

Changeset: 232adb83eae8 Author:cl Date: 2010-08-19 15:12 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/232adb83eae8 Added tag jdk7-b106 for changeset 519daea4 ! .hgtags Changeset: 8d810527b499 Author:cl Date: 2010-08-26 16:16 -0700 URL: http://hg.openj

hg: jdk7/tl: 4 new changesets

Changeset: 43096cccf1ce Author:cl Date: 2010-08-13 11:38 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/43096cccf1ce Added tag jdk7-b105 for changeset 9f96a4269d77 ! .hgtags Changeset: 7d396ad455c3 Author:cl Date: 2010-08-19 15:12 -0700 URL: http://hg.openjdk.jav

hg: jdk7/tl/jdk: 6981001: (launcher) EnsureJREInstallation is not being called in order

Changeset: b790c1ecee19 Author:ksrini Date: 2010-09-03 07:59 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b790c1ecee19 6981001: (launcher) EnsureJREInstallation is not being called in order Reviewed-by: darcy ! src/windows/bin/java_md.c + test/tools/launcher/MiscTests.java

Re: Code review request for 4881419 The type of X[].clone() should be X[]

Am 03.09.2010 12:31, schrieb Ulf Zibis: I think the question of variable types belongs to the spec, but here in Object class's javadoc we should speak about objects. So I now suggest: "...and that the returned object of the {...@code clone} method of an array object of class {...@code T[]} is

Re: Code review request for 4881419 The type of X[].clone() should be X[]

Am 03.09.2010 08:22, schrieb Martin Buchholz: On Thu, Sep 2, 2010 at 17:50, Joe Darcy mailto:[email protected]>> wrote: Martin Buchholz wrote: The usage T[] suggests that T is a reference type, as with generics, which is not the case here. More precisely, bot

hg: jdk7/tl/langtools: 6956462: AssertionError exception thrown in the Compiler Tree API in JDK 7.

Changeset: d54300fb3554 Author:sundar Date: 2010-09-03 12:36 +0530 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/d54300fb3554 6956462: AssertionError exception thrown in the Compiler Tree API in JDK 7. Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java