Re: Review request for 7034570 - java.lang.Runtime.exec(String[] cmd, String[] env) can not work properly if SystemRoot not inherited

2011-04-14 Thread David Holmes
Hi Michael, Michael McMahon said the following on 04/15/11 00:06: An updated webrev is available for this fix. I'll probably go ahead with the CCC request for the spec. change anyway. http://cr.openjdk.java.net/~michaelm/7034570/webrev.2/ Based on Alan's comments I checked for and found webre

Re: advice & review requested for 6896297, race condition in rmid causing JCK failure

2011-04-14 Thread Stuart Marks
Hi Peter, Thanks for your comments on this issue. I understand from Alan that you have some expertise in RMI; it's most welcome here. It's good to hear that serialization compatibility isn't that big of a deal. This makes things easier. It would seem reasonable to investigate replacing HashM

Re: Suspected regression: fix for 6735255 causes delay in GC of ZipFile InputStreams, increase in heap demand

2011-04-14 Thread Xueming Shen
Steve, Neil, As we discussed in previous emails that Neil's last patch (to put the inflater into the "streams" as the value of the map) does solve the FinalizeInflater failure issue (provides a "orderly" final cleanup between the "stream" and the "inflater". However to leave releaseInfalter()

Re: Review request for 7034570 - java.lang.Runtime.exec(String[] cmd, String[] env) can not work properly if SystemRoot not inherited

2011-04-14 Thread Ulf Zibis
If you like, you can save 1 more line: return sb.append('\u').toString(); ;-) -Ulf Am 14.04.2011 22:55, schrieb Ulf Zibis: sb.append('\u'); return sb.toString();

Re: Review request for 7034570 - java.lang.Runtime.exec(String[] cmd, String[] env) can not work properly if SystemRoot not inherited

2011-04-14 Thread Ulf Zibis
You can have the code much shorter (and faster): // Only for use by ProcessImpl.start() String toEnvironmentBlock() { // Sort Unicode-case-insensitively by name Map.Entry[] list = entrySet().toArray(new Map.Entry<>[size()]); Arrays.sort(list, entryComparator);

Re: Review request for 7034570 - java.lang.Runtime.exec(String[] cmd, String[] env) can not work properly if SystemRoot not inherited

2011-04-14 Thread Ulf Zibis
Oops, SystemRoot could be null theoretically. So forget my comment about NUL termination. But anyway, should we allow to have get("SystemRoot") != getEnv("SystemRoot")? Is it correct to defaultly set the "SystemRoot" variable on non-Windows OS? Why don't we inherit ProcessEnvironment from Tree

Re: Request for review: 6597112: Referential integrity loophole during remote object export

2011-04-14 Thread Neil Richards
Hi Alan, Thanks for making those modifications. I'm happy with how they look. I'm also happy with the suggested comment being added. I'm away from a computer until the weekend, so can't make the modification myself at the moment, but I'm happy if you want to proceed in getting it in. Thanks again

Re: Review request for 7034570 - java.lang.Runtime.exec(String[] cmd, String[] env) can not work properly if SystemRoot not inherited

2011-04-14 Thread Ulf Zibis
You need not to ensure double NUL termination, because now sb.length() is always > 0. -Ulf Am 14.04.2011 16:06, schrieb Michael McMahon: An updated webrev is available for this fix. I'll probably go ahead with the CCC request for the spec. change anyway. http://cr.openjdk.java.net/~michaelm/

Re: Review request for 7034570 - java.lang.Runtime.exec(String[] cmd, String[] env) can not work properly if SystemRoot not inherited

2011-04-14 Thread Alan Bateman
Michael McMahon wrote: An updated webrev is available for this fix. I'll probably go ahead with the CCC request for the spec. change anyway. http://cr.openjdk.java.net/~michaelm/7034570/webrev.2/ The updated webrev looks much better. A couple of minor suggestions - it might be useful to future

Re: Review request for 7034570 - java.lang.Runtime.exec(String[] cmd, String[] env) can not work properly if SystemRoot not inherited

2011-04-14 Thread Michael McMahon
An updated webrev is available for this fix. I'll probably go ahead with the CCC request for the spec. change anyway. http://cr.openjdk.java.net/~michaelm/7034570/webrev.2/ Thanks, Michael.

Re: proposal to optimise the performance of the Jar utility

2011-04-14 Thread mike . skells
Hi Mike & Sherman, My mistake - not sure where I got that from Regards Mike Sent from my BlackBerry® wireless device -Original Message- From: Mike Duigou Date: Wed, 13 Apr 2011 17:02:10 To: Xueming Shen Cc: ; core-libs-dev Libs Subject: Re: proposal to optimise the performance of the Ja

Re: proposal to optimise the performance of the Jar utility

2011-04-14 Thread mike . skells
Hi Sherman, I agree that the update case is different, but always thought that your new zip file system would be a better way to do this rather than unpacking and repacking a jar, which is what happens not isnt it? Forgive me if I am wrong but I never looked at the code in detail for update I