Re: Request for review: Rework cause-chaining in Exceptions was:JDK 8 code review request for 6380161 (reflect) Exception from newInstance() not chained to cause.

2011-08-16 Thread Alan Bateman
Sebastian Sickelmann wrote: Hi, some time ago, i wrote[5] with Joe and David about advancing some exception-types to the 4 standard ctors. The first Exception i have looked at was InternalError and now(after some struggeling with gnumake and hg) my patches for reviewing are ready. I

Re: [Fwd: Code review request: 7072353 JNDI libraries do not build with javac -Xlint:all -Werror]

2011-08-16 Thread Dr Andrew John Hughes
On 17:11 Tue 02 Aug , Alan Bateman wrote: Xuelei Fan wrote: : 1. I noticed the copyright date of a few files are unchanged, please update them before you push the changes. This has come up a few times but I don't think it is strictly required. Kelly or one of the release

Second try... Readable Collections Interfaces.

2011-08-16 Thread Carson Gross
(This bounced or got hung up the first time I sent it.) Hi Guys, I work on Gosu, a JDK-based language, and I was talking w/ Charles Nutter and Ola Bini today (ed: now last week) at OSCON, and a general idea that I've been kicking around for a long time came up. They both didn't think it was

Re: Request for review: Rework cause-chaining in Exceptions was:JDK 8 code review request for 6380161 (reflect) Exception from newInstance() not chained to cause.

2011-08-16 Thread Sebastian Sickelmann
Am 16.08.2011 13:35, schrieb Alan Bateman: Sebastian Sickelmann wrote: Hi, some time ago, i wrote[5] with Joe and David about advancing some exception-types to the 4 standard ctors. The first Exception i have looked at was InternalError and now(after some struggeling with gnumake and hg)

Re: Request for review: Rework cause-chaining in Exceptions was:JDK 8 code review request for 6380161 (reflect) Exception from newInstance() not chained to cause.

2011-08-16 Thread Alan Bateman
Sebastian Sickelmann wrote: It would be great to have a webrev for them. I rebased my patches on dd218ad64d5c of http://hg.openjdk.java.net/jdk8/tl/jdk/ The patches are here: https://bugs.openjdk.java.net/attachment.cgi?id=236 (diff view:

Re: Request for review: Rework cause-chaining in Exceptions was:JDK 8 code review request for 6380161 (reflect) Exception from newInstance() not chained to cause.

2011-08-16 Thread joe . darcy
Hello. On 8/14/2011 11:17 PM, Sebastian Sickelmann wrote: Hi, some time ago, i wrote[5] with Joe and David about advancing some exception-types to the 4 standard ctors. The first Exception i have looked at was InternalError and now(after some struggeling with gnumake and hg) my patches for