It turns out there's a problem with these changes as it didn't remove
the code to load the rmi library (we missed it in the code review too).
The result is that most of the RMI tests are now failing. I've just
created 7104577 for this. The diffs are trivial - can I get a reviewer
and we'll
Changeset: 72666cd49ac3
Author:alanb
Date: 2011-10-25 09:27 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/72666cd49ac3
7104577: Changes for 7104209 cause many RMI tests to fail
Reviewed-by: chegar
! src/share/classes/sun/rmi/server/MarshalInputStream.java
D'oh! Sorry my fault.
The changes look good, and thanks for taking care of this.
-Chris.
On 10/25/11 09:08 AM, Alan Bateman wrote:
It turns out there's a problem with these changes as it didn't remove
the code to load the rmi library (we missed it in the code review too).
The result is that
I'm getting a build error due to -Werror and the fact that Util.java
uses a raw type: new Class[] { ...} and so generates a raw type warning
David
Hmmm... there was an issue in javac where it was not reporting raw type
warnings for anonymous inner classes. Maurizio fixed this recently
(javac will now report these warnings), but I did a clean build with
Maurizio's patch and all went well. I can also still do a clean build (
but I build
On 10/25/2011 12:23 PM, David Holmes wrote:
I'm getting a build error due to -Werror and the fact that Util.java
uses a raw type: new Class[] { ...} and so generates a raw type warning
Until recently, javac has forgotten to warn about that kind of rawtype
(array of rawtype).
new Class?[] {
On 25/10/2011 8:48 PM, Chris Hegarty wrote:
Hmmm... there was an issue in javac where it was not reporting raw type
warnings for anonymous inner classes. Maurizio fixed this recently
(javac will now report these warnings), but I did a clean build with
Maurizio's patch and all went well. I can
On 25/10/2011 9:22 PM, Rémi Forax wrote:
On 10/25/2011 12:23 PM, David Holmes wrote:
I'm getting a build error due to -Werror and the fact that Util.java
uses a raw type: new Class[] { ...} and so generates a raw type warning
Until recently, javac has forgotten to warn about that kind of
On 25/10/11 12:22, Rémi Forax wrote:
On 10/25/2011 12:23 PM, David Holmes wrote:
I'm getting a build error due to -Werror and the fact that Util.java
uses a raw type: new Class[] { ...} and so generates a raw type
warning
Until recently, javac has forgotten to warn about that kind of rawtype
On 10/25/11 12:26 PM, David Holmes wrote:
On 25/10/2011 8:48 PM, Chris Hegarty wrote:
Hmmm... there was an issue in javac where it was not reporting raw type
warnings for anonymous inner classes. Maurizio fixed this recently
(javac will now report these warnings), but I did a clean build with
On 25/10/2011 9:39 PM, Chris Hegarty wrote:
On 10/25/11 12:26 PM, David Holmes wrote:
I suspect this is another case of a partial build causing files to be
compiled with different settings. I'll try another clean build.
Yeap, kinda but officially the other way around ;-) A full build for me
On 10/25/11 12:26 PM, David Holmes wrote:
On 25/10/2011 8:48 PM, Chris Hegarty wrote:
Hmmm... there was an issue in javac where it was not reporting raw type
warnings for anonymous inner classes. Maurizio fixed this recently
(javac will now report these warnings), but I did a clean build with
On 10/25/11 12:51 PM, David Holmes wrote:
On 25/10/2011 9:39 PM, Chris Hegarty wrote:
On 10/25/11 12:26 PM, David Holmes wrote:
I suspect this is another case of a partial build causing files to be
compiled with different settings. I'll try another clean build.
Yeap, kinda but officially
To close the loop on this one. I filed CR
7104650: rawtype warnings in java.nio.charset.Charset and sun.nio.ch.Util
And posted a request for review:
http://mail.openjdk.java.net/pipermail/core-libs-dev/2011-October/007995.html
-Chris.
On 10/25/11 12:56 PM, Chris Hegarty wrote:
On 10/25/11
On 25/10/2011 12:56, Chris Hegarty wrote:
Sasha, Kurchi, and others, are making their way through the core
libraries area fixing all the javac warnings. They are enabling
-Werror once they complete a specific area to ensure warnings don't
creep back in. I guess because some of these classes
The changes to remove warnings from the NIO code (7068616) missed
java/nio/charset/Charset.java and sun/nio/ch/Util.java. This was not
spotted at the time as the compiler was not generating raw type warnings
for anonymous inner classes. It does now, see CR 7090499.
This is not an issue when
Approved
Maurizio
On 25/10/11 13:36, Chris Hegarty wrote:
The changes to remove warnings from the NIO code (7068616) missed
java/nio/charset/Charset.java and sun/nio/ch/Util.java. This was not
spotted at the time as the compiler was not generating raw type
warnings for anonymous inner
On 25/10/2011 13:36, Chris Hegarty wrote:
The changes to remove warnings from the NIO code (7068616) missed
java/nio/charset/Charset.java and sun/nio/ch/Util.java. This was not
spotted at the time as the compiler was not generating raw type
warnings for anonymous inner classes. It does now,
Alan,
I found the same problem in the net and security makefiles, incremental
build fails because of raw type warnings.
I can file another CR or amend the category and description of this one,
to be more generic.
The changes are similarity trivial:
hg diff
Changeset: b73a9be0b993
Author:mcimadamore
Date: 2011-10-25 15:40 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b73a9be0b993
7104618: MessageInfo.java is failing after lexer changes
Summary: Two langtools regression tests cannot be built due to a bad import
statement
On 25/10/2011 15:32, Chris Hegarty wrote:
Alan,
I found the same problem in the net and security makefiles,
incremental build fails because of raw type warnings.
I can file another CR or amend the category and description of this
one, to be more generic.
Might as well fix these with the
All looks fine to me.
-Ulf
Am 25.10.2011 16:32, schrieb Chris Hegarty:
Alan,
I found the same problem in the net and security makefiles, incremental build fails because of raw
type warnings.
I can file another CR or amend the category and description of this one, to be
more generic.
The
Hi,
I do not agree to the evaluation on
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6963115 because:
Same as the x.split(x) case, this is a match found situation,
the resulting empty string is now a trailing empty string,
Yes, but don't forget the leading empty string.
In my
Looks good from me as well. Seems like a strange location to have the load
library!
Mike
On Oct 25 2011, at 01:08 , Alan Bateman wrote:
It turns out there's a problem with these changes as it didn't remove the
code to load the rmi library (we missed it in the code review too). The
Changeset: d830d28fc72e
Author:jjg
Date: 2011-10-25 10:48 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d830d28fc72e
7104039: refactor/cleanup javac Paths class
Reviewed-by: mcimadamore
! src/share/classes/com/sun/tools/apt/main/Main.java
!
I'll belatedly add my thumbs up.
Thanks Chris!
David
On 26/10/2011 12:55 AM, Ulf Zibis wrote:
All looks fine to me.
-Ulf
Am 25.10.2011 16:32, schrieb Chris Hegarty:
Alan,
I found the same problem in the net and security makefiles,
incremental build fails because of raw type warnings.
I
Changeset: a1eaf78ababb
Author:jjh
Date: 2011-10-25 19:18 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a1eaf78ababb
7104905: Java SE build fails on call to CreateSymbols
Reviewed-by: jjg
! src/share/classes/com/sun/tools/javac/file/Locations.java
27 matches
Mail list logo
