On 27/06/2012 4:57 PM, Eric Wang wrote:
Hi David Stuart,
Thank you for the help! please review the in webrev 6948101.zip in
attachment.
Thanks Eric. That fix also seems fine to me.
David
Regards,
Eric
On 2012/6/27 9:14, Stuart Marks wrote:
Hi Eric,
Alan Bateman asked me to help you
Hi Kurchi,
Thanks for updating this. This looks good to me. I guess Stuart will be
sponsoring the patch.
For his sins he's kindly offered to do so yes :-)
There are a couple of other switch statements in
src/share/classes/java/util/regex/Pattern.java.
which are not throwing fallthrough
Hi David,
Thank you for review!
Hi Stuart,
Can you please help to review and post the webrev, Thanks a lot!
Eric
On 2012/6/27 15:32, David Holmes wrote:
On 27/06/2012 4:57 PM, Eric Wang wrote:
Hi David Stuart,
Thank you for the help! please review the in webrev 6948101.zip in
attachment.
Hi all,
We've been working on improving the workflow for our patch review
system and so the new locations for the patches are at:
https://raw.github.com/AdoptOpenJDK/PatchReview/master/5-submitted/javac_warnings/core_java_text.patch
Hi Sean,
I think this looks good. ship it :-)
Best
Lance
On Jun 25, 2012, at 4:26 PM, Sean Coffey wrote:
Hi,
I'm looking for a code review around the following corba changes. It turns
out that we've a few bug fixes in corba area for jdk6 that were never forward
ported to jdk7 or 8. The
I welcome this issue is getting some serious attention then. When will this be
backported to 7u?
-- David
On 24.06.2012, at 18:58, Xueming Shen wrote:
Yes, I believe the issue described in MACOSX_PORT-165 is the
same issue this patch is trying to solve.
Btw, it appears there are typos
Hi Mike,
Yes, all that you say below is true. CharSequence is an interface that does
not define the contract of identity when implementations/subtypes of
CharSequence do - each in it's own way. Much like java.util.Collection and
List vs. Set. It's always dangerous for methods that return such
Changeset: 612e56cf284c
Author:coffeys
Date: 2012-06-27 21:10 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/612e56cf284c
6893617: JDK 6 CNCtx always uses the default ORB
Reviewed-by: lancea
! src/share/classes/com/sun/jndi/cosnaming/CNCtx.java
Changeset: 47adb42076f1
Author:coffeys
Date: 2012-06-27 21:09 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/47adb42076f1
7162902: Umbrella port of a number of corba bug fixes from JDK 6 to jdk7u/8
Reviewed-by: lancea
!
I've posted the webrev here:
http://cr.openjdk.java.net/~smarks/yiming.wang/7123972/webrev.0/
I've looked at the changes and they seem fine.
It's interesting that the run times take 30-60 sec in your experience. I've run
them on my system (Linux in a virtual machine) and they usually run in
Eric,
Ignore my comment about adding the timeouts. As Alan reminded me if the
test would hang then jtreg will time it out after two minutes anyway.
So this is good to go as far as I am concerned.
Thanks,
David
On 27/06/2012 7:51 AM, David Holmes wrote:
Thanks Eric.
So to summarize:
- we
On 27/06/2012 04:33, Xueming Shen wrote:
Alan,
Webrev has been updated accordingly at
http://cr.openjdk.java.net/~sherman/7130915/webrev
with changes
(1) added a CFStringCreateMutable(...) != null check in both io and
nio native, though it is
unlikely to fail here because we are
Hi,
On Jun 26, 2012, at 11:59 PM, Joe Wang wrote:
Hi Paul,
That method was contributed by engineers from Korea and intended to handle
paths that contained international characters, so that was how it was named.
It was an extra processing added. Outside of that scenario, we'd want to
Hi David,
Thank you! I run the test several times on 3 platforms (windows, solaris
and linux), the average execution time is 30secs to 60secs. if the test
hang 2 minutes, there should be something wrong.
Hi Marks,
I don't have the author role, Can you please help to review and post the
Hi David Stuart,
Thank you for the help! please review the in webrev 6948101.zip in
attachment.
Regards,
Eric
On 2012/6/27 9:14, Stuart Marks wrote:
Hi Eric,
Alan Bateman asked me to help you out with this since he's going to be
unavailable for a couple weeks.
I didn't see you on the
Thanks Alan!
The webrev has been updated to throw OOME as your other nio native
dispatcher does.
http://cr.openjdk.java.net/~sherman/7130915/webrev.
I can wait for your back from the vacation:-)
-Sherman
On 6/26/12 11:41 PM, Alan Bateman wrote:
On 27/06/2012 04:33, Xueming Shen wrote:
Changeset: e80ac58b5ba9
Author:katleman
Date: 2012-06-21 17:07 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/e80ac58b5ba9
Added tag jdk8-b44 for changeset f6a417540ef1
! .hgtags
Changeset: ad3ba4b392cc
Author:katleman
Date: 2012-06-21 17:07 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/ad3ba4b392cc
Added tag jdk8-b44 for changeset 439d9bf8e4ff
! .hgtags
Changeset: 5222b7d658d4
Author:coffeys
Date: 2012-03-26 14:01 +0100
URL:
Changeset: a39c99192184
Author:katleman
Date: 2012-06-21 17:08 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a39c99192184
Added tag jdk8-b44 for changeset 59cbead12ff4
! .hgtags
Changeset: e111e4587cca
Author:lana
Date: 2012-06-25 21:39 -0700
URL:
Changeset: 8fb4cd2f05a1
Author:mbykov
Date: 2012-06-19 14:24 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/rev/8fb4cd2f05a1
7178241: Basic script for JDK source code legal headers conformance verification
Summary: A new script lic_check.sh to check license headers in JDK source
Changeset: 6e2633440960
Author:amurillo
Date: 2012-06-01 15:30 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6e2633440960
7173438: new hotspot build - hs24-b14
Reviewed-by: jcoomes
! make/hotspot_version
Changeset: fab99b17c1de
Author:mikael
Date: 2012-06-01
Changeset: 9d88f2ce6338
Author:katleman
Date: 2012-06-21 17:08 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9d88f2ce6338
Added tag jdk8-b44 for changeset db471a7af031
! .hgtags
Changeset: eb50eeb2eb7d
Author:prr
Date: 2012-06-13 12:46 -0700
URL:
22 matches
Mail list logo
