Re: javax.sql.rowset.serial.SerialBlob doesn't support free and getBinaryStream

2012-10-29 Thread Deven You
Hi Alan, The Java Spec does not mention the thread safe for JDBC API. But I see the other code in SerialBlob/SerialClob have not consider it. I think use buff == null to replace isFree is a good idea because it also avoid the problem for the condition buf == null isFree == false so we

hg: jdk8/tl/jdk: 8001621: Update awk scripts that check output from jps/jcmd

2012-10-29 Thread staffan . larsen
Changeset: d1ffbdf7e3c6 Author:sla Date: 2012-10-29 09:23 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d1ffbdf7e3c6 8001621: Update awk scripts that check output from jps/jcmd Reviewed-by: alanb ! test/sun/tools/jcmd/jcmd_Output1.awk ! test/sun/tools/jps/jps-l_Output1.awk

Re: javax.sql.rowset.serial.SerialBlob doesn't support free and getBinaryStream

2012-10-29 Thread Lance Andersen - Oracle
Hi Deven, I will address the needed updates a bit later. Thank you for your input Best Lance On Oct 29, 2012, at 3:51 AM, Deven You wrote: Hi Alan, The Java Spec does not mention the thread safe for JDBC API. But I see the other code in SerialBlob/SerialClob have not consider it. I

hg: jdk8/tl/corba: 8000970: break out auxiliary classes that will prevent multi-core compilation of the JDK.

2012-10-29 Thread fredrik . ohrstrom
Changeset: 643e7612cf6d Author:ohrstrom Date: 2012-10-29 14:10 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/643e7612cf6d 8000970: break out auxiliary classes that will prevent multi-core compilation of the JDK. Reviewed-by: alanb, wetmore !

hg: jdk8/tl/jdk: 8000970: break out auxiliary classes that will prevent multi-core compilation of the JDK

2012-10-29 Thread fredrik . ohrstrom
Changeset: 17384fc6b31f Author:ohrstrom Date: 2012-10-29 14:12 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/17384fc6b31f 8000970: break out auxiliary classes that will prevent multi-core compilation of the JDK Reviewed-by: alanb, wetmore +

hg: jdk8/tl/jdk: 8000997: Multiple locale sensitive services cannot be loaded

2012-10-29 Thread naoto . sato
Changeset: 7fa45c455034 Author:naoto Date: 2012-10-29 10:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7fa45c455034 8000997: Multiple locale sensitive services cannot be loaded Reviewed-by: okutsu !

Re: Review/comment needed for the new public java.util.Base64 class

2012-10-29 Thread Ulf Zibis
Hi Sherman, can you give me a short answer please? -Ulf Am 23.10.2012 16:57, schrieb Ulf Zibis: Am 23.10.2012 15:04, schrieb Alan Bateman: I'm not sure that getUrlEncoder is the most suitable name to get a base64url encoder. The reason is that the method name makes it sound like it returns a

RFR: 6594697 - varargs message and Throwable methods for java.util.Logger

2012-10-29 Thread Jim Gish
Please review http://cr.openjdk.java.net/~jgish/Bug6594697-AddLogThrowable/ http://cr.openjdk.java.net/%7Ejgish/Bug6594697-AddLogThrowable/ This change adds three new methods to Logger that provide a Throwable along with a varags Object list as parameters to the log message. In addition, it

Re: RFR: 7184195 - java.util.logging.Logger.getGlobal().info() doesn't log without configuration

2012-10-29 Thread Mandy Chung
Jim, The logging deadlock issue is subtle and complex. Do we have a test case that verifies your fix that is deadlock-free? I can't tell for sure but looks like it smells the potential deadlock if Logger.getGlobal() triggers the LogManager class initialization but LogManager.clinit calls

Re: RFR: 7184195 - java.util.logging.Logger.getGlobal().info() doesn't log without configuration

2012-10-29 Thread Jim Gish
Hi Mandy, I don't understand your second sentence. Could you please clarify? Thanks, Jim On 10/29/2012 06:05 PM, Mandy Chung wrote: Jim, The logging deadlock issue is subtle and complex. Do we have a test case that verifies your fix that is deadlock-free? I can't tell for sure but

hg: jdk8/tl/jdk: 6206780: (str) Forwarding append methods in String{Buffer, Builder} are inconsistent

2012-10-29 Thread mike . duigou
Changeset: e2f976a73afb Author:jgish Date: 2012-10-29 16:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e2f976a73afb 6206780: (str) Forwarding append methods in String{Buffer,Builder} are inconsistent Summary: update StringBuilder StringBuffer to consistently handle

Re: RFR: 7184195 - java.util.logging.Logger.getGlobal().info() doesn't log without configuration

2012-10-29 Thread Mandy Chung
What I mean is when multiple threads are using j.u.logging and one calls Logger.getGlobal() but the LogManager class initialization is calling Logger.getGlobal(), what will happen? similar to what the LoggingDeadlock.java test does [1]. This is the code in LogManager I'm referring to.

Re: Review/comment needed for the new public java.util.Base64 class

2012-10-29 Thread Xueming Shen
Ulf, my apology. Some how I missed your email. We tried various prototypes for this simple utility class. See http://cr.openjdk.java.net/~sherman/base64/ The v4 might be close to the static constant approach you suggested. While It's hard to draw a clear line on which one is better, we