Hello,
This is the suggested fix described in sun bug 7201156 page. Please take a
look.
sunbug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7201156
webrev: http://cr.openjdk.java.net/~zhouyx/7201156/webrev.00/
--
Best Regards,
Sean Chou
On 07/11/2012 08:31, Sean Chou wrote:
Hello,
This is the suggested fix described in sun bug 7201156 page. Please take a
look.
sunbug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7201156
webrev: http://cr.openjdk.java.net/~zhouyx/7201156/webrev.00/
Looks like this was missed during
The change looks fine to me.
I wonder if it is worth creating an automatic regression test to verify
this change ( so an future regression in behavior gets caught early ).
You could call sun.tools.jar.Main directly passing suitable streams to
check the output.
-Chris.
On 07/11/2012 08:31,
On 11/07/2012 03:10 AM, David Holmes wrote:
Hi Peter,
The movement of the reflection caches to a helper object is exactly
what I had previously proposed here (some differences in the details
of course):
http://cr.openjdk.java.net/~dholmes/JEP-149/webrev/
and discussed here:
Changeset: 59e88d3b9b17
Author:jzavgren
Date: 2012-11-07 10:49 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/59e88d3b9b17
8001579: Cleanup warnings in security native code
Reviewed-by: chegar, alanb, vinnie
! src/share/native/sun/security/jgss/wrapper/GSSLibStub.c
!
I've just synced with jdk7u-dev and now it does not build.
symbol: class TimedWindowEvent
location: class SunToolkit
../../../src/share/classes/sun/awt/SunToolkit.java:472: error: cannot
find symbol
TimedWindowEvent twe = (TimedWindowEvent)nested;
I would like to start review discussion of the spec changes to
ForkJoinXXX ( add a default common pool, task tags, and other minor
updates ), and the addition of CountedCompleter, as part of part of JEP
155 [1].
These changes are of course coming form Doug and the JSR 166 EG members.
I have
On 4 nov 2012, at 16:13, Alan Bateman alan.bate...@oracle.com wrote:
On 04/11/2012 12:50, Staffan Larsen wrote:
:
I realize the focus is blocking I/O for now but one thing to know is that
timed read operations on socket adapters (the socket obtained by calling
SocketChannel's socket
Are you suggesting to run a local DNS server? If so then it is easy to access
that
via a JNDI context.
If you're proposing developing a basic JNDI service provider then that would be
more effort.
On 7 Nov 2012, at 01:05, Weijun Wang wrote:
Hi Vinnie
I want to write a regression test so
An update on performance. I have written microbenchmarks for file and socket
i/o and compared the results before my suggested changes and after.
FileChannelRead -4.06%
FileChannelWrite -1.06%
FileInputStream0.92%
FileOutputStream 1.32%
RandomAccessFileRead 1.66%
On 11/07/12 07:06, Chris Hegarty wrote:
I would like to start review discussion of the spec changes to ForkJoinXXX ( add
a default common pool, task tags, and other minor updates ), and the addition of
CountedCompleter, as part of part of JEP 155 [1].
Please hang on a while longer. The common
Staffan,
When you say you removed all implementation from fileBeginRead, do you mean
you just return null instead of doing the ENABLED check? Does making
ENABLED private yield zero-cost? May give JIT more confidence that this
field isn't modified via reflection from outside.
The other option is
On 7 nov 2012, at 14:53, Vitaly Davidovich vita...@gmail.com wrote:
Staffan,
When you say you removed all implementation from fileBeginRead, do you mean
you just return null instead of doing the ENABLED check?
Yes.
Does making ENABLED private yield zero-cost? May give JIT more
On 07/11/2012 13:51, Doug Lea wrote:
On 11/07/12 07:06, Chris Hegarty wrote:
I would like to start review discussion of the spec changes to
ForkJoinXXX ( add
a default common pool, task tags, and other minor updates ), and the
addition of
CountedCompleter, as part of part of JEP 155 [1].
OK, just after I sent the email I realized public/private won't really give
JIT more confidence.
I'd try the two different impls approach though. It does introduce more
types to load but if that's not an issue, I think perf should be good. At
least worth trying for curiosity's sake. :)
Sent
On 11/07/2012 07:55 AM, Staffan Larsen wrote:
An update on performance. I have written microbenchmarks for file and
socket i/o and compared the results before my suggested changes and
after.
FileChannelRead -4.06% FileChannelWrite -1.06%
FileInputStream0.92%
On 07/11/2012 12:55, Staffan Larsen wrote:
:
Negative values means that my changes added a regression. I think most of these
values are within the margin of error in the measurements. The one exception is
FileChannelRead. I've rerun this many times and it looks fairly consistent
around a 4%
On 11/6/12 10:08 PM, David Holmes wrote:
webrev:
http://cr.openjdk.java.net/~dholmes/8002040/webrev/
Thumbs up.
make/common/Defs-linux.gmk
No comments.
This is a simplified variant of the change just made to Hotspot.
Instead of disabling FDS when cross-compiling we change the default
Hi Vinnie
As you know, krb5 can read KDC info from DNS and I want to write a
regression test on it. However, the test must be independent and it
should not access any server not inside the test suite.
Java uses those 2 lines to read the KDC info. Surely it would work if I
write my own DNS
Change looks fine.
-Sherman
On 11/7/2012 12:31 AM, Sean Chou wrote:
Hello,
This is the suggested fix described in sun bug 7201156 page. Please take a
look.
sunbug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7201156
webrev: http://cr.openjdk.java.net/~zhouyx/7201156/webrev.00/
Changeset: 9e013ce42dd7
Author:dfuchs
Date: 2012-11-07 13:24 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9e013ce42dd7
6720349: (ch) Channels tests depending on hosts inside Sun
Summary: This changeset make the nio tests start small TCP or UDP servers from
within the
We've also seen deadlocks in accessing annotations in the wild.
So, many thanks for working on this (both performance improvements and
deadlock removal).
We don't have a test case to contribute, but here's a stacktrace:
sun.reflect.annotation.AnnotationType.getInstance(AnnotationType.java:80)
On 11/07/2012 06:59 PM, Martin Buchholz wrote:
We've also seen deadlocks in accessing annotations in the wild.
So, many thanks for working on this (both performance improvements and
deadlock removal).
We don't have a test case to contribute, but here's a stacktrace:
That's one thread. What
On Wed, Nov 7, 2012 at 11:02 AM, Peter Levart peter.lev...@gmail.comwrote:
On 11/07/2012 06:59 PM, Martin Buchholz wrote:
We've also seen deadlocks in accessing annotations in the wild.
So, many thanks for working on this (both performance improvements and
deadlock removal).
We don't have
On 11/07/2012 09:02 AM, Vitaly Davidovich wrote:
I'd try the two different impls approach though. It does introduce more
types to load but if that's not an issue, I think perf should be good. At
least worth trying for curiosity's sake. :)
I wonder if this intersects with the dynamic tracing
IcedTea bug: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1197
com.sun.naming.internal.ResourceManager.getApplicationResources() does not
close the input streams it gets from helper.getResources() and
helper.getJavaHomeLibStream(). This patch:
Is there a reason the patch was not created originally leveraging
try-with-resoruces as it seems like the perfect candidate from the webrev?
I can create a bug for it, but I think I would prefer to see the patch take
advantage of try-with-resoruces
Best
Lance
On Nov 7, 2012, at 3:30 PM, Andrew
Hi all,
I have redone the static memory footprint comparison calculations
(taking correct object headers and padding into account) and I hope this
time I've done it right. Here's what I got:
64bit addressing (16 byte object header):
patched Class uses 76 bytes less than original Class when
The bug number is 8003120
Best
Lance
On Nov 7, 2012, at 3:30 PM, Andrew Hughes wrote:
IcedTea bug: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1197
com.sun.naming.internal.ResourceManager.getApplicationResources() does not
close the input streams it gets from
- Original Message -
Is there a reason the patch was not created originally leveraging
try-with-resources as it seems like the perfect candidate from the
webrev?
I can create a bug for it, but I think I would prefer to see the
patch take advantage of try-with-resoruces
As you can
Changeset: f51943263267
Author:andrew
Date: 2012-11-07 16:07 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f51943263267
8003120: ResourceManager.getApplicationResources() does not close InputStreams
Summary: Add finally blocks to close the InputStream instances
Reviewed-by:
- Original Message -
The bug number is 8003120
Thanks. Pushed to tl: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f51943263267
Best
Lance
On Nov 7, 2012, at 3:30 PM, Andrew Hughes wrote:
IcedTea bug:
http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1197
2012/11/2 11:36 -0700, staffan.lar...@oracle.com:
Webrev: http://cr.openjdk.java.net/~sla/iotrace/webrev.00/
Who (or what) is the intended consumer of the sun.misc.IoTrace and
IoTraceListener APIs? In other words, are these meant to be stable
external interfaces that we're going to support for
Changeset: cc325832469c
Author:naoto
Date: 2012-11-07 15:08 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cc325832469c
8001205: Calendar.getDisplayName(...): Returns null when provider is SPI but
there is no SPI implementation
8001562: Collator.getAvailableLocales()
I think, it would be more intuitive, to calculate the SIZE from the BYTES, e.g.
SIZE = BYTES * 8.
Ulf
Am 08.11.2012 00:08, schrieb Mike Duigou:
Hello all;
A long time ago [1] this patch was put forward for review. Though the request
was approved the patch was never committed because some of
Changeset: 19d6ba779759
Author:vromero
Date: 2012-11-05 16:26 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/19d6ba779759
8000484: Bad error recovery when 'catch' without 'try' is found
Reviewed-by: jjg, mcimadamore
!
Changeset: a516debe2cee
Author:amurillo
Date: 2012-10-26 14:18 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a516debe2cee
8001663: new hotspot build - hs25-b08
Reviewed-by: jcoomes
! make/hotspot_version
Changeset: 5ec0c42da025
Author:coleenp
Date: 2012-10-25
Changeset: 2986e7052952
Author:jjg
Date: 2012-11-07 17:01 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2986e7052952
8002157: Write combo compiler tests for repeating annotations for JDK8
Reviewed-by: darcy, jjg
Contributed-by: sonali.g...@oracle.com
+
Changeset: 599f231cba97
Author:jfranck
Date: 2012-11-07 17:39 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/599f231cba97
8001598: Augment ElementType enum for JSR 308
Reviewed-by: darcy
! src/share/classes/java/lang/annotation/ElementType.java
Changeset: cdf02b372956
Author:sherman
Date: 2012-11-07 20:50 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cdf02b372956
6282196: There should be Math.mod(number, modulo) methods
Summary: added the requested methods
Reviewed-by: darcy, emcmanus, alanb
Contributed-by:
On 07/11/2012 20:51, Andrew Hughes wrote:
:
As you can see on the IcedTea bug, I've asked the same question.
I'd have preferred it to use try-with-resources myself (easier to
follow for one thing), but given the patch is as it is, I'm now
wary about changing it and negating the existing testing
41 matches
Mail list logo
