On 12/22/2012 06:54 AM, Joe Darcy wrote:
Hello Eric,
A few initial comments.
I'm not convinced a getNumParameters method pulls its weight. At the
very least, the specification should be updated to say whether or not
it includes synthetic + natural parameters or just natural ones.
Hi Henry,
Plain and simple.
I just noticed a few spellings:
line 670, 696, 863: Thus is it - Thus it is - this one has
already been written wrong in the original source, so it just multiplied
by copy-paste
line 688, 743, 854: Log a in-time - Log an in-time
Regards, Peter
On 12/22/2012
On 12/22/2012 12:13 PM, Peter Levart wrote:
Hi Henry,
Plain and simple.
yes,
I just noticed a few spellings:
line 670, 696, 863: Thus is it - Thus it is - this one has
already been written wrong in the original source, so it just
multiplied by copy-paste
line 688, 743, 854: Log a
The msg argument in most cases is a string literal because it is either a
resource bundle key or a MessageFormat literal. The established best practice
is to convert on the fly construction of messages to use the MessageFormat syle
logging. This current patch is kind of anti-pattern of that
At end...
On 12/18/2012 07:50 PM, Remi Forax wrote:
On 12/18/2012 10:18 AM, Peter Levart wrote:
On 12/17/2012 11:39 PM, Remi Forax wrote:
On 12/17/2012 11:14 PM, Peter Levart wrote:
On 12/17/2012 10:26 PM, Mandy Chung wrote:
On 12/17/12 7:36 AM, Peter Levart wrote:
Hi David and others,
On 12/21/2012 5:52 PM, Kevin Rushforth wrote:
David DeHaven wrote:
This explains what caused the confusion - I didn't expect that java -jar fxapp.jar will be passed
to fxlauncher with the same launch mode as java -cp fxapp.jar SomeFXAppClass (i.e. LM_CLASS). I
think the semantics there
Rémi wrote:
getNumParameters (I prefer the name getParameterCount() BTW)
I prefer getParameterCount() too.
When something has nb, num, nbr or number in its name,
people might get wrong about whether it refers to a count
(n sheeps) or to an identifier (sheep number n).
If count or id-likes
Hi Martin, thanks a lot for this.
I've renamed LINKFLAG to the more appropriate (and common) ARCHFLAG. It
seems to pop up all around our source but if build-dev know of a better
(or canonical) way of doing it I'll take it!
The BUILD_JEXEC differences don't show up in my webrev or hg diff,
