Hi Vlad,
On 22/02/2013 8:02 AM, Vladimir Danushevsky wrote:
Please review changes for
https://jbs.oracle.com/bugs/browse/JDK-8005545 "Add System property to
identify ARCH specific details such as ARM hard-float binaries" which
adds an optional sun.os.abi Java system property indicating an ABI t
Changeset: ffb4d2e95140
Author:erikj
Date: 2013-02-15 10:40 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/rev/ffb4d2e95140
8005879: Add -DMAC_OS_X_VERSION_MAX_ALLOWED=1070 to builds on Mac
Reviewed-by: ohair
! common/autoconf/generated-configure.sh
! common/autoconf/spec.gmk.in
! c
Hi Brent,
I am not an expert here, and I am hoping someone from I18N
also reviews this.
A nit
- " LC_ALL" + LC_ALL + "\n" +
+ " LC_ALL=" + LC_ALL + "\n" +
If Mac is the only system affected by this, should we make the checks for
LC* and LANG specific to Macs since other platforms don't have th
Do you want that I prepare this FloatingDecimal/FormattedFloatingDecimal patch ?
-Dima
On Fri, Feb 22, 2013 at 2:32 AM, Brian Burkhalter
wrote:
> I am withdrawing this patch for the time being as properly the changes should
> also go into the fork sun.misc.FormattedFloatingDecimal. I'll post
On 02/21/2013 10:46 AM, Alan Bateman wrote:
Joe Darcy recently added @jdk.Supported [1] to make it possible to
identify JDK-specific APIs.
I'd like to add this to a number of APIs in the com.sun namespace to
make it obvious these are "supported". Specifically I'm proposing to
add it to:
Hello,
Please review the simple fix below for
6556996: (ann spec) SuppressWarnings strings should be documented
http://bugs.sun.com/view_bug.do?bug_id=6556996
the webrev is at
http://cr.openjdk.java.net/~darcy/6556996.0/
and the patch is below. In brief, the only required string t
On 2/21/2013 10:46 AM, Alan Bateman wrote:
Joe Darcy recently added @jdk.Supported [1] to make it possible to
identify JDK-specific APIs.
I'd like to add this to a number of APIs in the com.sun namespace to
make it obvious these are "supported".
It's nice to be able to mark what is suppor
Hi,
This test started failing after 8003228 [1] was putback (setting
sun.jnu.encoding to UTF-8 on Mac). It tests if java is able to launch a
.jar stored in a directory named with two-byte characters.
The code comments in the test case state that (on Unix) it expects
LC_ALL to be set (to ja_
Changeset: 1da987f0311a
Author:rfield
Date: 2013-02-21 15:46 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1da987f0311a
8008356: Test LambdaSerialization.java failing
Summary: run in /othervm mode
Reviewed-by: ksrini
! test/java/lang/invoke/lambda/LambdaSerialization.java
Changeset: dabb36173c63
Author:ksrini
Date: 2013-02-21 12:23 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/dabb36173c63
8008658: Four new method param jtreg tests fail in nightly tests
Reviewed-by: jjg, ksrini, mcimadamore
Contributed-by: eric.mccor...@oracle.com
! sr
Changeset: cd7340a84bb8
Author:rfield
Date: 2013-02-21 14:43 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/cd7340a84bb8
8008405: Now that metafactory is in place, add javac lambda serialization tests
Summary: Tests part of original langtools serialization review.
Revie
I am withdrawing this patch for the time being as properly the changes should
also go into the fork sun.misc.FormattedFloatingDecimal. I'll post an updated
patch once it is available.
Thanks,
Brian
On Feb 14, 2013, at 5:23 PM, Brian Burkhalter wrote:
> The patch below is as submitted to OpenJ
Looks good to me other than the variable name.
I'd prefer JDK_ARCH_ABI_NAME or JDK_ARCH_ABI_PROP_NAME over ARCHABIPROPNAME.
Bob.
On Feb 21, 2013, at 5:02 PM, Vladimir Danushevsky wrote:
> Please review changes for https://jbs.oracle.com/bugs/browse/JDK-8005545
> "Add System property to iden
My initial testing with another micro-benchmarking framework (other than
Caliper) shows a performance increase of >900X for doubleValue() and >1500X for
floatValue() on a MacBookPro5,3.
There is some more evaluation yet to be done but we should be able to move this
patch along pretty soon.
Bri
On 2/21/2013 12:01 PM, Alan Bateman wrote:
A minor note - the list of known jar files seems to be incomplete
(e.g. tzdb.jar and some windows-specific ones). I think it may be
better to file a bug to follow up this and maybe even better to
replace the hardcoded list with other mechanism (if
On 21/02/2013 19:45, Mandy Chung wrote:
Alan,
This fix looks good and the "## fast path ..." comment can be taken
out as Chris pointed out.
Yes, I put that comment in there as a reminder and should have removed
it - thanks (and Chris).
A minor note - the list of known jar files seems to be
Alan,
This fix looks good and the "## fast path ..." comment can be taken out
as Chris pointed out.
A minor note - the list of known jar files seems to be incomplete (e.g.
tzdb.jar and some windows-specific ones). I think it may be better to
file a bug to follow up this and maybe even bette
Well, that was quite a few files to have to go through :-)
Looks fine
On Feb 21, 2013, at 1:46 PM, Alan Bateman wrote:
>
> Joe Darcy recently added @jdk.Supported [1] to make it possible to identify
> JDK-specific APIs.
>
> I'd like to add this to a number of APIs in the com.sun namespace to
At:
http://cr.openjdk.java.net/~briangoetz/jdk-8008670/webrev/
there is a webrev of a subset of the implementation of java.util.stream,
for review. These are all new files. None of these are public classes;
they are internal interfaces for the Stream library, as well as some
implementation
Joe Darcy recently added @jdk.Supported [1] to make it possible to
identify JDK-specific APIs.
I'd like to add this to a number of APIs in the com.sun namespace to
make it obvious these are "supported". Specifically I'm proposing to
add it to:
- Java Debug Interface (com.sun.jdi)
- Attach
On 21/02/2013 16:42, Iris Clark wrote:
Hi, Alan.
Very nice.
Just curious. How are you testing startup? Custom micro benchmark or are you
using something else?
A calendar :-)
I'm using a performance test suite from the Oracle performance team.
It's called refworkload and includes startup an
Hi, Alan.
Very nice.
Just curious. How are you testing startup? Custom micro benchmark or are you
using something else?
iris
-Original Message-
From: Alan Bateman
Sent: Thursday, February 21, 2013 6:33 AM
To: core-libs-dev
Subject: 8008290: (profiles) Startup regression due to addit
On 21/02/2013 16:11, Lance Andersen - Oracle wrote:
Alan,
the changes look good and glad you added the extra comments for clarity.
+1
Trivially, I think you can remove the comment:
* ## Add a fast path like Class-Path to avoid reading the manifest
when the attribute
*is not present
Alan,
the changes look good and glad you added the extra comments for clarity.
Best
Lance
On Feb 21, 2013, at 9:33 AM, Alan Bateman wrote:
>
> This one is a startup-time regression caused by the compact profiles work.
>
> As background, there was a lot of work done in the distant past on start
Changeset: d686d8a7eb78
Author:mcimadamore
Date: 2013-02-21 15:19 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d686d8a7eb78
8008227: Mixing lambdas with anonymous classes leads to NPE thrown by compiler
Summary: Disentangle cyclic dependency between static-ness of syn
This one is a startup-time regression caused by the compact profiles work.
As background, there was a lot of work done in the distant past on
startup performance. Amongst the startup improvements was to the code
that checks for the Class-Path attribute when opening JAR files so that
it skips
26 matches
Mail list logo
