On 02/22/2013 02:46 AM, Joe Darcy wrote:
Hello,
Please review the simple fix below for
6556996: (ann spec) SuppressWarnings strings should be documented
http://bugs.sun.com/view_bug.do?bug_id=6556996
the webrev is at
http://cr.openjdk.java.net/~darcy/6556996.0/
and the patch is
On 02/21/2013 08:17 PM, Brian Goetz wrote:
At
http://cr.openjdk.java.net/~briangoetz/jdk-8008670/webrev/
I've posted a webrev for about half the classes in java.util.stream.
None of these are public classes, so there are no public API issues
here, but plenty of internal API issues, naming
On 22/02/2013 22:03, Martin Buchholz wrote:
Hi Alan, Xueming, build-ers,
I'd like you to do a code review.
I've finally figured out why fastdebug jdk occasionally gives
InternalError in the zip code.
Exception in thread main java.lang.InternalError
at java.util.zip.Inflater.init(Native
On 22/02/2013 21:33, Vladimir Danushevsky wrote:
Thanks, webrev updated
http://cr.openjdk.java.net/~vladidan/8005545/webrev.01/
http://cr.openjdk.java.net/%7Evladidan/8005545/webrev.01/
This looks good to me too.
-Alan
I am actually encountering this in openjdk7 with the old build system.
I can repro the problem in openjdk8 with the old build system, but not the
new one.
I don't know if you consider this a bug with the new build system - it's
supposed to generate the same bits, after all???!!
I'm not sure why
Hi Nils,
If the counters are updated frequently from multiple threads, there
might be contention/scalability issues. Instead of synchronization on
updates, you might consider using atomic updates provided by
sun.misc.Unsafe, like for example:
Index:
On 23/02/2013 19:39, Peter Levart wrote:
Hi Nils,
If the counters are updated frequently from multiple threads, there
might be contention/scalability issues. Instead of synchronization on
updates, you might consider using atomic updates provided by
sun.misc.Unsafe, like for example:
Most
On 23/02/2013 18:06, Martin Buchholz wrote:
I am actually encountering this in openjdk7 with the old build system.
I can repro the problem in openjdk8 with the old build system, but not
the new one.
I don't know if you consider this a bug with the new build system -
it's supposed to generate
On 2/23/2013 1:25 AM, Remi Forax wrote:
On 02/22/2013 02:46 AM, Joe Darcy wrote:
Hello,
Please review the simple fix below for
6556996: (ann spec) SuppressWarnings strings should be documented
http://bugs.sun.com/view_bug.do?bug_id=6556996
the webrev is at
On 2/22/2013 3:04 PM, mark.reinh...@oracle.com wrote:
I understand (deeply!) the problem that @Supported is trying to solve.
Martin has raised a number of good questions about it already. Here are
some additional concerns I'd like to see addressed before we use it any
further in our source
Changeset: 6f9b3e216b01
Author:darcy
Date: 2013-02-23 13:32 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6f9b3e216b01
6556996: (ann spec) SuppressWarnings strings should be documented
Reviewed-by: mduigou, chegar, abuckley
! src/share/classes/java/lang/Deprecated.java
!
On 24/02/2013 6:08 AM, Alan Bateman wrote:
On 23/02/2013 19:39, Peter Levart wrote:
Hi Nils,
If the counters are updated frequently from multiple threads, there
might be contention/scalability issues. Instead of synchronization on
updates, you might consider using atomic updates provided by
Peter,
In your use of Unsafe you pass null as the object. I'm pretty certain
you can't pass null here. Unsafe operates on fields or array elements.
David
On 24/02/2013 5:39 AM, Peter Levart wrote:
Hi Nils,
If the counters are updated frequently from multiple threads, there
might be
13 matches
Mail list logo
