Sorry this slipped through the cracks.
Looks good to me. (Don't know if you already pushed it :) )
David
On 25/04/2013 5:16 PM, Joe Darcy wrote:
Hello,
Responding to David's comment and some comments from Alan off-list, here
is a variant which doesn't use suppressed exceptions in initCause,
Looks good. As a very small clarification, I might throw in a comma after
created.
On Mon, Apr 29, 2013 at 9:30 PM, Mike Duigou mike.dui...@oracle.com wrote:
Hello all;
This change originated as part of JDK-8006627 (which was also previously
split into JDK-8007398 as well). It adds an
On 29/04/2013 11:45 PM, Aleksej Efimov wrote:
Alan,
The XPathException class doesn't have any fields only methods (it had a
'cause' method, but it was deleted in suggested fix).
It had a cause field that was deleted not a method, hence the change to
the serialized form that Alan is
On 30/04/2013 05:30, Mike Duigou wrote:
Hello all;
This change originated as part of JDK-8006627 (which was also previously split
into JDK-8007398 as well). It adds an internal mechanism for performance
sensitive usages to create a string from a provided character array without
copying that
On 29/04/2013 23:05, Kumar Srinivasan wrote:
Hi,
Please review this fix which will enable profiles and embedded distros to
eliminate the unpack200 binaries saving space, all this does is switch
to the java implementation if the native one cannot be found.
Hi Kumar,
On 30/04/2013 8:05 AM, Kumar Srinivasan wrote:
Hi,
Please review this fix which will enable profiles and embedded distros to
eliminate the unpack200 binaries saving space, all this does is switch
to the java implementation if the native one cannot be found.
On 30/04/2013 5:48 PM, Alan Bateman wrote:
On 29/04/2013 23:05, Kumar Srinivasan wrote:
Hi,
Please review this fix which will enable profiles and embedded distros to
eliminate the unpack200 binaries saving space, all this does is switch
to the java implementation if the native one cannot be
On 04/30/2013 08:33 AM, Alan Bateman wrote:
On 30/04/2013 05:30, Mike Duigou wrote:
Hello all;
This change originated as part of JDK-8006627 (which was also
previously split into JDK-8007398 as well). It adds an internal
mechanism for performance sensitive usages to create a string from a
On Apr 29, 2013, at 9:41 PM, Henry Jen henry@oracle.com wrote:
On 04/27/2013 08:01 AM, Alan Bateman wrote:
On 27/04/2013 00:08, Henry Jen wrote:
Hi,
Please review webrev at
http://cr.openjdk.java.net/~henryjen/ccc/8012645.0/webrev
The API doc in specdiff format is at
Changeset: fff665e54df0
Author:sla
Date: 2013-04-30 10:48 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fff665e54df0
8003671: [findbugs] sun.management.AgentConfigurationError.getParams() may
expose internal representation by returning AgentConfigurationError.params
Changeset: 0547a1c76259
Author:attila
Date: 2013-04-23 12:52 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/0547a1c76259
8011065: Problems when script implements an interface with variadic methods
Reviewed-by: jlaskey, hannesw, sundar
!
On 15/04/2013 15:09, Daniel Fuchs wrote:
Hi,
This a fix for:
JDK-8008738 - Issue in
com.sun.org.apache.xml.internal.serializer.Encodings causes some JCK
tests to fail intermittently.
http://cr.openjdk.java.net/~dfuchs/JDK-8008738/webrev.02/
I skimmed over the webrev and it looks
Hello everybody!
Would you please review my proposal to change constructor of
CopyOnWriteArraySet?
http://cr.openjdk.java.net/~dmeetry/8005953/webrev.0/
http://cr.openjdk.java.net/%7Edmeetry/8005953/webrev.0/
Currently, the body of the constructor is like this:
al = new
Hi Ivan,
On 30/04/2013 9:41 PM, Ivan Gerasimov wrote:
Hello everybody!
Would you please review my proposal to change constructor of
CopyOnWriteArraySet?
Has this been run past Doug Lea and JSR-166 (ex)EG yet? All
java.util.concurrent updates have to be coordinated through Doug.
David
On 30.04.2013 15:45, David Holmes wrote:
Hi Ivan,
On 30/04/2013 9:41 PM, Ivan Gerasimov wrote:
Hello everybody!
Would you please review my proposal to change constructor of
CopyOnWriteArraySet?
Has this been run past Doug Lea and JSR-166 (ex)EG yet? All
java.util.concurrent updates have
Ivan,
The addAllAbsent() function has O(c.length^2) complexity, so
construction time quickly grows with the input size.
However, if we knew that c is a Set, we could construct the COWAS in
linear time.
You have to be able to prove that the given Set uses the same equivalence
relation as the
Hi Mike,
The changes look good to me.
Best
Lance
On Apr 29, 2013, at 10:11 PM, Mike Duigou wrote:
Hello All;
This is a review for three changes to the J2SE Netbeans project. If necessary
I can break this up into three separate patches but I would rather not if
possible.
On 30/04/2013 14:31, Carlos Lucasius wrote:
Webrev for my part of the fix to the code:
http://cr.openjdk.java.net/~clucasius/8009389/webrev00/
Thanks,
-Carlos
Looks okay except that it would be good to maintain the ordering, ie:
after t2k.
-Alan
Changeset: 49d6596100db
Author:msheppar
Date: 2013-04-29 23:07 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/49d6596100db
8007373: Inet6Address serialization incompatibility
Reviewed-by: alanb, chegar
! src/share/classes/java/net/Inet6Address.java
+
On 30/04/2013 06:05, Mandy Chung wrote:
test/sun/reflect/CallerSensitive/MethodFinder.java is a useful utility
class that jdeps or other tool can take advantage of. This fix moves
MethodFinder.java to com.sun.tools.classfile and generalize it to find
field, method, and interface method
Hi all,
the webrev at http://cr.openjdk.java.net/~tschatzl/7038914/webrev/
presents a first stab at the CR 7038914: VM could throw uncaught OOME
in ReferenceHandler thread.
The problem is that under very heavy memory pressure, there is the
reference handler throws an exception with the message
On 4/30/2013 7:50 AM, Alan Bateman wrote:
On 30/04/2013 06:05, Mandy Chung wrote:
test/sun/reflect/CallerSensitive/MethodFinder.java is a useful
utility class that jdeps or other tool can take advantage of. This
fix moves MethodFinder.java to com.sun.tools.classfile and generalize
it to find
Ok this also combines the build file changes.
http://cr.openjdk.java.net/~ksrini/8009389/webrev.2/
Thanks
Kumar
Hi David,
Good point, I have made the changes, here is the updated webrev:
http://cr.openjdk.java.net/~ksrini/8009389/webrev.1/
delta webrev to last change:
On 30/04/2013 16:17, Kumar Srinivasan wrote:
Ok this also combines the build file changes.
http://cr.openjdk.java.net/~ksrini/8009389/webrev.2/
Thanks
Kumar
Looks good to me.
-Alan.
Me too.
Bob.
On Apr 30, 2013, at 11:27 AM, Alan Bateman wrote:
On 30/04/2013 16:17, Kumar Srinivasan wrote:
Ok this also combines the build file changes.
http://cr.openjdk.java.net/~ksrini/8009389/webrev.2/
Thanks
Kumar
Looks good to me.
-Alan.
On 30/04/2013 15:57, Thomas Schatzl wrote:
Hi all,
the webrev at http://cr.openjdk.java.net/~tschatzl/7038914/webrev/
presents a first stab at the CR 7038914: VM could throw uncaught OOME
in ReferenceHandler thread.
The problem is that under very heavy memory pressure, there is the
Hi all,
This is a second request for review to add back
Remote Diagnostic Commands.
This work adds a new platform MBean providing
remote access to the diagnostic command framework
via JMX (already accessible locally with the jcmd
tool).
There's two CR number because this work is made of two
On Apr 30, 2013, at 5:43 PM, Henry Jen henry@oracle.com wrote:
So if possible we should report ORDERED and state the association, if any,
of encounter order with the order declared in the central directory, which i
hope is, and seems to be, the same. (Plus update the docs of entries()
Please review this fix which by fine-tuning of just one method gives up
to 40% performance
improvement on packing and repacking of jar files.
Also removed unneeded local variable initialization from Code class -
not for performance gain,
just to make world a better place.
Please review http://cr.openjdk.java.net/~jgish/TestRB.2/
http://cr.openjdk.java.net/%7Ejgish/TestRB.2/
This fixes a regression caused by the removal of the search of the call
stack for resource bundles by java.util.logging. We have added a
single-level search up the stack, i.e. just the
Hi,
It appears we dropped the ball on u+200c and u+200d when we updated
the simple word boundaries back to jdk7 [1]. You can find most of the
related discussion here [2]. These 2 code points are listed as one of the
issues we were trying to fix but obviously the final doc and implementation
The order of entries in a zip file can be and is used by applications.
Notably, many people spend a lot of time optimizing the order of entries in
a zip file for performance reasons. But it's also likely some people
depend on the order for correctness. Whether or not your streams are
ORDERED,
Hi Alex,
Great job identifying this hot method. I realize the code is
complicated but optimized
for speed.
Couple of nits:
I don't think you need the parens
j = (nextsemi nextangl ? nextsemi : nextangl);
Coding conventions nits:
missing spaces for operators.
for (int i = firstl+1, j; i
Changeset: ac3e189c9099
Author:lancea
Date: 2013-04-30 14:44 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ac3e189c9099
8010416: Add a way for java.sql.Driver to be notified when it is deregistered
Reviewed-by: alanb, ulfzibis
! src/share/classes/java/sql/Driver.java
+
Finally some follow up on this!
On Feb 13 2013, at 23:43 , Martin Buchholz wrote:
I like the optimizations in this change, especially the avoidance of copies.
Was there some good reason the jdk never before used JavaLangAccess to avoid
String creation copies?
Not that I am aware of. I did
Point taken.
It seems to me we should at least keep the ORDERED characterristic for the
returned stream, but not necessarily need to specify what order it is, which
would be inline with entries().
Does that make sense?
I'll add back the ORDERED flag but keep the javadoc not mention ordering.
Changeset: 0e6f412f5536
Author:mduigou
Date: 2013-04-30 12:31 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0e6f412f5536
8011814: Add testng.jar to Netbeans projects test compile classpath
8013271: Add MacOS sources to J2SE Netbeans project
8013272: JDK Netbeans projects
On Apr 30, 2013, at 9:02 PM, Henry Jen henry@oracle.com wrote:
Point taken.
It seems to me we should at least keep the ORDERED characterristic for the
returned stream, but not necessarily need to specify what order it is, which
would be inline with entries().
Does that make sense?
Hi Sherman,
Looks okay in general. A couple of comments:
Have you considered providing a method to map from group name to its
group index? Would that be useful?
group(String) can simply return group(getMatchedGroupIndex(name)) rather
than duplicating the implementation. Similarly for
In practice, the order of entries in the central directory is always the
same as the order of actual entries, although in theory they might be
different. I think it would be useful to say that the entries are returned
in the order that they are stored in the zip file, and leave the central
Changeset: eda99449ab26
Author:alanb
Date: 2013-04-30 21:19 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/eda99449ab26
8013647: JPRT unable to clean-up after tests that leave file trees with loops
Reviewed-by: chegar, tbell
!
On 04/30/2013 12:43 PM, Mandy Chung wrote:
Hi Sherman,
Looks okay in general. A couple of comments:
Have you considered providing a method to map from group name to its group
index? Would that be useful?
No plan for now. It appears a bit of redundant after we have the
On 30/04/2013 17:48, Jim Gish wrote:
Please review http://cr.openjdk.java.net/~jgish/TestRB.2/
http://cr.openjdk.java.net/%7Ejgish/TestRB.2/
This fixes a regression caused by the removal of the search of the
call stack for resource bundles by java.util.logging. We have added a
single-level
That's what it was, but as Alan pointed out, it is potential misleading to
people who knows detail about zip file.
I think the ordering is an implementation detail, and based on zip file spec, I
would assume it's the order as in central directory.
I didn't dig down to the native code to
Changeset: 1432a6247ac9
Author:ksrini
Date: 2013-04-30 13:12 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1432a6247ac9
8009389: Unpack200 native library should be removed from profiles
Reviewed-by: alanb, bobv, jrose
! makefiles/profile-includes.txt
!
On 4/30/13 1:22 PM, Xueming Shen wrote:
updated webrev:
http://cr.openjdk.java.net/~sherman/8013252/webrev/
Looks good.
(again, the RegExTest.java is mixed with the change for
#8013254)
Are you going to separate the change in the right changeset? I can't
find the webrev for 8013254 from
On 04/30/2013 01:32 PM, Henry Jen wrote:
That's what it was, but as Alan pointed out, it is potential misleading to
people who knows detail about zip file.
I think the ordering is an implementation detail, and based on zip file spec, I
would assume it's the order as in central directory.
I
On 04/30/2013 01:58 PM, Mandy Chung wrote:
On 4/30/13 1:22 PM, Xueming Shen wrote:
updated webrev:
http://cr.openjdk.java.net/~sherman/8013252/webrev/
Looks good.
(again, the RegExTest.java is mixed with the change for
#8013254)
Are you going to separate the change in the right changeset?
My apology, the webrev is at
http://cr.openjdk.java.net/~sherman/8013254/webrev/
-Sherman
On 04/30/2013 10:01 AM, Xueming Shen wrote:
Hi,
It appears we dropped the ball on u+200c and u+200d when we updated
the simple word boundaries back to jdk7 [1]. You can find most of the
related
On 04/30/2013 04:29 PM, Alan Bateman wrote:
On 30/04/2013 17:48, Jim Gish wrote:
Please review http://cr.openjdk.java.net/~jgish/TestRB.2/
http://cr.openjdk.java.net/%7Ejgish/TestRB.2/
This fixes a regression caused by the removal of the search of the
call stack for resource bundles by
On Apr 30, 2013, at 11:32 AM, Kumar Srinivasan kumar.x.sriniva...@oracle.com
wrote:
Couple of nits:
I don't think you need the parens
j = (nextsemi nextangl ? nextsemi : nextangl);
I recommend (and many style guides recommend) adding extra parens in when the
operator precedence is
Changeset: 4a82d2b86c75
Author:mchung
Date: 2013-04-30 15:42 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4a82d2b86c75
8013531: Provide a utility class in com.sun.tools.classfile to find
field/method references
Reviewed-by: alanb
!
Changeset: 57648bad3287
Author:mchung
Date: 2013-04-30 15:43 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/57648bad3287
8013531: Provide a utility class in com.sun.tools.classfile to find
field/method references
Reviewed-by: alanb
!
Hello all;
Another changeset coming from the lambda libraries effort. This one is two
small additions to the Objects class. The introduced methods are not really
intended to be used directly, comparison operators work better in imperative
logic, but the methods will be very useful as
On 4/30/13 2:02 PM, Xueming Shen wrote:
I'm planning to push them in one changeset, if both get approved.
http://cr.openjdk.java.net/~sherman/8013254/webrev/
These 2 bugs are not dependent on each other as I understand. Is there
a reason why you want to push them in one single changeset
Hello all;
Since this code will be introduced without any usages I decided it was critical
to make a stand alone unit test. I've updated the webrev:
http://cr.openjdk.java.net/~mduigou/JDK-8013528/1/webrev/
The webrev mistakes my hg copy for a rename... Ignore that. Capturing the
provenance
Here's an update:
http://cr.openjdk.java.net/~jgish/TestRB.3/
http://cr.openjdk.java.net/%7Ejgish/TestRB.3/
Thanks,
Jim
On 04/30/2013 05:10 PM, Jim Gish wrote:
On 04/30/2013 04:29 PM, Alan Bateman wrote:
On 30/04/2013 17:48, Jim Gish wrote:
Please review
On 4/30/2013 3:45 PM, Mike Duigou wrote:
Hello all;
Another changeset coming from the lambda libraries effort. This one is two
small additions to the Objects class. The introduced methods are not really
intended to be used directly, comparison operators work better in imperative
logic, but
I will make both suggested changes.
Thank you.
Mike
On Apr 30 2013, at 20:34 , Mandy Chung wrote:
On 4/30/2013 3:45 PM, Mike Duigou wrote:
Hello all;
Another changeset coming from the lambda libraries effort. This one is two
small additions to the Objects class. The introduced methods
On 04/29/2013 02:29 AM, Paul Sandoz wrote:
On Apr 27, 2013, at 10:15 AM, Alan Bateman alan.bate...@oracle.com wrote:
On 26/04/2013 22:59, Henry Jen wrote:
Hi,
Please review webrev at
http://cr.openjdk.java.net/~henryjen/ccc/8003258.1/webrev/
It adds a method to BufferedReader.
Changeset: d080f5168deb
Author:katleman
Date: 2013-04-25 09:24 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d080f5168deb
Added tag jdk8-b87 for changeset d4c266784660
! .hgtags
Changeset: c60f69931e1a
Author:amurillo
Date: 2013-04-11 21:54 -0700
URL:
61 matches
Mail list logo
