On 18/08/2013 05:07, Paul Benedict wrote:
I think the generated method needs to be listed in the class javadoc at
least. I presume it throws an exception too (like the other valueOf) if the
String can't be resolved to a constant, but no user is going to discover
this fact through the
On 19/08/2013 01:44, Dan Xu wrote:
HiAll,
Please review the simple change for JDK-8023203 - Wrap
RandomAccessFile.seek native method into a Java helper method. Itadds
a helper java method and makes it the only place that can invoke the
native method directly. Thanks!
Webrev:
Hi Joel,
The fix looks OK.
Not suggesting you do the following, unless you really want to, but the test is
an example of where TestNG data providers are useful, since all cases will be
tested and reported for pass or failure, rather than in this case the first
failure will cause other checks
On 19/08/2013 09:35, Alan Bateman wrote:
On 19/08/2013 01:44, Dan Xu wrote:
HiAll,
Please review the simple change for JDK-8023203 - Wrap
RandomAccessFile.seek native method into a Java helper method. Itadds
a helper java method and makes it the only place that can invoke the
native method
Changeset: 8e098a29ecd8
Author:egahlin
Date: 2013-08-16 17:02 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8e098a29ecd8
6417702: Graph in Memory tab is not redrawn immediately if changed via 'Chart'
combo box
Reviewed-by: alanb, jbachorik, sjiang
!
I just refreshed my clone of code-tools/jtreg to pick up a few changes,
including a number of fixes to the TestNG support.
With the updated jtreg then test/java/util/Comparator/TypeTest.java fails:
[TestNG] Running:
java/util/Comparator/TypeTest.java
test public static void
Hi Peter,
Looks good to me too.
cheers
/Joel
On 2013-08-17, Alan Bateman wrote:
On 17/08/2013 14:06, Peter Levart wrote:
Hi,
Please review the fix for a test that tries to provoke a deadlock when
parsing annotations:
Changeset: 9e9f5713b26d
Author:psandoz
Date: 2013-08-06 14:26 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9e9f5713b26d
8022318: Document Spliterator characteristics and binding policy of java util
concurrent collection impls
Reviewed-by: chegar
Contributed-by: Martin
Looks good, i will commit the same to the lambda repo.
Did you build jtreg yourself or did you download it?
Paul.
On Aug 19, 2013, at 11:14 AM, Alan Bateman alan.bate...@oracle.com wrote:
I just refreshed my clone of code-tools/jtreg to pick up a few changes,
including a number of fixes
Changeset: 00dcfaa6bc01
Author:aefimov
Date: 2013-08-16 18:40 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/rev/00dcfaa6bc01
8021820: Number of opened files used in select() is limited to 1024 [macosx]
Reviewed-by: alanb, chegar, tbell, smarks
!
Changeset: 11ccaabdb2a8
Author:aefimov
Date: 2013-08-16 18:41 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/11ccaabdb2a8
8021820: Number of opened files used in select() is limited to 1024 [macosx]
Reviewed-by: alanb, chegar, tbell, smarks
+
Changeset: f580728b08b4
Author:alanb
Date: 2013-08-19 11:04 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f580728b08b4
8023215: test/java/util/Comparator/TypeTest.java not running (failing but
reported as passing)
Reviewed-by: psandoz
!
Looks good to me Paul.
Trivially, typo in Spliterator.java
'structural interface' - 'structural interference'
-Chris.
On 12/08/2013 13:12, Paul Sandoz wrote:
Hi,
I have updated this webrev to remove documenting empty/singleton collections
(that will be tackled as a separate issue):
On 16/08/2013 23:40, Ivan Gerasimov wrote:
:
Your and Alan's idea of replacing the io implementation with calls to
its nio counterpart seems to me as the best approach.
So it may be better to defer this fix until this move is done.
I think it should be okay to just change this one method to
Hi,
This patch updates Random and ThreadLocalRandom to have functional consistency
(for the most part) across Random, ThreadLocalRandom and SplittableRandom:
http://cr.openjdk.java.net/~psandoz/tl/JDK-8023155-Random-TLR-SR-sync/webrev/
Hi,
This is the patch for SplittableRandom:
http://cr.openjdk.java.net/~psandoz/tl/JDK-8020292-SplittableRandom/webrev/
The algorithm remains the same as reported by Doug on the 9th August:
http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-August/019768.html
Paul.
On Aug 19, 2013, at 12:12 PM, Chris Hegarty chris.hega...@oracle.com wrote:
Looks good to me Paul.
Trivially, typo in Spliterator.java
'structural interface' - 'structural interference'
Thanks!, i updated my patch.
Paul.
On 08/19/2013 01:07 PM, Paul Sandoz wrote:
Hi,
This patch updates Random and ThreadLocalRandom to have functional consistency
(for the most part) across Random, ThreadLocalRandom and SplittableRandom:
http://cr.openjdk.java.net/~psandoz/tl/JDK-8023155-Random-TLR-SR-sync/webrev/
On Aug 19, 2013, at 2:26 PM, Peter Levart peter.lev...@gmail.com wrote:
I have yet to define a common interface e.g. RandomGenerator that Random,
ThreadLocalRandom and SplittableRandom could implement, but it would be very
easy to do so. Any thoughts on doing this?
Hi Paul,
Yes, a
Hi Alan,
yes, this is true for rngom library - we downgraded it to the version
which has been approved to be used as a 3rd party library. Licences are
unchanged from the ones in the library; is there somebody who could
approve these are ok?
Thanks
Miran
On 08/16/2013 12:43 PM, Alan
Hi Sherman
I try out jar i after signing and it puts INDEX.LIST at the very
beginning of the file. Does this mean INDEX.LIST was actually an
exception? Or it's just a bug?
Anyway, I think I should update the fix for 8021788 and here is the webrev:
I have been working with classes that don't have javadoc attachments. The
problem was I couldn't find the method in the source nor was the method
part of the Enum class. So where did it materialize from? Now I know the
answer: the compiler generates it.
I really think this knowledge should be
Changeset: 3647aab7b1d5
Author:psandoz
Date: 2013-08-06 14:26 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3647aab7b1d5
8014824: Document Spliterator characteristics and binding policy of java util
collection impls
Reviewed-by: chegar
!
Changeset: bbc4e9d37315
Author:jlaskey
Date: 2013-08-12 18:00 -0300
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/bbc4e9d37315
8022676: Confusing error message checking instanceof non-class
Reviewed-by: jlaskey, sundar
Contributed-by: michael.horow...@oracle.com
!
Uh, this one was wrote to be a regular jtreg test running with main, not a
testNG test.
Thanks for looking into this.
Also I am wondering if this one still add any value, it was added to test the
API when we had it like
S super T ComparatorS thenComparing(Comparator? super T cmp)
Cheers,
Hi,
This is the review for the issue originally found by Dr. Heinz Kabutz
and Victor Grazi. The issue is consequently diagnosed and fixed by Doug
Lea in JSR 166 CVS.
The webrev which brings in the fix and the regression tests in JDK 8:
http://cr.openjdk.java.net/~shade/8023234/webrev.00/
On 19/08/2013 13:56, Miroslav Kos wrote:
Hi Alan,
yes, this is true for rngom library - we downgraded it to the version
which has been approved to be used as a 3rd party library. Licences
are unchanged from the ones in the library; is there somebody who
could approve these are ok?
IANAL and
Changeset: 389eaf6ed973
Author:ksrini
Date: 2013-08-19 07:47 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/389eaf6ed973
7071377: Exception when javac -processor is given a class name with invalid
postfix
Reviewed-by: jjg, vromero
!
Hi,
Please review the webrev at
http://cr.openjdk.java.net/~henryjen/tl/8023275/0/webrev/
The patch adds override on default methods for a couple wrapping classed
and delegate those to underlying class.
There is a minor revise on synchronizedCollection javadoc to cover Stream.
A sanity check
- documentation of bound should mention that it is exclusive rather than
relying on the return documentation.
- I find disallowing the zero bounds and empty ranges slightly annoying. It
requires me to externally special case for situations such as:
Random ran = new Random();
String[] users =
Changeset: bce5205dbe84
Author:ascarpino
Date: 2013-08-14 10:50 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bce5205dbe84
8022669: OAEPParameterSpec does not work if MGF1ParameterSpec is set to SHA2
algorithms
Reviewed-by: mullan
!
- @SuppressWarnings(unchecked) would appear to be in some of the cases.
- Replace:
@summary Unit tests for wrapping classes should delegate to default methods
with
@summary Ensure Collections wrapping classes provide non-default implementations
- ArrayListMethod list - ListMethod list
-
On Aug 19, 2013, at 3:17 PM, Mike Duigou mike.dui...@oracle.com wrote:
- documentation of bound should mention that it is exclusive rather than
relying on the return documentation.
Agreed.
- I find disallowing the zero bounds and empty ranges slightly annoying. It
requires me to
On Aug 19, 2013, at 4:20 PM, Mike Duigou mike.dui...@oracle.com wrote:
On Aug 19 2013, at 13:12 , Guy Steele wrote:
On Aug 19, 2013, at 3:17 PM, Mike Duigou mike.dui...@oracle.com wrote:
- I find disallowing the zero bounds and empty ranges slightly annoying. It
requires me to
On Aug 19 2013, at 13:12 , Guy Steele wrote:
On Aug 19, 2013, at 3:17 PM, Mike Duigou mike.dui...@oracle.com wrote:
- I find disallowing the zero bounds and empty ranges slightly annoying. It
requires me to externally special case for situations such as:
Random ran = new Random();
Changeset: 2fd841fccb2e
Author:dxu
Date: 2013-08-19 12:38 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2fd841fccb2e
8023203: Wrap RandomAccessFile.seek native method into a Java helper method
Reviewed-by: alanb, chegar
! make/java/java/mapfile-vers
!
Changeset: f120e2c4b4b1
Author:mullan
Date: 2013-08-19 17:17 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f120e2c4b4b1
8016850: JCK javax.security.auth.Policy tests fail when run in Profiles mode
Summary: Move default javax.security.auth.Policy implementation to compact1
On Aug 1 2013, at 08:57 , Alan Bateman wrote:
On 26/07/2013 16:31, Mike Duigou wrote:
Hello all;
This patch adds some missing checks for null that, according to interface
contract, should be throwing NPE. It also improves the existing tests to
check for these cases.
http://cr.openjdk.java.net/~dholmes/8023311/webrev/
Patch inlined below
This is a trivial cleanup following on from an earlier change under
8017570. JFR was moved from profile compact3 to the full JRE but not all
the variables in profile-includes.txt were updated as needed. jfr.jar
needed to
On 08/19/2013 01:01 PM, Mike Duigou wrote:
- @SuppressWarnings(unchecked) would appear to be in some of the cases.
Added.
- Replace:
@summary Unit tests for wrapping classes should delegate to default methods
with
@summary Ensure Collections wrapping classes provide non-default
Changeset: 096e7c665857
Author:xuelei
Date: 2013-08-19 17:42 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/096e7c665857
8020842: IDN do not throw IAE when hostname ends with a trailing dot
Reviewed-by: weijun, michaelm
! src/share/classes/java/net/IDN.java
+
Hi Joel,
I agree the code looks fine.
However, I concur with the general sentiment of Paul test advice without
advocating using testng for this task.
A loop over a Class?[] initialized with the kinds of values of
interest would seem to be better structured to me and allow for better
Changeset: 21a25911f7f7
Author:xuelei
Date: 2013-08-19 18:49 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/21a25911f7f7
8023230: The impl of KerberosClientKeyExchange maybe not exist
Reviewed-by: weijun
! src/share/classes/sun/security/ssl/KerberosClientKeyExchange.java
I noticed this method is not listed in the Javadocs for 5/6/7/8 but it's
part of every enum. Is this an oversight or is there a good reason why it's
not documented?
--
Cheers,
Paul
Paul,
Can you give more details?
On a
44 matches
Mail list logo
