Changeset: dc2f0c40399a
Author:psandoz
Date: 2013-12-05 09:44 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dc2f0c40399a
8028564: Concurrent calls to CHM.put can fail to add the key/value to the map
Reviewed-by: psandoz, chegar, alanb
Contributed-by: Doug Lea
On 12/05/2013 07:54 AM, Shi Jun Zhang wrote:
On 11/30/2013 12:05 AM, Daniel Fuchs wrote:
On 11/29/13 4:56 PM, Alan Bateman wrote:
On 29/11/2013 10:08, Daniel Fuchs wrote:
However, removing or just moving the lock around might well
introduce new
unknown issues - so it will need to be
Hi all,
please review the fix
http://cr.openjdk.java.net/~yan/8029451/webrev.01/
for
https://bugs.openjdk.java.net/browse/JDK-8029451
This patch cleanup tidy warnings for generated html documentation, and do
not affect the appearance of the documentation.
Best regards,
Serge V. Lugovoy
I've created https://bugs.openjdk.java.net/browse/JDK-8029595 to track
some clean up in this area.
regards,
Sean.
On 04/12/2013 16:44, Mandy Chung wrote:
On 12/4/2013 7:51 AM, Alan Bateman wrote:
On 04/12/2013 15:44, Seán Coffey wrote:
Recent jdk8 builds seem to be more ambitious on the GC
Pretty much looks good.
However, I notice that the equals, hashCode and toString methods of
the 4 calendar specific date classes are inherited rather than
written. Without additional spec, I'm not sure that they can claim to
be value types. Adding the 12 Javadocs should be relatively easy.
On Dec 5, 2013, at 6:30 AM, Sergey Lugovoy sergey.lugo...@oracle.com wrote:
Hi all,
please review the fix
http://cr.openjdk.java.net/~yan/8029451/webrev.01/
for
https://bugs.openjdk.java.net/browse/JDK-8029451
This patch cleanup tidy warnings for generated html documentation, and do
not
Changeset: 427c78c88229
Author:erikj
Date: 2013-12-05 09:25 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/427c78c88229
8027963: Create unlimited policy jars.
Reviewed-by: wetmore, ihse
! make/CreateSecurityJars.gmk
! make/SignJars.gmk
-
Hi all,
please review the fix
http://cr.openjdk.java.net/~yan/8028712/webrev.02/
http://cr.openjdk.java.net/%7Eyan/8028712/webrev.02/
for
https://bugs.openjdk.java.net/browse/JDK-8028712
This patch cleanup tidy warnings for generated html documentation, and do
not affect the appearance of the
Changeset: 8534e297484d
Author:yan
Date: 2013-12-05 18:04 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8534e297484d
8029264: [doclint] more doclint and tidy cleanup
Reviewed-by: alexsch, serb, malenkov
! src/share/classes/javax/swing/Action.java
!
This failure cropped up again and Roger Riggs spotted that I was looking
at it from completely the wrong direction. He contributed the following fix:
http://cr.openjdk.java.net/~robm/8029525/webrev.01/
This is to avoid a race between:
thread.interrupt();
p.destroy();
Hoping to get this
Hi Stephen,
On 12/5/2013 6:04 AM, Stephen Colebourne wrote:
Pretty much looks good.
However, I notice that the equals, hashCode and toString methods of
the 4 calendar specific date classes are inherited rather than
written. Without additional spec, I'm not sure that they can claim to
be value
Hi Rob,
Looks fine. (Not a Reviewer).
Thanks for doing the legwork, Roger
On 12/5/2013 9:19 AM, Rob McKenna wrote:
This failure cropped up again and Roger Riggs spotted that I was
looking at it from completely the wrong direction. He contributed the
following fix:
On 5 Dec 2013, at 14:40, roger riggs roger.ri...@oracle.com wrote:
Hi Rob,
Looks fine. (Not a Reviewer).
+1. Looks ok to me too.
-Chris.
Thanks for doing the legwork, Roger
On 12/5/2013 9:19 AM, Rob McKenna wrote:
This failure cropped up again and Roger Riggs spotted that I was
Hi Serge,
A fine point but in java/sql/package.html; the self closing tag br/
is not supported in HTML 3.2 (defined in the DOCTYPE)).
Simply br is sufficient.
The rest looks fine to me. (Not a Reviewer)
Roger
On 12/5/2013 12:25 PM, Serge wrote:
Hi all,
please review the fix
On 05/12/2013 14:19, Rob McKenna wrote:
This failure cropped up again and Roger Riggs spotted that I was
looking at it from completely the wrong direction. He contributed the
following fix:
http://cr.openjdk.java.net/~robm/8029525/webrev.01/
This is to avoid a race between:
On 05/12/2013 17:25, Serge wrote:
Hi all,
please review the fix
http://cr.openjdk.java.net/~yan/8028712/webrev.02/
http://cr.openjdk.java.net/%7Eyan/8028712/webrev.02/
for
https://bugs.openjdk.java.net/browse/JDK-8028712
This patch cleanup tidy warnings for generated html documentation, and
Changeset: d3c4e8fe98c3
Author:bpb
Date: 2013-12-05 07:44 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d3c4e8fe98c3
8029514: java/math/BigInteger/BigIntegerTest.java failing since thresholds
adjusted in 8022181
Summary: Ensure the value returned by getLower() is unsigned.
Changeset: 72ea199e3e1b
Author:robm
Date: 2013-12-05 16:19 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/72ea199e3e1b
8029525: java/lang/ProcessBuilder/Basic.java fails intermittently
Reviewed-by: alanb, chegar
Contributed-by: roger.ri...@oracle.com
!
Shi Jun Zhang,
This problem is like hooking up your sink drain to your sink faucet. Even if
it you can get it to work you still would not want to use it. In your code
example you could just pre-pend the thread name to the formatter string and
return it.
However, if you really, really,
Hi Serge
This looks OK.
For
--- old/src/share/classes/java/sql/package.html 2013-12-05 15:08:50.587885460
+
+++ new/src/share/classes/java/sql/package.html 2013-12-05 15:08:50.435885464
+
Please remove the following
Package Specification
•
On 5 Dec 2013, at 19:18, Martin Buchholz marti...@google.com wrote:
You guys are way too trigger-happy.
I guess the reason for this is that there was a deadline today to get changes
into tl before the b120 snapshot. This is one of the final chances to get
non-showstopper changes into JDK
I'm curious about why this was done:
*** 4452,4462
public final boolean removeAll(Collection? c) {
! Objects.requireNonNull(c);
boolean modified = false;
--- 4495,4505
public final boolean removeAll(Collection? c) {
! if (c ==
On 12/05/2013 03:18 PM, Brent Christian wrote:
I'm curious about why this was done:
*** 4452,4462
public final boolean removeAll(Collection? c) {
! Objects.requireNonNull(c);
boolean modified = false;
--- 4495,4505
public final boolean
On 05/12/2013 19:42, Chris Hegarty wrote:
On 5 Dec 2013, at 19:18, Martin Buchholzmarti...@google.com wrote:
You guys are way too trigger-happy.
I guess the reason for this is that there was a deadline today to get changes
into tl before the b120 snapshot. This is one of the final chances to
Created an issue and attached the patch so it doesn't get lost.
https://bugs.openjdk.java.net/browse/JDK-8029629
Roger
On 12/5/2013 3:12 PM, Martin Buchholz wrote:
I understand y'all luhv stability, but ... it's ONLY A TEST!
Also, there's Martin's 4th Law of Software Development:
Developers
Coming late to the party...
Overall I'll +1 this change, with the following nit:
@throws NullPointerException if the specified key or value is null and
* this map does not support null keys or values, or the
* remappingFunction is null
This should be:
@throws
26 matches
Mail list logo
