Hi Daniel!
Would it make sense to make the old constructor FileHandler(String,
*int*, int, boolean) call the new one, casting the limit to long?
Sincerely yours,
Ivan
On 07.10.2014 17:13, Daniel Fuchs wrote:
Hi,
Please find below a patch for:
8059767: FileHandler should allow 'long' limits
Looks good Mandy; cheers,
-Joe
On 10/07/2014 07:05 PM, Mandy Chung wrote:
A simple patch to take out -mx flag from the test. The test should
use the default setting instead of setting the max heap size.
Thanks
Mandy
diff --git
a/test/sun/reflect/CallerSensitive/CallerSensit
A simple patch to take out -mx flag from the test. The test should
use the default setting instead of setting the max heap size.
Thanks
Mandy
diff --git a/test/sun/reflect/CallerSensitive/CallerSensitiveFinder.java
b/test/sun/reflect/CallerSensitive/CallerSensitiveFinder.java
Hi Daniel,
The only thing I noticed is a missing @since tag on the FileHandler.
Jason
> Date: Tue, 7 Oct 2014 15:13:13 +0200
> From: [email protected]
> To: [email protected]
> Subject: RFR: 8059767: FileHandler should allow 'long' li
> Please review this 2nd version of the fix taking into account your feedback.
I'm not recognized here as a reviewer, but the code looked OK to me and
it passed my patch test suite.
> I have merged HALF_UP and HALF_DOWN cases into a single switch case.
Good to know. My current patch injects a m
Hi Olivier,
Some rewording suggestions:
445 * @param alreadyRounded Boolean indicating if rounding up
already happened.
446 * @param allDecimalDigits Boolean indicating if the digits
provide an exact
447 * representation of the value.
Including the type of the parameter is
Hi,
Please find below a patch for:
8059767: FileHandler should allow 'long' limits and handle overflow
of MeteredStream.written.
https://bugs.openjdk.java.net/browse/JDK-8059767
webrev:
http://cr.openjdk.java.net/~dfuchs/webrev_8059767/webrev.00/
This follows an issue reported on this
On 06/10/2014 07:32, Frederic Parain wrote:
Thank you very much for catching the JVM_O_DELETE issue.
I moved the O_DELETE support into the ZipFile.c file
(code was the same for all non-Windows platforms) and
cleaned up the original code in HotSpot.
The new webrevs:
http://cr.openjdk.java.net/~f
Looks fine Daniel
Best
Lance
--
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
[email protected]
Sent from my iPhone
> On Oct 7, 2014, at 7:24 AM, Daniel Fuchs wrote:
>
>> On 07/10/14 13:22, Lance A
On 07/10/14 13:22, Lance Andersen wrote:
Hi Daniel,
Couldn't you just do
x.append(' ').append('{').append(i).append('}');
and avoid the String.valueOf() or do you find the performance the same?
Hi Lance,
I refreshed the webrev to remove the String.valueOf()
best regards,
-- daniel
Bes
Looks ok to me Daniel.
-Chris.
On 7 Oct 2014, at 11:59, Daniel Fuchs wrote:
> Hi,
>
> Please find below a trivial fix for
>
> 8028788: Logger.enterring uses String concatenation in a loop
> https://bugs.openjdk.java.net/browse/JDK-8028788
>
> webrev:
> http://cr.openjdk.java.net/~dfuchs/webr
Hi,
Please find below a trivial fix for
8028788: Logger.enterring uses String concatenation in a loop
https://bugs.openjdk.java.net/browse/JDK-8028788
webrev:
http://cr.openjdk.java.net/~dfuchs/webrev_8028788/webrev.00
best regards
-- daniel
Thank you Mandy!
I've updated the webrev based on your suggestions.
The test is moved to test/sun/misc/ProxyGenerator/ directory.
Here's the updated webrev:
http://cr.openjdk.java.net/~igerasim/8059563/1/webrev/
Sincerely yours,
Ivan
On 07.10.2014 9:47, Mandy Chung wrote:
On 10/6/2014 4:35 A
Thanks Martin for the comments!
On 06.10.2014 21:22, Martin Buchholz wrote:
Thanks for tackling this difficult area!
Alan is the most qualified to review, but I'll throw in some comments.
The title of the bug in jira doesn't match the one in the webrev -
they should be the same.
Do you mea
14 matches
Mail list logo
