Re: JDK 9 RFR of JDK-8068948: Update java.base module to use new try-with-resources statement

2015-01-13 Thread Ivan Gerasimov
Hi! A useful change! Might it also make sense to allow anonymous variables in the try-with-resource statement? So that something like `try (() -> System.out.println("closed")) {}` would work... Would it make sense to also patch jdk/src/java.base/windows/classes/java/io/FileDescriptor.java in

JDK 9 RFR of JDK-8068948: Update java.base module to use new try-with-resources statement

2015-01-13 Thread joe darcy
Hello, Earlier in JDK 9, a language change was made so that if a resource for a try-with-resources statement is already final or effectively final, a new resource variable does *not* need to be declared to manage the variable. The java.base module should take advantage of this language featur

Re: HashMap collision speed (regression 7->8)

2015-01-13 Thread Bernd Eckenfels
Hello, Windows 7 x64 on Core i7 Q720 (4C/8T/6MB L3, 1,6GHz) 8GB RAM my numbers in the gist are from a notebook, but I plan to repeat my and your benachmark versions on a different machine tomorow (which has less memory pressure), I will report. I was testing single threaded, will see if this mak

Re: RFR : 8066612: Add a test that will call getDeclaredFields() on all classes and try to set them accessible.

2015-01-13 Thread Chris Hegarty
This looks fine to me too ( removal of streams usage and JRT, for 7uXX ).. -Chris. On 9 Jan 2015, at 11:07, Seán Coffey wrote: > Thanks for reviewing Daniel. I'm mark you as author. If I can get a jdk7u > Reviewer to review, I'll push this. > Will update copyright before pushing also. > > reg

Re: RFR: JDK-8042707: Source changes needed to build JDK 9 with Visual Studio 2013 (VS2013)

2015-01-13 Thread Magnus Ihse Bursie
On 2015-01-13 09:41, Erik Joelsson wrote: Hello, New webrev for root repo: http://cr.openjdk.java.net/~erikj/8042707/webrev.root.02/ Fixes look good to me. Thanks! /Magnus On 2015-01-09 15:45, Magnus Ihse Bursie wrote: It looks basically good to me. Some remarks on toolchain_windows.m4,

Re: HashMap collision speed (regression 7->8)

2015-01-13 Thread Peter Levart
On 01/13/2015 12:36 PM, Doug Lea wrote: On 01/12/2015 05:12 PM, Peter Levart wrote: Hi, I added results obtained with JDK 8 (FCS and u20) - same machine, same VM options, just different JDKs: Thanks very much. It remains a mystery why the original report by Bernd showed a 40% difference fro

Re: RFR 8068730: Increase the precision of the implementation of java.time.Clock.systemUTC()

2015-01-13 Thread David Holmes
Hi Daniel, On 13/01/2015 7:53 PM, Daniel Fuchs wrote: On 13/01/15 04:52, David Holmes wrote: Here is the new webrev with Stephen & your feedback included http://cr.openjdk.java.net/~dfuchs/webrev_8068730/webrev.01/ (windows_time_stamp not renamed yet) I checked the updated webrev.02 and ever

Re: HashMap collision speed (regression 7->8)

2015-01-13 Thread Doug Lea
On 01/12/2015 05:12 PM, Peter Levart wrote: Hi, I added results obtained with JDK 8 (FCS and u20) - same machine, same VM options, just different JDKs: Thanks very much. It remains a mystery why the original report by Bernd showed a 40% difference from jdk7. The approx 10% hit seen in these mo

Re: Explicit Serialization API and Security

2015-01-13 Thread Peter Firmstone
Could we use a static validator method and generate bytecode for constructors dynamically? The developer can optionally implement the constructors. static GetField invariantCheck(GetField f); Create a caller sensitive GetField implementation and add a two new methods to GetField: abstract Obj

Re: Explicit Serialization API and Security

2015-01-13 Thread Peter Levart
Hi Chris, I stepped back and asked myself what problem(s) we are searching solution(s) for and tried to see how existing API solves or doesn't solve them. I think that existing readObject() + GetFields API already solves most of the problems discussed so far as it: - provides encapsulation (us

Re: RFR 8068730: Increase the precision of the implementation of java.time.Clock.systemUTC()

2015-01-13 Thread Daniel Fuchs
On 13/01/15 04:52, David Holmes wrote: Here is the new webrev with Stephen & your feedback included http://cr.openjdk.java.net/~dfuchs/webrev_8068730/webrev.01/ (windows_time_stamp not renamed yet) I checked the updated webrev.02 and everything looks good on the hotspot side. What are your pl

Re: RFR: JDK-8042707: Source changes needed to build JDK 9 with Visual Studio 2013 (VS2013)

2015-01-13 Thread Erik Joelsson
Hello, New webrev for root repo: http://cr.openjdk.java.net/~erikj/8042707/webrev.root.02/ On 2015-01-09 15:45, Magnus Ihse Bursie wrote: It looks basically good to me. Some remarks on toolchain_windows.m4, though. In TOOLCHAIN_CHECK_POSSIBLE_VISUAL_STUDIO_ROOT: # TODO: improve detection fo